Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 5.3.5.

Fichiers

fr/paris/lutece/plugins/dila/business/donneescomplementaires/dao/IComplementaryDataDAO.java

Violation Ligne
Avoid variables with short names like id 65
Avoid variables with short names like id 72
Avoid variables with short names like id 85

fr/paris/lutece/plugins/dila/business/donneescomplementaires/dao/IComplementaryDataLinkDAO.java

Violation Ligne
Avoid variables with short names like id 58

fr/paris/lutece/plugins/dila/business/donneescomplementaires/dao/impl/ComplementaryDataDAO.java

Violation Ligne
Avoid variables with short names like id 142
Avoid variables with short names like id 163
Avoid variables with short names like id 202

fr/paris/lutece/plugins/dila/business/donneescomplementaires/dao/impl/ComplementaryDataLinkDAO.java

Violation Ligne
Avoid variables with short names like id 127

fr/paris/lutece/plugins/dila/business/donneescomplementaires/dto/ComplementaryDataLinkDTO.java

Violation Ligne
Abstract classes should be named AbstractXXX 42153

fr/paris/lutece/plugins/dila/business/enums/ContentTypeEnum.java

Violation Ligne
Avoid variables with short names like id 47

fr/paris/lutece/plugins/dila/business/fichelocale/dao/ILocalDAO.java

Violation Ligne
Avoid variables with short names like id 53
Avoid variables with short names like id 62
Avoid variables with short names like id 98

fr/paris/lutece/plugins/dila/business/fichelocale/dao/IXmlDAO.java

Violation Ligne
Avoid variables with short names like id 51
Avoid variables with short names like id 58

fr/paris/lutece/plugins/dila/business/fichelocale/dao/impl/LocalDAO.java

Violation Ligne
Avoid variables with short names like id 97
Avoid variables with short names like id 132
Do not add empty strings 213
Do not add empty strings 214
Do not add empty strings 254
Do not add empty strings 255
Avoid variables with short names like id 264

fr/paris/lutece/plugins/dila/business/fichelocale/dao/impl/LocalFolderLinkDAO.java

Violation Ligne
Avoid variables with short names like id 111

fr/paris/lutece/plugins/dila/business/fichelocale/dao/impl/XmlDAO.java

Violation Ligne
Avoid variables with short names like id 98
Avoid variables with short names like id 118
Avoid appending characters as strings in StringBuffer.append. 146
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 146
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 147
Avoid appending characters as strings in StringBuffer.append. 148
Avoid appending characters as strings in StringBuffer.append. 166
Avoid appending characters as strings in StringBuffer.append. 191
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 191
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 192
Avoid appending characters as strings in StringBuffer.append. 193
Avoid appending characters as strings in StringBuffer.append. 211
Avoid variables with short names like id 325

fr/paris/lutece/plugins/dila/business/fichelocale/dto/LocalDTO.java

Violation Ligne
Document empty constructor 9799

fr/paris/lutece/plugins/dila/business/fichelocale/dto/XmlDTO.java

Violation Ligne
The class 'XmlDTO' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 43293
The class 'XmlDTO' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 43293
The class 'XmlDTO' has a Cyclomatic Complexity of 2 (Highest = 10). 43293
Avoid using final local variables, turn them into fields 234
The method 'equals' has a Standard Cyclomatic Complexity of 10. 248292
The method 'equals' has a Modified Cyclomatic Complexity of 10. 248292
The method 'equals' has a Cyclomatic Complexity of 10. 248292

fr/paris/lutece/plugins/dila/business/stylesheet/dao/impl/ContentTypeDAO.java

Violation Ligne
Avoid excessively long variable names like SQL_QUERY_SELECT_CONTENT_TYPE_WITHOUT_ASSOCIATED_STYLESHEET 58

fr/paris/lutece/plugins/dila/business/stylesheet/dao/impl/DilaStyleSheetDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 8098
Prefer StringBuffer over += for concatenating strings 109
Prefer StringBuffer over += for concatenating strings 119
Prefer StringBuffer over += for concatenating strings 123
Prefer StringBuffer over += for concatenating strings 126
This statement may have some unnecessary parentheses 185

fr/paris/lutece/plugins/dila/business/stylesheet/dto/DilaStyleSheet.java

Violation Ligne
Do not add empty strings 109

fr/paris/lutece/plugins/dila/daemon/DilaXmlDaemon.java

Violation Ligne
Avoid variables with short names like sb 59
StringBuffer constructor is initialized with size 16, but has at least 100 characters appended. 59
StringBuffer (or StringBuilder).append is called 6 consecutive times with literal Strings. Use a single append with a single combined String. 65
Avoid appending characters as strings in StringBuffer.append. 66
Avoid appending characters as strings in StringBuffer.append. 69
Avoid appending characters as strings in StringBuffer.append. 72
Avoid appending characters as strings in StringBuffer.append. 78

fr/paris/lutece/plugins/dila/exception/DilaException.java

Violation Ligne
Avoid variables with short names like e 58

fr/paris/lutece/plugins/dila/service/DilaPlugin.java

Violation Ligne
Document empty method 5051

fr/paris/lutece/plugins/dila/service/DilaStyleSheetResourceIdService.java

Violation Ligne
Private field '_dilaStyleSheetService' could be made final; it is only initialized in the declaration or constructor. 72
It is a good practice to call super() in a constructor 7578
Avoid variables with short names like rt 85
Avoid variables with short names like p 91

fr/paris/lutece/plugins/dila/service/IDilaComplementaryDataService.java

Violation Ligne
Avoid variables with short names like id 69
Avoid variables with short names like id 76
Avoid variables with short names like id 89

fr/paris/lutece/plugins/dila/service/IDilaExtractService.java

Violation Ligne
A method/constructor shouldnt explicitly throw java.lang.Exception 69
A method/constructor shouldnt explicitly throw java.lang.Exception 69

fr/paris/lutece/plugins/dila/service/IDilaLocalFolderLinkService.java

Violation Ligne
Avoid variables with short names like id 63

fr/paris/lutece/plugins/dila/service/IDilaLocalService.java

Violation Ligne
Avoid variables with short names like id 84
Avoid variables with short names like id 93
Avoid variables with short names like id 102

fr/paris/lutece/plugins/dila/service/IDilaXmlService.java

Violation Ligne
Avoid variables with short names like id 56
Avoid variables with short names like id 63

fr/paris/lutece/plugins/dila/service/impl/DilaBatchXMLService.java

Violation Ligne
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 120

fr/paris/lutece/plugins/dila/service/impl/DilaCacheService.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 4336
The class 'DilaCacheService' has a Modified Cyclomatic Complexity of 6 (Highest = 19). 60336
The class 'DilaCacheService' has a Standard Cyclomatic Complexity of 7 (Highest = 23). 60336
The class 'DilaCacheService' has a Cyclomatic Complexity of 8 (Highest = 26). 60336
It is a good practice to call super() in a constructor 9396
The method buildDilaPage() has an NCSS line count of 114 126335
The method 'buildDilaPage' has a Cyclomatic Complexity of 26. 126335
The method 'buildDilaPage' has a Modified Cyclomatic Complexity of 19. 126335
The method buildDilaPage() has an NPath complexity of 7448 126335
Avoid really long methods. 126335
The method 'buildDilaPage' has a Standard Cyclomatic Complexity of 23. 126335
Avoid declaring a variable if it is unreferenced before a possible exit point. 157
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 284
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 289
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 290

fr/paris/lutece/plugins/dila/service/impl/DilaComplementaryDataService.java

Violation Ligne
Avoid variables with short names like id 105
Avoid variables with short names like id 114
Avoid variables with short names like id 132

fr/paris/lutece/plugins/dila/service/impl/DilaDownloadService.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34271
The class 'DilaDownloadService' has a Modified Cyclomatic Complexity of 9 (Highest = 16). 75271
The class 'DilaDownloadService' has a Standard Cyclomatic Complexity of 9 (Highest = 16). 75271
The class 'DilaDownloadService' has a Cyclomatic Complexity of 10 (Highest = 17). 75271
The method 'download' has a Standard Cyclomatic Complexity of 16. 105270
Avoid really long methods. 105270
The method 'download' has a Modified Cyclomatic Complexity of 16. 105270
The method 'download' has a Cyclomatic Complexity of 17. 105270
The method download() has an NPath complexity of 18432 105270
The String literal "Error on HTTP protocol" appears 4 times in this file; the first occurrence is on line 153 153
New exception is thrown in catch block, original stack trace may be lost 154
New exception is thrown in catch block, original stack trace may be lost 159
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 164
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 168
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 178
New exception is thrown in catch block, original stack trace may be lost 181
Avoid declaring a variable if it is unreferenced before a possible exit point. 187
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 192
New exception is thrown in catch block, original stack trace may be lost 201
New exception is thrown in catch block, original stack trace may be lost 214
New exception is thrown in catch block, original stack trace may be lost 224
New exception is thrown in catch block, original stack trace may be lost 235
New exception is thrown in catch block, original stack trace may be lost 246
New exception is thrown in catch block, original stack trace may be lost 257
New exception is thrown in catch block, original stack trace may be lost 268

fr/paris/lutece/plugins/dila/service/impl/DilaExtractService.java

Violation Ligne
The class 'DilaExtractService' has a Modified Cyclomatic Complexity of 6 (Highest = 10). 65360
The class 'DilaExtractService' has a Cyclomatic Complexity of 6 (Highest = 10). 65360
The class 'DilaExtractService' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 65360
Perhaps '_strArchivesDirPath' could be replaced by a local variable. 71
Private field '_filenameFilterArchive' could be made final; it is only initialized in the declaration or constructor. 76
The method 'extractAll' has a Standard Cyclomatic Complexity of 10. 79161
The method 'extractAll' has a Cyclomatic Complexity of 10. 79161
The method 'extractAll' has a Modified Cyclomatic Complexity of 10. 79161
Avoid using Literals in Conditional Statements 96
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 104
New exception is thrown in catch block, original stack trace may be lost 151
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 153
New exception is thrown in catch block, original stack trace may be lost 155
A method/constructor shouldnt explicitly throw java.lang.Exception 165
A method/constructor shouldnt explicitly throw java.lang.Exception 165
This statement may have some unnecessary parentheses 171
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 216
New exception is thrown in catch block, original stack trace may be lost 219
A method/constructor shouldnt explicitly throw java.lang.Exception 273
A method/constructor shouldnt explicitly throw java.lang.Exception 273
Avoid variables with short names like in 280
New exception is thrown in catch block, original stack trace may be lost 305
New exception is thrown in catch block, original stack trace may be lost 309

fr/paris/lutece/plugins/dila/service/impl/DilaIndexationService.java

Violation Ligne
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 119

fr/paris/lutece/plugins/dila/service/impl/DilaLocalCardService.java

Violation Ligne
The class 'DilaLocalCardService' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 56186
The class 'DilaLocalCardService' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 56186
The class 'DilaLocalCardService' has a Cyclomatic Complexity of 2 (Highest = 12). 56186
The method 'insertCardLinks' has a Standard Cyclomatic Complexity of 11. 105179
The method 'insertCardLinks' has a Cyclomatic Complexity of 12. 105179
The method 'insertCardLinks' has a Modified Cyclomatic Complexity of 11. 105179
Avoid using Literals in Conditional Statements 139
Do not add empty strings 143
Do not add empty strings 144
Do not add empty strings 153
Do not add empty strings 164

fr/paris/lutece/plugins/dila/service/impl/DilaLocalFolderLinkService.java

Violation Ligne
Avoid variables with short names like id 81

fr/paris/lutece/plugins/dila/service/impl/DilaLocalFolderService.java

Violation Ligne
The class 'DilaLocalFolderService' has a Cyclomatic Complexity of 2 (Highest = 10). 56190
The method 'insertFolderLinks' has a Cyclomatic Complexity of 10. 118180
Avoid using Literals in Conditional Statements 141
Do not add empty strings 145
Do not add empty strings 146
Do not add empty strings 155
Do not add empty strings 166

fr/paris/lutece/plugins/dila/service/impl/DilaLocalService.java

Violation Ligne
Avoid variables with short names like id 68
Avoid variables with short names like id 74
Avoid variables with short names like id 104

fr/paris/lutece/plugins/dila/service/impl/DilaValidationService.java

Violation Ligne
Possible God class (WMC=52, ATFD=49, TCC=0.0) 34403
Avoid declaring a variable if it is unreferenced before a possible exit point. 142
Avoid declaring a variable if it is unreferenced before a possible exit point. 224
Avoid declaring a variable if it is unreferenced before a possible exit point. 225
This call to String.startsWith can be rewritten using String.charAt(0) 298

fr/paris/lutece/plugins/dila/service/impl/DilaXmlService.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34324
The class 'DilaXmlService' has a Cyclomatic Complexity of 2 (Highest = 12). 86324
The class 'DilaXmlService' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 86324
The class 'DilaXmlService' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 86324
The method 'insertRssLinks' has a Cyclomatic Complexity of 12. 205315
The method 'insertRssLinks' has a Modified Cyclomatic Complexity of 11. 205315
Avoid really long methods. 205315
The method 'insertRssLinks' has a Standard Cyclomatic Complexity of 11. 205315
Deeply nested if..then statements are hard to read 232238

fr/paris/lutece/plugins/dila/service/search/DilaLocalIndexer.java

Violation Ligne
Private field '_dilaLocalService' could be made final; it is only initialized in the declaration or constructor. 72
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 87
This statement may have some unnecessary parentheses 130
Position literals first in String comparisons for EqualsIgnoreCase 130
Do not add empty strings 177
Do not add empty strings 190

fr/paris/lutece/plugins/dila/service/search/DilaXMLIndexer.java

Violation Ligne
Private field '_dilaXmlService' could be made final; it is only initialized in the declaration or constructor. 71
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 86
Position literals first in String comparisons for EqualsIgnoreCase 129
This statement may have some unnecessary parentheses 129
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 191
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 192
Avoid appending characters as strings in StringBuffer.append. 192

fr/paris/lutece/plugins/dila/utils/CacheKeyUtils.java

Violation Ligne
Avoid using Literals in Conditional Statements 73

fr/paris/lutece/plugins/dila/utils/DateUtils.java

Violation Ligne
When instantiating a SimpleDateFormat object, specify a Locale 64
When instantiating a SimpleDateFormat object, specify a Locale 78

fr/paris/lutece/plugins/dila/utils/ListUtils.java

Violation Ligne
The String literal "Error creating a combo list : " appears 4 times in this file; the first occurrence is on line 124 124
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 134

fr/paris/lutece/plugins/dila/utils/XMLConvertor.java

Violation Ligne
Avoid really long methods. 117226
When instantiating a SimpleDateFormat object, specify a Locale 119
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 124
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 125
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 128
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 129
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 130
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 131
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 132
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 133
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 134135
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 184
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 196
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 197
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 221
When instantiating a SimpleDateFormat object, specify a Locale 237
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 242
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 243
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 246
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 247
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 248
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 249
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 250
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 251
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 252253
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 304
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 305
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 306
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 308
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 309
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 313
Do not add empty strings 317

fr/paris/lutece/plugins/dila/utils/filter/FilenameFilterArchive.java

Violation Ligne
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 59

fr/paris/lutece/plugins/dila/utils/filter/FilenameFilterXml.java

Violation Ligne
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 60

fr/paris/lutece/plugins/dila/utils/http/HttpResponseInterceptorBzip2.java

Violation Ligne
Deeply nested if..then statements are hard to read 6974

fr/paris/lutece/plugins/dila/web/ComplementaryDataJspBean.java

Violation Ligne
Possible God class (WMC=58, ATFD=121, TCC=0.30994152046783624) 34769
A high number of imports can indicate a high degree of coupling within an object. 34769
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 116
Private field '_dilaComplementaryDataService' could be made final; it is only initialized in the declaration or constructor. 118
Private field '_dilaComplementaryDataLinkService' could be made final; it is only initialized in the declaration or constructor. 120
Private field '_dilaXmlService' could be made final; it is only initialized in the declaration or constructor. 122
Private field '_dilaAudienceService' could be made final; it is only initialized in the declaration or constructor. 123
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 132
Prefer StringBuffer over += for concatenating strings 162
Prefer StringBuffer over += for concatenating strings 167
Do not add empty strings 174
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 195
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 243
Avoid variables with short names like id 271
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 279
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 295
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 324
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 350
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 379
Avoid variables with short names like id 473
Avoid variables with short names like id 553
Avoid unused method parameters such as 'id'. 575
Avoid variables with short names like id 575

fr/paris/lutece/plugins/dila/web/DilaApp.java

Violation Ligne
Private field '_dilaCacheService' could be made final; it is only initialized in the declaration or constructor. 76

fr/paris/lutece/plugins/dila/web/DilaLocalApp.java

Violation Ligne
Private field '_dilaLocalService' could be made final; it is only initialized in the declaration or constructor. 59
Prefer StringBuffer over += for concatenating strings 86
Prefer StringBuffer over += for concatenating strings 86
Prefer StringBuffer over += for concatenating strings 90
Prefer StringBuffer over += for concatenating strings 90

fr/paris/lutece/plugins/dila/web/LocalCardJspBean.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 341017
Possible God class (WMC=73, ATFD=151, TCC=0.24867724867724866) 341017
The class 'LocalCardJspBean' has a Cyclomatic Complexity of 3 (Highest = 10). 791017
Private field '_dilaLocalFolderService' could be made final; it is only initialized in the declaration or constructor. 125
Private field '_dilaLocalService' could be made final; it is only initialized in the declaration or constructor. 126
Private field '_dilaLocalCardService' could be made final; it is only initialized in the declaration or constructor. 127
Private field '_dilaAudienceService' could be made final; it is only initialized in the declaration or constructor. 128
Private field '_dilaLocalCardChapterService' could be made final; it is only initialized in the declaration or constructor. 129
Private field '_dilaLocalFolderLinkService' could be made final; it is only initialized in the declaration or constructor. 131
Private field '_dilaValidationService' could be made final; it is only initialized in the declaration or constructor. 133
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 142
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 198
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 247
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 271
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 298
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 338
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 364
Avoid using Literals in Conditional Statements 370
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 392
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 417
Avoid declaring a variable if it is unreferenced before a possible exit point. 440
Avoid declaring a variable if it is unreferenced before a possible exit point. 470
Avoid declaring a variable if it is unreferenced before a possible exit point. 503
Avoid declaring a variable if it is unreferenced before a possible exit point. 533
Avoid declaring a variable if it is unreferenced before a possible exit point. 564
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 775
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 829
Avoid variables with short names like id 952
The method 'filterLocal' has a Cyclomatic Complexity of 10. 952982

fr/paris/lutece/plugins/dila/web/StyleSheetJspBean.java

Violation Ligne
Possible God class (WMC=68, ATFD=169, TCC=0.0) 34706
A high number of imports can indicate a high degree of coupling within an object. 34706
The class 'StyleSheetJspBean' has a Modified Cyclomatic Complexity of 6 (Highest = 12). 94706
The class 'StyleSheetJspBean' has a Standard Cyclomatic Complexity of 6 (Highest = 12). 94706
The class 'StyleSheetJspBean' has a Cyclomatic Complexity of 7 (Highest = 19). 94706
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 104
Private field '_typeContenuService' could be made final; it is only initialized in the declaration or constructor. 108
Private field '_dilaStyleSheetService' could be made final; it is only initialized in the declaration or constructor. 109
Private field '_dilaStyleSheetActionService' could be made final; it is only initialized in the declaration or constructor. 110
Prefer StringBuffer over += for concatenating strings 122
Prefer StringBuffer over += for concatenating strings 122
Prefer StringBuffer over += for concatenating strings 162
Prefer StringBuffer over += for concatenating strings 167
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 174
Do not add empty strings 201
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 226
The method doSaveStyleSheet() has an NPath complexity of 800 286364
The method 'doSaveStyleSheet' has a Modified Cyclomatic Complexity of 12. 286364
The method 'doSaveStyleSheet' has a Cyclomatic Complexity of 12. 286364
The method 'doSaveStyleSheet' has a Standard Cyclomatic Complexity of 12. 286364
Avoid declaring a variable if it is unreferenced before a possible exit point. 288
The String literal "User is not authrorized to access this page." appears 5 times in this file; the first occurrence is on line 305 305
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 395
The method 'getData' has a Standard Cyclomatic Complexity of 11. 440539
The method 'getData' has a Modified Cyclomatic Complexity of 11. 440539
The method 'getData' has a Cyclomatic Complexity of 19. 440539
The method getData() has an NPath complexity of 2800 440539
Avoid declaring a variable if it is unreferenced before a possible exit point. 443
Avoid declaring a variable if it is unreferenced before a possible exit point. 445
These nested if statements could be combined 459462
Avoid variables with short names like is 555
These nested if statements could be combined 590593
These nested if statements could be combined 625628
Avoid variables with short names like os 694