Le document suivant contient les résultats de PMD 5.5.1.
Violation | Ligne |
---|---|
The class 'AbstractEntryTypeUpload' has a Cyclomatic Complexity of 5 (Highest = 17). | 63–379 |
The class 'AbstractEntryTypeUpload' has a Standard Cyclomatic Complexity of 4 (Highest = 10). | 63–379 |
The class 'AbstractEntryTypeUpload' has a Modified Cyclomatic Complexity of 4 (Highest = 10). | 63–379 |
Avoid excessively long variable names like PROPERTY_MESSAGE_ERROR_UPLOADING_FILE_FILE_MAX_SIZE | 77 |
The method 'canUploadFiles' has a Standard Cyclomatic Complexity of 10. | 110–177 |
The method 'canUploadFiles' has a Modified Cyclomatic Complexity of 10. | 110–177 |
The method 'canUploadFiles' has a Cyclomatic Complexity of 17. | 110–177 |
The method canUploadFiles() has an NPath complexity of 960 | 110–177 |
The method 'checkRecordFieldData' has a Cyclomatic Complexity of 11. | 253–285 |
Violation | Ligne |
---|---|
This class has a bunch of public methods and attributes | 34–1039 |
Too many fields | 61–1039 |
Singleton is not thread safe | 144–148 |
Singleton is not thread safe | 150–154 |
Singleton is not thread safe | 156–160 |
Singleton is not thread safe | 162–166 |
Singleton is not thread safe | 168–172 |
Singleton is not thread safe | 174–178 |
Do not add empty strings | 399 |
Violation | Ligne |
---|---|
The class 'DirectoryDAO' has a Modified Cyclomatic Complexity of 5 (Highest = 15). | 49–474 |
The class 'DirectoryDAO' has a Cyclomatic Complexity of 5 (Highest = 15). | 49–474 |
The class 'DirectoryDAO' has a Standard Cyclomatic Complexity of 5 (Highest = 15). | 49–474 |
Use block level rather than method level synchronization | 115–178 |
The method 'selectDirectoryList' has a Standard Cyclomatic Complexity of 15. | 332–448 |
The method selectDirectoryList() has an NPath complexity of 6912 | 332–448 |
The method 'selectDirectoryList' has a Modified Cyclomatic Complexity of 15. | 332–448 |
Avoid really long methods. | 332–448 |
The method 'selectDirectoryList' has a Cyclomatic Complexity of 15. | 332–448 |
Violation | Ligne |
---|---|
Do not add empty strings | 154 |
Violation | Ligne |
---|---|
Use block level rather than method level synchronization | 91–122 |
Violation | Ligne |
---|---|
This class has a bunch of public methods and attributes | 34–1332 |
Possible God class (WMC=132, ATFD=28, TCC=0.008712871287128714) | 34–1332 |
Avoid really long classes. | 63–1332 |
Too many fields | 63–1332 |
Assigning an Object to null is a code smell. Consider refactoring. | 828 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 899 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 919 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 941 |
Avoid using Literals in Conditional Statements | 952 |
Prefer StringBuffer over += for concatenating strings | 954 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 976 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 998 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1018 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1039 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1127 |
Avoid variables with short names like b | 1155 |
A getX() method which returns a boolean should be named isX() | 1282–1285 |
Violation | Ligne |
---|---|
Possible God class (WMC=120, ATFD=236, TCC=0.03333333333333333) | 34–1147 |
The class 'EntryDAO' has a Modified Cyclomatic Complexity of 8 (Highest = 35). | 47–1147 |
Avoid really long classes. | 47–1147 |
The class 'EntryDAO' has a Standard Cyclomatic Complexity of 8 (Highest = 35). | 47–1147 |
The class 'EntryDAO' has a Cyclomatic Complexity of 8 (Highest = 35). | 47–1147 |
Use block level rather than method level synchronization | 170–226 |
Avoid really long methods. | 232–333 |
Avoid really long methods. | 415–522 |
The method 'setSelectFilter' has a Standard Cyclomatic Complexity of 21. | 415–522 |
The method 'setSelectFilter' has a Modified Cyclomatic Complexity of 21. | 415–522 |
The method setSelectFilter() has an NPath complexity of 1048576 | 415–522 |
The method 'setSelectFilter' has a Cyclomatic Complexity of 21. | 415–522 |
The method setSelectFilterValues() has an NPath complexity of 524288 | 524–643 |
Avoid really long methods. | 524–643 |
The method 'setSelectFilterValues' has a Standard Cyclomatic Complexity of 20. | 524–643 |
The method 'setSelectFilterValues' has a Modified Cyclomatic Complexity of 20. | 524–643 |
The method 'setSelectFilterValues' has a Cyclomatic Complexity of 20. | 524–643 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 648 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 650 |
The method 'selectNumberEntryByFilter' has a Modified Cyclomatic Complexity of 35. | 794–997 |
The method 'selectNumberEntryByFilter' has a Standard Cyclomatic Complexity of 35. | 794–997 |
Avoid really long methods. | 794–997 |
The method 'selectNumberEntryByFilter' has a Cyclomatic Complexity of 35. | 794–997 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1006 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 1015 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 1017 |
Violation | Ligne |
---|---|
This class has a bunch of public methods and attributes | 34–652 |
Too many fields | 41–652 |
Violation | Ligne |
---|---|
This statement may have some unnecessary parentheses | 235 |
Avoid empty catch blocks | 242–245 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 242 |
Violation | Ligne |
---|---|
Possible God class (WMC=47, ATFD=67, TCC=0.0) | 34–412 |
The class 'EntryTypeArray' has a Modified Cyclomatic Complexity of 4 (Highest = 17). | 59–412 |
The class 'EntryTypeArray' has a Standard Cyclomatic Complexity of 4 (Highest = 17). | 59–412 |
The class 'EntryTypeArray' has a Cyclomatic Complexity of 4 (Highest = 20). | 59–412 |
This final field could be made static | 61 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
This final field could be made static | 68 |
The method getEntryData() has an NPath complexity of 11500 | 116–263 |
The method 'getEntryData' has a Cyclomatic Complexity of 20. | 116–263 |
The method 'getEntryData' has a Standard Cyclomatic Complexity of 17. | 116–263 |
Avoid really long methods. | 116–263 |
The method 'getEntryData' has a Modified Cyclomatic Complexity of 17. | 116–263 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 119 |
Assigning an Object to null is a code smell. Consider refactoring. | 119 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 120–121 |
Assigning an Object to null is a code smell. Consider refactoring. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Violation | Ligne |
---|---|
Possible God class (WMC=54, ATFD=74, TCC=0.01282051282051282) | 34–509 |
The class 'EntryTypeCamera' has a Cyclomatic Complexity of 4 (Highest = 15). | 71–509 |
The class 'EntryTypeCamera' has a Standard Cyclomatic Complexity of 3 (Highest = 11). | 71–509 |
The class 'EntryTypeCamera' has a Modified Cyclomatic Complexity of 3 (Highest = 11). | 71–509 |
The field name indicates a constant but its modifiers do not | 73 |
Private field 'PROPERTY_IMAGE_TITLE' could be made final; it is only initialized in the declaration or constructor. | 73 |
The String literal "directory.create_entry.label_width" appears 4 times in this file; the first occurrence is on line 74 | 74 |
This final field could be made static | 85 |
This final field could be made static | 86 |
This final field could be made static | 87 |
This final field could be made static | 88 |
This final field could be made static | 89 |
This final field could be made static | 90 |
This final field could be made static | 91 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Assigning an Object to null is a code smell. Consider refactoring. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 138 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 139 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 141 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 142 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 143 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 145 |
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 11. | 226–308 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 15. | 226–308 |
The method getRecordFieldData() has an NPath complexity of 3012 | 226–308 |
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 11. | 226–308 |
Avoid variables with short names like c | 243 |
Do not add empty strings | 264 |
New exception is thrown in catch block, original stack trace may be lost | 281 |
The method 'checkEntryData' has a Cyclomatic Complexity of 12. | 361–420 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 373 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 374 |
New exception is thrown in catch block, original stack trace may be lost | 449 |
Document empty method | 507–508 |
Violation | Ligne |
---|---|
The class 'EntryTypeCheckBox' has a Modified Cyclomatic Complexity of 3 (Highest = 10). | 58–344 |
The class 'EntryTypeCheckBox' has a Cyclomatic Complexity of 3 (Highest = 11). | 58–344 |
The class 'EntryTypeCheckBox' has a Standard Cyclomatic Complexity of 3 (Highest = 10). | 58–344 |
This final field could be made static | 60 |
This final field could be made static | 61 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
Assigning an Object to null is a code smell. Consider refactoring. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 119–120 |
Assigning an Object to null is a code smell. Consider refactoring. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 10. | 247–304 |
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 10. | 247–304 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. | 247–304 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 253 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 287 |
Violation | Ligne |
---|---|
This final field could be made static | 52 |
This final field could be made static | 53 |
This final field could be made static | 54 |
This final field could be made static | 55 |
Violation | Ligne |
---|---|
Possible God class (WMC=58, ATFD=66, TCC=0.03636363636363636) | 34–428 |
The class 'EntryTypeDate' has a Standard Cyclomatic Complexity of 4 (Highest = 16). | 58–428 |
The class 'EntryTypeDate' has a Modified Cyclomatic Complexity of 4 (Highest = 16). | 58–428 |
The class 'EntryTypeDate' has a Cyclomatic Complexity of 5 (Highest = 28). | 58–428 |
This final field could be made static | 67 |
This final field could be made static | 68 |
This final field could be made static | 69 |
This final field could be made static | 70 |
This final field could be made static | 71 |
This final field could be made static | 72 |
This final field could be made static | 73 |
This final field could be made static | 74 |
The method 'getEntryData' has a Cyclomatic Complexity of 10. | 122–196 |
The method getEntryData() has an NPath complexity of 1200 | 122–196 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Assigning an Object to null is a code smell. Consider refactoring. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126–127 |
Assigning an Object to null is a code smell. Consider refactoring. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 134 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 135 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 136 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 137 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 138 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 140 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 141 |
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 16. | 242–348 |
Avoid really long methods. | 242–348 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 28. | 242–348 |
The method getRecordFieldData() has an NPath complexity of 3267 | 242–348 |
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 16. | 242–348 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 322 |
Assigning an Object to null is a code smell. Consider refactoring. | 322 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 365 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 413 |
Violation | Ligne |
---|---|
Possible God class (WMC=48, ATFD=63, TCC=0.0) | 34–411 |
The class 'EntryTypeDirectory' has a Cyclomatic Complexity of 4 (Highest = 12). | 64–411 |
This final field could be made static | 81 |
This final field could be made static | 82 |
This final field could be made static | 83 |
This final field could be made static | 84 |
This final field could be made static | 85 |
This final field could be made static | 86 |
This final field could be made static | 87 |
This final field could be made static | 88 |
The method 'getEntryData' has a Cyclomatic Complexity of 10. | 136–216 |
The method getEntryData() has an NPath complexity of 600 | 136–216 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 139 |
Assigning an Object to null is a code smell. Consider refactoring. | 139 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 140–141 |
Assigning an Object to null is a code smell. Consider refactoring. | 141 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 142 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 143 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 145 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 146 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 147 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 148 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 149 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 150 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 154 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 155 |
Assigning an Object to null is a code smell. Consider refactoring. | 252 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 252 |
The method 'convertRecordFieldValueToString' has a Cyclomatic Complexity of 12. | 318–392 |
Violation | Ligne |
---|---|
Avoid declaring a variable if it is unreferenced before a possible exit point. | 58 |
Avoid unnecessary if..then..else statements when returning booleans | 69–72 |
Violation | Ligne |
---|---|
Possible God class (WMC=70, ATFD=91, TCC=0.03676470588235294) | 34–648 |
The class 'EntryTypeDownloadUrl' has a Cyclomatic Complexity of 4 (Highest = 22). | 70–648 |
The class 'EntryTypeDownloadUrl' has a Modified Cyclomatic Complexity of 3 (Highest = 17). | 70–648 |
The class 'EntryTypeDownloadUrl' has a Standard Cyclomatic Complexity of 3 (Highest = 17). | 70–648 |
This final field could be made static | 103 |
This final field could be made static | 104 |
This final field could be made static | 105 |
This final field could be made static | 106 |
This final field could be made static | 107 |
This final field could be made static | 108 |
This final field could be made static | 109 |
This final field could be made static | 110 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 160 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 161 |
Assigning an Object to null is a code smell. Consider refactoring. | 161 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 162–163 |
Assigning an Object to null is a code smell. Consider refactoring. | 163 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 164 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 165 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 166 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 167 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 168 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 169 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 170 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 171 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 172 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 173 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 174 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 22. | 262–397 |
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 17. | 262–397 |
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 17. | 262–397 |
Avoid really long methods. | 262–397 |
The method getRecordFieldData() has an NPath complexity of 208 | 262–397 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 349 |
New exception is thrown in catch block, original stack trace may be lost | 351 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 412 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 416 |
The method checkRecordFieldData() has an NPath complexity of 420 | 511–564 |
The method 'checkRecordFieldData' has a Cyclomatic Complexity of 15. | 511–564 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 523 |
Violation | Ligne |
---|---|
The class 'EntryTypeFile' has a Cyclomatic Complexity of 3 (Highest = 16). | 67–426 |
The class 'EntryTypeFile' has a Modified Cyclomatic Complexity of 2 (Highest = 11). | 67–426 |
The class 'EntryTypeFile' has a Standard Cyclomatic Complexity of 2 (Highest = 11). | 67–426 |
This final field could be made static | 69 |
This final field could be made static | 70 |
This final field could be made static | 71 |
This final field could be made static | 72 |
This final field could be made static | 73 |
This final field could be made static | 74 |
This final field could be made static | 75 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 111 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 112 |
Assigning an Object to null is a code smell. Consider refactoring. | 112 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 113 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 114 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 115 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 116 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 117 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 119 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid variables with short names like ph | 200 |
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 11. | 211–275 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 16. | 211–275 |
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 11. | 211–275 |
Violation | Ligne |
---|---|
Possible God class (WMC=84, ATFD=147, TCC=0.02766798418972332) | 34–915 |
The class 'EntryTypeGeolocation' has a Modified Cyclomatic Complexity of 3 (Highest = 16). | 63–915 |
The class 'EntryTypeGeolocation' has a Standard Cyclomatic Complexity of 3 (Highest = 16). | 63–915 |
The class 'EntryTypeGeolocation' has a Cyclomatic Complexity of 4 (Highest = 17). | 63–915 |
The method 'getEntryData' has a Standard Cyclomatic Complexity of 16. | 207–404 |
The method 'getEntryData' has a Cyclomatic Complexity of 17. | 207–404 |
Avoid really long methods. | 207–404 |
The method getEntryData() has an NPath complexity of 768000 | 207–404 |
The method 'getEntryData' has a Modified Cyclomatic Complexity of 16. | 207–404 |
The method getEntryData() has an NCSS line count of 120 | 207–404 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 210 |
Assigning an Object to null is a code smell. Consider refactoring. | 210 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 211–212 |
Assigning an Object to null is a code smell. Consider refactoring. | 212 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 213 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 214 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 215 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 216 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 217 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 218 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 219 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 220 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 221 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 222 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 223 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 224 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 225 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 226 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 227 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 228 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 231 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 234 |
These nested if statements could be combined | 484–492 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 12. | 501–585 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 511 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 514 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 516 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 517 |
Avoid variables with short names like b | 592 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 739 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 835 |
Violation | Ligne |
---|---|
This final field could be made static | 53 |
Violation | Ligne |
---|---|
Possible God class (WMC=91, ATFD=169, TCC=0.08571428571428572) | 34–771 |
The class 'EntryTypeImg' has a Cyclomatic Complexity of 6 (Highest = 30). | 77–771 |
The class 'EntryTypeImg' has a Standard Cyclomatic Complexity of 4 (Highest = 18). | 77–771 |
The class 'EntryTypeImg' has a Modified Cyclomatic Complexity of 4 (Highest = 18). | 77–771 |
The String literal "directory.create_entry.label_width" appears 4 times in this file; the first occurrence is on line 79 | 79 |
This final field could be made static | 101 |
This final field could be made static | 103 |
This final field could be made static | 104 |
This final field could be made static | 105 |
This final field could be made static | 106 |
This final field could be made static | 107 |
This final field could be made static | 108 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 145 |
Assigning an Object to null is a code smell. Consider refactoring. | 145 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 146 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 147 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 148 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 149 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 150 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 156 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 157 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 159 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 160 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 161 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 162 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 163 |
The method getRecordFieldData() has an NPath complexity of 5312 | 244–394 |
Avoid really long methods. | 244–394 |
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 16. | 244–394 |
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 16. | 244–394 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 24. | 244–394 |
Deeply nested if..then statements are hard to read | 297–300 |
Deeply nested if..then statements are hard to read | 309–338 |
Deeply nested if..then statements are hard to read | 343–372 |
The method 'checkEntryData' has a Modified Cyclomatic Complexity of 18. | 447–568 |
The method checkEntryData() has an NPath complexity of 143361 | 447–568 |
The method 'checkEntryData' has a Standard Cyclomatic Complexity of 18. | 447–568 |
The method 'checkEntryData' has a Cyclomatic Complexity of 30. | 447–568 |
Avoid really long methods. | 447–568 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 465 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 466 |
Violation | Ligne |
---|---|
The class 'EntryTypeInternalLink' has a Cyclomatic Complexity of 4 (Highest = 11). | 58–245 |
This final field could be made static | 60 |
This final field could be made static | 61 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
The method getEntryData() has an NPath complexity of 600 | 115–185 |
Assigning an Object to null is a code smell. Consider refactoring. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 119–120 |
Assigning an Object to null is a code smell. Consider refactoring. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. | 209–244 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 214 |
Assigning an Object to null is a code smell. Consider refactoring. | 214 |
Prefer StringBuffer over += for concatenating strings | 229 |
Violation | Ligne |
---|---|
Possible God class (WMC=48, ATFD=50, TCC=0.0) | 34–401 |
The class 'EntryTypeMail' has a Modified Cyclomatic Complexity of 3 (Highest = 11). | 66–401 |
The class 'EntryTypeMail' has a Cyclomatic Complexity of 4 (Highest = 20). | 66–401 |
The class 'EntryTypeMail' has a Standard Cyclomatic Complexity of 3 (Highest = 11). | 66–401 |
This final field could be made static | 81 |
This final field could be made static | 82 |
This final field could be made static | 83 |
This final field could be made static | 84 |
This final field could be made static | 85 |
This final field could be made static | 86 |
This final field could be made static | 87 |
This final field could be made static | 88 |
The method 'getEntryData' has a Modified Cyclomatic Complexity of 10. | 136–229 |
The method getEntryData() has an NPath complexity of 5000 | 136–229 |
The method 'getEntryData' has a Standard Cyclomatic Complexity of 10. | 136–229 |
The method 'getEntryData' has a Cyclomatic Complexity of 14. | 136–229 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 139 |
Assigning an Object to null is a code smell. Consider refactoring. | 139 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 140–141 |
Assigning an Object to null is a code smell. Consider refactoring. | 141 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 142 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 143 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 145 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 146 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 147 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 148 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 149 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 150 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 153 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 154 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 155 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 157 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 158 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 20. | 288–352 |
The method getRecordFieldData() has an NPath complexity of 2910 | 288–352 |
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 11. | 288–352 |
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 11. | 288–352 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 293 |
Assigning an Object to null is a code smell. Consider refactoring. | 293 |
Prefer StringBuffer over += for concatenating strings | 309 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 321 |
Prefer StringBuffer over += for concatenating strings | 366 |
Prefer StringBuffer over += for concatenating strings | 366 |
Violation | Ligne |
---|---|
The class 'EntryTypeMyLuteceUser' has a Cyclomatic Complexity of 4 (Highest = 10). | 68–446 |
The method getEntryData() has an NPath complexity of 900 | 162–242 |
Assigning an Object to null is a code smell. Consider refactoring. | 165 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 165 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 166–167 |
Assigning an Object to null is a code smell. Consider refactoring. | 167 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 168 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 169 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 170 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 171 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 172 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 173 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 174 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 175 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 176 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 177 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 178 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 181 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 183 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 184 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 252 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 308 |
The method 'convertRecordFieldValueToString' has a Cyclomatic Complexity of 10. | 344–380 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 417 |
Violation | Ligne |
---|---|
The class 'EntryTypeNumbering' has a Cyclomatic Complexity of 3 (Highest = 10). | 66–374 |
This final field could be made static | 75 |
This final field could be made static | 76 |
This final field could be made static | 77 |
This final field could be made static | 78 |
This final field could be made static | 79 |
This final field could be made static | 80 |
This final field could be made static | 81 |
This final field could be made static | 82 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 136 |
The method getEntryData() has an NPath complexity of 300 | 153–212 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 156–157 |
Assigning an Object to null is a code smell. Consider refactoring. | 157 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 158 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 160 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 161 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 162 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 163 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 164 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 165 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 166 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 167 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 168 |
The method getRecordFieldData() has an NPath complexity of 200 | 236–302 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 10. | 236–302 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 257 |
Assigning an Object to null is a code smell. Consider refactoring. | 257 |
Violation | Ligne |
---|---|
The class 'EntryTypeRadioButton' has a Cyclomatic Complexity of 3 (Highest = 11). | 57–308 |
This final field could be made static | 59 |
This final field could be made static | 60 |
This final field could be made static | 61 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 117 |
Assigning an Object to null is a code smell. Consider refactoring. | 117 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 118–119 |
Assigning an Object to null is a code smell. Consider refactoring. | 119 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 134 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. | 225–268 |
The method getRecordFieldData() has an NPath complexity of 300 | 225–268 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 228 |
Assigning an Object to null is a code smell. Consider refactoring. | 228 |
These nested if statements could be combined | 241–244 |
Deeply nested if..then statements are hard to read | 255–258 |
Deeply nested if..then statements are hard to read | 260–263 |
Violation | Ligne |
---|---|
The class 'EntryTypeRemoteMyLuteceUser' has a Cyclomatic Complexity of 3 (Highest = 10). | 65–372 |
The method getEntryData() has an NPath complexity of 900 | 151–231 |
Assigning an Object to null is a code smell. Consider refactoring. | 154 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 154 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 155–156 |
Assigning an Object to null is a code smell. Consider refactoring. | 156 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 157 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 158 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 159 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 160 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 161 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 162 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 163 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 164 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 165 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 166 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 167 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 170 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 172 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 173 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 240 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 259 |
The method 'convertRecordFieldValueToString' has a Cyclomatic Complexity of 10. | 286–322 |
Violation | Ligne |
---|---|
The class 'EntryTypeRichText' has a Cyclomatic Complexity of 3 (Highest = 11). | 58–265 |
This final field could be made static | 60 |
This final field could be made static | 61 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
The method getEntryData() has an NPath complexity of 600 | 115–185 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
Assigning an Object to null is a code smell. Consider refactoring. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 119–120 |
Assigning an Object to null is a code smell. Consider refactoring. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. | 209–244 |
Assigning an Object to null is a code smell. Consider refactoring. | 214 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 214 |
Prefer StringBuffer over += for concatenating strings | 229 |
Violation | Ligne |
---|---|
The class 'EntryTypeSQL' has a Cyclomatic Complexity of 3 (Highest = 11). | 58–317 |
This final field could be made static | 60 |
This final field could be made static | 61 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
The method getEntryData() has an NPath complexity of 500 | 115–181 |
Assigning an Object to null is a code smell. Consider refactoring. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 119–120 |
Assigning an Object to null is a code smell. Consider refactoring. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. | 214–249 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 219 |
Assigning an Object to null is a code smell. Consider refactoring. | 219 |
Prefer StringBuffer over += for concatenating strings | 234 |
Violation | Ligne |
---|---|
The class 'EntryTypeSelect' has a Cyclomatic Complexity of 3 (Highest = 11). | 58–352 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
This final field could be made static | 68 |
This final field could be made static | 69 |
The method getEntryData() has an NPath complexity of 500 | 117–190 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 120 |
Assigning an Object to null is a code smell. Consider refactoring. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121–122 |
Assigning an Object to null is a code smell. Consider refactoring. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 136 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 137 |
The method getRecordFieldData() has an NPath complexity of 300 | 242–285 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. | 242–285 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 245 |
Assigning an Object to null is a code smell. Consider refactoring. | 245 |
These nested if statements could be combined | 258–261 |
Violation | Ligne |
---|---|
The class 'EntryTypeText' has a Cyclomatic Complexity of 4 (Highest = 18). | 63–353 |
The class 'EntryTypeText' has a Standard Cyclomatic Complexity of 3 (Highest = 10). | 63–353 |
The class 'EntryTypeText' has a Modified Cyclomatic Complexity of 3 (Highest = 10). | 63–353 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
This final field could be made static | 68 |
This final field could be made static | 69 |
This final field could be made static | 70 |
This final field could be made static | 71 |
This final field could be made static | 72 |
The method 'getEntryData' has a Standard Cyclomatic Complexity of 10. | 120–215 |
The method 'getEntryData' has a Modified Cyclomatic Complexity of 10. | 120–215 |
The method getEntryData() has an NPath complexity of 5000 | 120–215 |
The method 'getEntryData' has a Cyclomatic Complexity of 14. | 120–215 |
Assigning an Object to null is a code smell. Consider refactoring. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124–125 |
Assigning an Object to null is a code smell. Consider refactoring. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 134 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 137 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 138 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 139 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 140 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 142 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 143 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 18. | 274–322 |
The method getRecordFieldData() has an NPath complexity of 990 | 274–322 |
Assigning an Object to null is a code smell. Consider refactoring. | 279 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 279 |
Prefer StringBuffer over += for concatenating strings | 295 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 307 |
Violation | Ligne |
---|---|
The class 'EntryTypeTextArea' has a Standard Cyclomatic Complexity of 3 (Highest = 11). | 58–292 |
The class 'EntryTypeTextArea' has a Modified Cyclomatic Complexity of 3 (Highest = 11). | 58–292 |
The class 'EntryTypeTextArea' has a Cyclomatic Complexity of 4 (Highest = 14). | 58–292 |
This final field could be made static | 60 |
This final field could be made static | 61 |
This final field could be made static | 62 |
This final field could be made static | 63 |
This final field could be made static | 64 |
This final field could be made static | 65 |
This final field could be made static | 66 |
This final field could be made static | 67 |
The method 'getEntryData' has a Standard Cyclomatic Complexity of 11. | 115–214 |
The method getEntryData() has an NPath complexity of 4200 | 115–214 |
The method 'getEntryData' has a Cyclomatic Complexity of 14. | 115–214 |
The method 'getEntryData' has a Modified Cyclomatic Complexity of 11. | 115–214 |
Assigning an Object to null is a code smell. Consider refactoring. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 119–120 |
Assigning an Object to null is a code smell. Consider refactoring. | 120 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 134 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 136 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 137 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. | 238–273 |
Assigning an Object to null is a code smell. Consider refactoring. | 243 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 243 |
Prefer StringBuffer over += for concatenating strings | 258 |
Violation | Ligne |
---|---|
The class 'EntryTypeUrl' has a Standard Cyclomatic Complexity of 3 (Highest = 10). | 63–371 |
The class 'EntryTypeUrl' has a Modified Cyclomatic Complexity of 3 (Highest = 10). | 63–371 |
The class 'EntryTypeUrl' has a Cyclomatic Complexity of 4 (Highest = 18). | 63–371 |
This final field could be made static | 71 |
This final field could be made static | 72 |
This final field could be made static | 73 |
This final field could be made static | 74 |
This final field could be made static | 75 |
This final field could be made static | 76 |
This final field could be made static | 77 |
This final field could be made static | 78 |
The method 'getEntryData' has a Cyclomatic Complexity of 14. | 126–219 |
The method 'getEntryData' has a Modified Cyclomatic Complexity of 10. | 126–219 |
The method getEntryData() has an NPath complexity of 5000 | 126–219 |
The method 'getEntryData' has a Standard Cyclomatic Complexity of 10. | 126–219 |
Assigning an Object to null is a code smell. Consider refactoring. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 130–131 |
Assigning an Object to null is a code smell. Consider refactoring. | 131 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 133 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 134 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 135 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 136 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 137 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 138 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 139 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 140 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 143 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 145 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 147 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 148 |
The method getRecordFieldData() has an NPath complexity of 990 | 278–326 |
The method 'getRecordFieldData' has a Cyclomatic Complexity of 18. | 278–326 |
Assigning an Object to null is a code smell. Consider refactoring. | 283 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 283 |
Prefer StringBuffer over += for concatenating strings | 299 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 311 |
Prefer StringBuffer over += for concatenating strings | 338 |
Prefer StringBuffer over += for concatenating strings | 338 |
Violation | Ligne |
---|---|
Use block level rather than method level synchronization | 131–158 |
Assigning an Object to null is a code smell. Consider refactoring. | 146 |
Assigning an Object to null is a code smell. Consider refactoring. | 271 |
Violation | Ligne |
---|---|
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 151 |
Deeply nested if..then statements are hard to read | 151–164 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 196 |
Deeply nested if..then statements are hard to read | 196–209 |
Violation | Ligne |
---|---|
Avoid short class names like File | 48–249 |
Violation | Ligne |
---|---|
Use block level rather than method level synchronization | 85–110 |
Violation | Ligne |
---|---|
This class has a bunch of public methods and attributes | 34–885 |
Avoid using implementation types like 'HashMap'; use the interface instead | 724 |
Avoid using implementation types like 'HashMap'; use the interface instead | 724 |
Avoid variables with short names like b | 755 |
A getX() method which returns a boolean should be named isX() | 842 |
Violation | Ligne |
---|---|
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 36 |
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 36 |
Avoid unused imports such as 'javax.servlet.http.HttpSession' | 37 |
Avoid unused imports such as 'javax.servlet.http.HttpSession' | 37 |
Violation | Ligne |
---|---|
Use block level rather than method level synchronization | 84–96 |
Violation | Ligne |
---|---|
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 36 |
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 36 |
Avoid unused imports such as 'javax.servlet.http.HttpSession' | 37 |
Avoid unused imports such as 'javax.servlet.http.HttpSession' | 37 |
Violation | Ligne |
---|---|
Returning '_byValue' may expose an internal array. | 71 |
The user-supplied array 'value' is stored directly. | 80 |
Violation | Ligne |
---|---|
Use block level rather than method level synchronization | 80–92 |
Violation | Ligne |
---|---|
Possible God class (WMC=68, ATFD=45, TCC=0.036923076923076927) | 34–725 |
The class 'Record' has a Standard Cyclomatic Complexity of 2 (Highest = 15). | 61–725 |
The class 'Record' has a Modified Cyclomatic Complexity of 2 (Highest = 15). | 61–725 |
The class 'Record' has a Cyclomatic Complexity of 2 (Highest = 17). | 61–725 |
Avoid long parameter lists. | 300–301 |
The method 'getXml' has a Cyclomatic Complexity of 10. | 334–391 |
Avoid long parameter lists. | 334–336 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 339 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 355 |
The method 'getXmlListRecordField' has a Standard Cyclomatic Complexity of 15. | 412–518 |
The method 'getXmlListRecordField' has a Cyclomatic Complexity of 17. | 412–518 |
The method 'getXmlListRecordField' has a Modified Cyclomatic Complexity of 15. | 412–518 |
The method getXmlListRecordField() has an NPath complexity of 2750 | 412–518 |
Avoid really long methods. | 412–518 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 418 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 428 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 451 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 489 |
Avoid long parameter lists. | 545–546 |
The method 'getXmlForCsvExport' has a Cyclomatic Complexity of 10. | 579–652 |
Avoid long parameter lists. | 579–581 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 584 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 590 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 696 |
Violation | Ligne |
---|---|
Possible God class (WMC=62, ATFD=71, TCC=0.009523809523809525) | 34–683 |
The class 'RecordDAO' has a Cyclomatic Complexity of 4 (Highest = 21). | 53–683 |
The class 'RecordDAO' has a Standard Cyclomatic Complexity of 4 (Highest = 19). | 53–683 |
The class 'RecordDAO' has a Modified Cyclomatic Complexity of 4 (Highest = 19). | 53–683 |
Avoid excessively long variable names like SQL_QUERY_SELECT_COUNT_DIRECYTORY_RECORD_HAS_WORKFLOW | 72 |
Use block level rather than method level synchronization | 119–136 |
Avoid variables with short names like sb | 218 |
Prefer StringBuffer over += for concatenating strings | 488 |
Prefer StringBuffer over += for concatenating strings | 492 |
The method buildFilterQueryHeader() has an NPath complexity of 16132 | 505–619 |
Avoid really long methods. | 505–619 |
The method 'buildFilterQueryHeader' has a Cyclomatic Complexity of 21. | 505–619 |
The method 'buildFilterQueryHeader' has a Standard Cyclomatic Complexity of 19. | 505–619 |
The method 'buildFilterQueryHeader' has a Modified Cyclomatic Complexity of 19. | 505–619 |
Avoid using Literals in Conditional Statements | 553 |
Avoid using Literals in Conditional Statements | 597 |
The method 'buildFilterQueryFooter' has a Standard Cyclomatic Complexity of 10. | 629–682 |
The method 'buildFilterQueryFooter' has a Modified Cyclomatic Complexity of 10. | 629–682 |
The method 'buildFilterQueryFooter' has a Cyclomatic Complexity of 10. | 629–682 |
Violation | Ligne |
---|---|
Avoid unnecessary if..then..else statements when returning booleans | 197–200 |
Avoid unnecessary if..then..else statements when returning booleans | 212–215 |
Violation | Ligne |
---|---|
Possible God class (WMC=91, ATFD=161, TCC=0.11428571428571428) | 34–1029 |
The class 'RecordFieldDAO' has a Standard Cyclomatic Complexity of 6 (Highest = 19). | 47–1029 |
The class 'RecordFieldDAO' has a Cyclomatic Complexity of 6 (Highest = 19). | 47–1029 |
The class 'RecordFieldDAO' has a Modified Cyclomatic Complexity of 6 (Highest = 19). | 47–1029 |
Avoid excessively long variable names like SQL_QUERY_SELECT_FULL_RECORD_FIELD_LIST_WITH_RECORD | 73 |
Use block level rather than method level synchronization | 147–180 |
Avoid really long methods. | 371–517 |
The method 'getRecordFieldListByRecordIdList' has a Modified Cyclomatic Complexity of 12. | 371–517 |
The method 'getRecordFieldListByRecordIdList' has a Standard Cyclomatic Complexity of 12. | 371–517 |
The method 'getRecordFieldListByRecordIdList' has a Cyclomatic Complexity of 12. | 371–517 |
Avoid using Literals in Conditional Statements | 393 |
Avoid variables with short names like pf | 502 |
The method selectSpecificList() has an NPath complexity of 396 | 523–664 |
The method 'selectSpecificList' has a Modified Cyclomatic Complexity of 13. | 523–664 |
Avoid really long methods. | 523–664 |
The method 'selectSpecificList' has a Standard Cyclomatic Complexity of 13. | 523–664 |
The method 'selectSpecificList' has a Cyclomatic Complexity of 13. | 523–664 |
Avoid using Literals in Conditional Statements | 544 |
Avoid variables with short names like pf | 650 |
Avoid really long methods. | 670–824 |
The method selectListByFilter() has an NPath complexity of 67584 | 670–824 |
The method 'selectListByFilter' has a Modified Cyclomatic Complexity of 19. | 670–824 |
The method 'selectListByFilter' has a Cyclomatic Complexity of 19. | 670–824 |
The method 'selectListByFilter' has a Standard Cyclomatic Complexity of 19. | 670–824 |
The method 'getCountByFilter' has a Modified Cyclomatic Complexity of 12. | 830–908 |
The method 'getCountByFilter' has a Standard Cyclomatic Complexity of 12. | 830–908 |
The method 'getCountByFilter' has a Cyclomatic Complexity of 12. | 830–908 |
The method getCountByFilter() has an NPath complexity of 2048 | 830–908 |
Avoid using Literals in Conditional Statements | 977 |
Violation | Ligne |
---|---|
Too many fields | 47–528 |
Avoid using redundant field initializer for '_bOrderByDateModification' | 69 |
Avoid using redundant field initializer for '_bContainsFile' | 70 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 446 |
Violation | Ligne |
---|---|
The class 'RecordFieldHome' has a Cyclomatic Complexity of 2 (Highest = 11). | 48–452 |
The method 'getRecordFieldList' has a Cyclomatic Complexity of 11. | 301–328 |
Violation | Ligne |
---|---|
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 94 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 156 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 201 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 248 |
Violation | Ligne |
---|---|
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 59 |
Use block level rather than method level synchronization | 81–92 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–1098 |
Possible God class (WMC=107, ATFD=365, TCC=0.2909090909090909) | 34–1098 |
The class 'DirectoryResourceRss' has a Modified Cyclomatic Complexity of 8 (Highest = 22). | 88–1098 |
Avoid really long classes. | 88–1098 |
The class 'DirectoryResourceRss' has a Standard Cyclomatic Complexity of 8 (Highest = 22). | 88–1098 |
The class 'DirectoryResourceRss' has a Cyclomatic Complexity of 10 (Highest = 25). | 88–1098 |
Avoid variables with short names like ID | 161 |
Avoid unnecessary if..then..else statements when returning booleans | 173–176 |
The method 'doValidateConfigForm' has a Cyclomatic Complexity of 13. | 255–320 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 257 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 262 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 263 |
Avoid really long methods. | 326–464 |
The method 'getDisplayCreateConfigForm' has a Modified Cyclomatic Complexity of 17. | 326–464 |
The method getDisplayCreateConfigForm() has an NPath complexity of 8004 | 326–464 |
The method 'getDisplayCreateConfigForm' has a Standard Cyclomatic Complexity of 17. | 326–464 |
The method 'getDisplayCreateConfigForm' has a Cyclomatic Complexity of 20. | 326–464 |
The method 'getDisplayModifyConfigForm' has a Standard Cyclomatic Complexity of 22. | 470–666 |
The method getDisplayModifyConfigForm() has an NCSS line count of 111 | 470–666 |
The method 'getDisplayModifyConfigForm' has a Cyclomatic Complexity of 25. | 470–666 |
The method 'getDisplayModifyConfigForm' has a Modified Cyclomatic Complexity of 22. | 470–666 |
The method getDisplayModifyConfigForm() has an NPath complexity of 19600 | 470–666 |
Avoid really long methods. | 470–666 |
The method 'createHtmlRss' has a Cyclomatic Complexity of 23. | 675–846 |
Avoid really long methods. | 675–846 |
The method createHtmlRss() has an NPath complexity of 19332 | 675–846 |
The method 'createHtmlRss' has a Modified Cyclomatic Complexity of 16. | 675–846 |
The method 'createHtmlRss' has a Standard Cyclomatic Complexity of 16. | 675–846 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 864 |
The method 'getFeed' has a Standard Cyclomatic Complexity of 16. | 897–1097 |
The method 'getFeed' has a Cyclomatic Complexity of 23. | 897–1097 |
Avoid really long methods. | 897–1097 |
The method getFeed() has an NCSS line count of 108 | 897–1097 |
The method 'getFeed' has a Modified Cyclomatic Complexity of 16. | 897–1097 |
The method getFeed() has an NPath complexity of 19332 | 897–1097 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1032 |
Violation | Ligne |
---|---|
Use block level rather than method level synchronization | 65–85 |
Violation | Ligne |
---|---|
The class 'DirectoryResourceRssConfigRemovalListener' has a Cyclomatic Complexity of 6 (Highest = 10). | 49–96 |
Avoid excessively long variable names like PROPERTY_DIRECTORY_RESOURCE_RSS_CONFIG_CANNOT_BE_REMOVED | 51 |
The method 'canBeRemoved' has a Cyclomatic Complexity of 10. | 57–85 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 59 |
Violation | Ligne |
---|---|
It is a good practice to call super() in a constructor | 139–142 |
Avoid really long methods. | 148–263 |
Avoid variables with short names like rt | 151 |
Avoid variables with short names like p | 162 |
Assigning an Object to null is a code smell. Consider refactoring. | 287 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–588 |
Possible God class (WMC=67, ATFD=127, TCC=0.008333333333333333) | 34–588 |
Singleton is not thread safe | 125–128 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 142 |
Deeply nested if..then statements are hard to read | 240–243 |
These nested if statements could be combined | 269–283 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 367 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 433 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 509 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 558 |
Violation | Ligne |
---|---|
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 82 |
Violation | Ligne |
---|---|
It is a good practice to call super() in a constructor | 70–73 |
Avoid variables with short names like rt | 81 |
Avoid variables with short names like p | 87 |
Assigning an Object to null is a code smell. Consider refactoring. | 127 |
Violation | Ligne |
---|---|
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 51 |
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 51 |
Document empty constructor | 69–71 |
Deeply nested if..then statements are hard to read | 122–129 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–499 |
The class 'DirectoryIndexer' has a Modified Cyclomatic Complexity of 4 (Highest = 10). | 76–499 |
The class 'DirectoryIndexer' has a Standard Cyclomatic Complexity of 4 (Highest = 10). | 76–499 |
The class 'DirectoryIndexer' has a Cyclomatic Complexity of 4 (Highest = 10). | 76–499 |
The method 'indexListRecord' has a Modified Cyclomatic Complexity of 10. | 109–178 |
The method 'indexListRecord' has a Cyclomatic Complexity of 10. | 109–178 |
Avoid using implementation types like 'HashMap'; use the interface instead | 109 |
Avoid using implementation types like 'HashMap'; use the interface instead | 109 |
Avoid using implementation types like 'HashMap'; use the interface instead | 109 |
The method 'indexListRecord' has a Standard Cyclomatic Complexity of 10. | 109–178 |
Avoid using implementation types like 'HashMap'; use the interface instead | 109 |
Avoid variables with short names like it | 112 |
Avoid using implementation types like 'HashMap'; use the interface instead | 191 |
Avoid using implementation types like 'HashMap'; use the interface instead | 191 |
Avoid using implementation types like 'HashMap'; use the interface instead | 191 |
Avoid using implementation types like 'HashMap'; use the interface instead | 191 |
Avoid variables with short names like hm | 191 |
The method 'processIndexing' has a Cyclomatic Complexity of 10. | 211–295 |
The method 'processIndexing' has a Standard Cyclomatic Complexity of 10. | 211–295 |
The method 'processIndexing' has a Modified Cyclomatic Complexity of 10. | 211–295 |
Avoid variables with short names like hm | 215 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 281 |
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 312 |
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 316 |
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 316 |
Avoid variables with short names like ft | 318 |
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 368 |
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 371 |
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 371 |
Avoid variables with short names like ft | 373 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 475 |
Avoid appending characters as strings in StringBuffer.append. | 481 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 481 |
Violation | Ligne |
---|---|
The class 'DirectoryLuceneSearchEngine' has a Cyclomatic Complexity of 18 (Highest = 17). | 62–226 |
The class 'DirectoryLuceneSearchEngine' has a Standard Cyclomatic Complexity of 15 (Highest = 14). | 62–226 |
The class 'DirectoryLuceneSearchEngine' has a Modified Cyclomatic Complexity of 15 (Highest = 14). | 62–226 |
The method 'getSearchResults' has a Cyclomatic Complexity of 17. | 68–225 |
The method getSearchResults() has an NPath complexity of 10369 | 68–225 |
The method 'getSearchResults' has a Modified Cyclomatic Complexity of 14. | 68–225 |
Avoid really long methods. | 68–225 |
The method 'getSearchResults' has a Standard Cyclomatic Complexity of 14. | 68–225 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 219 |
Violation | Ligne |
---|---|
Avoid using implementation types like 'HashMap'; use the interface instead | 51 |
Avoid using implementation types like 'HashMap'; use the interface instead | 51 |
Violation | Ligne |
---|---|
Avoid instantiation through private constructors from outside of the constructors class. | 169 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–522 |
The class 'DirectorySearchService' has a Cyclomatic Complexity of 5 (Highest = 22). | 73–522 |
The class 'DirectorySearchService' has a Modified Cyclomatic Complexity of 4 (Highest = 17). | 73–522 |
The class 'DirectorySearchService' has a Standard Cyclomatic Complexity of 4 (Highest = 17). | 73–522 |
Possible unsafe assignment to a non-final static field in a constructor. | 80 |
Possible unsafe assignment to a non-final static field in a constructor. | 81 |
Singleton is not thread safe | 102–105 |
Avoid using implementation types like 'HashMap'; use the interface instead | 129 |
Avoid using implementation types like 'HashMap'; use the interface instead | 129 |
Avoid using implementation types like 'HashMap'; use the interface instead | 160 |
Avoid using implementation types like 'HashMap'; use the interface instead | 160 |
Avoid really long methods. | 160–333 |
Avoid long parameter lists. | 160–161 |
The method 'getSearchResults' has a Cyclomatic Complexity of 22. | 160–333 |
The method 'getSearchResults' has a Standard Cyclomatic Complexity of 17. | 160–333 |
The method getSearchResults() has an NPath complexity of 2690 | 160–333 |
The method 'getSearchResults' has a Modified Cyclomatic Complexity of 17. | 160–333 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 206 |
Deeply nested if..then statements are hard to read | 222–230 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 239 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 324 |
A method/constructor shouldnt explicitly throw java.lang.Exception | 335 |
A method/constructor shouldnt explicitly throw java.lang.Exception | 335 |
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 373 |
Avoid variables with short names like jo | 377 |
StringBuffer constructor is initialized with size 16, but has at least 147 characters appended. | 400 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 406 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 422 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 424 |
Violation | Ligne |
---|---|
Avoid using implementation types like 'HashMap'; use the interface instead | 51 |
Avoid using implementation types like 'HashMap'; use the interface instead | 51 |
Violation | Ligne |
---|---|
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 72 |
Violation | Ligne |
---|---|
The String literal "directory.transactionManager" appears 5 times in this file; the first occurrence is on line 62 | 62 |
Violation | Ligne |
---|---|
The class 'RecordService' has a Cyclomatic Complexity of 2 (Highest = 15). | 68–262 |
The class 'RecordService' has a Standard Cyclomatic Complexity of 2 (Highest = 11). | 68–262 |
The class 'RecordService' has a Modified Cyclomatic Complexity of 2 (Highest = 11). | 68–262 |
The String literal "directory.transactionManager" appears 5 times in this file; the first occurrence is on line 79 | 79 |
The method 'isFileAuthorized' has a Standard Cyclomatic Complexity of 11. | 195–261 |
The method 'isFileAuthorized' has a Modified Cyclomatic Complexity of 11. | 195–261 |
The method 'isFileAuthorized' has a Cyclomatic Complexity of 15. | 195–261 |
Deeply nested if..then statements are hard to read | 217–225 |
Deeply nested if..then statements are hard to read | 232–257 |
These nested if statements could be combined | 232–257 |
These nested if statements could be combined | 234–256 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–430 |
The class 'DirectorySearchIndexer' has a Cyclomatic Complexity of 3 (Highest = 12). | 81–430 |
Position literals first in String comparisons for EqualsIgnoreCase | 128 |
This statement may have some unnecessary parentheses | 128 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 161 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 275 |
The method 'getDocument' has a Cyclomatic Complexity of 12. | 305–395 |
The method getDocument() has an NPath complexity of 432 | 305–395 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 307 |
Avoid variables with short names like ft | 309 |
Avoid variables with short names like sb | 417 |
Avoid appending characters as strings in StringBuffer.append. | 425 |
Violation | Ligne |
---|---|
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 112 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 138 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–1193 |
Possible God class (WMC=120, ATFD=101, TCC=0.013289036544850499) | 34–1193 |
The class 'DirectoryAsynchronousUploadHandler' has a Cyclomatic Complexity of 3 (Highest = 13). | 95–1193 |
Avoid really long classes. | 95–1193 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 101 |
Use block level rather than method level synchronization | 422–433 |
Use block level rather than method level synchronization | 441–444 |
Use bitwise inversion to invert boolean values | 477 |
Avoid empty if statements | 481–486 |
The method 'reinitMap' has a Cyclomatic Complexity of 13. | 850–899 |
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' | 857 |
The user-supplied array 'bValue' is stored directly. | 1034 |
Assigning an Object to null is a code smell. Consider refactoring. | 1046 |
Returning '_bValue' may expose an internal array. | 1055 |
A method/constructor shouldnt explicitly throw java.lang.Exception | 1170 |
A method/constructor shouldnt explicitly throw java.lang.Exception | 1170 |
Violation | Ligne |
---|---|
It is a good practice to call super() in a constructor | 56–61 |
It is a good practice to call super() in a constructor | 69–73 |
Violation | Ligne |
---|---|
Possible God class (WMC=156, ATFD=186, TCC=0.0) | 34–1570 |
A high number of imports can indicate a high degree of coupling within an object. | 34–1570 |
Avoid really long classes. | 106–1570 |
The class 'DirectoryUtils' has a Cyclomatic Complexity of 4 (Highest = 10). | 106–1570 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 431 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 461 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 522 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 540 |
Avoid variables with short names like tt | 540 |
Avoid variables with short names like it | 558 |
Avoid using implementation types like 'HashMap'; use the interface instead | 625 |
Avoid using implementation types like 'HashMap'; use the interface instead | 625 |
Avoid using Literals in Conditional Statements | 938 |
Avoid variables with short names like it | 1050 |
Avoid variables with short names like it | 1066 |
Avoid variables with short names like ts | 1095 |
The method 'getListResults' has a Cyclomatic Complexity of 10. | 1172–1255 |
These nested if statements could be combined | 1463–1472 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1515 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1554 |
Violation | Ligne |
---|---|
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 185 |
Violation | Ligne |
---|---|
The class 'UrlUtils' has a Cyclomatic Complexity of 6 (Highest = 10). | 48–104 |
The method 'getMapParametersFromUrl' has a Cyclomatic Complexity of 10. | 68–103 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 70 |
Deeply nested if..then statements are hard to read | 87–96 |
Violation | Ligne |
---|---|
The class 'RecordComparator' has a Modified Cyclomatic Complexity of 8 (Highest = 12). | 54–220 |
The class 'RecordComparator' has a Cyclomatic Complexity of 14 (Highest = 25). | 54–220 |
The class 'RecordComparator' has a Standard Cyclomatic Complexity of 8 (Highest = 12). | 54–220 |
Private field '_entry' could be made final; it is only initialized in the declaration or constructor. | 58 |
Private field '_bIsAscSort' could be made final; it is only initialized in the declaration or constructor. | 59 |
Avoid variables with short names like r1 | 85 |
Avoid variables with short names like r2 | 85 |
The method 'compare' has a Standard Cyclomatic Complexity of 10. | 85–145 |
The method 'compare' has a Cyclomatic Complexity of 14. | 85–145 |
The method 'compare' has a Modified Cyclomatic Complexity of 10. | 85–145 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 103 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 115 |
The method 'getRecordFieldToCompare' has a Standard Cyclomatic Complexity of 12. | 154–219 |
Avoid variables with short names like r | 154 |
The method 'getRecordFieldToCompare' has a Cyclomatic Complexity of 25. | 154–219 |
The method 'getRecordFieldToCompare' has a Modified Cyclomatic Complexity of 12. | 154–219 |
Avoid variables with short names like rf | 156 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 178 |
Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' due to existing import 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' | 184 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–998 |
The class 'DirectoryApp' has a Cyclomatic Complexity of 16 (Highest = 60). | 103–998 |
The class 'DirectoryApp' has a Modified Cyclomatic Complexity of 10 (Highest = 35). | 103–998 |
The class 'DirectoryApp' has a Standard Cyclomatic Complexity of 10 (Highest = 35). | 103–998 |
Avoid really long methods. | 223–562 |
The method getPage() has an NCSS line count of 165 | 223–562 |
The method 'getPage' has a Standard Cyclomatic Complexity of 35. | 223–562 |
The method 'getPage' has a Cyclomatic Complexity of 60. | 223–562 |
The method 'getPage' has a Modified Cyclomatic Complexity of 35. | 223–562 |
The method getPage() has an NPath complexity of 213162602 | 223–562 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 230 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 251–252 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 271 |
Deeply nested if..then statements are hard to read | 277–281 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 287 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 345 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 453 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 469 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 499 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 508 |
Avoid using implementation types like 'HashMap'; use the interface instead | 577 |
Avoid using implementation types like 'HashMap'; use the interface instead | 577 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 609 |
The method 'getHtmlResultList' has a Cyclomatic Complexity of 10. | 664–746 |
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 713 |
The method 'getHtmlResultRecord' has a Cyclomatic Complexity of 11. | 763–850 |
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 790 |
Do not add empty strings | 826 |
Do not add empty strings | 837 |
Avoid really long methods. | 863–964 |
The method 'getSearchPage' has a Cyclomatic Complexity of 15. | 863–964 |
The method 'getSearchPage' has a Standard Cyclomatic Complexity of 12. | 863–964 |
The method getSearchPage() has an NPath complexity of 654 | 863–964 |
The method 'getSearchPage' has a Modified Cyclomatic Complexity of 12. | 863–964 |
Violation | Ligne |
---|---|
Avoid declaring a variable if it is unreferenced before a possible exit point. | 92 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 93 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 94 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 104 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 110 |
Avoid variables with short names like t | 145 |
Avoid unused method parameters such as 'plugin'. | 159 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–5975 |
This class has a bunch of public methods and attributes | 34–5975 |
Avoid unused imports such as 'fr.paris.lutece.plugins.directory.business.EntryTypeDownloadUrl' | 50 |
Avoid unused imports such as 'fr.paris.lutece.plugins.directory.business.EntryTypeDownloadUrl' | 50 |
The type has an NCSS line count of 2577 | 138–5975 |
Avoid really long classes. | 138–5975 |
The class 'DirectoryJspBean' has a Standard Cyclomatic Complexity of 4 (Highest = 20). | 138–5975 |
The class 'DirectoryJspBean' has a Modified Cyclomatic Complexity of 4 (Highest = 20). | 138–5975 |
The class 'DirectoryJspBean' has a Cyclomatic Complexity of 7 (Highest = 29). | 138–5975 |
This class has too many methods, consider refactoring it. | 139–5975 |
Avoid unused private fields such as 'MESSAGE_CANNOT_REMOVE_ENTRY_DIRECTORY_IS_NOT_EMPTY'. | 195 |
Avoid excessively long variable names like PARAMETER_DATE_MODIFICATION_SHOWN_IN_ADVANCED_SEARCH | 433 |
The field name indicates a constant but its modifiers do not | 478 |
Private field 'DEFAULT_TYPE_IMAGE' could be made final; it is only initialized in the declaration or constructor. | 478 |
Private field '_searchFields' could be made final; it is only initialized in the declaration or constructor. | 481 |
Private field '_directoryActionResult' could be made final; it is only initialized in the declaration or constructor. | 482 |
Private field '_recordService' could be made final; it is only initialized in the declaration or constructor. | 483 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 537 |
The method 'getDirectoryData' has a Cyclomatic Complexity of 29. | 592–801 |
The method getDirectoryData() has an NPath complexity of 72576 | 592–801 |
Avoid really long methods. | 592–801 |
The method getDirectoryData() has an NCSS line count of 131 | 592–801 |
The method 'getDirectoryData' has a Modified Cyclomatic Complexity of 19. | 592–801 |
The method 'getDirectoryData' has a Standard Cyclomatic Complexity of 19. | 592–801 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 595 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 598 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 599 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 607 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 609 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 610 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 611 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 612 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 613 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 614 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 615 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 618 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 619 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 620 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 621 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 622 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 623 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 624 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 627 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 628 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 629 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 630 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 631 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 632 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 633 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 638 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 639 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 640 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 815 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 836 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 885 |
The method getModifyDirectory() has an NCSS line count of 127 | 910–1127 |
Avoid really long methods. | 910–1127 |
The method getModifyDirectory() has an NPath complexity of 8064 | 910–1127 |
The method 'getModifyDirectory' has a Cyclomatic Complexity of 20. | 910–1127 |
The method 'getModifyDirectory' has a Standard Cyclomatic Complexity of 17. | 910–1127 |
The method 'getModifyDirectory' has a Modified Cyclomatic Complexity of 17. | 910–1127 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 912 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 913 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 914 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 915 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 945 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 987 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 997 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1043 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 1070 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1157 |
The method 'doChangeOrderEntry' has a Cyclomatic Complexity of 20. | 1191–1318 |
Avoid really long methods. | 1191–1318 |
The method 'doChangeOrderEntry' has a Standard Cyclomatic Complexity of 15. | 1191–1318 |
The method 'doChangeOrderEntry' has a Modified Cyclomatic Complexity of 15. | 1191–1318 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1351 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1386 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1454 |
The method 'getCreateEntry' has a Cyclomatic Complexity of 11. | 1526–1622 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1532 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1533 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1557 |
The method 'doCreateEntry' has a Cyclomatic Complexity of 10. | 1633–1682 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1635 |
Avoid really long methods. | 1693–1858 |
The method getModifyEntry() has an NPath complexity of 25920 | 1693–1858 |
The method 'getModifyEntry' has a Standard Cyclomatic Complexity of 18. | 1693–1858 |
The method 'getModifyEntry' has a Modified Cyclomatic Complexity of 18. | 1693–1858 |
The method 'getModifyEntry' has a Cyclomatic Complexity of 25. | 1693–1858 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1695 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1696 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1699 |
The method 'doModifyEntry' has a Cyclomatic Complexity of 11. | 1869–1927 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1872 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1940 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1943 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1987 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2091 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2092 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2116 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2139 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2140 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2142 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2381 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2469 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2485 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2515 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2536 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2656 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2675 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2676 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2775 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 2823 |
The method getManageDirectoryRecord() has an NCSS line count of 122 | 2955–3187 |
The method getManageDirectoryRecord() has an NPath complexity of 1539000 | 2955–3187 |
The method 'getManageDirectoryRecord' has a Cyclomatic Complexity of 25. | 2955–3187 |
The method 'getManageDirectoryRecord' has a Modified Cyclomatic Complexity of 20. | 2955–3187 |
Avoid really long methods. | 2955–3187 |
The method 'getManageDirectoryRecord' has a Standard Cyclomatic Complexity of 20. | 2955–3187 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 3002 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 3005 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 3006 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3115 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3231 |
The method 'doImportDirectoryRecord' has a Modified Cyclomatic Complexity of 13. | 3266–3409 |
The method doImportDirectoryRecord() has an NPath complexity of 2800 | 3266–3409 |
The method 'doImportDirectoryRecord' has a Standard Cyclomatic Complexity of 13. | 3266–3409 |
Avoid really long methods. | 3266–3409 |
The method 'doImportDirectoryRecord' has a Cyclomatic Complexity of 20. | 3266–3409 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 3270 |
The String literal " > " appears 4 times in this file; the first occurrence is on line 3,349 | 3349 |
The String literal "<br/>" appears 4 times in this file; the first occurrence is on line 3,351 | 3351 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3428 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3508 |
The method 'getCreateDirectoryRecordWithInitialValues' has a Standard Cyclomatic Complexity of 11. | 3571–3663 |
The method 'getCreateDirectoryRecordWithInitialValues' has a Modified Cyclomatic Complexity of 11. | 3571–3663 |
The method 'getCreateDirectoryRecordWithInitialValues' has a Cyclomatic Complexity of 13. | 3571–3663 |
The method getCreateDirectoryRecordWithInitialValues() has an NPath complexity of 150000 | 3571–3663 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3584 |
Avoid variables with short names like fn | 3625 |
Avoid variables with short names like ln | 3626 |
Avoid variables with short names like em | 3627 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3719 |
The method 'getModifyDirectoryRecord' has a Cyclomatic Complexity of 10. | 3743–3817 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3792 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3859 |
The method 'getConfirmRemoveDirectoryRecord' has a Cyclomatic Complexity of 12. | 3881–3927 |
The method 'doRemoveDirectoryRecord' has a Cyclomatic Complexity of 12. | 3938–3994 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3978 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 4029 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 4066 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 4121 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 4166 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 4204 |
The method 'doSaveTasksForm' has a Cyclomatic Complexity of 12. | 4228–4328 |
The method 'doSaveTasksForm' has a Modified Cyclomatic Complexity of 10. | 4228–4328 |
The method 'doSaveTasksForm' has a Standard Cyclomatic Complexity of 10. | 4228–4328 |
Avoid really long methods. | 4228–4328 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 4273 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 4347 |
This statement may have some unnecessary parentheses | 4347 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 4350 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 4385 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 4434 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 4476 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 4518 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 4520 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 4520 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 4855 |
Avoid variables with short names like it | 4906 |
Avoid instantiating String objects; this is usually unnecessary. | 4937 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 4972 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 5022 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 5206 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 5224 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 5258 |
The method doImportField() has an NPath complexity of 600 | 5294–5402 |
The method 'doImportField' has a Cyclomatic Complexity of 17. | 5294–5402 |
Avoid really long methods. | 5294–5402 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 5298 |
The method 'getConfirmChangeStatesRecord' has a Cyclomatic Complexity of 12. | 5413–5459 |
The method 'doChangeStatesRecord' has a Cyclomatic Complexity of 10. | 5470–5503 |
Avoid unused method parameters such as 'request'. | 5518 |
Consider using varargs for methods or constructors which take an array the last parameter. | 5518 |
The method 'moveDownEntryOrder' has a Standard Cyclomatic Complexity of 13. | 5749–5836 |
The method 'moveDownEntryOrder' has a Modified Cyclomatic Complexity of 13. | 5749–5836 |
The method 'moveDownEntryOrder' has a Cyclomatic Complexity of 16. | 5749–5836 |
The method 'moveUpEntryOrder' has a Standard Cyclomatic Complexity of 11. | 5850–5926 |
The method 'moveUpEntryOrder' has a Cyclomatic Complexity of 14. | 5850–5926 |
The method 'moveUpEntryOrder' has a Modified Cyclomatic Complexity of 11. | 5850–5926 |
Violation | Ligne |
---|---|
Avoid variables with short names like se | 52 |
Avoid variables with short names like se | 61 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–500 |
The class 'DirectoryXslJspBean' has a Cyclomatic Complexity of 4 (Highest = 11). | 82–500 |
Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 134 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 243 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 353 |
The method 'getDirectoryXslData' has a Cyclomatic Complexity of 11. | 394–461 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 399 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 401 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 402 |
Avoid variables with short names like is | 478 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 481 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–214 |
The class 'DoDownloadFile' has a Standard Cyclomatic Complexity of 6 (Highest = 13). | 77–214 |
The class 'DoDownloadFile' has a Modified Cyclomatic Complexity of 6 (Highest = 13). | 77–214 |
The class 'DoDownloadFile' has a Cyclomatic Complexity of 9 (Highest = 20). | 77–214 |
The method doDownloadFile() has an NPath complexity of 6160 | 99–195 |
The method 'doDownloadFile' has a Modified Cyclomatic Complexity of 13. | 99–195 |
The method 'doDownloadFile' has a Standard Cyclomatic Complexity of 13. | 99–195 |
The method 'doDownloadFile' has a Cyclomatic Complexity of 20. | 99–195 |
Assigning an Object to null is a code smell. Consider refactoring. | 165 |
Avoid variables with short names like os | 184 |
These nested if statements could be combined | 202–210 |
Violation | Ligne |
---|---|
Avoid declaring a variable if it is unreferenced before a possible exit point. | 74 |
Violation | Ligne |
---|---|
Abstract classes should be named AbstractXXX | 57–457 |
Too many fields | 57–457 |
Avoid using implementation types like 'HashMap'; use the interface instead | 71 |
Avoid using implementation types like 'HashMap'; use the interface instead | 71 |
Avoid using implementation types like 'HashMap'; use the interface instead | 158 |
Avoid using implementation types like 'HashMap'; use the interface instead | 158 |
Avoid using implementation types like 'HashMap'; use the interface instead | 258 |
Avoid using implementation types like 'HashMap'; use the interface instead | 258 |
Avoid empty if statements | 302–304 |
Violation | Ligne |
---|---|
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 123 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 188 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 242 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 272 |
Avoid variables with short names like e | 297 |
Avoid appending characters as strings in StringBuffer.append. | 308 |
Violation | Ligne |
---|---|
Possible God class (WMC=55, ATFD=9, TCC=0.023228803716608595) | 34–608 |
Too many fields | 51–608 |
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 72 |
Method names should not contain underscores | 378 |
Violation | Ligne |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–712 |
Possible God class (WMC=56, ATFD=97, TCC=0.09523809523809523) | 34–712 |
Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' | 79 |
Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' | 79 |
The class 'ExportDirectoryAction' has a Standard Cyclomatic Complexity of 7 (Highest = 40). | 112–712 |
The class 'ExportDirectoryAction' has a Cyclomatic Complexity of 8 (Highest = 47). | 112–712 |
The class 'ExportDirectoryAction' has a Modified Cyclomatic Complexity of 7 (Highest = 40). | 112–712 |
The method 'process' has a Cyclomatic Complexity of 47. | 195–646 |
The method 'process' has a Modified Cyclomatic Complexity of 40. | 195–646 |
The method 'process' has a Standard Cyclomatic Complexity of 40. | 195–646 |
Avoid really long methods. | 195–646 |
The method process() has an NCSS line count of 221 | 195–646 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 206 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 207 |
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 236 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 352 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 363 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 377 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 441 |
Avoid variables with short names like k | 445 |
This statement may have some unnecessary parentheses | 481 |
Avoid variables with short names like in | 584 |
Unnecessary wrapper object creation | 593 |
Avoid reassigning parameters such as 'strBufferListRecordXml' | 677 |
Violation | Ligne |
---|---|
Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' | 36 |
Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' | 36 |
Avoid unused imports such as 'java.util.Map' | 40 |
Avoid unused imports such as 'java.util.Map' | 40 |
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 42 |
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 42 |
Avoid unused imports such as 'javax.servlet.http.HttpServletResponse' | 43 |
Avoid unused imports such as 'javax.servlet.http.HttpServletResponse' | 43 |
Violation | Ligne |
---|---|
Avoid using implementation types like 'HashMap'; use the interface instead | 120 |
Avoid using implementation types like 'HashMap'; use the interface instead | 120 |
Avoid using implementation types like 'HashMap'; use the interface instead | 128 |
Avoid using implementation types like 'HashMap'; use the interface instead | 128 |