Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/directory/business/AbstractEntryTypeUpload.java

Violation Line
The class 'AbstractEntryTypeUpload' has a Cyclomatic Complexity of 5 (Highest = 17). 63379
The class 'AbstractEntryTypeUpload' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 63379
The class 'AbstractEntryTypeUpload' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 63379
Avoid excessively long variable names like PROPERTY_MESSAGE_ERROR_UPLOADING_FILE_FILE_MAX_SIZE 77
The method 'canUploadFiles' has a Standard Cyclomatic Complexity of 10. 110177
The method 'canUploadFiles' has a Modified Cyclomatic Complexity of 10. 110177
The method 'canUploadFiles' has a Cyclomatic Complexity of 17. 110177
The method canUploadFiles() has an NPath complexity of 960 110177
The method 'checkRecordFieldData' has a Cyclomatic Complexity of 11. 253285

fr/paris/lutece/plugins/directory/business/Directory.java

Violation Line
This class has a bunch of public methods and attributes 341039
Too many fields 611039
Singleton is not thread safe 144148
Singleton is not thread safe 150154
Singleton is not thread safe 156160
Singleton is not thread safe 162166
Singleton is not thread safe 168172
Singleton is not thread safe 174178
Do not add empty strings 399

fr/paris/lutece/plugins/directory/business/DirectoryDAO.java

Violation Line
The class 'DirectoryDAO' has a Modified Cyclomatic Complexity of 5 (Highest = 15). 49474
The class 'DirectoryDAO' has a Cyclomatic Complexity of 5 (Highest = 15). 49474
The class 'DirectoryDAO' has a Standard Cyclomatic Complexity of 5 (Highest = 15). 49474
Use block level rather than method level synchronization 115178
The method 'selectDirectoryList' has a Standard Cyclomatic Complexity of 15. 332448
The method selectDirectoryList() has an NPath complexity of 6912 332448
The method 'selectDirectoryList' has a Modified Cyclomatic Complexity of 15. 332448
Avoid really long methods. 332448
The method 'selectDirectoryList' has a Cyclomatic Complexity of 15. 332448

fr/paris/lutece/plugins/directory/business/DirectoryXsl.java

Violation Line
Do not add empty strings 154

fr/paris/lutece/plugins/directory/business/DirectoryXslDAO.java

Violation Line
Use block level rather than method level synchronization 91122

fr/paris/lutece/plugins/directory/business/Entry.java

Violation Line
This class has a bunch of public methods and attributes 341332
Possible God class (WMC=132, ATFD=28, TCC=0.008712871287128714) 341332
Avoid really long classes. 631332
Too many fields 631332
Assigning an Object to null is a code smell. Consider refactoring. 828
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 899
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 919
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 941
Avoid using Literals in Conditional Statements 952
Prefer StringBuffer over += for concatenating strings 954
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 976
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 998
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1018
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1039
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1127
Avoid variables with short names like b 1155
A getX() method which returns a boolean should be named isX() 12821285

fr/paris/lutece/plugins/directory/business/EntryDAO.java

Violation Line
Possible God class (WMC=120, ATFD=236, TCC=0.03333333333333333) 341147
The class 'EntryDAO' has a Modified Cyclomatic Complexity of 8 (Highest = 35). 471147
Avoid really long classes. 471147
The class 'EntryDAO' has a Standard Cyclomatic Complexity of 8 (Highest = 35). 471147
The class 'EntryDAO' has a Cyclomatic Complexity of 8 (Highest = 35). 471147
Use block level rather than method level synchronization 170226
Avoid really long methods. 232333
Avoid really long methods. 415522
The method 'setSelectFilter' has a Standard Cyclomatic Complexity of 21. 415522
The method 'setSelectFilter' has a Modified Cyclomatic Complexity of 21. 415522
The method setSelectFilter() has an NPath complexity of 1048576 415522
The method 'setSelectFilter' has a Cyclomatic Complexity of 21. 415522
The method setSelectFilterValues() has an NPath complexity of 524288 524643
Avoid really long methods. 524643
The method 'setSelectFilterValues' has a Standard Cyclomatic Complexity of 20. 524643
The method 'setSelectFilterValues' has a Modified Cyclomatic Complexity of 20. 524643
The method 'setSelectFilterValues' has a Cyclomatic Complexity of 20. 524643
Avoid declaring a variable if it is unreferenced before a possible exit point. 648
Avoid declaring a variable if it is unreferenced before a possible exit point. 650
The method 'selectNumberEntryByFilter' has a Modified Cyclomatic Complexity of 35. 794997
The method 'selectNumberEntryByFilter' has a Standard Cyclomatic Complexity of 35. 794997
Avoid really long methods. 794997
The method 'selectNumberEntryByFilter' has a Cyclomatic Complexity of 35. 794997
Avoid declaring a variable if it is unreferenced before a possible exit point. 1006
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1015
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1017

fr/paris/lutece/plugins/directory/business/EntryFilter.java

Violation Line
This class has a bunch of public methods and attributes 34652
Too many fields 41652

fr/paris/lutece/plugins/directory/business/EntryHome.java

Violation Line
This statement may have some unnecessary parentheses 235
Avoid empty catch blocks 242245
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 242

fr/paris/lutece/plugins/directory/business/EntryTypeArray.java

Violation Line
Possible God class (WMC=47, ATFD=67, TCC=0.0) 34412
The class 'EntryTypeArray' has a Modified Cyclomatic Complexity of 4 (Highest = 17). 59412
The class 'EntryTypeArray' has a Standard Cyclomatic Complexity of 4 (Highest = 17). 59412
The class 'EntryTypeArray' has a Cyclomatic Complexity of 4 (Highest = 20). 59412
This final field could be made static 61
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
This final field could be made static 68
The method getEntryData() has an NPath complexity of 11500 116263
The method 'getEntryData' has a Cyclomatic Complexity of 20. 116263
The method 'getEntryData' has a Standard Cyclomatic Complexity of 17. 116263
Avoid really long methods. 116263
The method 'getEntryData' has a Modified Cyclomatic Complexity of 17. 116263
Avoid declaring a variable if it is unreferenced before a possible exit point. 119
Assigning an Object to null is a code smell. Consider refactoring. 119
Avoid declaring a variable if it is unreferenced before a possible exit point. 120121
Assigning an Object to null is a code smell. Consider refactoring. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133

fr/paris/lutece/plugins/directory/business/EntryTypeCamera.java

Violation Line
Possible God class (WMC=54, ATFD=74, TCC=0.01282051282051282) 34509
The class 'EntryTypeCamera' has a Cyclomatic Complexity of 4 (Highest = 15). 71509
The class 'EntryTypeCamera' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 71509
The class 'EntryTypeCamera' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 71509
The field name indicates a constant but its modifiers do not 73
Private field 'PROPERTY_IMAGE_TITLE' could be made final; it is only initialized in the declaration or constructor. 73
The String literal "directory.create_entry.label_width" appears 4 times in this file; the first occurrence is on line 74 74
This final field could be made static 85
This final field could be made static 86
This final field could be made static 87
This final field could be made static 88
This final field could be made static 89
This final field could be made static 90
This final field could be made static 91
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Assigning an Object to null is a code smell. Consider refactoring. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
Avoid declaring a variable if it is unreferenced before a possible exit point. 138
Avoid declaring a variable if it is unreferenced before a possible exit point. 139
Avoid declaring a variable if it is unreferenced before a possible exit point. 141
Avoid declaring a variable if it is unreferenced before a possible exit point. 142
Avoid declaring a variable if it is unreferenced before a possible exit point. 143
Avoid declaring a variable if it is unreferenced before a possible exit point. 144
Avoid declaring a variable if it is unreferenced before a possible exit point. 145
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 11. 226308
The method 'getRecordFieldData' has a Cyclomatic Complexity of 15. 226308
The method getRecordFieldData() has an NPath complexity of 3012 226308
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 11. 226308
Avoid variables with short names like c 243
Do not add empty strings 264
New exception is thrown in catch block, original stack trace may be lost 281
The method 'checkEntryData' has a Cyclomatic Complexity of 12. 361420
Avoid declaring a variable if it is unreferenced before a possible exit point. 373
Avoid declaring a variable if it is unreferenced before a possible exit point. 374
New exception is thrown in catch block, original stack trace may be lost 449
Document empty method 507508

fr/paris/lutece/plugins/directory/business/EntryTypeCheckBox.java

Violation Line
The class 'EntryTypeCheckBox' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 58344
The class 'EntryTypeCheckBox' has a Cyclomatic Complexity of 3 (Highest = 11). 58344
The class 'EntryTypeCheckBox' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 58344
This final field could be made static 60
This final field could be made static 61
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
Avoid declaring a variable if it is unreferenced before a possible exit point. 118
Assigning an Object to null is a code smell. Consider refactoring. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 119120
Assigning an Object to null is a code smell. Consider refactoring. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 10. 247304
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 10. 247304
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. 247304
Avoid declaring a variable if it is unreferenced before a possible exit point. 253
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 287

fr/paris/lutece/plugins/directory/business/EntryTypeComment.java

Violation Line
This final field could be made static 52
This final field could be made static 53
This final field could be made static 54
This final field could be made static 55

fr/paris/lutece/plugins/directory/business/EntryTypeDate.java

Violation Line
Possible God class (WMC=58, ATFD=66, TCC=0.03636363636363636) 34428
The class 'EntryTypeDate' has a Standard Cyclomatic Complexity of 4 (Highest = 16). 58428
The class 'EntryTypeDate' has a Modified Cyclomatic Complexity of 4 (Highest = 16). 58428
The class 'EntryTypeDate' has a Cyclomatic Complexity of 5 (Highest = 28). 58428
This final field could be made static 67
This final field could be made static 68
This final field could be made static 69
This final field could be made static 70
This final field could be made static 71
This final field could be made static 72
This final field could be made static 73
This final field could be made static 74
The method 'getEntryData' has a Cyclomatic Complexity of 10. 122196
The method getEntryData() has an NPath complexity of 1200 122196
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Assigning an Object to null is a code smell. Consider refactoring. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126127
Assigning an Object to null is a code smell. Consider refactoring. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
Avoid declaring a variable if it is unreferenced before a possible exit point. 134
Avoid declaring a variable if it is unreferenced before a possible exit point. 135
Avoid declaring a variable if it is unreferenced before a possible exit point. 136
Avoid declaring a variable if it is unreferenced before a possible exit point. 137
Avoid declaring a variable if it is unreferenced before a possible exit point. 138
Avoid declaring a variable if it is unreferenced before a possible exit point. 140
Avoid declaring a variable if it is unreferenced before a possible exit point. 141
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 16. 242348
Avoid really long methods. 242348
The method 'getRecordFieldData' has a Cyclomatic Complexity of 28. 242348
The method getRecordFieldData() has an NPath complexity of 3267 242348
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 16. 242348
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 322
Assigning an Object to null is a code smell. Consider refactoring. 322
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 365
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 413

fr/paris/lutece/plugins/directory/business/EntryTypeDirectory.java

Violation Line
Possible God class (WMC=48, ATFD=63, TCC=0.0) 34411
The class 'EntryTypeDirectory' has a Cyclomatic Complexity of 4 (Highest = 12). 64411
This final field could be made static 81
This final field could be made static 82
This final field could be made static 83
This final field could be made static 84
This final field could be made static 85
This final field could be made static 86
This final field could be made static 87
This final field could be made static 88
The method 'getEntryData' has a Cyclomatic Complexity of 10. 136216
The method getEntryData() has an NPath complexity of 600 136216
Avoid declaring a variable if it is unreferenced before a possible exit point. 139
Assigning an Object to null is a code smell. Consider refactoring. 139
Avoid declaring a variable if it is unreferenced before a possible exit point. 140141
Assigning an Object to null is a code smell. Consider refactoring. 141
Avoid declaring a variable if it is unreferenced before a possible exit point. 142
Avoid declaring a variable if it is unreferenced before a possible exit point. 143
Avoid declaring a variable if it is unreferenced before a possible exit point. 144
Avoid declaring a variable if it is unreferenced before a possible exit point. 145
Avoid declaring a variable if it is unreferenced before a possible exit point. 146
Avoid declaring a variable if it is unreferenced before a possible exit point. 147
Avoid declaring a variable if it is unreferenced before a possible exit point. 148
Avoid declaring a variable if it is unreferenced before a possible exit point. 149
Avoid declaring a variable if it is unreferenced before a possible exit point. 150
Avoid declaring a variable if it is unreferenced before a possible exit point. 154
Avoid declaring a variable if it is unreferenced before a possible exit point. 155
Assigning an Object to null is a code smell. Consider refactoring. 252
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 252
The method 'convertRecordFieldValueToString' has a Cyclomatic Complexity of 12. 318392

fr/paris/lutece/plugins/directory/business/EntryTypeDirectoryRemovalListener.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 58
Avoid unnecessary if..then..else statements when returning booleans 6972

fr/paris/lutece/plugins/directory/business/EntryTypeDownloadUrl.java

Violation Line
Possible God class (WMC=70, ATFD=91, TCC=0.03676470588235294) 34648
The class 'EntryTypeDownloadUrl' has a Cyclomatic Complexity of 4 (Highest = 22). 70648
The class 'EntryTypeDownloadUrl' has a Modified Cyclomatic Complexity of 3 (Highest = 17). 70648
The class 'EntryTypeDownloadUrl' has a Standard Cyclomatic Complexity of 3 (Highest = 17). 70648
This final field could be made static 103
This final field could be made static 104
This final field could be made static 105
This final field could be made static 106
This final field could be made static 107
This final field could be made static 108
This final field could be made static 109
This final field could be made static 110
Avoid declaring a variable if it is unreferenced before a possible exit point. 160
Avoid declaring a variable if it is unreferenced before a possible exit point. 161
Assigning an Object to null is a code smell. Consider refactoring. 161
Avoid declaring a variable if it is unreferenced before a possible exit point. 162163
Assigning an Object to null is a code smell. Consider refactoring. 163
Avoid declaring a variable if it is unreferenced before a possible exit point. 164
Avoid declaring a variable if it is unreferenced before a possible exit point. 165
Avoid declaring a variable if it is unreferenced before a possible exit point. 166
Avoid declaring a variable if it is unreferenced before a possible exit point. 167
Avoid declaring a variable if it is unreferenced before a possible exit point. 168
Avoid declaring a variable if it is unreferenced before a possible exit point. 169
Avoid declaring a variable if it is unreferenced before a possible exit point. 170
Avoid declaring a variable if it is unreferenced before a possible exit point. 171
Avoid declaring a variable if it is unreferenced before a possible exit point. 172
Avoid declaring a variable if it is unreferenced before a possible exit point. 173
Avoid declaring a variable if it is unreferenced before a possible exit point. 174
The method 'getRecordFieldData' has a Cyclomatic Complexity of 22. 262397
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 17. 262397
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 17. 262397
Avoid really long methods. 262397
The method getRecordFieldData() has an NPath complexity of 208 262397
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 349
New exception is thrown in catch block, original stack trace may be lost 351
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 412
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 416
The method checkRecordFieldData() has an NPath complexity of 420 511564
The method 'checkRecordFieldData' has a Cyclomatic Complexity of 15. 511564
Avoid declaring a variable if it is unreferenced before a possible exit point. 523

fr/paris/lutece/plugins/directory/business/EntryTypeFile.java

Violation Line
The class 'EntryTypeFile' has a Cyclomatic Complexity of 3 (Highest = 16). 67426
The class 'EntryTypeFile' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 67426
The class 'EntryTypeFile' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 67426
This final field could be made static 69
This final field could be made static 70
This final field could be made static 71
This final field could be made static 72
This final field could be made static 73
This final field could be made static 74
This final field could be made static 75
Avoid declaring a variable if it is unreferenced before a possible exit point. 111
Avoid declaring a variable if it is unreferenced before a possible exit point. 112
Assigning an Object to null is a code smell. Consider refactoring. 112
Avoid declaring a variable if it is unreferenced before a possible exit point. 113
Avoid declaring a variable if it is unreferenced before a possible exit point. 114
Avoid declaring a variable if it is unreferenced before a possible exit point. 115
Avoid declaring a variable if it is unreferenced before a possible exit point. 116
Avoid declaring a variable if it is unreferenced before a possible exit point. 117
Avoid declaring a variable if it is unreferenced before a possible exit point. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 119
Avoid declaring a variable if it is unreferenced before a possible exit point. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid variables with short names like ph 200
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 11. 211275
The method 'getRecordFieldData' has a Cyclomatic Complexity of 16. 211275
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 11. 211275

fr/paris/lutece/plugins/directory/business/EntryTypeGeolocation.java

Violation Line
Possible God class (WMC=84, ATFD=147, TCC=0.02766798418972332) 34915
The class 'EntryTypeGeolocation' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 63915
The class 'EntryTypeGeolocation' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 63915
The class 'EntryTypeGeolocation' has a Cyclomatic Complexity of 4 (Highest = 17). 63915
The method 'getEntryData' has a Standard Cyclomatic Complexity of 16. 207404
The method 'getEntryData' has a Cyclomatic Complexity of 17. 207404
Avoid really long methods. 207404
The method getEntryData() has an NPath complexity of 768000 207404
The method 'getEntryData' has a Modified Cyclomatic Complexity of 16. 207404
The method getEntryData() has an NCSS line count of 120 207404
Avoid declaring a variable if it is unreferenced before a possible exit point. 210
Assigning an Object to null is a code smell. Consider refactoring. 210
Avoid declaring a variable if it is unreferenced before a possible exit point. 211212
Assigning an Object to null is a code smell. Consider refactoring. 212
Avoid declaring a variable if it is unreferenced before a possible exit point. 213
Avoid declaring a variable if it is unreferenced before a possible exit point. 214
Avoid declaring a variable if it is unreferenced before a possible exit point. 215
Avoid declaring a variable if it is unreferenced before a possible exit point. 216
Avoid declaring a variable if it is unreferenced before a possible exit point. 217
Avoid declaring a variable if it is unreferenced before a possible exit point. 218
Avoid declaring a variable if it is unreferenced before a possible exit point. 219
Avoid declaring a variable if it is unreferenced before a possible exit point. 220
Avoid declaring a variable if it is unreferenced before a possible exit point. 221
Avoid declaring a variable if it is unreferenced before a possible exit point. 222
Avoid declaring a variable if it is unreferenced before a possible exit point. 223
Avoid declaring a variable if it is unreferenced before a possible exit point. 224
Avoid declaring a variable if it is unreferenced before a possible exit point. 225
Avoid declaring a variable if it is unreferenced before a possible exit point. 226
Avoid declaring a variable if it is unreferenced before a possible exit point. 227
Avoid declaring a variable if it is unreferenced before a possible exit point. 228
Avoid declaring a variable if it is unreferenced before a possible exit point. 231
Avoid declaring a variable if it is unreferenced before a possible exit point. 234
These nested if statements could be combined 484492
The method 'getRecordFieldData' has a Cyclomatic Complexity of 12. 501585
Avoid declaring a variable if it is unreferenced before a possible exit point. 511
Avoid declaring a variable if it is unreferenced before a possible exit point. 514
Avoid declaring a variable if it is unreferenced before a possible exit point. 516
Avoid declaring a variable if it is unreferenced before a possible exit point. 517
Avoid variables with short names like b 592
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 739
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 835

fr/paris/lutece/plugins/directory/business/EntryTypeGroup.java

Violation Line
This final field could be made static 53

fr/paris/lutece/plugins/directory/business/EntryTypeImg.java

Violation Line
Possible God class (WMC=91, ATFD=169, TCC=0.08571428571428572) 34771
The class 'EntryTypeImg' has a Cyclomatic Complexity of 6 (Highest = 30). 77771
The class 'EntryTypeImg' has a Standard Cyclomatic Complexity of 4 (Highest = 18). 77771
The class 'EntryTypeImg' has a Modified Cyclomatic Complexity of 4 (Highest = 18). 77771
The String literal "directory.create_entry.label_width" appears 4 times in this file; the first occurrence is on line 79 79
This final field could be made static 101
This final field could be made static 103
This final field could be made static 104
This final field could be made static 105
This final field could be made static 106
This final field could be made static 107
This final field could be made static 108
Avoid declaring a variable if it is unreferenced before a possible exit point. 144
Avoid declaring a variable if it is unreferenced before a possible exit point. 145
Assigning an Object to null is a code smell. Consider refactoring. 145
Avoid declaring a variable if it is unreferenced before a possible exit point. 146
Avoid declaring a variable if it is unreferenced before a possible exit point. 147
Avoid declaring a variable if it is unreferenced before a possible exit point. 148
Avoid declaring a variable if it is unreferenced before a possible exit point. 149
Avoid declaring a variable if it is unreferenced before a possible exit point. 150
Avoid declaring a variable if it is unreferenced before a possible exit point. 156
Avoid declaring a variable if it is unreferenced before a possible exit point. 157
Avoid declaring a variable if it is unreferenced before a possible exit point. 159
Avoid declaring a variable if it is unreferenced before a possible exit point. 160
Avoid declaring a variable if it is unreferenced before a possible exit point. 161
Avoid declaring a variable if it is unreferenced before a possible exit point. 162
Avoid declaring a variable if it is unreferenced before a possible exit point. 163
The method getRecordFieldData() has an NPath complexity of 5312 244394
Avoid really long methods. 244394
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 16. 244394
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 16. 244394
The method 'getRecordFieldData' has a Cyclomatic Complexity of 24. 244394
Deeply nested if..then statements are hard to read 297300
Deeply nested if..then statements are hard to read 309338
Deeply nested if..then statements are hard to read 343372
The method 'checkEntryData' has a Modified Cyclomatic Complexity of 18. 447568
The method checkEntryData() has an NPath complexity of 143361 447568
The method 'checkEntryData' has a Standard Cyclomatic Complexity of 18. 447568
The method 'checkEntryData' has a Cyclomatic Complexity of 30. 447568
Avoid really long methods. 447568
Avoid declaring a variable if it is unreferenced before a possible exit point. 465
Avoid declaring a variable if it is unreferenced before a possible exit point. 466

fr/paris/lutece/plugins/directory/business/EntryTypeInternalLink.java

Violation Line
The class 'EntryTypeInternalLink' has a Cyclomatic Complexity of 4 (Highest = 11). 58245
This final field could be made static 60
This final field could be made static 61
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
The method getEntryData() has an NPath complexity of 600 115185
Assigning an Object to null is a code smell. Consider refactoring. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 119120
Assigning an Object to null is a code smell. Consider refactoring. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. 209244
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 214
Assigning an Object to null is a code smell. Consider refactoring. 214
Prefer StringBuffer over += for concatenating strings 229

fr/paris/lutece/plugins/directory/business/EntryTypeMail.java

Violation Line
Possible God class (WMC=48, ATFD=50, TCC=0.0) 34401
The class 'EntryTypeMail' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 66401
The class 'EntryTypeMail' has a Cyclomatic Complexity of 4 (Highest = 20). 66401
The class 'EntryTypeMail' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 66401
This final field could be made static 81
This final field could be made static 82
This final field could be made static 83
This final field could be made static 84
This final field could be made static 85
This final field could be made static 86
This final field could be made static 87
This final field could be made static 88
The method 'getEntryData' has a Modified Cyclomatic Complexity of 10. 136229
The method getEntryData() has an NPath complexity of 5000 136229
The method 'getEntryData' has a Standard Cyclomatic Complexity of 10. 136229
The method 'getEntryData' has a Cyclomatic Complexity of 14. 136229
Avoid declaring a variable if it is unreferenced before a possible exit point. 139
Assigning an Object to null is a code smell. Consider refactoring. 139
Avoid declaring a variable if it is unreferenced before a possible exit point. 140141
Assigning an Object to null is a code smell. Consider refactoring. 141
Avoid declaring a variable if it is unreferenced before a possible exit point. 142
Avoid declaring a variable if it is unreferenced before a possible exit point. 143
Avoid declaring a variable if it is unreferenced before a possible exit point. 144
Avoid declaring a variable if it is unreferenced before a possible exit point. 145
Avoid declaring a variable if it is unreferenced before a possible exit point. 146
Avoid declaring a variable if it is unreferenced before a possible exit point. 147
Avoid declaring a variable if it is unreferenced before a possible exit point. 148
Avoid declaring a variable if it is unreferenced before a possible exit point. 149
Avoid declaring a variable if it is unreferenced before a possible exit point. 150
Avoid declaring a variable if it is unreferenced before a possible exit point. 153
Avoid declaring a variable if it is unreferenced before a possible exit point. 154
Avoid declaring a variable if it is unreferenced before a possible exit point. 155
Avoid declaring a variable if it is unreferenced before a possible exit point. 157
Avoid declaring a variable if it is unreferenced before a possible exit point. 158
The method 'getRecordFieldData' has a Cyclomatic Complexity of 20. 288352
The method getRecordFieldData() has an NPath complexity of 2910 288352
The method 'getRecordFieldData' has a Standard Cyclomatic Complexity of 11. 288352
The method 'getRecordFieldData' has a Modified Cyclomatic Complexity of 11. 288352
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 293
Assigning an Object to null is a code smell. Consider refactoring. 293
Prefer StringBuffer over += for concatenating strings 309
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 321
Prefer StringBuffer over += for concatenating strings 366
Prefer StringBuffer over += for concatenating strings 366

fr/paris/lutece/plugins/directory/business/EntryTypeMyLuteceUser.java

Violation Line
The class 'EntryTypeMyLuteceUser' has a Cyclomatic Complexity of 4 (Highest = 10). 68446
The method getEntryData() has an NPath complexity of 900 162242
Assigning an Object to null is a code smell. Consider refactoring. 165
Avoid declaring a variable if it is unreferenced before a possible exit point. 165
Avoid declaring a variable if it is unreferenced before a possible exit point. 166167
Assigning an Object to null is a code smell. Consider refactoring. 167
Avoid declaring a variable if it is unreferenced before a possible exit point. 168
Avoid declaring a variable if it is unreferenced before a possible exit point. 169
Avoid declaring a variable if it is unreferenced before a possible exit point. 170
Avoid declaring a variable if it is unreferenced before a possible exit point. 171
Avoid declaring a variable if it is unreferenced before a possible exit point. 172
Avoid declaring a variable if it is unreferenced before a possible exit point. 173
Avoid declaring a variable if it is unreferenced before a possible exit point. 174
Avoid declaring a variable if it is unreferenced before a possible exit point. 175
Avoid declaring a variable if it is unreferenced before a possible exit point. 176
Avoid declaring a variable if it is unreferenced before a possible exit point. 177
Avoid declaring a variable if it is unreferenced before a possible exit point. 178
Avoid declaring a variable if it is unreferenced before a possible exit point. 181
Avoid declaring a variable if it is unreferenced before a possible exit point. 183
Avoid declaring a variable if it is unreferenced before a possible exit point. 184
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 252
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 308
The method 'convertRecordFieldValueToString' has a Cyclomatic Complexity of 10. 344380
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 417

fr/paris/lutece/plugins/directory/business/EntryTypeNumbering.java

Violation Line
The class 'EntryTypeNumbering' has a Cyclomatic Complexity of 3 (Highest = 10). 66374
This final field could be made static 75
This final field could be made static 76
This final field could be made static 77
This final field could be made static 78
This final field could be made static 79
This final field could be made static 80
This final field could be made static 81
This final field could be made static 82
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 136
The method getEntryData() has an NPath complexity of 300 153212
Avoid declaring a variable if it is unreferenced before a possible exit point. 156157
Assigning an Object to null is a code smell. Consider refactoring. 157
Avoid declaring a variable if it is unreferenced before a possible exit point. 158
Avoid declaring a variable if it is unreferenced before a possible exit point. 160
Avoid declaring a variable if it is unreferenced before a possible exit point. 161
Avoid declaring a variable if it is unreferenced before a possible exit point. 162
Avoid declaring a variable if it is unreferenced before a possible exit point. 163
Avoid declaring a variable if it is unreferenced before a possible exit point. 164
Avoid declaring a variable if it is unreferenced before a possible exit point. 165
Avoid declaring a variable if it is unreferenced before a possible exit point. 166
Avoid declaring a variable if it is unreferenced before a possible exit point. 167
Avoid declaring a variable if it is unreferenced before a possible exit point. 168
The method getRecordFieldData() has an NPath complexity of 200 236302
The method 'getRecordFieldData' has a Cyclomatic Complexity of 10. 236302
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 257
Assigning an Object to null is a code smell. Consider refactoring. 257

fr/paris/lutece/plugins/directory/business/EntryTypeRadioButton.java

Violation Line
The class 'EntryTypeRadioButton' has a Cyclomatic Complexity of 3 (Highest = 11). 57308
This final field could be made static 59
This final field could be made static 60
This final field could be made static 61
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
Avoid declaring a variable if it is unreferenced before a possible exit point. 117
Assigning an Object to null is a code smell. Consider refactoring. 117
Avoid declaring a variable if it is unreferenced before a possible exit point. 118119
Assigning an Object to null is a code smell. Consider refactoring. 119
Avoid declaring a variable if it is unreferenced before a possible exit point. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
Avoid declaring a variable if it is unreferenced before a possible exit point. 134
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. 225268
The method getRecordFieldData() has an NPath complexity of 300 225268
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 228
Assigning an Object to null is a code smell. Consider refactoring. 228
These nested if statements could be combined 241244
Deeply nested if..then statements are hard to read 255258
Deeply nested if..then statements are hard to read 260263

fr/paris/lutece/plugins/directory/business/EntryTypeRemoteMyLuteceUser.java

Violation Line
The class 'EntryTypeRemoteMyLuteceUser' has a Cyclomatic Complexity of 3 (Highest = 10). 65372
The method getEntryData() has an NPath complexity of 900 151231
Assigning an Object to null is a code smell. Consider refactoring. 154
Avoid declaring a variable if it is unreferenced before a possible exit point. 154
Avoid declaring a variable if it is unreferenced before a possible exit point. 155156
Assigning an Object to null is a code smell. Consider refactoring. 156
Avoid declaring a variable if it is unreferenced before a possible exit point. 157
Avoid declaring a variable if it is unreferenced before a possible exit point. 158
Avoid declaring a variable if it is unreferenced before a possible exit point. 159
Avoid declaring a variable if it is unreferenced before a possible exit point. 160
Avoid declaring a variable if it is unreferenced before a possible exit point. 161
Avoid declaring a variable if it is unreferenced before a possible exit point. 162
Avoid declaring a variable if it is unreferenced before a possible exit point. 163
Avoid declaring a variable if it is unreferenced before a possible exit point. 164
Avoid declaring a variable if it is unreferenced before a possible exit point. 165
Avoid declaring a variable if it is unreferenced before a possible exit point. 166
Avoid declaring a variable if it is unreferenced before a possible exit point. 167
Avoid declaring a variable if it is unreferenced before a possible exit point. 170
Avoid declaring a variable if it is unreferenced before a possible exit point. 172
Avoid declaring a variable if it is unreferenced before a possible exit point. 173
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 240
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 259
The method 'convertRecordFieldValueToString' has a Cyclomatic Complexity of 10. 286322

fr/paris/lutece/plugins/directory/business/EntryTypeRichText.java

Violation Line
The class 'EntryTypeRichText' has a Cyclomatic Complexity of 3 (Highest = 11). 58265
This final field could be made static 60
This final field could be made static 61
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
The method getEntryData() has an NPath complexity of 600 115185
Avoid declaring a variable if it is unreferenced before a possible exit point. 118
Assigning an Object to null is a code smell. Consider refactoring. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 119120
Assigning an Object to null is a code smell. Consider refactoring. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. 209244
Assigning an Object to null is a code smell. Consider refactoring. 214
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 214
Prefer StringBuffer over += for concatenating strings 229

fr/paris/lutece/plugins/directory/business/EntryTypeSQL.java

Violation Line
The class 'EntryTypeSQL' has a Cyclomatic Complexity of 3 (Highest = 11). 58317
This final field could be made static 60
This final field could be made static 61
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
The method getEntryData() has an NPath complexity of 500 115181
Assigning an Object to null is a code smell. Consider refactoring. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 119120
Assigning an Object to null is a code smell. Consider refactoring. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. 214249
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 219
Assigning an Object to null is a code smell. Consider refactoring. 219
Prefer StringBuffer over += for concatenating strings 234

fr/paris/lutece/plugins/directory/business/EntryTypeSelect.java

Violation Line
The class 'EntryTypeSelect' has a Cyclomatic Complexity of 3 (Highest = 11). 58352
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
This final field could be made static 68
This final field could be made static 69
The method getEntryData() has an NPath complexity of 500 117190
Avoid declaring a variable if it is unreferenced before a possible exit point. 120
Assigning an Object to null is a code smell. Consider refactoring. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121122
Assigning an Object to null is a code smell. Consider refactoring. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
Avoid declaring a variable if it is unreferenced before a possible exit point. 136
Avoid declaring a variable if it is unreferenced before a possible exit point. 137
The method getRecordFieldData() has an NPath complexity of 300 242285
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. 242285
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 245
Assigning an Object to null is a code smell. Consider refactoring. 245
These nested if statements could be combined 258261

fr/paris/lutece/plugins/directory/business/EntryTypeText.java

Violation Line
The class 'EntryTypeText' has a Cyclomatic Complexity of 4 (Highest = 18). 63353
The class 'EntryTypeText' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 63353
The class 'EntryTypeText' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 63353
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
This final field could be made static 68
This final field could be made static 69
This final field could be made static 70
This final field could be made static 71
This final field could be made static 72
The method 'getEntryData' has a Standard Cyclomatic Complexity of 10. 120215
The method 'getEntryData' has a Modified Cyclomatic Complexity of 10. 120215
The method getEntryData() has an NPath complexity of 5000 120215
The method 'getEntryData' has a Cyclomatic Complexity of 14. 120215
Assigning an Object to null is a code smell. Consider refactoring. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124125
Assigning an Object to null is a code smell. Consider refactoring. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
Avoid declaring a variable if it is unreferenced before a possible exit point. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
Avoid declaring a variable if it is unreferenced before a possible exit point. 134
Avoid declaring a variable if it is unreferenced before a possible exit point. 137
Avoid declaring a variable if it is unreferenced before a possible exit point. 138
Avoid declaring a variable if it is unreferenced before a possible exit point. 139
Avoid declaring a variable if it is unreferenced before a possible exit point. 140
Avoid declaring a variable if it is unreferenced before a possible exit point. 142
Avoid declaring a variable if it is unreferenced before a possible exit point. 143
The method 'getRecordFieldData' has a Cyclomatic Complexity of 18. 274322
The method getRecordFieldData() has an NPath complexity of 990 274322
Assigning an Object to null is a code smell. Consider refactoring. 279
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 279
Prefer StringBuffer over += for concatenating strings 295
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 307

fr/paris/lutece/plugins/directory/business/EntryTypeTextArea.java

Violation Line
The class 'EntryTypeTextArea' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 58292
The class 'EntryTypeTextArea' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 58292
The class 'EntryTypeTextArea' has a Cyclomatic Complexity of 4 (Highest = 14). 58292
This final field could be made static 60
This final field could be made static 61
This final field could be made static 62
This final field could be made static 63
This final field could be made static 64
This final field could be made static 65
This final field could be made static 66
This final field could be made static 67
The method 'getEntryData' has a Standard Cyclomatic Complexity of 11. 115214
The method getEntryData() has an NPath complexity of 4200 115214
The method 'getEntryData' has a Cyclomatic Complexity of 14. 115214
The method 'getEntryData' has a Modified Cyclomatic Complexity of 11. 115214
Assigning an Object to null is a code smell. Consider refactoring. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 119120
Assigning an Object to null is a code smell. Consider refactoring. 120
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 122
Avoid declaring a variable if it is unreferenced before a possible exit point. 123
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid declaring a variable if it is unreferenced before a possible exit point. 125
Avoid declaring a variable if it is unreferenced before a possible exit point. 126
Avoid declaring a variable if it is unreferenced before a possible exit point. 127
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
Avoid declaring a variable if it is unreferenced before a possible exit point. 134
Avoid declaring a variable if it is unreferenced before a possible exit point. 136
Avoid declaring a variable if it is unreferenced before a possible exit point. 137
The method 'getRecordFieldData' has a Cyclomatic Complexity of 11. 238273
Assigning an Object to null is a code smell. Consider refactoring. 243
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 243
Prefer StringBuffer over += for concatenating strings 258

fr/paris/lutece/plugins/directory/business/EntryTypeUrl.java

Violation Line
The class 'EntryTypeUrl' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 63371
The class 'EntryTypeUrl' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 63371
The class 'EntryTypeUrl' has a Cyclomatic Complexity of 4 (Highest = 18). 63371
This final field could be made static 71
This final field could be made static 72
This final field could be made static 73
This final field could be made static 74
This final field could be made static 75
This final field could be made static 76
This final field could be made static 77
This final field could be made static 78
The method 'getEntryData' has a Cyclomatic Complexity of 14. 126219
The method 'getEntryData' has a Modified Cyclomatic Complexity of 10. 126219
The method getEntryData() has an NPath complexity of 5000 126219
The method 'getEntryData' has a Standard Cyclomatic Complexity of 10. 126219
Assigning an Object to null is a code smell. Consider refactoring. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 130131
Assigning an Object to null is a code smell. Consider refactoring. 131
Avoid declaring a variable if it is unreferenced before a possible exit point. 132
Avoid declaring a variable if it is unreferenced before a possible exit point. 133
Avoid declaring a variable if it is unreferenced before a possible exit point. 134
Avoid declaring a variable if it is unreferenced before a possible exit point. 135
Avoid declaring a variable if it is unreferenced before a possible exit point. 136
Avoid declaring a variable if it is unreferenced before a possible exit point. 137
Avoid declaring a variable if it is unreferenced before a possible exit point. 138
Avoid declaring a variable if it is unreferenced before a possible exit point. 139
Avoid declaring a variable if it is unreferenced before a possible exit point. 140
Avoid declaring a variable if it is unreferenced before a possible exit point. 143
Avoid declaring a variable if it is unreferenced before a possible exit point. 144
Avoid declaring a variable if it is unreferenced before a possible exit point. 145
Avoid declaring a variable if it is unreferenced before a possible exit point. 147
Avoid declaring a variable if it is unreferenced before a possible exit point. 148
The method getRecordFieldData() has an NPath complexity of 990 278326
The method 'getRecordFieldData' has a Cyclomatic Complexity of 18. 278326
Assigning an Object to null is a code smell. Consider refactoring. 283
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 283
Prefer StringBuffer over += for concatenating strings 299
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 311
Prefer StringBuffer over += for concatenating strings 338
Prefer StringBuffer over += for concatenating strings 338

fr/paris/lutece/plugins/directory/business/Field.java

Violation Line
Too many fields 47393

fr/paris/lutece/plugins/directory/business/FieldDAO.java

Violation Line
Use block level rather than method level synchronization 131158
Assigning an Object to null is a code smell. Consider refactoring. 146
Assigning an Object to null is a code smell. Consider refactoring. 271

fr/paris/lutece/plugins/directory/business/FieldHome.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 151
Deeply nested if..then statements are hard to read 151164
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 196
Deeply nested if..then statements are hard to read 196209

fr/paris/lutece/plugins/directory/business/File.java

Violation Line
Avoid short class names like File 48249

fr/paris/lutece/plugins/directory/business/FileDAO.java

Violation Line
Use block level rather than method level synchronization 85110

fr/paris/lutece/plugins/directory/business/IEntry.java

Violation Line
This class has a bunch of public methods and attributes 34885
Avoid using implementation types like 'HashMap'; use the interface instead 724
Avoid using implementation types like 'HashMap'; use the interface instead 724
Avoid variables with short names like b 755
A getX() method which returns a boolean should be named isX() 842

fr/paris/lutece/plugins/directory/business/IMapProvider.java

Violation Line
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 36
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 36
Avoid unused imports such as 'javax.servlet.http.HttpSession' 37
Avoid unused imports such as 'javax.servlet.http.HttpSession' 37

fr/paris/lutece/plugins/directory/business/IndexerActionDAO.java

Violation Line
Use block level rather than method level synchronization 8496

fr/paris/lutece/plugins/directory/business/MapProvider.java

Violation Line
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 36
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 36
Avoid unused imports such as 'javax.servlet.http.HttpSession' 37
Avoid unused imports such as 'javax.servlet.http.HttpSession' 37

fr/paris/lutece/plugins/directory/business/PhysicalFile.java

Violation Line
Returning '_byValue' may expose an internal array. 71
The user-supplied array 'value' is stored directly. 80

fr/paris/lutece/plugins/directory/business/PhysicalFileDAO.java

Violation Line
Use block level rather than method level synchronization 8092

fr/paris/lutece/plugins/directory/business/Record.java

Violation Line
Possible God class (WMC=68, ATFD=45, TCC=0.036923076923076927) 34725
The class 'Record' has a Standard Cyclomatic Complexity of 2 (Highest = 15). 61725
The class 'Record' has a Modified Cyclomatic Complexity of 2 (Highest = 15). 61725
The class 'Record' has a Cyclomatic Complexity of 2 (Highest = 17). 61725
Avoid long parameter lists. 300301
The method 'getXml' has a Cyclomatic Complexity of 10. 334391
Avoid long parameter lists. 334336
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 339
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 355
The method 'getXmlListRecordField' has a Standard Cyclomatic Complexity of 15. 412518
The method 'getXmlListRecordField' has a Cyclomatic Complexity of 17. 412518
The method 'getXmlListRecordField' has a Modified Cyclomatic Complexity of 15. 412518
The method getXmlListRecordField() has an NPath complexity of 2750 412518
Avoid really long methods. 412518
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 418
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 428
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 451
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 489
Avoid long parameter lists. 545546
The method 'getXmlForCsvExport' has a Cyclomatic Complexity of 10. 579652
Avoid long parameter lists. 579581
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 584
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 590
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 696

fr/paris/lutece/plugins/directory/business/RecordDAO.java

Violation Line
Possible God class (WMC=62, ATFD=71, TCC=0.009523809523809525) 34683
The class 'RecordDAO' has a Cyclomatic Complexity of 4 (Highest = 21). 53683
The class 'RecordDAO' has a Standard Cyclomatic Complexity of 4 (Highest = 19). 53683
The class 'RecordDAO' has a Modified Cyclomatic Complexity of 4 (Highest = 19). 53683
Avoid excessively long variable names like SQL_QUERY_SELECT_COUNT_DIRECYTORY_RECORD_HAS_WORKFLOW 72
Use block level rather than method level synchronization 119136
Avoid variables with short names like sb 218
Prefer StringBuffer over += for concatenating strings 488
Prefer StringBuffer over += for concatenating strings 492
The method buildFilterQueryHeader() has an NPath complexity of 16132 505619
Avoid really long methods. 505619
The method 'buildFilterQueryHeader' has a Cyclomatic Complexity of 21. 505619
The method 'buildFilterQueryHeader' has a Standard Cyclomatic Complexity of 19. 505619
The method 'buildFilterQueryHeader' has a Modified Cyclomatic Complexity of 19. 505619
Avoid using Literals in Conditional Statements 553
Avoid using Literals in Conditional Statements 597
The method 'buildFilterQueryFooter' has a Standard Cyclomatic Complexity of 10. 629682
The method 'buildFilterQueryFooter' has a Modified Cyclomatic Complexity of 10. 629682
The method 'buildFilterQueryFooter' has a Cyclomatic Complexity of 10. 629682

fr/paris/lutece/plugins/directory/business/RecordField.java

Violation Line
Avoid unnecessary if..then..else statements when returning booleans 197200
Avoid unnecessary if..then..else statements when returning booleans 212215

fr/paris/lutece/plugins/directory/business/RecordFieldDAO.java

Violation Line
Possible God class (WMC=91, ATFD=161, TCC=0.11428571428571428) 341029
The class 'RecordFieldDAO' has a Standard Cyclomatic Complexity of 6 (Highest = 19). 471029
The class 'RecordFieldDAO' has a Cyclomatic Complexity of 6 (Highest = 19). 471029
The class 'RecordFieldDAO' has a Modified Cyclomatic Complexity of 6 (Highest = 19). 471029
Avoid excessively long variable names like SQL_QUERY_SELECT_FULL_RECORD_FIELD_LIST_WITH_RECORD 73
Use block level rather than method level synchronization 147180
Avoid really long methods. 371517
The method 'getRecordFieldListByRecordIdList' has a Modified Cyclomatic Complexity of 12. 371517
The method 'getRecordFieldListByRecordIdList' has a Standard Cyclomatic Complexity of 12. 371517
The method 'getRecordFieldListByRecordIdList' has a Cyclomatic Complexity of 12. 371517
Avoid using Literals in Conditional Statements 393
Avoid variables with short names like pf 502
The method selectSpecificList() has an NPath complexity of 396 523664
The method 'selectSpecificList' has a Modified Cyclomatic Complexity of 13. 523664
Avoid really long methods. 523664
The method 'selectSpecificList' has a Standard Cyclomatic Complexity of 13. 523664
The method 'selectSpecificList' has a Cyclomatic Complexity of 13. 523664
Avoid using Literals in Conditional Statements 544
Avoid variables with short names like pf 650
Avoid really long methods. 670824
The method selectListByFilter() has an NPath complexity of 67584 670824
The method 'selectListByFilter' has a Modified Cyclomatic Complexity of 19. 670824
The method 'selectListByFilter' has a Cyclomatic Complexity of 19. 670824
The method 'selectListByFilter' has a Standard Cyclomatic Complexity of 19. 670824
The method 'getCountByFilter' has a Modified Cyclomatic Complexity of 12. 830908
The method 'getCountByFilter' has a Standard Cyclomatic Complexity of 12. 830908
The method 'getCountByFilter' has a Cyclomatic Complexity of 12. 830908
The method getCountByFilter() has an NPath complexity of 2048 830908
Avoid using Literals in Conditional Statements 977

fr/paris/lutece/plugins/directory/business/RecordFieldFilter.java

Violation Line
Too many fields 47528
Avoid using redundant field initializer for '_bOrderByDateModification' 69
Avoid using redundant field initializer for '_bContainsFile' 70
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 446

fr/paris/lutece/plugins/directory/business/RecordFieldHome.java

Violation Line
The class 'RecordFieldHome' has a Cyclomatic Complexity of 2 (Highest = 11). 48452
The method 'getRecordFieldList' has a Cyclomatic Complexity of 11. 301328

fr/paris/lutece/plugins/directory/business/RecordHome.java

Violation Line
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 94
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 156
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 201
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 248

fr/paris/lutece/plugins/directory/business/attribute/DirectoryAttributeDAO.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 59
Use block level rather than method level synchronization 8192

fr/paris/lutece/plugins/directory/business/rss/DirectoryResourceRss.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 341098
Possible God class (WMC=107, ATFD=365, TCC=0.2909090909090909) 341098
The class 'DirectoryResourceRss' has a Modified Cyclomatic Complexity of 8 (Highest = 22). 881098
Avoid really long classes. 881098
The class 'DirectoryResourceRss' has a Standard Cyclomatic Complexity of 8 (Highest = 22). 881098
The class 'DirectoryResourceRss' has a Cyclomatic Complexity of 10 (Highest = 25). 881098
Avoid variables with short names like ID 161
Avoid unnecessary if..then..else statements when returning booleans 173176
The method 'doValidateConfigForm' has a Cyclomatic Complexity of 13. 255320
Avoid declaring a variable if it is unreferenced before a possible exit point. 257
Avoid declaring a variable if it is unreferenced before a possible exit point. 262
Avoid declaring a variable if it is unreferenced before a possible exit point. 263
Avoid really long methods. 326464
The method 'getDisplayCreateConfigForm' has a Modified Cyclomatic Complexity of 17. 326464
The method getDisplayCreateConfigForm() has an NPath complexity of 8004 326464
The method 'getDisplayCreateConfigForm' has a Standard Cyclomatic Complexity of 17. 326464
The method 'getDisplayCreateConfigForm' has a Cyclomatic Complexity of 20. 326464
The method 'getDisplayModifyConfigForm' has a Standard Cyclomatic Complexity of 22. 470666
The method getDisplayModifyConfigForm() has an NCSS line count of 111 470666
The method 'getDisplayModifyConfigForm' has a Cyclomatic Complexity of 25. 470666
The method 'getDisplayModifyConfigForm' has a Modified Cyclomatic Complexity of 22. 470666
The method getDisplayModifyConfigForm() has an NPath complexity of 19600 470666
Avoid really long methods. 470666
The method 'createHtmlRss' has a Cyclomatic Complexity of 23. 675846
Avoid really long methods. 675846
The method createHtmlRss() has an NPath complexity of 19332 675846
The method 'createHtmlRss' has a Modified Cyclomatic Complexity of 16. 675846
The method 'createHtmlRss' has a Standard Cyclomatic Complexity of 16. 675846
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 864
The method 'getFeed' has a Standard Cyclomatic Complexity of 16. 8971097
The method 'getFeed' has a Cyclomatic Complexity of 23. 8971097
Avoid really long methods. 8971097
The method getFeed() has an NCSS line count of 108 8971097
The method 'getFeed' has a Modified Cyclomatic Complexity of 16. 8971097
The method getFeed() has an NPath complexity of 19332 8971097
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1032

fr/paris/lutece/plugins/directory/business/rss/DirectoryResourceRssConfigDAO.java

Violation Line
Use block level rather than method level synchronization 6585

fr/paris/lutece/plugins/directory/business/rss/DirectoryResourceRssConfigRemovalListener.java

Violation Line
The class 'DirectoryResourceRssConfigRemovalListener' has a Cyclomatic Complexity of 6 (Highest = 10). 4996
Avoid excessively long variable names like PROPERTY_DIRECTORY_RESOURCE_RSS_CONFIG_CANNOT_BE_REMOVED 51
The method 'canBeRemoved' has a Cyclomatic Complexity of 10. 5785
Avoid declaring a variable if it is unreferenced before a possible exit point. 59

fr/paris/lutece/plugins/directory/service/DirectoryResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 139142
Avoid really long methods. 148263
Avoid variables with short names like rt 151
Avoid variables with short names like p 162
Assigning an Object to null is a code smell. Consider refactoring. 287

fr/paris/lutece/plugins/directory/service/DirectoryService.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34588
Possible God class (WMC=67, ATFD=127, TCC=0.008333333333333333) 34588
Singleton is not thread safe 125128
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 142
Deeply nested if..then statements are hard to read 240243
These nested if statements could be combined 269283
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 367
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 433
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 509
Avoid declaring a variable if it is unreferenced before a possible exit point. 558

fr/paris/lutece/plugins/directory/service/DirectoryWorkflowRecordRemovalDaemon.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 82

fr/paris/lutece/plugins/directory/service/DirectoryXslResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 7073
Avoid variables with short names like rt 81
Avoid variables with short names like p 87
Assigning an Object to null is a code smell. Consider refactoring. 127

fr/paris/lutece/plugins/directory/service/FileImgService.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 51
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 51
Document empty constructor 6971
Deeply nested if..then statements are hard to read 122129

fr/paris/lutece/plugins/directory/service/directorysearch/DirectoryIndexer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34499
The class 'DirectoryIndexer' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 76499
The class 'DirectoryIndexer' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 76499
The class 'DirectoryIndexer' has a Cyclomatic Complexity of 4 (Highest = 10). 76499
The method 'indexListRecord' has a Modified Cyclomatic Complexity of 10. 109178
The method 'indexListRecord' has a Cyclomatic Complexity of 10. 109178
Avoid using implementation types like 'HashMap'; use the interface instead 109
Avoid using implementation types like 'HashMap'; use the interface instead 109
Avoid using implementation types like 'HashMap'; use the interface instead 109
The method 'indexListRecord' has a Standard Cyclomatic Complexity of 10. 109178
Avoid using implementation types like 'HashMap'; use the interface instead 109
Avoid variables with short names like it 112
Avoid using implementation types like 'HashMap'; use the interface instead 191
Avoid using implementation types like 'HashMap'; use the interface instead 191
Avoid using implementation types like 'HashMap'; use the interface instead 191
Avoid using implementation types like 'HashMap'; use the interface instead 191
Avoid variables with short names like hm 191
The method 'processIndexing' has a Cyclomatic Complexity of 10. 211295
The method 'processIndexing' has a Standard Cyclomatic Complexity of 10. 211295
The method 'processIndexing' has a Modified Cyclomatic Complexity of 10. 211295
Avoid variables with short names like hm 215
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 281
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 312
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 316
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 316
Avoid variables with short names like ft 318
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 368
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 371
Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 371
Avoid variables with short names like ft 373
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 475
Avoid appending characters as strings in StringBuffer.append. 481
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 481

fr/paris/lutece/plugins/directory/service/directorysearch/DirectoryLuceneSearchEngine.java

Violation Line
The class 'DirectoryLuceneSearchEngine' has a Cyclomatic Complexity of 18 (Highest = 17). 62226
The class 'DirectoryLuceneSearchEngine' has a Standard Cyclomatic Complexity of 15 (Highest = 14). 62226
The class 'DirectoryLuceneSearchEngine' has a Modified Cyclomatic Complexity of 15 (Highest = 14). 62226
The method 'getSearchResults' has a Cyclomatic Complexity of 17. 68225
The method getSearchResults() has an NPath complexity of 10369 68225
The method 'getSearchResults' has a Modified Cyclomatic Complexity of 14. 68225
Avoid really long methods. 68225
The method 'getSearchResults' has a Standard Cyclomatic Complexity of 14. 68225
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 219

fr/paris/lutece/plugins/directory/service/directorysearch/DirectorySearchEngine.java

Violation Line
Avoid using implementation types like 'HashMap'; use the interface instead 51
Avoid using implementation types like 'HashMap'; use the interface instead 51

fr/paris/lutece/plugins/directory/service/directorysearch/DirectorySearchFactory.java

Violation Line
Avoid instantiation through private constructors from outside of the constructors class. 169

fr/paris/lutece/plugins/directory/service/directorysearch/DirectorySearchService.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34522
The class 'DirectorySearchService' has a Cyclomatic Complexity of 5 (Highest = 22). 73522
The class 'DirectorySearchService' has a Modified Cyclomatic Complexity of 4 (Highest = 17). 73522
The class 'DirectorySearchService' has a Standard Cyclomatic Complexity of 4 (Highest = 17). 73522
Possible unsafe assignment to a non-final static field in a constructor. 80
Possible unsafe assignment to a non-final static field in a constructor. 81
Singleton is not thread safe 102105
Avoid using implementation types like 'HashMap'; use the interface instead 129
Avoid using implementation types like 'HashMap'; use the interface instead 129
Avoid using implementation types like 'HashMap'; use the interface instead 160
Avoid using implementation types like 'HashMap'; use the interface instead 160
Avoid really long methods. 160333
Avoid long parameter lists. 160161
The method 'getSearchResults' has a Cyclomatic Complexity of 22. 160333
The method 'getSearchResults' has a Standard Cyclomatic Complexity of 17. 160333
The method getSearchResults() has an NPath complexity of 2690 160333
The method 'getSearchResults' has a Modified Cyclomatic Complexity of 17. 160333
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 206
Deeply nested if..then statements are hard to read 222230
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 239
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 324
A method/constructor shouldnt explicitly throw java.lang.Exception 335
A method/constructor shouldnt explicitly throw java.lang.Exception 335
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 373
Avoid variables with short names like jo 377
StringBuffer constructor is initialized with size 16, but has at least 147 characters appended. 400
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 406
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 422
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 424

fr/paris/lutece/plugins/directory/service/directorysearch/IDirectorySearchEngine.java

Violation Line
Avoid using implementation types like 'HashMap'; use the interface instead 51
Avoid using implementation types like 'HashMap'; use the interface instead 51

fr/paris/lutece/plugins/directory/service/file/DirectoryFileService.java

Violation Line
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 72

fr/paris/lutece/plugins/directory/service/record/IRecordService.java

Violation Line
The String literal "directory.transactionManager" appears 5 times in this file; the first occurrence is on line 62 62

fr/paris/lutece/plugins/directory/service/record/RecordService.java

Violation Line
The class 'RecordService' has a Cyclomatic Complexity of 2 (Highest = 15). 68262
The class 'RecordService' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 68262
The class 'RecordService' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 68262
The String literal "directory.transactionManager" appears 5 times in this file; the first occurrence is on line 79 79
The method 'isFileAuthorized' has a Standard Cyclomatic Complexity of 11. 195261
The method 'isFileAuthorized' has a Modified Cyclomatic Complexity of 11. 195261
The method 'isFileAuthorized' has a Cyclomatic Complexity of 15. 195261
Deeply nested if..then statements are hard to read 217225
Deeply nested if..then statements are hard to read 232257
These nested if statements could be combined 232257
These nested if statements could be combined 234256

fr/paris/lutece/plugins/directory/service/search/DirectorySearchIndexer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34430
The class 'DirectorySearchIndexer' has a Cyclomatic Complexity of 3 (Highest = 12). 81430
Position literals first in String comparisons for EqualsIgnoreCase 128
This statement may have some unnecessary parentheses 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 161
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 275
The method 'getDocument' has a Cyclomatic Complexity of 12. 305395
The method getDocument() has an NPath complexity of 432 305395
Avoid declaring a variable if it is unreferenced before a possible exit point. 307
Avoid variables with short names like ft 309
Avoid variables with short names like sb 417
Avoid appending characters as strings in StringBuffer.append. 425

fr/paris/lutece/plugins/directory/service/security/DirectoryUserAttributesManager.java

Violation Line
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 112
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 138

fr/paris/lutece/plugins/directory/service/upload/DirectoryAsynchronousUploadHandler.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 341193
Possible God class (WMC=120, ATFD=101, TCC=0.013289036544850499) 341193
The class 'DirectoryAsynchronousUploadHandler' has a Cyclomatic Complexity of 3 (Highest = 13). 951193
Avoid really long classes. 951193
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 101
Use block level rather than method level synchronization 422433
Use block level rather than method level synchronization 441444
Use bitwise inversion to invert boolean values 477
Avoid empty if statements 481486
The method 'reinitMap' has a Cyclomatic Complexity of 13. 850899
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 857
The user-supplied array 'bValue' is stored directly. 1034
Assigning an Object to null is a code smell. Consider refactoring. 1046
Returning '_bValue' may expose an internal array. 1055
A method/constructor shouldnt explicitly throw java.lang.Exception 1170
A method/constructor shouldnt explicitly throw java.lang.Exception 1170

fr/paris/lutece/plugins/directory/utils/DirectoryErrorException.java

Violation Line
It is a good practice to call super() in a constructor 5661
It is a good practice to call super() in a constructor 6973

fr/paris/lutece/plugins/directory/utils/DirectoryUtils.java

Violation Line
Possible God class (WMC=156, ATFD=186, TCC=0.0) 341570
A high number of imports can indicate a high degree of coupling within an object. 341570
Avoid really long classes. 1061570
The class 'DirectoryUtils' has a Cyclomatic Complexity of 4 (Highest = 10). 1061570
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 431
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 461
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 522
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 540
Avoid variables with short names like tt 540
Avoid variables with short names like it 558
Avoid using implementation types like 'HashMap'; use the interface instead 625
Avoid using implementation types like 'HashMap'; use the interface instead 625
Avoid using Literals in Conditional Statements 938
Avoid variables with short names like it 1050
Avoid variables with short names like it 1066
Avoid variables with short names like ts 1095
The method 'getListResults' has a Cyclomatic Complexity of 10. 11721255
These nested if statements could be combined 14631472
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1515
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1554

fr/paris/lutece/plugins/directory/utils/JSONUtils.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 185

fr/paris/lutece/plugins/directory/utils/UrlUtils.java

Violation Line
The class 'UrlUtils' has a Cyclomatic Complexity of 6 (Highest = 10). 48104
The method 'getMapParametersFromUrl' has a Cyclomatic Complexity of 10. 68103
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 70
Deeply nested if..then statements are hard to read 8796

fr/paris/lutece/plugins/directory/utils/sort/RecordComparator.java

Violation Line
The class 'RecordComparator' has a Modified Cyclomatic Complexity of 8 (Highest = 12). 54220
The class 'RecordComparator' has a Cyclomatic Complexity of 14 (Highest = 25). 54220
The class 'RecordComparator' has a Standard Cyclomatic Complexity of 8 (Highest = 12). 54220
Private field '_entry' could be made final; it is only initialized in the declaration or constructor. 58
Private field '_bIsAscSort' could be made final; it is only initialized in the declaration or constructor. 59
Avoid variables with short names like r1 85
Avoid variables with short names like r2 85
The method 'compare' has a Standard Cyclomatic Complexity of 10. 85145
The method 'compare' has a Cyclomatic Complexity of 14. 85145
The method 'compare' has a Modified Cyclomatic Complexity of 10. 85145
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 103
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 115
The method 'getRecordFieldToCompare' has a Standard Cyclomatic Complexity of 12. 154219
Avoid variables with short names like r 154
The method 'getRecordFieldToCompare' has a Cyclomatic Complexity of 25. 154219
The method 'getRecordFieldToCompare' has a Modified Cyclomatic Complexity of 12. 154219
Avoid variables with short names like rf 156
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 178
Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' due to existing import 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' 184

fr/paris/lutece/plugins/directory/web/DirectoryApp.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34998
The class 'DirectoryApp' has a Cyclomatic Complexity of 16 (Highest = 60). 103998
The class 'DirectoryApp' has a Modified Cyclomatic Complexity of 10 (Highest = 35). 103998
The class 'DirectoryApp' has a Standard Cyclomatic Complexity of 10 (Highest = 35). 103998
Avoid really long methods. 223562
The method getPage() has an NCSS line count of 165 223562
The method 'getPage' has a Standard Cyclomatic Complexity of 35. 223562
The method 'getPage' has a Cyclomatic Complexity of 60. 223562
The method 'getPage' has a Modified Cyclomatic Complexity of 35. 223562
The method getPage() has an NPath complexity of 213162602 223562
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 230
Avoid declaring a variable if it is unreferenced before a possible exit point. 251252
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 271
Deeply nested if..then statements are hard to read 277281
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 287
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 345
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 453
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 469
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 499
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 508
Avoid using implementation types like 'HashMap'; use the interface instead 577
Avoid using implementation types like 'HashMap'; use the interface instead 577
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 609
The method 'getHtmlResultList' has a Cyclomatic Complexity of 10. 664746
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 713
The method 'getHtmlResultRecord' has a Cyclomatic Complexity of 11. 763850
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 790
Do not add empty strings 826
Do not add empty strings 837
Avoid really long methods. 863964
The method 'getSearchPage' has a Cyclomatic Complexity of 15. 863964
The method 'getSearchPage' has a Standard Cyclomatic Complexity of 12. 863964
The method getSearchPage() has an NPath complexity of 654 863964
The method 'getSearchPage' has a Modified Cyclomatic Complexity of 12. 863964

fr/paris/lutece/plugins/directory/web/DirectoryDashboardComponent.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 92
Avoid declaring a variable if it is unreferenced before a possible exit point. 93
Avoid declaring a variable if it is unreferenced before a possible exit point. 94
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 104
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 110
Avoid variables with short names like t 145
Avoid unused method parameters such as 'plugin'. 159

fr/paris/lutece/plugins/directory/web/DirectoryJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 345975
This class has a bunch of public methods and attributes 345975
Avoid unused imports such as 'fr.paris.lutece.plugins.directory.business.EntryTypeDownloadUrl' 50
Avoid unused imports such as 'fr.paris.lutece.plugins.directory.business.EntryTypeDownloadUrl' 50
The type has an NCSS line count of 2577 1385975
Avoid really long classes. 1385975
The class 'DirectoryJspBean' has a Standard Cyclomatic Complexity of 4 (Highest = 20). 1385975
The class 'DirectoryJspBean' has a Modified Cyclomatic Complexity of 4 (Highest = 20). 1385975
The class 'DirectoryJspBean' has a Cyclomatic Complexity of 7 (Highest = 29). 1385975
This class has too many methods, consider refactoring it. 1395975
Avoid unused private fields such as 'MESSAGE_CANNOT_REMOVE_ENTRY_DIRECTORY_IS_NOT_EMPTY'. 195
Avoid excessively long variable names like PARAMETER_DATE_MODIFICATION_SHOWN_IN_ADVANCED_SEARCH 433
The field name indicates a constant but its modifiers do not 478
Private field 'DEFAULT_TYPE_IMAGE' could be made final; it is only initialized in the declaration or constructor. 478
Private field '_searchFields' could be made final; it is only initialized in the declaration or constructor. 481
Private field '_directoryActionResult' could be made final; it is only initialized in the declaration or constructor. 482
Private field '_recordService' could be made final; it is only initialized in the declaration or constructor. 483
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 537
The method 'getDirectoryData' has a Cyclomatic Complexity of 29. 592801
The method getDirectoryData() has an NPath complexity of 72576 592801
Avoid really long methods. 592801
The method getDirectoryData() has an NCSS line count of 131 592801
The method 'getDirectoryData' has a Modified Cyclomatic Complexity of 19. 592801
The method 'getDirectoryData' has a Standard Cyclomatic Complexity of 19. 592801
Avoid declaring a variable if it is unreferenced before a possible exit point. 595
Avoid declaring a variable if it is unreferenced before a possible exit point. 598
Avoid declaring a variable if it is unreferenced before a possible exit point. 599
Avoid declaring a variable if it is unreferenced before a possible exit point. 607
Avoid declaring a variable if it is unreferenced before a possible exit point. 609
Avoid declaring a variable if it is unreferenced before a possible exit point. 610
Avoid declaring a variable if it is unreferenced before a possible exit point. 611
Avoid declaring a variable if it is unreferenced before a possible exit point. 612
Avoid declaring a variable if it is unreferenced before a possible exit point. 613
Avoid declaring a variable if it is unreferenced before a possible exit point. 614
Avoid declaring a variable if it is unreferenced before a possible exit point. 615
Avoid declaring a variable if it is unreferenced before a possible exit point. 618
Avoid declaring a variable if it is unreferenced before a possible exit point. 619
Avoid declaring a variable if it is unreferenced before a possible exit point. 620
Avoid declaring a variable if it is unreferenced before a possible exit point. 621
Avoid declaring a variable if it is unreferenced before a possible exit point. 622
Avoid declaring a variable if it is unreferenced before a possible exit point. 623
Avoid declaring a variable if it is unreferenced before a possible exit point. 624
Avoid declaring a variable if it is unreferenced before a possible exit point. 627
Avoid declaring a variable if it is unreferenced before a possible exit point. 628
Avoid declaring a variable if it is unreferenced before a possible exit point. 629
Avoid declaring a variable if it is unreferenced before a possible exit point. 630
Avoid declaring a variable if it is unreferenced before a possible exit point. 631
Avoid declaring a variable if it is unreferenced before a possible exit point. 632
Avoid declaring a variable if it is unreferenced before a possible exit point. 633
Avoid declaring a variable if it is unreferenced before a possible exit point. 638
Avoid declaring a variable if it is unreferenced before a possible exit point. 639
Avoid declaring a variable if it is unreferenced before a possible exit point. 640
Avoid declaring a variable if it is unreferenced before a possible exit point. 815
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 836
Avoid declaring a variable if it is unreferenced before a possible exit point. 885
The method getModifyDirectory() has an NCSS line count of 127 9101127
Avoid really long methods. 9101127
The method getModifyDirectory() has an NPath complexity of 8064 9101127
The method 'getModifyDirectory' has a Cyclomatic Complexity of 20. 9101127
The method 'getModifyDirectory' has a Standard Cyclomatic Complexity of 17. 9101127
The method 'getModifyDirectory' has a Modified Cyclomatic Complexity of 17. 9101127
Avoid declaring a variable if it is unreferenced before a possible exit point. 912
Avoid declaring a variable if it is unreferenced before a possible exit point. 913
Avoid declaring a variable if it is unreferenced before a possible exit point. 914
Avoid declaring a variable if it is unreferenced before a possible exit point. 915
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 945
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 987
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 997
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1043
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1070
Avoid declaring a variable if it is unreferenced before a possible exit point. 1157
The method 'doChangeOrderEntry' has a Cyclomatic Complexity of 20. 11911318
Avoid really long methods. 11911318
The method 'doChangeOrderEntry' has a Standard Cyclomatic Complexity of 15. 11911318
The method 'doChangeOrderEntry' has a Modified Cyclomatic Complexity of 15. 11911318
Avoid declaring a variable if it is unreferenced before a possible exit point. 1351
Avoid declaring a variable if it is unreferenced before a possible exit point. 1386
Avoid declaring a variable if it is unreferenced before a possible exit point. 1454
The method 'getCreateEntry' has a Cyclomatic Complexity of 11. 15261622
Avoid declaring a variable if it is unreferenced before a possible exit point. 1532
Avoid declaring a variable if it is unreferenced before a possible exit point. 1533
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1557
The method 'doCreateEntry' has a Cyclomatic Complexity of 10. 16331682
Avoid declaring a variable if it is unreferenced before a possible exit point. 1635
Avoid really long methods. 16931858
The method getModifyEntry() has an NPath complexity of 25920 16931858
The method 'getModifyEntry' has a Standard Cyclomatic Complexity of 18. 16931858
The method 'getModifyEntry' has a Modified Cyclomatic Complexity of 18. 16931858
The method 'getModifyEntry' has a Cyclomatic Complexity of 25. 16931858
Avoid declaring a variable if it is unreferenced before a possible exit point. 1695
Avoid declaring a variable if it is unreferenced before a possible exit point. 1696
Avoid declaring a variable if it is unreferenced before a possible exit point. 1699
The method 'doModifyEntry' has a Cyclomatic Complexity of 11. 18691927
Avoid declaring a variable if it is unreferenced before a possible exit point. 1872
Avoid declaring a variable if it is unreferenced before a possible exit point. 1940
Avoid declaring a variable if it is unreferenced before a possible exit point. 1943
Avoid declaring a variable if it is unreferenced before a possible exit point. 1987
Avoid declaring a variable if it is unreferenced before a possible exit point. 2091
Avoid declaring a variable if it is unreferenced before a possible exit point. 2092
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2116
Avoid declaring a variable if it is unreferenced before a possible exit point. 2139
Avoid declaring a variable if it is unreferenced before a possible exit point. 2140
Avoid declaring a variable if it is unreferenced before a possible exit point. 2142
Avoid declaring a variable if it is unreferenced before a possible exit point. 2381
Avoid declaring a variable if it is unreferenced before a possible exit point. 2469
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2485
Avoid declaring a variable if it is unreferenced before a possible exit point. 2515
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2536
Avoid declaring a variable if it is unreferenced before a possible exit point. 2656
Avoid declaring a variable if it is unreferenced before a possible exit point. 2675
Avoid declaring a variable if it is unreferenced before a possible exit point. 2676
Avoid declaring a variable if it is unreferenced before a possible exit point. 2775
Avoid declaring a variable if it is unreferenced before a possible exit point. 2823
The method getManageDirectoryRecord() has an NCSS line count of 122 29553187
The method getManageDirectoryRecord() has an NPath complexity of 1539000 29553187
The method 'getManageDirectoryRecord' has a Cyclomatic Complexity of 25. 29553187
The method 'getManageDirectoryRecord' has a Modified Cyclomatic Complexity of 20. 29553187
Avoid really long methods. 29553187
The method 'getManageDirectoryRecord' has a Standard Cyclomatic Complexity of 20. 29553187
Avoid declaring a variable if it is unreferenced before a possible exit point. 3002
Avoid declaring a variable if it is unreferenced before a possible exit point. 3005
Avoid declaring a variable if it is unreferenced before a possible exit point. 3006
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3115
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3231
The method 'doImportDirectoryRecord' has a Modified Cyclomatic Complexity of 13. 32663409
The method doImportDirectoryRecord() has an NPath complexity of 2800 32663409
The method 'doImportDirectoryRecord' has a Standard Cyclomatic Complexity of 13. 32663409
Avoid really long methods. 32663409
The method 'doImportDirectoryRecord' has a Cyclomatic Complexity of 20. 32663409
Avoid declaring a variable if it is unreferenced before a possible exit point. 3270
The String literal " > " appears 4 times in this file; the first occurrence is on line 3,349 3349
The String literal "<br/>" appears 4 times in this file; the first occurrence is on line 3,351 3351
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3428
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3508
The method 'getCreateDirectoryRecordWithInitialValues' has a Standard Cyclomatic Complexity of 11. 35713663
The method 'getCreateDirectoryRecordWithInitialValues' has a Modified Cyclomatic Complexity of 11. 35713663
The method 'getCreateDirectoryRecordWithInitialValues' has a Cyclomatic Complexity of 13. 35713663
The method getCreateDirectoryRecordWithInitialValues() has an NPath complexity of 150000 35713663
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3584
Avoid variables with short names like fn 3625
Avoid variables with short names like ln 3626
Avoid variables with short names like em 3627
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3719
The method 'getModifyDirectoryRecord' has a Cyclomatic Complexity of 10. 37433817
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3792
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3859
The method 'getConfirmRemoveDirectoryRecord' has a Cyclomatic Complexity of 12. 38813927
The method 'doRemoveDirectoryRecord' has a Cyclomatic Complexity of 12. 39383994
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3978
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 4029
Avoid declaring a variable if it is unreferenced before a possible exit point. 4066
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 4121
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 4166
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 4204
The method 'doSaveTasksForm' has a Cyclomatic Complexity of 12. 42284328
The method 'doSaveTasksForm' has a Modified Cyclomatic Complexity of 10. 42284328
The method 'doSaveTasksForm' has a Standard Cyclomatic Complexity of 10. 42284328
Avoid really long methods. 42284328
Avoid declaring a variable if it is unreferenced before a possible exit point. 4273
Avoid declaring a variable if it is unreferenced before a possible exit point. 4347
This statement may have some unnecessary parentheses 4347
Avoid declaring a variable if it is unreferenced before a possible exit point. 4350
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 4385
Avoid declaring a variable if it is unreferenced before a possible exit point. 4434
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 4476
Avoid declaring a variable if it is unreferenced before a possible exit point. 4518
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 4520
Avoid declaring a variable if it is unreferenced before a possible exit point. 4520
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 4855
Avoid variables with short names like it 4906
Avoid instantiating String objects; this is usually unnecessary. 4937
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 4972
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 5022
Avoid declaring a variable if it is unreferenced before a possible exit point. 5206
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 5224
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 5258
The method doImportField() has an NPath complexity of 600 52945402
The method 'doImportField' has a Cyclomatic Complexity of 17. 52945402
Avoid really long methods. 52945402
Avoid declaring a variable if it is unreferenced before a possible exit point. 5298
The method 'getConfirmChangeStatesRecord' has a Cyclomatic Complexity of 12. 54135459
The method 'doChangeStatesRecord' has a Cyclomatic Complexity of 10. 54705503
Avoid unused method parameters such as 'request'. 5518
Consider using varargs for methods or constructors which take an array the last parameter. 5518
The method 'moveDownEntryOrder' has a Standard Cyclomatic Complexity of 13. 57495836
The method 'moveDownEntryOrder' has a Modified Cyclomatic Complexity of 13. 57495836
The method 'moveDownEntryOrder' has a Cyclomatic Complexity of 16. 57495836
The method 'moveUpEntryOrder' has a Standard Cyclomatic Complexity of 11. 58505926
The method 'moveUpEntryOrder' has a Cyclomatic Complexity of 14. 58505926
The method 'moveUpEntryOrder' has a Modified Cyclomatic Complexity of 11. 58505926

fr/paris/lutece/plugins/directory/web/DirectorySessionListener.java

Violation Line
Avoid variables with short names like se 52
Avoid variables with short names like se 61

fr/paris/lutece/plugins/directory/web/DirectoryXslJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34500
The class 'DirectoryXslJspBean' has a Cyclomatic Complexity of 4 (Highest = 11). 82500
Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 134
Avoid declaring a variable if it is unreferenced before a possible exit point. 243
Avoid declaring a variable if it is unreferenced before a possible exit point. 353
The method 'getDirectoryXslData' has a Cyclomatic Complexity of 11. 394461
Avoid declaring a variable if it is unreferenced before a possible exit point. 399
Avoid declaring a variable if it is unreferenced before a possible exit point. 401
Avoid declaring a variable if it is unreferenced before a possible exit point. 402
Avoid variables with short names like is 478
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 481

fr/paris/lutece/plugins/directory/web/DoDownloadFile.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34214
The class 'DoDownloadFile' has a Standard Cyclomatic Complexity of 6 (Highest = 13). 77214
The class 'DoDownloadFile' has a Modified Cyclomatic Complexity of 6 (Highest = 13). 77214
The class 'DoDownloadFile' has a Cyclomatic Complexity of 9 (Highest = 20). 77214
The method doDownloadFile() has an NPath complexity of 6160 99195
The method 'doDownloadFile' has a Modified Cyclomatic Complexity of 13. 99195
The method 'doDownloadFile' has a Standard Cyclomatic Complexity of 13. 99195
The method 'doDownloadFile' has a Cyclomatic Complexity of 20. 99195
Assigning an Object to null is a code smell. Consider refactoring. 165
Avoid variables with short names like os 184
These nested if statements could be combined 202210

fr/paris/lutece/plugins/directory/web/DoRemoveAsynchronousFile.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 74

fr/paris/lutece/plugins/directory/web/action/DefaultDirectorySearchFields.java

Violation Line
Abstract classes should be named AbstractXXX 57457
Too many fields 57457
Avoid using implementation types like 'HashMap'; use the interface instead 71
Avoid using implementation types like 'HashMap'; use the interface instead 71
Avoid using implementation types like 'HashMap'; use the interface instead 158
Avoid using implementation types like 'HashMap'; use the interface instead 158
Avoid using implementation types like 'HashMap'; use the interface instead 258
Avoid using implementation types like 'HashMap'; use the interface instead 258
Avoid empty if statements 302304

fr/paris/lutece/plugins/directory/web/action/DirectoryActionResult.java

Violation Line
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 123
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 188
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 242
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 272
Avoid variables with short names like e 297
Avoid appending characters as strings in StringBuffer.append. 308

fr/paris/lutece/plugins/directory/web/action/DirectoryAdminSearchFields.java

Violation Line
Possible God class (WMC=55, ATFD=9, TCC=0.023228803716608595) 34608
Too many fields 51608
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 72
Method names should not contain underscores 378

fr/paris/lutece/plugins/directory/web/action/ExportDirectoryAction.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34712
Possible God class (WMC=56, ATFD=97, TCC=0.09523809523809523) 34712
Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' 79
Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' 79
The class 'ExportDirectoryAction' has a Standard Cyclomatic Complexity of 7 (Highest = 40). 112712
The class 'ExportDirectoryAction' has a Cyclomatic Complexity of 8 (Highest = 47). 112712
The class 'ExportDirectoryAction' has a Modified Cyclomatic Complexity of 7 (Highest = 40). 112712
The method 'process' has a Cyclomatic Complexity of 47. 195646
The method 'process' has a Modified Cyclomatic Complexity of 40. 195646
The method 'process' has a Standard Cyclomatic Complexity of 40. 195646
Avoid really long methods. 195646
The method process() has an NCSS line count of 221 195646
Avoid declaring a variable if it is unreferenced before a possible exit point. 198
Avoid declaring a variable if it is unreferenced before a possible exit point. 206
Avoid declaring a variable if it is unreferenced before a possible exit point. 207
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 236
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 352
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 363
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 377
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 441
Avoid variables with short names like k 445
This statement may have some unnecessary parentheses 481
Avoid variables with short names like in 584
Unnecessary wrapper object creation 593
Avoid reassigning parameters such as 'strBufferListRecordXml' 677

fr/paris/lutece/plugins/directory/web/action/IDirectoryAction.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' 36
Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' 36
Avoid unused imports such as 'java.util.Map' 40
Avoid unused imports such as 'java.util.Map' 40
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 42
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 42
Avoid unused imports such as 'javax.servlet.http.HttpServletResponse' 43
Avoid unused imports such as 'javax.servlet.http.HttpServletResponse' 43

fr/paris/lutece/plugins/directory/web/action/IDirectorySearchFields.java

Violation Line
Avoid using implementation types like 'HashMap'; use the interface instead 120
Avoid using implementation types like 'HashMap'; use the interface instead 120
Avoid using implementation types like 'HashMap'; use the interface instead 128
Avoid using implementation types like 'HashMap'; use the interface instead 128

fr/paris/lutece/plugins/directory/web/action/MassWorkflowDirectoryAction.java

Violation Line
Deeply nested if..then statements are hard to read 104108