Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/document/business/attributes/MapProviderManager.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'MapProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 5498

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublicationHome.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 47179

fr/paris/lutece/plugins/document/service/AttributeService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 48115

fr/paris/lutece/plugins/document/service/DocumentService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 94814

fr/paris/lutece/plugins/document/service/DocumentTools.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'DocumentTools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 47111

fr/paris/lutece/plugins/document/service/DocumentTypeService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 45111

fr/paris/lutece/plugins/document/service/attributes/DefaultManager.java

Rule Violation Ligne
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 343346
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 378381

fr/paris/lutece/plugins/document/service/attributes/DocumentAttributesService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 46121

fr/paris/lutece/plugins/document/service/docsearch/DocSearchItem.java

Rule Violation Ligne
ConstructorCallsOverridableMethod Overridable method 'setId' called during object construction 65
ConstructorCallsOverridableMethod Overridable method 'setTitle' called during object construction 66
ConstructorCallsOverridableMethod Overridable method 'setSummary' called during object construction 67
ConstructorCallsOverridableMethod Overridable method 'setDate' called during object construction 68
ConstructorCallsOverridableMethod Overridable method 'setType' called during object construction 69

fr/paris/lutece/plugins/document/service/docsearch/DocSearchService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 94624

fr/paris/lutece/plugins/document/service/history/DocumentHistoryService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 49128

fr/paris/lutece/plugins/document/service/publishing/PublishingService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 63462

fr/paris/lutece/plugins/document/service/rules/RuleEngine.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 4893

fr/paris/lutece/plugins/document/service/spaces/DocumentSpacesService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 71612
LocalVariableNamingConventions The local variable name '_template' doesn't match '[a-z][a-zA-Z0-9]*' 525

fr/paris/lutece/plugins/document/web/DocumentResourceServlet.java

Rule Violation Ligne
FieldNamingConventions The constant name '_cache' doesn't match '[A-Z][A-Z_0-9]*' 75

fr/paris/lutece/plugins/document/web/publishing/DocumentPublishingJspBean.java

Rule Violation Ligne
FieldNamingConventions The constant name 'MARk_DOCUMENT_LIST_PORTLET_LIST' doesn't match '[A-Z][A-Z_0-9]*' 147

fr/paris/lutece/plugins/document/web/rules/DocumentRulesJspBean.java

Rule Violation Ligne
FieldNamingConventions The field name '_StrRuleAttributeSelected' doesn't match '_[a-z][a-zA-Z0-9]*' 92

Priority 2

fr/paris/lutece/plugins/document/business/DocumentDAO.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 803
GuardLogStatement Logger calls should be surrounded by log level guards. 811
GuardLogStatement Logger calls should be surrounded by log level guards. 818
GuardLogStatement Logger calls should be surrounded by log level guards. 825
GuardLogStatement Logger calls should be surrounded by log level guards. 836
GuardLogStatement Logger calls should be surrounded by log level guards. 847

fr/paris/lutece/plugins/document/service/DocumentContentService.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 202203
GuardLogStatement Logger calls should be surrounded by log level guards. 219
GuardLogStatement Logger calls should be surrounded by log level guards. 225
AvoidReassigningParameters Avoid reassigning parameters such as 'strPortletId' 264
ProperCloneImplementation Object clone() should be implemented with super.clone() 765

fr/paris/lutece/plugins/document/service/attributes/DefaultManager.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 211
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 249

Priority 3

fr/paris/lutece/plugins/document/business/Document.java

Rule Violation Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 34873
TooManyFields Too many fields 62873
GodClass Possible God Class (WMC=73, ATFD=8, TCC=2.191%) 62873
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_QUESTION_MARK'. 80
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_EQUALS'. 81
ConfusingTernary Avoid if (x != y) ..; else ..; 200
ConfusingTernary Avoid if (x != y) ..; else ..; 322
ConfusingTernary Avoid if (x != y) ..; else ..; 667674
ShortVariable Avoid variables with short names like gc 763
LogicInversion Use opposite operator instead of the logic complement operator. 803

fr/paris/lutece/plugins/document/business/DocumentDAO.java

Rule Violation Ligne
GodClass Possible God Class (WMC=96, ATFD=317, TCC=0.430%) 531253
ExcessiveClassLength Avoid really long classes. 531253
CyclomaticComplexity The class 'DocumentDAO' has a total cyclomatic complexity of 96 (highest 33). 531253
TooManyMethods This class has too many methods, consider refactoring it. 541253
AvoidDuplicateLiterals The String literal " a.date_modification, a.xml_working_content, a.xml_validated_content, a.id_space , b.document_space_name , " appears 4 times in this file; the first occurrence is on line 58 58
AvoidDuplicateLiterals The String literal " INNER JOIN document_type d ON a.code_document_type = d.code_document_type " appears 5 times in this file; the first occurrence is on line 79 79
MissingOverride The method 'newPrimaryKey()' is missing an @Override annotation. 167184
MissingOverride The method 'insert(Document)' is missing an @Override annotation. 191218
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 191218
MissingOverride The method 'load(int)' is missing an @Override annotation. 273276
MissingOverride The method 'loadWithoutBinaries(int)' is missing an @Override annotation. 284287
MissingOverride The method 'loadFromSpaceId(int)' is missing an @Override annotation. 363392
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 369
MissingOverride The method 'loadAttributes(Document)' is missing an @Override annotation. 398441
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 400
MissingOverride The method 'loadAttributesWithoutBinaries(Document, boolean)' is missing an @Override annotation. 449492
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 451
MissingOverride The method 'delete(int)' is missing an @Override annotation. 499513
MissingOverride The method 'validateAttributes(int)' is missing an @Override annotation. 547557
MissingOverride The method 'store(Document, boolean)' is missing an @Override annotation. 578612
MissingOverride The method 'selectPrimaryKeysByFilter(DocumentFilter)' is missing an @Override annotation. 620634
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 622
MissingOverride The method 'selectByFilter(DocumentFilter)' is missing an @Override annotation. 642698
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 644
ExcessiveMethodLength Avoid really long methods. 706853
NPathComplexity The method 'getDaoFromFilter(String, DocumentFilter)' has an NPath complexity of 6386688 706853
NcssCount The method 'getDaoFromFilter(String, DocumentFilter)' has a NCSS line count of 73. 706853
CyclomaticComplexity The method 'getDaoFromFilter(String, DocumentFilter)' has a cyclomatic complexity of 33. 706853
ConfusingTernary Avoid if (x != y) ..; else ..; 714
ConfusingTernary Avoid if (x != y) ..; else ..; 720
ShortVariable Avoid variables with short names like i 728
ConfusingTernary Avoid if (x != y) ..; else ..; 750
ConfusingTernary Avoid if (x != y) ..; else ..; 769
ConfusingTernary Avoid if (x != y) ..; else ..; 774
ConfusingTernary Avoid if (x != y) ..; else ..; 780
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 781
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 782
ConfusingTernary Avoid if (x != y) ..; else ..; 786
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 787
ConfusingTernary Avoid if (x != y) ..; else ..; 791
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 792
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 799
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 802
AvoidDuplicateLiterals The String literal "Param" appears 5 times in this file; the first occurrence is on line 811 811
MissingOverride The method 'selectByRelatedCategories(Document)' is missing an @Override annotation. 861911
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 863
MissingOverride The method 'loadResource(int)' is missing an @Override annotation. 920939
MissingOverride The method 'loadSpecificResource(int, int, boolean)' is missing an @Override annotation. 950971
MissingOverride The method 'selectAllPrimaryKeys()' is missing an @Override annotation. 977993
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 979
MissingOverride The method 'selectAll()' is missing an @Override annotation. 10001042
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1002
MissingOverride The method 'getPageTemplateDocumentPath(int)' is missing an @Override annotation. 10501066
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1076
MissingOverride The method 'loadLastModifiedAttributes(int)' is missing an @Override annotation. 11421160
MissingOverride The method 'loadLastModifiedDocumentFromUser(String)' is missing an @Override annotation. 11681207
MissingOverride The method 'loadLastPublishedDocument()' is missing an @Override annotation. 12141252

fr/paris/lutece/plugins/document/business/DocumentFilter.java

Rule Violation Ligne
MethodReturnsInternalArray Returning '_arrayCategoriesId' may expose an internal array. 153
ArrayIsStoredDirectly The user-supplied array 'arrayCategoriesId' is stored directly. 159
MethodReturnsInternalArray Returning '_arrayId' may expose an internal array. 188
ArrayIsStoredDirectly The user-supplied array 'arrayId' is stored directly. 194

fr/paris/lutece/plugins/document/business/DocumentHome.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 51327

fr/paris/lutece/plugins/document/business/DocumentPageTemplateDAO.java

Rule Violation Ligne
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the newPrimaryKey method if you want a default access modifier 6381
DefaultPackage Use explicit scoping instead of the default package private level 6381
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 87100
MissingOverride The method 'insert(DocumentPageTemplate)' is missing an @Override annotation. 87100
MissingOverride The method 'load(int)' is missing an @Override annotation. 108128
MissingOverride The method 'delete(int)' is missing an @Override annotation. 134140
MissingOverride The method 'store(DocumentPageTemplate)' is missing an @Override annotation. 146158
MissingOverride The method 'selectPageTemplatesList()' is missing an @Override annotation. 164184
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 166

fr/paris/lutece/plugins/document/business/DocumentResource.java

Rule Violation Ligne
MethodReturnsInternalArray Returning '_strContent' may expose an internal array. 54
ArrayIsStoredDirectly The user-supplied array 'strContent' is stored directly. 62

fr/paris/lutece/plugins/document/business/DocumentType.java

Rule Violation Ligne
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85
ImmutableField Private field '_listAttributes' could be made final; it is only initialized in the declaration or constructor. 85
MethodReturnsInternalArray Returning '_baAdminXsl' may expose an internal array. 177
ArrayIsStoredDirectly The user-supplied array 'baXsl' is stored directly. 185
MethodReturnsInternalArray Returning '_baContentServiceXsl' may expose an internal array. 197
ArrayIsStoredDirectly The user-supplied array 'baXsl' is stored directly. 205
ConfusingTernary Avoid if (x != y) ..; else ..; 255
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 272275
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 281284
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 293
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 308
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 308
ConfusingTernary Avoid if (x != y) ..; else ..; 326334

fr/paris/lutece/plugins/document/business/DocumentTypeDAO.java

Rule Violation Ligne
MissingOverride The method 'insert(DocumentType)' is missing an @Override annotation. 6577
MissingOverride The method 'load(String)' is missing an @Override annotation. 84109
MissingOverride The method 'delete(String)' is missing an @Override annotation. 115122
MissingOverride The method 'store(DocumentType)' is missing an @Override annotation. 128141
MissingOverride The method 'selectDocumentTypeList()' is missing an @Override annotation. 147169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 149
MissingOverride The method 'getDocumentTypeList()' is missing an @Override annotation. 175192
MissingOverride The method 'checkDocuments(String)' is missing an @Override annotation. 199209
MissingOverride The method 'reorderAttributes(int, int, int, int)' is missing an @Override annotation. 218228
MissingOverride The method 'setAdminStyleSheet(byte, String)' is missing an @Override annotation. 235243
MissingOverride The method 'setContentStyleSheet(byte, String)' is missing an @Override annotation. 250258

fr/paris/lutece/plugins/document/business/IDocumentDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 44190

fr/paris/lutece/plugins/document/business/IndexerActionDAO.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 6582
MissingOverride The method 'newPrimaryKey()' is missing an @Override annotation. 6582
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8799
CommentRequired Public method and constructor comments are required 8799
MissingOverride The method 'insert(IndexerAction)' is missing an @Override annotation. 8799
MissingOverride The method 'load(int)' is missing an @Override annotation. 104123
CommentRequired Public method and constructor comments are required 104123
CommentRequired Public method and constructor comments are required 128134
MissingOverride The method 'delete(int)' is missing an @Override annotation. 128134
CommentRequired Public method and constructor comments are required 139144
MissingOverride The method 'deleteAll()' is missing an @Override annotation. 139144
CommentRequired Public method and constructor comments are required 149160
MissingOverride The method 'store(IndexerAction)' is missing an @Override annotation. 149160
CommentRequired Public method and constructor comments are required 165203
MissingOverride The method 'selectList(IndexerActionFilter)' is missing an @Override annotation. 165203
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 167
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 169
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 221
AssignmentInOperand Avoid assignments in operands 221

fr/paris/lutece/plugins/document/business/attributes/AttributeType.java

Rule Violation Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 8992

fr/paris/lutece/plugins/document/business/attributes/AttributeTypeDAO.java

Rule Violation Ligne
MissingOverride The method 'insert(AttributeType)' is missing an @Override annotation. 6474
MissingOverride The method 'load(int)' is missing an @Override annotation. 82102
MissingOverride The method 'delete(AttributeType)' is missing an @Override annotation. 108115
MissingOverride The method 'store(AttributeType)' is missing an @Override annotation. 121132
MissingOverride The method 'selectDocumentAttributeTypeList()' is missing an @Override annotation. 138158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 140
MissingOverride The method 'selectAttributeTypeList(Locale)' is missing an @Override annotation. 165183
MissingOverride The method 'getAttributeManagersList()' is missing an @Override annotation. 192206
MissingOverride The method 'selectAttributeTypeParameterList(String)' is missing an @Override annotation. 216247
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 218
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 219
PositionLiteralsFirstInComparisons Position literals first in String comparisons 233

fr/paris/lutece/plugins/document/business/attributes/AttributeTypeParameter.java

Rule Violation Ligne
ImmutableField Private field '_listDefaultValue' could be made final; it is only initialized in the declaration or constructor. 53
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 53
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 54
ImmutableField Private field '_listValues' could be made final; it is only initialized in the declaration or constructor. 54
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 8285
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 153
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 186

fr/paris/lutece/plugins/document/business/attributes/DocumentAttribute.java

Rule Violation Ligne
ArrayIsStoredDirectly The user-supplied array 'bytes' is stored directly. 298
MethodReturnsInternalArray Returning '_bytes' may expose an internal array. 309

fr/paris/lutece/plugins/document/business/attributes/DocumentAttributeDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 48431
MissingOverride The method 'insert(DocumentAttribute)' is missing an @Override annotation. 109127
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 109127
MissingOverride The method 'load(int)' is missing an @Override annotation. 134158
MissingOverride The method 'delete(int)' is missing an @Override annotation. 164173
MissingOverride The method 'store(DocumentAttribute)' is missing an @Override annotation. 207227
MissingOverride The method 'selectAttributesByDocumentType(DocumentType)' is missing an @Override annotation. 233259
MissingOverride The method 'selectAllAttributesOfDocumentType(String)' is missing an @Override annotation. 266291
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 268
ShortVariable Avoid variables with short names like i 300
MissingOverride The method 'selectAttributeParametersValues(int)' is missing an @Override annotation. 321339
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 323
MissingOverride The method 'getAttributeParameterValues(int, String)' is missing an @Override annotation. 347363
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 349
MissingOverride The method 'insertRegularExpression(int, int)' is missing an @Override annotation. 371378
MissingOverride The method 'deleteRegularExpression(int, int)' is missing an @Override annotation. 386393
MissingOverride The method 'selectListRegularExpressionKeyByIdAttribute(int)' is missing an @Override annotation. 414430
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 416

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublication.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 5559

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublicationDAO.java

Rule Violation Ligne
MissingOverride The method 'delete(int, int)' is missing an @Override annotation. 6673
MissingOverride The method 'deleteAllSpaces(int)' is missing an @Override annotation. 8086
MissingOverride The method 'insert(DocumentAutoPublication)' is missing an @Override annotation. 94102
MissingOverride The method 'load(int, int)' is missing an @Override annotation. 111130
MissingOverride The method 'load()' is missing an @Override annotation. 137155
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 142
MissingOverride The method 'selectByPortletId(int)' is missing an @Override annotation. 163182
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 169
MissingOverride The method 'selectBySpaceId(int)' is missing an @Override annotation. 190209
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 196
MissingOverride The method 'store(DocumentAutoPublication)' is missing an @Override annotation. 216226

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublicationDocumentSpaceRemovalListener.java

Rule Violation Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 5676
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 8488

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublicationHome.java

Rule Violation Ligne
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 156159
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 172175

fr/paris/lutece/plugins/document/business/category/Category.java

Rule Violation Ligne
MethodReturnsInternalArray Returning '_byteIconContent' may expose an internal array. 58
ArrayIsStoredDirectly The user-supplied array 'byteIconContent' is stored directly. 64
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 137140

fr/paris/lutece/plugins/document/business/category/CategoryDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 47339
MissingOverride The method 'selectAll()' is missing an @Override annotation. 7196
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 74
MissingOverride The method 'insert(Category)' is missing an @Override annotation. 102116
MissingOverride The method 'load(int)' is missing an @Override annotation. 143167
MissingOverride The method 'delete(int)' is missing an @Override annotation. 173180
MissingOverride The method 'store(Category)' is missing an @Override annotation. 186199
MissingOverride The method 'selectByName(String)' is missing an @Override annotation. 206232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 209
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 256
ShortVariable Avoid variables with short names like i 270
MissingOverride The method 'selectCountIdDocuments(int)' is missing an @Override annotation. 298313
MissingOverride The method 'loadImageResource(int)' is missing an @Override annotation. 320338

fr/paris/lutece/plugins/document/business/category/CategoryHome.java

Rule Violation Ligne
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'categoryList' 66

fr/paris/lutece/plugins/document/business/history/HistoryEvent.java

Rule Violation Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 185188

fr/paris/lutece/plugins/document/business/history/HistoryEventDAO.java

Rule Violation Ligne
MissingOverride The method 'insert(HistoryEvent)' is missing an @Override annotation. 5971
MissingOverride The method 'delete(int)' is missing an @Override annotation. 7885
MissingOverride The method 'selectEventListByDocument(int)' is missing an @Override annotation. 93116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 95
MissingOverride The method 'selectEventListByUser(String)' is missing an @Override annotation. 124147
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 126

fr/paris/lutece/plugins/document/business/portlet/DocumentListPortlet.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 6568
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 7694
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'str' 93
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 102105
MissingOverride The method 'remove()' is missing an @Override annotation. 118121
MethodReturnsInternalArray Returning '_nArrayIdCategory' may expose an internal array. 169
ArrayIsStoredDirectly The user-supplied array 'arrayIdCategory' is stored directly. 175

fr/paris/lutece/plugins/document/business/portlet/DocumentListPortletDAO.java

Rule Violation Ligne
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 8092
ShortVariable Avoid variables with short names like p 82
ShortVariable Avoid variables with short names like p 100
MissingOverride The method 'delete(int)' is missing an @Override annotation. 124138
MissingOverride The method 'load(int)' is missing an @Override annotation. 170189
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 202
ShortVariable Avoid variables with short names like i 212
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 227241
ShortVariable Avoid variables with short names like p 229
MissingOverride The method 'selectByDocumentIdAndDocumentType(int, String, PortletOrder, PortletFilter)' is missing an @Override annotation. 250306
CyclomaticComplexity The method 'selectByDocumentIdAndDocumentType(int, String, PortletOrder, PortletFilter)' has a cyclomatic complexity of 10. 250306
ConfusingTernary Avoid if (x != y) ..; else ..; 256
MissingOverride The method 'checkIsAliasPortlet(int)' is missing an @Override annotation. 314330

fr/paris/lutece/plugins/document/business/portlet/DocumentListPortletHome.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 57
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 57
CallSuperInConstructor It is a good practice to call super() in a constructor 6268
NonThreadSafeSingleton Singleton is not thread safe 7780
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 9096
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 95
MissingOverride The method 'getDAO()' is missing an @Override annotation. 103106

fr/paris/lutece/plugins/document/business/portlet/DocumentPortlet.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 6871
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 7996
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'str' 95
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 104107
MissingOverride The method 'remove()' is missing an @Override annotation. 120123
MethodReturnsInternalArray Returning '_nArrayIdCategory' may expose an internal array. 170
ArrayIsStoredDirectly The user-supplied array 'arrayIdCategory' is stored directly. 176

fr/paris/lutece/plugins/document/business/portlet/DocumentPortletDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 46369
TooManyMethods This class has too many methods, consider refactoring it. 47369
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 8092
ShortVariable Avoid variables with short names like p 82
ShortVariable Avoid variables with short names like p 102
MissingOverride The method 'delete(int)' is missing an @Override annotation. 127141
MissingOverride The method 'load(int)' is missing an @Override annotation. 179198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 212
ShortVariable Avoid variables with short names like i 222
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 238252
ShortVariable Avoid variables with short names like p 240
CyclomaticComplexity The method 'selectByDocumentOdAndDocumentType(int, String, PortletOrder, PortletFilter)' has a cyclomatic complexity of 10. 266321
MissingOverride The method 'selectByDocumentOdAndDocumentType(int, String, PortletOrder, PortletFilter)' is missing an @Override annotation. 266321
ConfusingTernary Avoid if (x != y) ..; else ..; 272
MissingOverride The method 'checkIsAliasPortlet(int)' is missing an @Override annotation. 330346
MissingOverride The method 'selectPortletsByDocumentId(int)' is missing an @Override annotation. 352368
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 358

fr/paris/lutece/plugins/document/business/portlet/DocumentPortletHome.java

Rule Violation Ligne
CommentRequired Header comments are required 46140
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 54
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 54
CallSuperInConstructor It is a good practice to call super() in a constructor 5965
NonThreadSafeSingleton Singleton is not thread safe 7477
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 8793
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 92
MissingOverride The method 'getDAO()' is missing an @Override annotation. 100103

fr/paris/lutece/plugins/document/business/portlet/IDocumentListPortletDAO.java

Rule Violation Ligne
MissingOverride The method 'delete(int)' is missing an @Override annotation. 64
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 72
MissingOverride The method 'load(int)' is missing an @Override annotation. 81
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 100

fr/paris/lutece/plugins/document/business/portlet/PortletFilter.java

Rule Violation Ligne
ArrayIsStoredDirectly The user-supplied array 'strPageTitle' is stored directly. 67
MethodReturnsInternalArray Returning '_tabPageName' may expose an internal array. 78
ArrayIsStoredDirectly The user-supplied array 'strPortletTitle' is stored directly. 85
MethodReturnsInternalArray Returning '_tabPortletName' may expose an internal array. 96
CyclomaticComplexity The method 'getSQLFilter()' has a cyclomatic complexity of 13. 159206

fr/paris/lutece/plugins/document/business/publication/DocumentPublicationDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 49372
MissingOverride The method 'insert(DocumentPublication)' is missing an @Override annotation. 6981
MissingOverride The method 'store(DocumentPublication)' is missing an @Override annotation. 8899
MissingOverride The method 'delete(int, int)' is missing an @Override annotation. 107114
MissingOverride The method 'deleteFromPortletId(int)' is missing an @Override annotation. 121127
MissingOverride The method 'deleteFromDocumentId(int)' is missing an @Override annotation. 134140
MissingOverride The method 'select(int, int)' is missing an @Override annotation. 151172
MissingOverride The method 'selectByPortletId(int)' is missing an @Override annotation. 179200
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 181
MissingOverride The method 'selectByDocumentId(int)' is missing an @Override annotation. 207228
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 209
MissingOverride The method 'selectByPortletIdAndStatus(int, int)' is missing an @Override annotation. 236258
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 238
MissingOverride The method 'selectByDocumentIdAndStatus(int, int)' is missing an @Override annotation. 266288
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 268
MissingOverride The method 'selectSinceDatePublishingAndStatus(Date, int)' is missing an @Override annotation. 296318
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 298
MissingOverride The method 'selectMaxDocumentOrder(int)' is missing an @Override annotation. 325340
MissingOverride The method 'selectDocumentIdByOrder(int, int)' is missing an @Override annotation. 349371
ConfusingTernary Avoid if (x != y) ..; else ..; 358366

fr/paris/lutece/plugins/document/business/publication/DocumentPublicationHome.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 47182
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 47182

fr/paris/lutece/plugins/document/business/publication/IDocumentPublicationDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 46144

fr/paris/lutece/plugins/document/business/rules/AbstractRule.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 55
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 55
ImmutableField Private field '_mapAttributes' could be made final; it is only initialized in the declaration or constructor. 55
MissingOverride The method 'getId()' is missing an @Override annotation. 6467
MissingOverride The method 'setId(int)' is missing an @Override annotation. 7477
MissingOverride The method 'getRuleTypeId()' is missing an @Override annotation. 8487
MissingOverride The method 'setRuleTypeId(String)' is missing an @Override annotation. 9497
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 104107
MissingOverride The method 'setAttribute(String, String)' is missing an @Override annotation. 123126
MissingOverride The method 'getAttribute(String)' is missing an @Override annotation. 133136
MissingOverride The method 'readAttributes(HttpServletRequest)' is missing an @Override annotation. 142158
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 149157
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 164
MissingOverride The method 'getUser()' is missing an @Override annotation. 170173
MissingOverride The method 'setUser(AdminUser)' is missing an @Override annotation. 180183

fr/paris/lutece/plugins/document/business/rules/RuleDAO.java

Rule Violation Ligne
MissingOverride The method 'insert(Rule)' is missing an @Override annotation. 8799
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8799
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 110120
MissingOverride The method 'load(int, IRuleTypesSet)' is missing an @Override annotation. 130149
MissingOverride The method 'delete(int)' is missing an @Override annotation. 173182
MissingOverride The method 'store(Rule)' is missing an @Override annotation. 201206
MissingOverride The method 'selectRuleList(IRuleTypesSet)' is missing an @Override annotation. 213229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 215
MissingOverride The method 'selectRuleListByRuleTypeKey(String, IRuleTypesSet)' is missing an @Override annotation. 237256
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 239

fr/paris/lutece/plugins/document/business/rules/RuleTypesSet.java

Rule Violation Ligne
MissingOverride The method 'setRuleTypesMap(Map)' is missing an @Override annotation. 5659
MissingOverride The method 'newInstance(String)' is missing an @Override annotation. 6685
IdenticalCatchBranches 'catch' branch identical to 'InstantiationException' branch 7982
MissingOverride The method 'getRuleTypeKey(Rule)' is missing an @Override annotation. 91117
IdenticalCatchBranches 'catch' branch identical to 'InstantiationException' branch 110113
MissingOverride The method 'getRuleTypesList(Locale)' is missing an @Override annotation. 123134
MissingOverride The method 'getRuleTypes()' is missing an @Override annotation. 140143

fr/paris/lutece/plugins/document/business/spaces/DocumentSpace.java

Rule Violation Ligne
ImmutableField Private field '_listDocumentType' could be made final; it is only initialized in the declaration or constructor. 57
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 57
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 57
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 264267
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 273276
AddEmptyString Do not add empty strings 275
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 282285

fr/paris/lutece/plugins/document/business/spaces/DocumentSpaceDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 49458
MissingOverride The method 'insert(DocumentSpace)' is missing an @Override annotation. 108125
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 108125
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 135143
MissingOverride The method 'load(int)' is missing an @Override annotation. 152182
MissingOverride The method 'delete(int)' is missing an @Override annotation. 207215
MissingOverride The method 'store(DocumentSpace)' is missing an @Override annotation. 234252
MissingOverride The method 'selectChilds(int, String)' is missing an @Override annotation. 261298
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 263
ConfusingTernary Avoid if (x != y) ..; else ..; 266276
MissingOverride The method 'selectSpacesAllowingDocumentCreationByDocumentType(String, int)' is missing an @Override annotation. 306336
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 309
MissingOverride The method 'getDocumentSpaceList()' is missing an @Override annotation. 342360
MissingOverride The method 'getViewTypeList(Locale)' is missing an @Override annotation. 367383
MissingOverride The method 'getIconsList()' is missing an @Override annotation. 389405
MissingOverride The method 'selectAll()' is missing an @Override annotation. 411435
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 413
MissingOverride The method 'getAllowedDocumentTypes(int)' is missing an @Override annotation. 442457

fr/paris/lutece/plugins/document/business/spaces/SpaceAction.java

Rule Violation Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 6063
MissingOverride The method 'getPermission()' is missing an @Override annotation. 169172

fr/paris/lutece/plugins/document/business/spaces/SpaceActionDAO.java

Rule Violation Ligne
MissingOverride The method 'selectActions()' is missing an @Override annotation. 5475
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 56

fr/paris/lutece/plugins/document/business/workflow/DocumentAction.java

Rule Violation Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 107110
MissingOverride The method 'getPermission()' is missing an @Override annotation. 216219

fr/paris/lutece/plugins/document/business/workflow/DocumentActionDAO.java

Rule Violation Ligne
MissingOverride The method 'load(int)' is missing an @Override annotation. 5989
MissingOverride The method 'selectActions(Document)' is missing an @Override annotation. 97120
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 99

fr/paris/lutece/plugins/document/business/workflow/DocumentStateDAO.java

Rule Violation Ligne
MissingOverride The method 'load(int)' is missing an @Override annotation. 5776
MissingOverride The method 'selectDocumentStatesList(Locale)' is missing an @Override annotation. 83101

fr/paris/lutece/plugins/document/business/workflow/DocumentStateHome.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4669

fr/paris/lutece/plugins/document/modules/metadatadublincore/DublinCoreMetadataHandler.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 81
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 81
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 99
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 99

fr/paris/lutece/plugins/document/modules/metadatadublincore/business/DublinCoreMetadata.java

Rule Violation Ligne
NPathComplexity The method 'getXml()' has an NPath complexity of 14348907 387470
CyclomaticComplexity The method 'getXml()' has a cyclomatic complexity of 31. 387470
ShortVariable Avoid variables with short names like sr 489
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 497500
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 501504

fr/paris/lutece/plugins/document/modules/rulemovespace/business/MoveSpaceRule.java

Rule Violation Ligne
MissingOverride The method 'init()' is missing an @Override annotation. 8795
MissingOverride The method 'getNameKey()' is missing an @Override annotation. 101104
MissingOverride The method 'apply(DocumentEvent)' is missing an @Override annotation. 111133
CollapsibleIfStatements These nested if statements could be combined 121125
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 128
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 131
MissingOverride The method 'getCreateForm(AdminUser, Locale)' is missing an @Override annotation. 141196
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 143
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 143
MissingOverride The method 'isAuthorized(AdminUser)' is missing an @Override annotation. 203219
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 206
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 213216
MissingOverride The method 'validateRule()' is missing an @Override annotation. 226250
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 229
MissingOverride The method 'getAttributesList()' is missing an @Override annotation. 256259
MethodReturnsInternalArray Returning '_attributes' may expose an internal array. 258
MissingOverride The method 'getRule()' is missing an @Override annotation. 265285
CyclomaticComplexity The method 'equals(Object)' has a cyclomatic complexity of 12. 315346
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 315

fr/paris/lutece/plugins/document/modules/rulemovespace/business/MoveSpaceSpaceRemovalListener.java

Rule Violation Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 5888
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 96100
ShortVariable Avoid variables with short names like id 96

fr/paris/lutece/plugins/document/modules/rulenotifyusers/business/NotifyUsersMailingListRemovalListener.java

Rule Violation Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 5887
ShortVariable Avoid variables with short names like id 95
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 9599

fr/paris/lutece/plugins/document/modules/rulenotifyusers/business/NotifyUsersRule.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34474
MissingOverride The method 'init()' is missing an @Override annotation. 127141
MissingOverride The method 'getNameKey()' is missing an @Override annotation. 147150
MissingOverride The method 'apply(DocumentEvent)' is missing an @Override annotation. 157203
CollapsibleIfStatements These nested if statements could be combined 169196
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 176
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 176
ShortVariable Avoid variables with short names like t 185
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 199
MissingOverride The method 'getCreateForm(AdminUser, Locale)' is missing an @Override annotation. 211263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 213
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 213
MissingOverride The method 'validateRule()' is missing an @Override annotation. 270286
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 272
MissingOverride The method 'isAuthorized(AdminUser)' is missing an @Override annotation. 293303
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 297300
MissingOverride The method 'getAttributesList()' is missing an @Override annotation. 309312
MethodReturnsInternalArray Returning '_attributes' may expose an internal array. 311
MissingOverride The method 'getRule()' is missing an @Override annotation. 318350
CyclomaticComplexity The method 'equals(Object)' has a cyclomatic complexity of 15. 439473
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 439

fr/paris/lutece/plugins/document/modules/rulenotifyusers/business/NotifyUsersSpaceRemovalListener.java

Rule Violation Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 5886
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 9498
ShortVariable Avoid variables with short names like id 94

fr/paris/lutece/plugins/document/service/AttributeService.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 51
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 51
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6271
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 9598
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 99102

fr/paris/lutece/plugins/document/service/DocumentContentService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34788
GodClass Possible God Class (WMC=71, ATFD=89, TCC=12.281%) 102788
TooManyMethods This class has too many methods, consider refactoring it. 103788
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 148
MissingOverride The method 'getPage(HttpServletRequest, int)' is missing an @Override annotation. 170229
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 240
CyclomaticComplexity The method 'buildPage(HttpServletRequest, String, String, String, int)' has a cyclomatic complexity of 18. 264412
NPathComplexity The method 'buildPage(HttpServletRequest, String, String, String, int)' has an NPath complexity of 3900 264412
NcssCount The method 'buildPage(HttpServletRequest, String, String, String, int)' has a NCSS line count of 73. 264412
ExcessiveMethodLength Avoid really long methods. 264412
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 270
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 338
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 363
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 363
MissingOverride The method 'isInvoked(HttpServletRequest)' is missing an @Override annotation. 421433
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 426430
MissingOverride The method 'getName()' is missing an @Override annotation. 440443
ConfusingTernary Avoid if (x != y) ..; else ..; 452461
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPageTemplateDocument' 456
CyclomaticComplexity The method 'getPortlet(HttpServletRequest, String, int)' has a cyclomatic complexity of 12. 476599
ExcessiveMethodLength Avoid really long methods. 476599
NPathComplexity The method 'getPortlet(HttpServletRequest, String, int)' has an NPath complexity of 273 476599
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 483
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 499
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 510
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 510
ConfusingTernary Avoid if (x != y) ..; else ..; 522530
ConfusingTernary Avoid if (x != y) ..; else ..; 541542
CyclomaticComplexity The method 'getRelatedDocumentsPortlet(HttpServletRequest, Document, int, int)' has a cyclomatic complexity of 10. 611656
UnusedFormalParameter Avoid unused method parameters such as 'nPortletId'. 611
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 616
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 619
MissingOverride The method 'dispose()' is missing an @Override annotation. 661663
UncommentedEmptyMethodBody Document empty method body 662663
MissingOverride The method 'notifyElementEvicted(Ehcache, Element)' is missing an @Override annotation. 669672
MissingOverride The method 'notifyElementExpired(Ehcache, Element)' is missing an @Override annotation. 678681
MissingOverride The method 'notifyElementPut(Ehcache, Element)' is missing an @Override annotation. 687690
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 688
UncommentedEmptyMethodBody Document empty method body 689690
MissingOverride The method 'notifyElementRemoved(Ehcache, Element)' is missing an @Override annotation. 696700
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 697
MissingOverride The method 'notifyElementUpdated(Ehcache, Element)' is missing an @Override annotation. 706709
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 707
UncommentedEmptyMethodBody Document empty method body 708709
MissingOverride The method 'notifyRemoveAll(Ehcache)' is missing an @Override annotation. 714717
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 765768

fr/paris/lutece/plugins/document/service/DocumentEvent.java

Rule Violation Ligne
ImmutableField Private field '_document' could be made final; it is only initialized in the declaration or constructor. 52
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 53
ImmutableField Private field '_nType' could be made final; it is only initialized in the declaration or constructor. 54
ImmutableField Private field '_nSpaceId' could be made final; it is only initialized in the declaration or constructor. 55
ImmutableField Private field '_nStateId' could be made final; it is only initialized in the declaration or constructor. 56

fr/paris/lutece/plugins/document/service/DocumentEventListernersManager.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the notifyListeners method if you want a default access modifier 7278
DefaultPackage Use explicit scoping instead of the default package private level 7278

fr/paris/lutece/plugins/document/service/DocumentException.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 5558

fr/paris/lutece/plugins/document/service/DocumentMassActionResourceService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 6164
MissingOverride The method 'register()' is missing an @Override annotation. 6983
ShortVariable Avoid variables with short names like rt 71
ShortVariable Avoid variables with short names like p 77
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 9196

fr/paris/lutece/plugins/document/service/DocumentPlugin.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 5158
MissingOverride The method 'init()' is missing an @Override annotation. 5158

fr/paris/lutece/plugins/document/service/DocumentService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34814
GodClass Possible God Class (WMC=91, ATFD=185, TCC=0.585%) 94814
CyclomaticComplexity The class 'DocumentService' has a total cyclomatic complexity of 91 (highest 27). 94814
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 132
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the buildXmlContent method if you want a default access modifier 156190
DefaultPackage Use explicit scoping instead of the default package private level 156190
LinguisticNaming Linguistics Antipattern - The getter 'getActions' should not return void linguistically 381397
LinguisticNaming Linguistics Antipattern - The getter 'getPublishedStatus' should not return void linguistically 403414
ConfusingTernary Avoid if (x != y) ..; else ..; 479490
SimplifiedTernary Ternary operators that can be simplified with || or && 531532
ExcessiveMethodLength Avoid really long methods. 547673
NcssCount The method 'getDocumentData(MultipartHttpServletRequest, Document, Locale)' has a NCSS line count of 65. 547673
CyclomaticComplexity The method 'getDocumentData(MultipartHttpServletRequest, Document, Locale)' has a cyclomatic complexity of 25. 547673
NPathComplexity The method 'getDocumentData(MultipartHttpServletRequest, Document, Locale)' has an NPath complexity of 209952 547673
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 551
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 552
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 553
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 555
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 557
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 559
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 561
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 562
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 592
CollapsibleIfStatements These nested if statements could be combined 633637
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 660
NPathComplexity The method 'setAttribute(DocumentAttribute, Document, MultipartHttpServletRequest, Locale)' has an NPath complexity of 13023 684813
CyclomaticComplexity The method 'setAttribute(DocumentAttribute, Document, MultipartHttpServletRequest, Locale)' has a cyclomatic complexity of 27. 684813
ExcessiveMethodLength Avoid really long methods. 684813
LinguisticNaming Linguistics Antipattern - The setter 'setAttribute' should not return any type except void linguistically 684813
ConfusingTernary Avoid if (x != y) ..; else ..; 694810

fr/paris/lutece/plugins/document/service/DocumentTools.java

Rule Violation Ligne
SimplifiedTernary Ternary operators that can be simplified with || or && 69
ConfusingTernary Avoid if (x != y) ..; else ..; 69
SimplifiedTernary Ternary operators that can be simplified with || or && 7172
ConfusingTernary Avoid if (x != y) ..; else ..; 7172
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 49 characters appended. 73
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 94
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 105
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 106

fr/paris/lutece/plugins/document/service/DocumentTypeResourceIdService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 103106
MissingOverride The method 'register()' is missing an @Override annotation. 111180
ShortVariable Avoid variables with short names like rt 113
ShortVariable Avoid variables with short names like p 119
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 187190
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 198203

fr/paris/lutece/plugins/document/service/attributes/DateManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 6871
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 7780
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 8689
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 9598
MissingOverride The method 'validateValue(int, String, Locale)' is missing an @Override annotation. 107124
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 132160
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 145
MissingOverride The method 'getAttributeParametersValues(int, Locale)' is missing an @Override annotation. 168187
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 178
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 180
CyclomaticComplexity The method 'validateDate(String, Locale)' has a cyclomatic complexity of 10. 195240
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 198
ShortVariable Avoid variables with short names like i 199
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 199

fr/paris/lutece/plugins/document/service/attributes/DefaultManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateFormHtml(DocumentAttribute, Locale, String)' is missing an @Override annotation. 118134
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 125
MissingOverride The method 'getModifyFormHtml(DocumentAttribute, Document, Locale, String)' is missing an @Override annotation. 139192
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 141
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 141
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 171180
MissingOverride The method 'getCreateParametersFormHtml(Locale)' is missing an @Override annotation. 197200
MissingOverride The method 'getCreateParametersFormHtml(List, Locale)' is missing an @Override annotation. 205208
CommentRequired Public method and constructor comments are required 210239
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 215
ConfusingTernary Avoid if (x != y) ..; else ..; 225232
MissingOverride The method 'getModifyParametersFormHtml(Locale, int)' is missing an @Override annotation. 244247
CommentRequired Public method and constructor comments are required 249269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 253
MissingOverride The method 'getExtraParameters(Locale)' is missing an @Override annotation. 274277
MissingOverride The method 'getExtraParametersValues(Locale, int)' is missing an @Override annotation. 282293
MissingOverride The method 'setAttributeTypeCode(String)' is missing an @Override annotation. 298301
MissingOverride The method 'getAttributeTypeCode()' is missing an @Override annotation. 306309
MissingOverride The method 'validateValue(int, String, Locale)' is missing an @Override annotation. 314338
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 322
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 343346
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 351354
MissingOverride The method 'canBeUsedAsThumbnail()' is missing an @Override annotation. 370373
MissingOverride The method 'getValueParameters(HttpServletRequest, Locale)' is missing an @Override annotation. 378381
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 391

fr/paris/lutece/plugins/document/service/attributes/DocumentAttributesService.java

Rule Violation Ligne
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listAttributes' 100

fr/paris/lutece/plugins/document/service/attributes/FileManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 6265
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 7174
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 8083
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 8992
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 101119

fr/paris/lutece/plugins/document/service/attributes/ImageFileManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 5154
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 6063
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 6972
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 7881

fr/paris/lutece/plugins/document/service/attributes/InternalLinkManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 5255
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 6164
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 7073
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 7982
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 9094

fr/paris/lutece/plugins/document/service/attributes/ListBoxManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 8083
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 8992
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 98101
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 107110
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 118129
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 144
CyclomaticComplexity The method 'getValueParameters(HttpServletRequest, Locale)' has a cyclomatic complexity of 14. 178249
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 190
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 257
CollapsibleIfStatements These nested if statements could be combined 291298

fr/paris/lutece/plugins/document/service/attributes/MultilineManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 4952
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 5861
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 6770
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 7679

fr/paris/lutece/plugins/document/service/attributes/NumerictextManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 5659
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 6568
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 7477
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 8386
MissingOverride The method 'validateValue(int, String, Locale)' is missing an @Override annotation. 95116
ConfusingTernary Avoid if (x != y) ..; else ..; 99113

fr/paris/lutece/plugins/document/service/attributes/RichTextManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 5255
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 6164
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 7073
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 7982
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 9094

fr/paris/lutece/plugins/document/service/attributes/TextManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 5962
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 6871
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 7780
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 8689
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 97124

fr/paris/lutece/plugins/document/service/attributes/UrlManager.java

Rule Violation Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 5255
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 6164
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 7276

fr/paris/lutece/plugins/document/service/autoarchiving/AutoArchivingDaemon.java

Rule Violation Ligne
MissingOverride The method 'run()' is missing an @Override annotation. 4750

fr/paris/lutece/plugins/document/service/autoarchiving/AutoArchivingService.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 6265
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 122 characters appended. 85

fr/paris/lutece/plugins/document/service/autopublication/AutoPublicationDaemon.java

Rule Violation Ligne
MissingOverride The method 'run()' is missing an @Override annotation. 4750

fr/paris/lutece/plugins/document/service/autopublication/AutoPublicationService.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 6871
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 125 characters appended. 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 133

fr/paris/lutece/plugins/document/service/category/CategoryService.java

Rule Violation Ligne
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the CategoryService constructor if you want a default access modifier 6467
MissingOverride The method 'getImageResource(int)' is missing an @Override annotation. 8487
MissingOverride The method 'getResourceTypeId()' is missing an @Override annotation. 9396
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 108
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 135
ShortVariable Avoid variables with short names like i 169
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 186

fr/paris/lutece/plugins/document/service/docsearch/DefaultDocSearchIndexer.java

Rule Violation Ligne
UseUnderscoresInNumericLiterals Number 1000000 should separate every third digit with an underscore 78
MissingOverride The method 'getDocuments(Collection)' is missing an @Override annotation. 86102
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 89
ShortVariable Avoid variables with short names like ft 119
IdenticalCatchBranches 'catch' branch identical to 'SAXException' branch 146149
ShortVariable Avoid variables with short names like sb 153
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 181
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 182
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 182
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 183
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 184
ConfusingTernary Avoid if (x != y) ..; else ..; 190214
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 193
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 206

fr/paris/lutece/plugins/document/service/docsearch/DocSearchIndexerDaemon.java

Rule Violation Ligne
MissingOverride The method 'run()' is missing an @Override annotation. 5054

fr/paris/lutece/plugins/document/service/docsearch/DocSearchItem.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 119
ConfusingTernary Avoid if (x != y) ..; else ..; 139

fr/paris/lutece/plugins/document/service/docsearch/DocSearchService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34624
GodClass Possible God Class (WMC=61, ATFD=111, TCC=8.333%) 94624
UseUnderscoresInNumericLiterals Number 1000000 should separate every third digit with an underscore 101
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 102
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 103
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 106
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 132
NonThreadSafeSingleton Singleton is not thread safe 144147
CyclomaticComplexity The method 'processIndexing(boolean)' has a cyclomatic complexity of 21. 157360
NPathComplexity The method 'processIndexing(boolean)' has an NPath complexity of 308 157360
ExcessiveMethodLength Avoid really long methods. 157360
NcssCount The method 'processIndexing(boolean)' has a NCSS line count of 116. 157360
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 109 characters appended. 159
ConfusingTernary Avoid if (x != y) ..; else ..; 189328
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 196
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 203
ShortVariable Avoid variables with short names like it 205
AvoidDuplicateLiterals The String literal "\r\n" appears 5 times in this file; the first occurrence is on line 217 217
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 221
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 223
AvoidDuplicateLiterals The String literal "Indexing error : " appears 4 times in this file; the first occurrence is on line 228 228
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 237
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 244
ShortVariable Avoid variables with short names like it 246
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 263
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 265
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 281
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 299
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 318
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 320
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 335
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 371
ShortVariable Avoid variables with short names like ir 373
ShortVariable Avoid variables with short names like si 409
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 413
NcssCount The method 'getSearchResults(String, boolean, boolean, String, DocumentType)' has a NCSS line count of 68. 430553
NPathComplexity The method 'getSearchResults(String, boolean, boolean, String, DocumentType)' has an NPath complexity of 4034 430553
ExcessiveMethodLength Avoid really long methods. 430553
CyclomaticComplexity The method 'getSearchResults(String, boolean, boolean, String, DocumentType)' has a cyclomatic complexity of 17. 430553
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 433
ShortVariable Avoid variables with short names like ir 435
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 439
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 440
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 441
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 493
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 493
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 494
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 499
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 499
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 500
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 503
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 520
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 547

fr/paris/lutece/plugins/document/service/history/DocumentHistoryService.java

Rule Violation Ligne
MissingOverride The method 'processDocumentEvent(DocumentEvent)' is missing an @Override annotation. 76127
ConfusingTernary Avoid if (x != y) ..; else ..; 84
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 123

fr/paris/lutece/plugins/document/service/metadata/MetadataService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4697
ShortVariable Avoid variables with short names like st 67

fr/paris/lutece/plugins/document/service/publishing/PortletInvalider.java

Rule Violation Ligne
MissingOverride The method 'processPublishingEvent(PublishingEvent)' is missing an @Override annotation. 5458
MissingOverride The method 'processDocumentEvent(DocumentEvent)' is missing an @Override annotation. 6474

fr/paris/lutece/plugins/document/service/publishing/PublishingEvent.java

Rule Violation Ligne
ImmutableField Private field '_nDocumentId' could be made final; it is only initialized in the declaration or constructor. 47
ImmutableField Private field '_nPortletId' could be made final; it is only initialized in the declaration or constructor. 48
ImmutableField Private field '_nType' could be made final; it is only initialized in the declaration or constructor. 49

fr/paris/lutece/plugins/document/service/publishing/PublishingEventListenersManager.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the notifyListeners method if you want a default access modifier 7076
DefaultPackage Use explicit scoping instead of the default package private level 7076

fr/paris/lutece/plugins/document/service/publishing/PublishingService.java

Rule Violation Ligne
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 66
CyclomaticComplexity The method 'changeDocumentOrder(int, int, int)' has a cyclomatic complexity of 10. 186229
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 255
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 267
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 303
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 326
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 379
ShortVariable Avoid variables with short names like i 385
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listDocuments' 402
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 415
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 433
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 434

fr/paris/lutece/plugins/document/service/resource/DocumentExtendableResourceService.java

Rule Violation Ligne
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 116

fr/paris/lutece/plugins/document/service/rules/RuleEngine.java

Rule Violation Ligne
MissingOverride The method 'processDocumentEvent(DocumentEvent)' is missing an @Override annotation. 8592

fr/paris/lutece/plugins/document/service/search/DocumentIndexer.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34390
UseUnderscoresInNumericLiterals Number 1000000 should separate every third digit with an underscore 100
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 134
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 159
ShortVariable Avoid variables with short names like it 162
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 224
ShortVariable Avoid variables with short names like ft 247
IdenticalCatchBranches 'catch' branch identical to 'SAXException' branch 283286
ConfusingTernary Avoid if (x != y) ..; else ..; 328355
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 331
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 346
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 360
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 360
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 372

fr/paris/lutece/plugins/document/service/spaces/DocumentSpacesService.java

Rule Violation Ligne
GodClass Possible God Class (WMC=62, ATFD=58, TCC=1.471%) 71612
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'xslSource' 191
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 216
CyclomaticComplexity The method 'findSpacesByCodeType(StringBuffer, int, AdminUser, String)' has a cyclomatic complexity of 13. 242327
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 263
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 284290
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 385
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 386
NPathComplexity The method 'getSpacesBrowser(HttpServletRequest, AdminUser, Locale, boolean, boolean, boolean)' has an NPath complexity of 1152 436531
CyclomaticComplexity The method 'getSpacesBrowser(HttpServletRequest, AdminUser, Locale, boolean, boolean, boolean)' has a cyclomatic complexity of 13. 436531
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 441
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 441
ShortVariable Avoid variables with short names like i 446
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 504
ControlStatementBraces This statement should have braces 526
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 555
LinguisticNaming Linguistics Antipattern - The getter 'getSpaceParents' should not return void linguistically 568581
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 603

fr/paris/lutece/plugins/document/service/spaces/SpaceRemovalListenerService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4455

fr/paris/lutece/plugins/document/service/spaces/SpaceResourceIdService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 7982
MissingOverride The method 'register()' is missing an @Override annotation. 87121
ShortVariable Avoid variables with short names like rt 89
ShortVariable Avoid variables with short names like p 95
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 128131
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 139159

fr/paris/lutece/plugins/document/utils/ImageUtils.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like in 73

fr/paris/lutece/plugins/document/web/DocumentContentJspBean.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 101
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 101

fr/paris/lutece/plugins/document/web/DocumentDashboardComponent.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 114
ShortVariable Avoid variables with short names like t 121

fr/paris/lutece/plugins/document/web/DocumentJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341983
CyclomaticComplexity The class 'DocumentJspBean' has a total cyclomatic complexity of 204 (highest 40). 1241983
GodClass Possible God Class (WMC=204, ATFD=320, TCC=14.225%) 1241983
ExcessiveClassLength Avoid really long classes. 1241983
TooManyMethods This class has too many methods, consider refactoring it. 1251983
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 254
CallSuperInConstructor It is a good practice to call super() in a constructor 262265
ExcessiveMethodLength Avoid really long methods. 272397
NcssCount The method 'getManageDocuments(HttpServletRequest)' has a NCSS line count of 70. 272397
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 274
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 305
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 305
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 340342
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 344
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 372
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 421
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 421
UnusedFormalParameter Avoid unused method parameters such as 'request'. 463
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 466
UnusedFormalParameter Avoid unused method parameters such as 'request'. 480
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 482
ConfusingTernary Avoid if (x != y) ..; else ..; 503
ConfusingTernary Avoid if (x != y) ..; else ..; 516
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 540
ConfusingTernary Avoid if (x != y) ..; else ..; 630631
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 632
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 632
CyclomaticComplexity The method 'doActionSelectionDocument(HttpServletRequest)' has a cyclomatic complexity of 40. 10911285
NcssCount The method 'doActionSelectionDocument(HttpServletRequest)' has a NCSS line count of 83. 10911285
ExcessiveMethodLength Avoid really long methods. 10911285
UnusedLocalVariable Avoid unused local variables such as 'nbDocumentsAffected'. 1097
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 11731176
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 12121217
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 12641269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1409
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1409
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1442
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1442
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1471
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1480
NcssCount The method 'getMassArchivalDocument(HttpServletRequest)' has a NCSS line count of 80. 15241679
CyclomaticComplexity The method 'getMassArchivalDocument(HttpServletRequest)' has a cyclomatic complexity of 21. 15241679
NPathComplexity The method 'getMassArchivalDocument(HttpServletRequest)' has an NPath complexity of 2720 15241679
ExcessiveMethodLength Avoid really long methods. 15241679
AvoidDuplicateLiterals The String literal "to_archive" appears 4 times in this file; the first occurrence is on line 1,537 1537
AvoidDuplicateLiterals The String literal "jsp/admin/plugins/document/MassArchivalDocument.jsp" appears 4 times in this file; the first occurrence is on line 1,581 1581
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 1587
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 1588
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1638
AddEmptyString Do not add empty strings 1652
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1664
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1664
ConfusingTernary Avoid if (x != y) ..; else ..; 17091716
ConfusingTernary Avoid if (x != y) ..; else ..; 17531760
ConfusingTernary Avoid if (x != y) ..; else ..; 17881795
ConfusingTernary Avoid if (x != y) ..; else ..; 18241832
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1897
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1897
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 19161922
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 1949

fr/paris/lutece/plugins/document/web/DocumentLegacyServletRedirectFilter.java

Rule Violation Ligne
MissingOverride The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' is missing an @Override annotation. 6891
ConfusingTernary Avoid if (x != y) ..; else ..; 7380

fr/paris/lutece/plugins/document/web/DocumentMetaPageInclude.java

Rule Violation Ligne
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 74102
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 8697
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'sourceXsl' 113

fr/paris/lutece/plugins/document/web/DocumentResourceServlet.java

Rule Violation Ligne
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 154
ConfusingTernary Avoid if (x != y) ..; else ..; 202211
ConfusingTernary Avoid if (x != y) ..; else ..; 284303
PositionLiteralsFirstInComparisons Position literals first in String comparisons 315
PositionLiteralsFirstInComparisons Position literals first in String comparisons 315
PositionLiteralsFirstInComparisons Position literals first in String comparisons 316
PositionLiteralsFirstInComparisons Position literals first in String comparisons 316

fr/paris/lutece/plugins/document/web/DocumentServiceJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34439
MissingOverride The method 'getInsertServiceSelectorUI(HttpServletRequest)' is missing an @Override annotation. 159162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 259
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 380
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 381
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 382
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 383
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 383
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 385
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 433
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 433

fr/paris/lutece/plugins/document/web/DocumentTypeJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341014
GodClass Possible God Class (WMC=91, ATFD=176, TCC=24.923%) 881014
CyclomaticComplexity The class 'DocumentTypeJspBean' has a total cyclomatic complexity of 91 (highest 11). 881014
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 881014
TooManyMethods This class has too many methods, consider refactoring it. 891014
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 160
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 188
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 188
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 206
ConfusingTernary Avoid if (x != y) ..; else ..; 246253
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 263
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 263
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 281
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 283
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 284
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 285
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 287
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 288
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 328
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 328
LinguisticNaming Linguistics Antipattern - The getter 'getAttributeData' should not return void linguistically 456509
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 459
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 465
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 518
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 537
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 582
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 612613
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 615
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 615
AddEmptyString Do not add empty strings 641
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 739
CyclomaticComplexity The method 'getStyleSheets(MultipartHttpServletRequest)' has a cyclomatic complexity of 11. 817871
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 819
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 823
ConfusingTernary Avoid if (x != y) ..; else ..; 886893
LinguisticNaming Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' 916933
ShortVariable Avoid variables with short names like is 924
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 927

fr/paris/lutece/plugins/document/web/ResourceServletCache.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 5154
MissingOverride The method 'getName()' is missing an @Override annotation. 6063
DefaultPackage Use explicit scoping instead of the default package private level 89100
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the removeFromKeyPattern method if you want a default access modifier 89100

fr/paris/lutece/plugins/document/web/ResourceServletContentTypeCache.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 5362
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 57
MissingOverride The method 'getName()' is missing an @Override annotation. 6871

fr/paris/lutece/plugins/document/web/ResourceValueObject.java

Rule Violation Ligne
UncommentedEmptyConstructor Document empty constructor 5961
MethodReturnsInternalArray Returning '_content' may expose an internal array. 104
ArrayIsStoredDirectly The user-supplied array 'content' is stored directly. 111

fr/paris/lutece/plugins/document/web/category/CategoryJspBean.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 116118
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 116118
UncommentedEmptyConstructor Document empty constructor 116118
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 131
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 150
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 171
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 174
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 177
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 214
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 229
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 229
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 246
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 247
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 248
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 249
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 250

fr/paris/lutece/plugins/document/web/docsearch/AdvancedSearch.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 70253
CyclomaticComplexity The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 17. 100211
NPathComplexity The method 'getPage(HttpServletRequest, int, Plugin)' has an NPath complexity of 1409 100211
ExcessiveMethodLength Avoid really long methods. 100211
MissingOverride The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. 100211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 104
ConfusingTernary Avoid if (x != y) ..; else ..; 109199
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 145
ShortVariable Avoid variables with short names like i 148
ShortVariable Avoid variables with short names like c 156
ShortVariable Avoid variables with short names like it 157
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 177
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 191
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 220
ShortVariable Avoid variables with short names like f 220

fr/paris/lutece/plugins/document/web/docsearch/DocSearchJspBean.java

Rule Violation Ligne
NPathComplexity The method 'getSearch(HttpServletRequest)' has an NPath complexity of 408 105211
NcssCount The method 'getSearch(HttpServletRequest)' has a NCSS line count of 61. 105211
CyclomaticComplexity The method 'getSearch(HttpServletRequest)' has a cyclomatic complexity of 11. 105211
ExcessiveMethodLength Avoid really long methods. 105211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 112
ConfusingTernary Avoid if (x != y) ..; else ..; 125
ConfusingTernary Avoid if (x != y) ..; else ..; 129
ConfusingTernary Avoid if (x != y) ..; else ..; 137188
ConfusingTernary Avoid if (x != y) ..; else ..; 162171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 198199

fr/paris/lutece/plugins/document/web/history/DocumentHistoryJspBean.java

Rule Violation Ligne
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 95
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 95

fr/paris/lutece/plugins/document/web/portlet/DocumentListPortletJspBean.java

Rule Violation Ligne
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 105116
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 124137
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 145175
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 149
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 152
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 183230
LinguisticNaming Linguistics Antipattern - The setter 'setIdCategory' should not return any type except void linguistically 237255
ShortVariable Avoid variables with short names like i 244
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 277
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 277
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 295
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 312
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 312

fr/paris/lutece/plugins/document/web/portlet/DocumentPortletJspBean.java

Rule Violation Ligne
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 107118
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 126139
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 147177
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 154
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 185231
LinguisticNaming Linguistics Antipattern - The setter 'setIdCategory' should not return any type except void linguistically 238256
ShortVariable Avoid variables with short names like i 245
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 278
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 278
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 296
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 313
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 313

fr/paris/lutece/plugins/document/web/publishing/DocumentPublishingJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341171
CyclomaticComplexity The class 'DocumentPublishingJspBean' has a total cyclomatic complexity of 110 (highest 21). 931171
ExcessiveClassLength Avoid really long classes. 931171
CyclomaticComplexity The method 'getManageDocumentPublishing(HttpServletRequest)' has a cyclomatic complexity of 21. 181299
ExcessiveMethodLength Avoid really long methods. 181299
NPathComplexity The method 'getManageDocumentPublishing(HttpServletRequest)' has an NPath complexity of 4322 181299
NcssCount The method 'getManageDocumentPublishing(HttpServletRequest)' has a NCSS line count of 61. 181299
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 194
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 194
ConfusingTernary Avoid if (x != y) ..; else ..; 204205
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 221224
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 244
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 246262
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 255
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 327
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listFilteredPortlets' 340
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 369
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listFilteredPortlets' 381
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 395
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 406
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 406
CyclomaticComplexity The method 'doAssignedDocument(HttpServletRequest)' has a cyclomatic complexity of 11. 436496
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 445
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 463
ConfusingTernary Avoid if (x != y) ..; else ..; 513520
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 535
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 536
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 546
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 546
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 572579
MissingBreakInSwitch A switch statement does not contain a break 604621
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 604621
ConfusingTernary Avoid if (x != y) ..; else ..; 624632
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 665683
MissingBreakInSwitch A switch statement does not contain a break 665683
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 768
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 768
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 883
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 883
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 928
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 928
UnusedFormalParameter Avoid unused method parameters such as 'request'. 1039
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1049
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1049
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1065
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1065
UnusedFormalParameter Avoid unused method parameters such as 'request'. 1089
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1092
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1102
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1102
ConfusingTernary Avoid if (x != y) ..; else ..; 1109
LinguisticNaming Linguistics Antipattern - The setter 'setFillFilter' should not return any type except void linguistically 11321170
ConfusingTernary Avoid if (x != y) ..; else ..; 11371167

fr/paris/lutece/plugins/document/web/rules/DocumentRulesJspBean.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 142
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 153
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 153
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 179
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 179
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 233
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 233

fr/paris/lutece/plugins/document/web/spaces/DocumentSpaceJspBean.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 130
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 130
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 197
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 254
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 255
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 258
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 259
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 260
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 262
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 263
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 282285
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 304
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 315
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 328
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 385
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 386
ConfusingTernary Avoid if (x != y) ..; else ..; 389396
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 403
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 403
CyclomaticComplexity The method 'doMoveSpace(HttpServletRequest)' has a cyclomatic complexity of 10. 421471

Priority 4

fr/paris/lutece/plugins/document/business/DocumentFilter.java

Rule Violation Ligne
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 159
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 194
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 204207

fr/paris/lutece/plugins/document/business/portlet/DocumentListPortlet.java

Rule Violation Ligne
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 175

fr/paris/lutece/plugins/document/business/portlet/DocumentPortlet.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.util.Collection' 41
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 176

fr/paris/lutece/plugins/document/business/portlet/PortletFilter.java

Rule Violation Ligne
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 67
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 85

fr/paris/lutece/plugins/document/business/rules/Rule.java

Rule Violation Ligne
ShortClassName Avoid short class names like Rule 49164

fr/paris/lutece/plugins/document/service/DocumentService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.attributes.MapProviderManager' 42
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 241
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 242
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 260

fr/paris/lutece/plugins/document/service/attributes/DefaultManager.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.attributes.IMapProvider' 41

fr/paris/lutece/plugins/document/service/category/CategoryService.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 291294

fr/paris/lutece/plugins/document/service/docsearch/DocSearchService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'org.apache.lucene.util.Version' 73
UnusedImports Avoid unused imports such as 'java.io.File' 75
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 201
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 209
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 242
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 246
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 250

Fichiers

fr/paris/lutece/plugins/document/business/Document.java

Rule Violation Priority Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34873
TooManyFields Too many fields 3 62873
GodClass Possible God Class (WMC=73, ATFD=8, TCC=2.191%) 3 62873
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_QUESTION_MARK'. 3 80
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_EQUALS'. 3 81
ConfusingTernary Avoid if (x != y) ..; else ..; 3 200
ConfusingTernary Avoid if (x != y) ..; else ..; 3 322
ConfusingTernary Avoid if (x != y) ..; else ..; 3 667674
ShortVariable Avoid variables with short names like gc 3 763
LogicInversion Use opposite operator instead of the logic complement operator. 3 803

fr/paris/lutece/plugins/document/business/DocumentDAO.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=96, ATFD=317, TCC=0.430%) 3 531253
ExcessiveClassLength Avoid really long classes. 3 531253
CyclomaticComplexity The class 'DocumentDAO' has a total cyclomatic complexity of 96 (highest 33). 3 531253
TooManyMethods This class has too many methods, consider refactoring it. 3 541253
AvoidDuplicateLiterals The String literal " a.date_modification, a.xml_working_content, a.xml_validated_content, a.id_space , b.document_space_name , " appears 4 times in this file; the first occurrence is on line 58 3 58
AvoidDuplicateLiterals The String literal " INNER JOIN document_type d ON a.code_document_type = d.code_document_type " appears 5 times in this file; the first occurrence is on line 79 3 79
MissingOverride The method 'newPrimaryKey()' is missing an @Override annotation. 3 167184
MissingOverride The method 'insert(Document)' is missing an @Override annotation. 3 191218
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 191218
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 273276
MissingOverride The method 'loadWithoutBinaries(int)' is missing an @Override annotation. 3 284287
MissingOverride The method 'loadFromSpaceId(int)' is missing an @Override annotation. 3 363392
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 369
MissingOverride The method 'loadAttributes(Document)' is missing an @Override annotation. 3 398441
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 400
MissingOverride The method 'loadAttributesWithoutBinaries(Document, boolean)' is missing an @Override annotation. 3 449492
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 451
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 499513
MissingOverride The method 'validateAttributes(int)' is missing an @Override annotation. 3 547557
MissingOverride The method 'store(Document, boolean)' is missing an @Override annotation. 3 578612
MissingOverride The method 'selectPrimaryKeysByFilter(DocumentFilter)' is missing an @Override annotation. 3 620634
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 622
MissingOverride The method 'selectByFilter(DocumentFilter)' is missing an @Override annotation. 3 642698
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 644
ExcessiveMethodLength Avoid really long methods. 3 706853
NPathComplexity The method 'getDaoFromFilter(String, DocumentFilter)' has an NPath complexity of 6386688 3 706853
NcssCount The method 'getDaoFromFilter(String, DocumentFilter)' has a NCSS line count of 73. 3 706853
CyclomaticComplexity The method 'getDaoFromFilter(String, DocumentFilter)' has a cyclomatic complexity of 33. 3 706853
ConfusingTernary Avoid if (x != y) ..; else ..; 3 714
ConfusingTernary Avoid if (x != y) ..; else ..; 3 720
ShortVariable Avoid variables with short names like i 3 728
ConfusingTernary Avoid if (x != y) ..; else ..; 3 750
ConfusingTernary Avoid if (x != y) ..; else ..; 3 769
ConfusingTernary Avoid if (x != y) ..; else ..; 3 774
ConfusingTernary Avoid if (x != y) ..; else ..; 3 780
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 781
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 782
ConfusingTernary Avoid if (x != y) ..; else ..; 3 786
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 787
ConfusingTernary Avoid if (x != y) ..; else ..; 3 791
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 792
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 799
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 802
GuardLogStatement Logger calls should be surrounded by log level guards. 2 803
GuardLogStatement Logger calls should be surrounded by log level guards. 2 811
AvoidDuplicateLiterals The String literal "Param" appears 5 times in this file; the first occurrence is on line 811 3 811
GuardLogStatement Logger calls should be surrounded by log level guards. 2 818
GuardLogStatement Logger calls should be surrounded by log level guards. 2 825
GuardLogStatement Logger calls should be surrounded by log level guards. 2 836
GuardLogStatement Logger calls should be surrounded by log level guards. 2 847
MissingOverride The method 'selectByRelatedCategories(Document)' is missing an @Override annotation. 3 861911
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 863
MissingOverride The method 'loadResource(int)' is missing an @Override annotation. 3 920939
MissingOverride The method 'loadSpecificResource(int, int, boolean)' is missing an @Override annotation. 3 950971
MissingOverride The method 'selectAllPrimaryKeys()' is missing an @Override annotation. 3 977993
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 979
MissingOverride The method 'selectAll()' is missing an @Override annotation. 3 10001042
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1002
MissingOverride The method 'getPageTemplateDocumentPath(int)' is missing an @Override annotation. 3 10501066
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1076
MissingOverride The method 'loadLastModifiedAttributes(int)' is missing an @Override annotation. 3 11421160
MissingOverride The method 'loadLastModifiedDocumentFromUser(String)' is missing an @Override annotation. 3 11681207
MissingOverride The method 'loadLastPublishedDocument()' is missing an @Override annotation. 3 12141252

fr/paris/lutece/plugins/document/business/DocumentFilter.java

Rule Violation Priority Ligne
MethodReturnsInternalArray Returning '_arrayCategoriesId' may expose an internal array. 3 153
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 159
ArrayIsStoredDirectly The user-supplied array 'arrayCategoriesId' is stored directly. 3 159
MethodReturnsInternalArray Returning '_arrayId' may expose an internal array. 3 188
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 194
ArrayIsStoredDirectly The user-supplied array 'arrayId' is stored directly. 3 194
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 204207

fr/paris/lutece/plugins/document/business/DocumentHome.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 51327

fr/paris/lutece/plugins/document/business/DocumentPageTemplateDAO.java

Rule Violation Priority Ligne
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the newPrimaryKey method if you want a default access modifier 3 6381
DefaultPackage Use explicit scoping instead of the default package private level 3 6381
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 87100
MissingOverride The method 'insert(DocumentPageTemplate)' is missing an @Override annotation. 3 87100
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 108128
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 134140
MissingOverride The method 'store(DocumentPageTemplate)' is missing an @Override annotation. 3 146158
MissingOverride The method 'selectPageTemplatesList()' is missing an @Override annotation. 3 164184
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 166

fr/paris/lutece/plugins/document/business/DocumentResource.java

Rule Violation Priority Ligne
MethodReturnsInternalArray Returning '_strContent' may expose an internal array. 3 54
ArrayIsStoredDirectly The user-supplied array 'strContent' is stored directly. 3 62

fr/paris/lutece/plugins/document/business/DocumentType.java

Rule Violation Priority Ligne
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85
ImmutableField Private field '_listAttributes' could be made final; it is only initialized in the declaration or constructor. 3 85
MethodReturnsInternalArray Returning '_baAdminXsl' may expose an internal array. 3 177
ArrayIsStoredDirectly The user-supplied array 'baXsl' is stored directly. 3 185
MethodReturnsInternalArray Returning '_baContentServiceXsl' may expose an internal array. 3 197
ArrayIsStoredDirectly The user-supplied array 'baXsl' is stored directly. 3 205
ConfusingTernary Avoid if (x != y) ..; else ..; 3 255
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 3 272275
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 3 281284
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 293
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 308
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 308
ConfusingTernary Avoid if (x != y) ..; else ..; 3 326334

fr/paris/lutece/plugins/document/business/DocumentTypeDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'insert(DocumentType)' is missing an @Override annotation. 3 6577
MissingOverride The method 'load(String)' is missing an @Override annotation. 3 84109
MissingOverride The method 'delete(String)' is missing an @Override annotation. 3 115122
MissingOverride The method 'store(DocumentType)' is missing an @Override annotation. 3 128141
MissingOverride The method 'selectDocumentTypeList()' is missing an @Override annotation. 3 147169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 149
MissingOverride The method 'getDocumentTypeList()' is missing an @Override annotation. 3 175192
MissingOverride The method 'checkDocuments(String)' is missing an @Override annotation. 3 199209
MissingOverride The method 'reorderAttributes(int, int, int, int)' is missing an @Override annotation. 3 218228
MissingOverride The method 'setAdminStyleSheet(byte, String)' is missing an @Override annotation. 3 235243
MissingOverride The method 'setContentStyleSheet(byte, String)' is missing an @Override annotation. 3 250258

fr/paris/lutece/plugins/document/business/IDocumentDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 44190

fr/paris/lutece/plugins/document/business/IndexerActionDAO.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 6582
MissingOverride The method 'newPrimaryKey()' is missing an @Override annotation. 3 6582
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 8799
CommentRequired Public method and constructor comments are required 3 8799
MissingOverride The method 'insert(IndexerAction)' is missing an @Override annotation. 3 8799
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 104123
CommentRequired Public method and constructor comments are required 3 104123
CommentRequired Public method and constructor comments are required 3 128134
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 128134
CommentRequired Public method and constructor comments are required 3 139144
MissingOverride The method 'deleteAll()' is missing an @Override annotation. 3 139144
CommentRequired Public method and constructor comments are required 3 149160
MissingOverride The method 'store(IndexerAction)' is missing an @Override annotation. 3 149160
CommentRequired Public method and constructor comments are required 3 165203
MissingOverride The method 'selectList(IndexerActionFilter)' is missing an @Override annotation. 3 165203
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 167
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 169
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 221
AssignmentInOperand Avoid assignments in operands 3 221

fr/paris/lutece/plugins/document/business/attributes/AttributeType.java

Rule Violation Priority Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 3 8992

fr/paris/lutece/plugins/document/business/attributes/AttributeTypeDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'insert(AttributeType)' is missing an @Override annotation. 3 6474
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 82102
MissingOverride The method 'delete(AttributeType)' is missing an @Override annotation. 3 108115
MissingOverride The method 'store(AttributeType)' is missing an @Override annotation. 3 121132
MissingOverride The method 'selectDocumentAttributeTypeList()' is missing an @Override annotation. 3 138158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 140
MissingOverride The method 'selectAttributeTypeList(Locale)' is missing an @Override annotation. 3 165183
MissingOverride The method 'getAttributeManagersList()' is missing an @Override annotation. 3 192206
MissingOverride The method 'selectAttributeTypeParameterList(String)' is missing an @Override annotation. 3 216247
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 218
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 219
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 233

fr/paris/lutece/plugins/document/business/attributes/AttributeTypeParameter.java

Rule Violation Priority Ligne
ImmutableField Private field '_listDefaultValue' could be made final; it is only initialized in the declaration or constructor. 3 53
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 53
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 54
ImmutableField Private field '_listValues' could be made final; it is only initialized in the declaration or constructor. 3 54
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 3 8285
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 153
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 186

fr/paris/lutece/plugins/document/business/attributes/DocumentAttribute.java

Rule Violation Priority Ligne
ArrayIsStoredDirectly The user-supplied array 'bytes' is stored directly. 3 298
MethodReturnsInternalArray Returning '_bytes' may expose an internal array. 3 309

fr/paris/lutece/plugins/document/business/attributes/DocumentAttributeDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 48431
MissingOverride The method 'insert(DocumentAttribute)' is missing an @Override annotation. 3 109127
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 109127
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 134158
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 164173
MissingOverride The method 'store(DocumentAttribute)' is missing an @Override annotation. 3 207227
MissingOverride The method 'selectAttributesByDocumentType(DocumentType)' is missing an @Override annotation. 3 233259
MissingOverride The method 'selectAllAttributesOfDocumentType(String)' is missing an @Override annotation. 3 266291
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 268
ShortVariable Avoid variables with short names like i 3 300
MissingOverride The method 'selectAttributeParametersValues(int)' is missing an @Override annotation. 3 321339
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 323
MissingOverride The method 'getAttributeParameterValues(int, String)' is missing an @Override annotation. 3 347363
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 349
MissingOverride The method 'insertRegularExpression(int, int)' is missing an @Override annotation. 3 371378
MissingOverride The method 'deleteRegularExpression(int, int)' is missing an @Override annotation. 3 386393
MissingOverride The method 'selectListRegularExpressionKeyByIdAttribute(int)' is missing an @Override annotation. 3 414430
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 416

fr/paris/lutece/plugins/document/business/attributes/MapProviderManager.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'MapProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 5498

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublication.java

Rule Violation Priority Ligne
NonThreadSafeSingleton Singleton is not thread safe 3 5559

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublicationDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'delete(int, int)' is missing an @Override annotation. 3 6673
MissingOverride The method 'deleteAllSpaces(int)' is missing an @Override annotation. 3 8086
MissingOverride The method 'insert(DocumentAutoPublication)' is missing an @Override annotation. 3 94102
MissingOverride The method 'load(int, int)' is missing an @Override annotation. 3 111130
MissingOverride The method 'load()' is missing an @Override annotation. 3 137155
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 142
MissingOverride The method 'selectByPortletId(int)' is missing an @Override annotation. 3 163182
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 169
MissingOverride The method 'selectBySpaceId(int)' is missing an @Override annotation. 3 190209
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 196
MissingOverride The method 'store(DocumentAutoPublication)' is missing an @Override annotation. 3 216226

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublicationDocumentSpaceRemovalListener.java

Rule Violation Priority Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 3 5676
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 3 8488

fr/paris/lutece/plugins/document/business/autopublication/DocumentAutoPublicationHome.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 47179
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 156159
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 172175

fr/paris/lutece/plugins/document/business/category/Category.java

Rule Violation Priority Ligne
MethodReturnsInternalArray Returning '_byteIconContent' may expose an internal array. 3 58
ArrayIsStoredDirectly The user-supplied array 'byteIconContent' is stored directly. 3 64
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 3 137140

fr/paris/lutece/plugins/document/business/category/CategoryDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 47339
MissingOverride The method 'selectAll()' is missing an @Override annotation. 3 7196
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 74
MissingOverride The method 'insert(Category)' is missing an @Override annotation. 3 102116
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 143167
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 173180
MissingOverride The method 'store(Category)' is missing an @Override annotation. 3 186199
MissingOverride The method 'selectByName(String)' is missing an @Override annotation. 3 206232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 209
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 256
ShortVariable Avoid variables with short names like i 3 270
MissingOverride The method 'selectCountIdDocuments(int)' is missing an @Override annotation. 3 298313
MissingOverride The method 'loadImageResource(int)' is missing an @Override annotation. 3 320338

fr/paris/lutece/plugins/document/business/category/CategoryHome.java

Rule Violation Priority Ligne
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'categoryList' 3 66

fr/paris/lutece/plugins/document/business/history/HistoryEvent.java

Rule Violation Priority Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 3 185188

fr/paris/lutece/plugins/document/business/history/HistoryEventDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'insert(HistoryEvent)' is missing an @Override annotation. 3 5971
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 7885
MissingOverride The method 'selectEventListByDocument(int)' is missing an @Override annotation. 3 93116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 95
MissingOverride The method 'selectEventListByUser(String)' is missing an @Override annotation. 3 124147
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 126

fr/paris/lutece/plugins/document/business/portlet/DocumentListPortlet.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6568
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 3 7694
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'str' 3 93
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 3 102105
MissingOverride The method 'remove()' is missing an @Override annotation. 3 118121
MethodReturnsInternalArray Returning '_nArrayIdCategory' may expose an internal array. 3 169
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 175
ArrayIsStoredDirectly The user-supplied array 'arrayIdCategory' is stored directly. 3 175

fr/paris/lutece/plugins/document/business/portlet/DocumentListPortletDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 8092
ShortVariable Avoid variables with short names like p 3 82
ShortVariable Avoid variables with short names like p 3 100
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 124138
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 170189
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 202
ShortVariable Avoid variables with short names like i 3 212
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 227241
ShortVariable Avoid variables with short names like p 3 229
MissingOverride The method 'selectByDocumentIdAndDocumentType(int, String, PortletOrder, PortletFilter)' is missing an @Override annotation. 3 250306
CyclomaticComplexity The method 'selectByDocumentIdAndDocumentType(int, String, PortletOrder, PortletFilter)' has a cyclomatic complexity of 10. 3 250306
ConfusingTernary Avoid if (x != y) ..; else ..; 3 256
MissingOverride The method 'checkIsAliasPortlet(int)' is missing an @Override annotation. 3 314330

fr/paris/lutece/plugins/document/business/portlet/DocumentListPortletHome.java

Rule Violation Priority Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 57
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 57
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6268
NonThreadSafeSingleton Singleton is not thread safe 3 7780
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 3 9096
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 3 95
MissingOverride The method 'getDAO()' is missing an @Override annotation. 3 103106

fr/paris/lutece/plugins/document/business/portlet/DocumentPortlet.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'java.util.Collection' 4 41
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6871
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 3 7996
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'str' 3 95
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 3 104107
MissingOverride The method 'remove()' is missing an @Override annotation. 3 120123
MethodReturnsInternalArray Returning '_nArrayIdCategory' may expose an internal array. 3 170
ArrayIsStoredDirectly The user-supplied array 'arrayIdCategory' is stored directly. 3 176
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 176

fr/paris/lutece/plugins/document/business/portlet/DocumentPortletDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 46369
TooManyMethods This class has too many methods, consider refactoring it. 3 47369
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 8092
ShortVariable Avoid variables with short names like p 3 82
ShortVariable Avoid variables with short names like p 3 102
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 127141
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 179198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 212
ShortVariable Avoid variables with short names like i 3 222
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 238252
ShortVariable Avoid variables with short names like p 3 240
CyclomaticComplexity The method 'selectByDocumentOdAndDocumentType(int, String, PortletOrder, PortletFilter)' has a cyclomatic complexity of 10. 3 266321
MissingOverride The method 'selectByDocumentOdAndDocumentType(int, String, PortletOrder, PortletFilter)' is missing an @Override annotation. 3 266321
ConfusingTernary Avoid if (x != y) ..; else ..; 3 272
MissingOverride The method 'checkIsAliasPortlet(int)' is missing an @Override annotation. 3 330346
MissingOverride The method 'selectPortletsByDocumentId(int)' is missing an @Override annotation. 3 352368
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 358

fr/paris/lutece/plugins/document/business/portlet/DocumentPortletHome.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 46140
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 54
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 54
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5965
NonThreadSafeSingleton Singleton is not thread safe 3 7477
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 3 8793
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 3 92
MissingOverride The method 'getDAO()' is missing an @Override annotation. 3 100103

fr/paris/lutece/plugins/document/business/portlet/IDocumentListPortletDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 64
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 72
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 81
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 100

fr/paris/lutece/plugins/document/business/portlet/PortletFilter.java

Rule Violation Priority Ligne
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 67
ArrayIsStoredDirectly The user-supplied array 'strPageTitle' is stored directly. 3 67
MethodReturnsInternalArray Returning '_tabPageName' may expose an internal array. 3 78
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 85
ArrayIsStoredDirectly The user-supplied array 'strPortletTitle' is stored directly. 3 85
MethodReturnsInternalArray Returning '_tabPortletName' may expose an internal array. 3 96
CyclomaticComplexity The method 'getSQLFilter()' has a cyclomatic complexity of 13. 3 159206

fr/paris/lutece/plugins/document/business/publication/DocumentPublicationDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 49372
MissingOverride The method 'insert(DocumentPublication)' is missing an @Override annotation. 3 6981
MissingOverride The method 'store(DocumentPublication)' is missing an @Override annotation. 3 8899
MissingOverride The method 'delete(int, int)' is missing an @Override annotation. 3 107114
MissingOverride The method 'deleteFromPortletId(int)' is missing an @Override annotation. 3 121127
MissingOverride The method 'deleteFromDocumentId(int)' is missing an @Override annotation. 3 134140
MissingOverride The method 'select(int, int)' is missing an @Override annotation. 3 151172
MissingOverride The method 'selectByPortletId(int)' is missing an @Override annotation. 3 179200
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 181
MissingOverride The method 'selectByDocumentId(int)' is missing an @Override annotation. 3 207228
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 209
MissingOverride The method 'selectByPortletIdAndStatus(int, int)' is missing an @Override annotation. 3 236258
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 238
MissingOverride The method 'selectByDocumentIdAndStatus(int, int)' is missing an @Override annotation. 3 266288
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 268
MissingOverride The method 'selectSinceDatePublishingAndStatus(Date, int)' is missing an @Override annotation. 3 296318
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 298
MissingOverride The method 'selectMaxDocumentOrder(int)' is missing an @Override annotation. 3 325340
MissingOverride The method 'selectDocumentIdByOrder(int, int)' is missing an @Override annotation. 3 349371
ConfusingTernary Avoid if (x != y) ..; else ..; 3 358366

fr/paris/lutece/plugins/document/business/publication/DocumentPublicationHome.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 47182
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 47182

fr/paris/lutece/plugins/document/business/publication/IDocumentPublicationDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 46144

fr/paris/lutece/plugins/document/business/rules/AbstractRule.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 55
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 55
ImmutableField Private field '_mapAttributes' could be made final; it is only initialized in the declaration or constructor. 3 55
MissingOverride The method 'getId()' is missing an @Override annotation. 3 6467
MissingOverride The method 'setId(int)' is missing an @Override annotation. 3 7477
MissingOverride The method 'getRuleTypeId()' is missing an @Override annotation. 3 8487
MissingOverride The method 'setRuleTypeId(String)' is missing an @Override annotation. 3 9497
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 3 104107
MissingOverride The method 'setAttribute(String, String)' is missing an @Override annotation. 3 123126
MissingOverride The method 'getAttribute(String)' is missing an @Override annotation. 3 133136
MissingOverride The method 'readAttributes(HttpServletRequest)' is missing an @Override annotation. 3 142158
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 149157
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 164
MissingOverride The method 'getUser()' is missing an @Override annotation. 3 170173
MissingOverride The method 'setUser(AdminUser)' is missing an @Override annotation. 3 180183

fr/paris/lutece/plugins/document/business/rules/Rule.java

Rule Violation Priority Ligne
ShortClassName Avoid short class names like Rule 4 49164

fr/paris/lutece/plugins/document/business/rules/RuleDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'insert(Rule)' is missing an @Override annotation. 3 8799
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 8799
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 110120
MissingOverride The method 'load(int, IRuleTypesSet)' is missing an @Override annotation. 3 130149
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 173182
MissingOverride The method 'store(Rule)' is missing an @Override annotation. 3 201206
MissingOverride The method 'selectRuleList(IRuleTypesSet)' is missing an @Override annotation. 3 213229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 215
MissingOverride The method 'selectRuleListByRuleTypeKey(String, IRuleTypesSet)' is missing an @Override annotation. 3 237256
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 239

fr/paris/lutece/plugins/document/business/rules/RuleTypesSet.java

Rule Violation Priority Ligne
MissingOverride The method 'setRuleTypesMap(Map)' is missing an @Override annotation. 3 5659
MissingOverride The method 'newInstance(String)' is missing an @Override annotation. 3 6685
IdenticalCatchBranches 'catch' branch identical to 'InstantiationException' branch 3 7982
MissingOverride The method 'getRuleTypeKey(Rule)' is missing an @Override annotation. 3 91117
IdenticalCatchBranches 'catch' branch identical to 'InstantiationException' branch 3 110113
MissingOverride The method 'getRuleTypesList(Locale)' is missing an @Override annotation. 3 123134
MissingOverride The method 'getRuleTypes()' is missing an @Override annotation. 3 140143

fr/paris/lutece/plugins/document/business/spaces/DocumentSpace.java

Rule Violation Priority Ligne
ImmutableField Private field '_listDocumentType' could be made final; it is only initialized in the declaration or constructor. 3 57
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 57
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 57
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 3 264267
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 3 273276
AddEmptyString Do not add empty strings 3 275
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 3 282285

fr/paris/lutece/plugins/document/business/spaces/DocumentSpaceDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 49458
MissingOverride The method 'insert(DocumentSpace)' is missing an @Override annotation. 3 108125
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 108125
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 135143
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 152182
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 207215
MissingOverride The method 'store(DocumentSpace)' is missing an @Override annotation. 3 234252
MissingOverride The method 'selectChilds(int, String)' is missing an @Override annotation. 3 261298
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 263
ConfusingTernary Avoid if (x != y) ..; else ..; 3 266276
MissingOverride The method 'selectSpacesAllowingDocumentCreationByDocumentType(String, int)' is missing an @Override annotation. 3 306336
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 309
MissingOverride The method 'getDocumentSpaceList()' is missing an @Override annotation. 3 342360
MissingOverride The method 'getViewTypeList(Locale)' is missing an @Override annotation. 3 367383
MissingOverride The method 'getIconsList()' is missing an @Override annotation. 3 389405
MissingOverride The method 'selectAll()' is missing an @Override annotation. 3 411435
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 413
MissingOverride The method 'getAllowedDocumentTypes(int)' is missing an @Override annotation. 3 442457

fr/paris/lutece/plugins/document/business/spaces/SpaceAction.java

Rule Violation Priority Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 3 6063
MissingOverride The method 'getPermission()' is missing an @Override annotation. 3 169172

fr/paris/lutece/plugins/document/business/spaces/SpaceActionDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'selectActions()' is missing an @Override annotation. 3 5475
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 56

fr/paris/lutece/plugins/document/business/workflow/DocumentAction.java

Rule Violation Priority Ligne
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 3 107110
MissingOverride The method 'getPermission()' is missing an @Override annotation. 3 216219

fr/paris/lutece/plugins/document/business/workflow/DocumentActionDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 5989
MissingOverride The method 'selectActions(Document)' is missing an @Override annotation. 3 97120
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 99

fr/paris/lutece/plugins/document/business/workflow/DocumentStateDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 5776
MissingOverride The method 'selectDocumentStatesList(Locale)' is missing an @Override annotation. 3 83101

fr/paris/lutece/plugins/document/business/workflow/DocumentStateHome.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4669

fr/paris/lutece/plugins/document/modules/metadatadublincore/DublinCoreMetadataHandler.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 81
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 81
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 99
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 99

fr/paris/lutece/plugins/document/modules/metadatadublincore/business/DublinCoreMetadata.java

Rule Violation Priority Ligne
NPathComplexity The method 'getXml()' has an NPath complexity of 14348907 3 387470
CyclomaticComplexity The method 'getXml()' has a cyclomatic complexity of 31. 3 387470
ShortVariable Avoid variables with short names like sr 3 489
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 3 497500
IdenticalCatchBranches 'catch' branch identical to 'FileNotFoundException' branch 3 501504

fr/paris/lutece/plugins/document/modules/rulemovespace/business/MoveSpaceRule.java

Rule Violation Priority Ligne
MissingOverride The method 'init()' is missing an @Override annotation. 3 8795
MissingOverride The method 'getNameKey()' is missing an @Override annotation. 3 101104
MissingOverride The method 'apply(DocumentEvent)' is missing an @Override annotation. 3 111133
CollapsibleIfStatements These nested if statements could be combined 3 121125
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 128
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 131
MissingOverride The method 'getCreateForm(AdminUser, Locale)' is missing an @Override annotation. 3 141196
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 143
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 143
MissingOverride The method 'isAuthorized(AdminUser)' is missing an @Override annotation. 3 203219
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 206
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 213216
MissingOverride The method 'validateRule()' is missing an @Override annotation. 3 226250
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 229
MissingOverride The method 'getAttributesList()' is missing an @Override annotation. 3 256259
MethodReturnsInternalArray Returning '_attributes' may expose an internal array. 3 258
MissingOverride The method 'getRule()' is missing an @Override annotation. 3 265285
CyclomaticComplexity The method 'equals(Object)' has a cyclomatic complexity of 12. 3 315346
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 315

fr/paris/lutece/plugins/document/modules/rulemovespace/business/MoveSpaceSpaceRemovalListener.java

Rule Violation Priority Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 3 5888
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 3 96100
ShortVariable Avoid variables with short names like id 3 96

fr/paris/lutece/plugins/document/modules/rulenotifyusers/business/NotifyUsersMailingListRemovalListener.java

Rule Violation Priority Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 3 5887
ShortVariable Avoid variables with short names like id 3 95
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 3 9599

fr/paris/lutece/plugins/document/modules/rulenotifyusers/business/NotifyUsersRule.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34474
MissingOverride The method 'init()' is missing an @Override annotation. 3 127141
MissingOverride The method 'getNameKey()' is missing an @Override annotation. 3 147150
MissingOverride The method 'apply(DocumentEvent)' is missing an @Override annotation. 3 157203
CollapsibleIfStatements These nested if statements could be combined 3 169196
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 176
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 176
ShortVariable Avoid variables with short names like t 3 185
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 199
MissingOverride The method 'getCreateForm(AdminUser, Locale)' is missing an @Override annotation. 3 211263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 213
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 213
MissingOverride The method 'validateRule()' is missing an @Override annotation. 3 270286
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 272
MissingOverride The method 'isAuthorized(AdminUser)' is missing an @Override annotation. 3 293303
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 297300
MissingOverride The method 'getAttributesList()' is missing an @Override annotation. 3 309312
MethodReturnsInternalArray Returning '_attributes' may expose an internal array. 3 311
MissingOverride The method 'getRule()' is missing an @Override annotation. 3 318350
CyclomaticComplexity The method 'equals(Object)' has a cyclomatic complexity of 15. 3 439473
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 439

fr/paris/lutece/plugins/document/modules/rulenotifyusers/business/NotifyUsersSpaceRemovalListener.java

Rule Violation Priority Ligne
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 3 5886
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 3 9498
ShortVariable Avoid variables with short names like id 3 94

fr/paris/lutece/plugins/document/service/AttributeService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 48115
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 51
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 51
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6271
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 9598
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 99102

fr/paris/lutece/plugins/document/service/DocumentContentService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34788
GodClass Possible God Class (WMC=71, ATFD=89, TCC=12.281%) 3 102788
TooManyMethods This class has too many methods, consider refactoring it. 3 103788
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 148
MissingOverride The method 'getPage(HttpServletRequest, int)' is missing an @Override annotation. 3 170229
GuardLogStatement Logger calls should be surrounded by log level guards. 2 202203
GuardLogStatement Logger calls should be surrounded by log level guards. 2 219
GuardLogStatement Logger calls should be surrounded by log level guards. 2 225
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 240
AvoidReassigningParameters Avoid reassigning parameters such as 'strPortletId' 2 264
CyclomaticComplexity The method 'buildPage(HttpServletRequest, String, String, String, int)' has a cyclomatic complexity of 18. 3 264412
NPathComplexity The method 'buildPage(HttpServletRequest, String, String, String, int)' has an NPath complexity of 3900 3 264412
NcssCount The method 'buildPage(HttpServletRequest, String, String, String, int)' has a NCSS line count of 73. 3 264412
ExcessiveMethodLength Avoid really long methods. 3 264412
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 270
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 293
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 338
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 363
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 363
MissingOverride The method 'isInvoked(HttpServletRequest)' is missing an @Override annotation. 3 421433
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 426430
MissingOverride The method 'getName()' is missing an @Override annotation. 3 440443
ConfusingTernary Avoid if (x != y) ..; else ..; 3 452461
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPageTemplateDocument' 3 456
CyclomaticComplexity The method 'getPortlet(HttpServletRequest, String, int)' has a cyclomatic complexity of 12. 3 476599
ExcessiveMethodLength Avoid really long methods. 3 476599
NPathComplexity The method 'getPortlet(HttpServletRequest, String, int)' has an NPath complexity of 273 3 476599
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 483
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 499
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 510
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 510
ConfusingTernary Avoid if (x != y) ..; else ..; 3 522530
ConfusingTernary Avoid if (x != y) ..; else ..; 3 541542
CyclomaticComplexity The method 'getRelatedDocumentsPortlet(HttpServletRequest, Document, int, int)' has a cyclomatic complexity of 10. 3 611656
UnusedFormalParameter Avoid unused method parameters such as 'nPortletId'. 3 611
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 616
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 619
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 661663
UncommentedEmptyMethodBody Document empty method body 3 662663
MissingOverride The method 'notifyElementEvicted(Ehcache, Element)' is missing an @Override annotation. 3 669672
MissingOverride The method 'notifyElementExpired(Ehcache, Element)' is missing an @Override annotation. 3 678681
MissingOverride The method 'notifyElementPut(Ehcache, Element)' is missing an @Override annotation. 3 687690
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 688
UncommentedEmptyMethodBody Document empty method body 3 689690
MissingOverride The method 'notifyElementRemoved(Ehcache, Element)' is missing an @Override annotation. 3 696700
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 697
MissingOverride The method 'notifyElementUpdated(Ehcache, Element)' is missing an @Override annotation. 3 706709
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 707
UncommentedEmptyMethodBody Document empty method body 3 708709
MissingOverride The method 'notifyRemoveAll(Ehcache)' is missing an @Override annotation. 3 714717
ProperCloneImplementation Object clone() should be implemented with super.clone() 2 765
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 3 765768

fr/paris/lutece/plugins/document/service/DocumentEvent.java

Rule Violation Priority Ligne
ImmutableField Private field '_document' could be made final; it is only initialized in the declaration or constructor. 3 52
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 3 53
ImmutableField Private field '_nType' could be made final; it is only initialized in the declaration or constructor. 3 54
ImmutableField Private field '_nSpaceId' could be made final; it is only initialized in the declaration or constructor. 3 55
ImmutableField Private field '_nStateId' could be made final; it is only initialized in the declaration or constructor. 3 56

fr/paris/lutece/plugins/document/service/DocumentEventListernersManager.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the notifyListeners method if you want a default access modifier 3 7278
DefaultPackage Use explicit scoping instead of the default package private level 3 7278

fr/paris/lutece/plugins/document/service/DocumentException.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5558

fr/paris/lutece/plugins/document/service/DocumentMassActionResourceService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6164
MissingOverride The method 'register()' is missing an @Override annotation. 3 6983
ShortVariable Avoid variables with short names like rt 3 71
ShortVariable Avoid variables with short names like p 3 77
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 3 9196

fr/paris/lutece/plugins/document/service/DocumentPlugin.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 5158
MissingOverride The method 'init()' is missing an @Override annotation. 3 5158

fr/paris/lutece/plugins/document/service/DocumentService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34814
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.attributes.MapProviderManager' 4 42
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 94814
GodClass Possible God Class (WMC=91, ATFD=185, TCC=0.585%) 3 94814
CyclomaticComplexity The class 'DocumentService' has a total cyclomatic complexity of 91 (highest 27). 3 94814
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 132
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the buildXmlContent method if you want a default access modifier 3 156190
DefaultPackage Use explicit scoping instead of the default package private level 3 156190
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 4 241
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 4 242
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 4 260
LinguisticNaming Linguistics Antipattern - The getter 'getActions' should not return void linguistically 3 381397
LinguisticNaming Linguistics Antipattern - The getter 'getPublishedStatus' should not return void linguistically 3 403414
ConfusingTernary Avoid if (x != y) ..; else ..; 3 479490
SimplifiedTernary Ternary operators that can be simplified with || or && 3 531532
ExcessiveMethodLength Avoid really long methods. 3 547673
NcssCount The method 'getDocumentData(MultipartHttpServletRequest, Document, Locale)' has a NCSS line count of 65. 3 547673
CyclomaticComplexity The method 'getDocumentData(MultipartHttpServletRequest, Document, Locale)' has a cyclomatic complexity of 25. 3 547673
NPathComplexity The method 'getDocumentData(MultipartHttpServletRequest, Document, Locale)' has an NPath complexity of 209952 3 547673
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 551
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 552
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 553
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 555
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 557
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 559
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 561
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 562
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 592
CollapsibleIfStatements These nested if statements could be combined 3 633637
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 660
NPathComplexity The method 'setAttribute(DocumentAttribute, Document, MultipartHttpServletRequest, Locale)' has an NPath complexity of 13023 3 684813
CyclomaticComplexity The method 'setAttribute(DocumentAttribute, Document, MultipartHttpServletRequest, Locale)' has a cyclomatic complexity of 27. 3 684813
ExcessiveMethodLength Avoid really long methods. 3 684813
LinguisticNaming Linguistics Antipattern - The setter 'setAttribute' should not return any type except void linguistically 3 684813
ConfusingTernary Avoid if (x != y) ..; else ..; 3 694810

fr/paris/lutece/plugins/document/service/DocumentTools.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'DocumentTools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 47111
SimplifiedTernary Ternary operators that can be simplified with || or && 3 69
ConfusingTernary Avoid if (x != y) ..; else ..; 3 69
SimplifiedTernary Ternary operators that can be simplified with || or && 3 7172
ConfusingTernary Avoid if (x != y) ..; else ..; 3 7172
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 49 characters appended. 3 73
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 94
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 105
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 106

fr/paris/lutece/plugins/document/service/DocumentTypeResourceIdService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 103106
MissingOverride The method 'register()' is missing an @Override annotation. 3 111180
ShortVariable Avoid variables with short names like rt 3 113
ShortVariable Avoid variables with short names like p 3 119
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 3 187190
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 3 198203

fr/paris/lutece/plugins/document/service/DocumentTypeService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 45111

fr/paris/lutece/plugins/document/service/attributes/DateManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 6871
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 7780
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 8689
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 9598
MissingOverride The method 'validateValue(int, String, Locale)' is missing an @Override annotation. 3 107124
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 3 132160
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 145
MissingOverride The method 'getAttributeParametersValues(int, Locale)' is missing an @Override annotation. 3 168187
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 178
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 180
CyclomaticComplexity The method 'validateDate(String, Locale)' has a cyclomatic complexity of 10. 3 195240
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 198
ShortVariable Avoid variables with short names like i 3 199
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 199

fr/paris/lutece/plugins/document/service/attributes/DefaultManager.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.attributes.IMapProvider' 4 41
MissingOverride The method 'getCreateFormHtml(DocumentAttribute, Locale, String)' is missing an @Override annotation. 3 118134
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 125
MissingOverride The method 'getModifyFormHtml(DocumentAttribute, Document, Locale, String)' is missing an @Override annotation. 3 139192
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 141
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 141
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 171180
MissingOverride The method 'getCreateParametersFormHtml(Locale)' is missing an @Override annotation. 3 197200
MissingOverride The method 'getCreateParametersFormHtml(List, Locale)' is missing an @Override annotation. 3 205208
CommentRequired Public method and constructor comments are required 3 210239
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 2 211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 215
ConfusingTernary Avoid if (x != y) ..; else ..; 3 225232
MissingOverride The method 'getModifyParametersFormHtml(Locale, int)' is missing an @Override annotation. 3 244247
AvoidReassigningParameters Avoid reassigning parameters such as 'model' 2 249
CommentRequired Public method and constructor comments are required 3 249269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 253
MissingOverride The method 'getExtraParameters(Locale)' is missing an @Override annotation. 3 274277
MissingOverride The method 'getExtraParametersValues(Locale, int)' is missing an @Override annotation. 3 282293
MissingOverride The method 'setAttributeTypeCode(String)' is missing an @Override annotation. 3 298301
MissingOverride The method 'getAttributeTypeCode()' is missing an @Override annotation. 3 306309
MissingOverride The method 'validateValue(int, String, Locale)' is missing an @Override annotation. 3 314338
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 322
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 343346
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 3 343346
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 3 351354
MissingOverride The method 'canBeUsedAsThumbnail()' is missing an @Override annotation. 3 370373
MissingOverride The method 'getValueParameters(HttpServletRequest, Locale)' is missing an @Override annotation. 3 378381
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 378381
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 391

fr/paris/lutece/plugins/document/service/attributes/DocumentAttributesService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 46121
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listAttributes' 3 100

fr/paris/lutece/plugins/document/service/attributes/FileManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 6265
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 7174
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 8083
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 8992
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 3 101119

fr/paris/lutece/plugins/document/service/attributes/ImageFileManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 5154
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 6063
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 6972
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 7881

fr/paris/lutece/plugins/document/service/attributes/InternalLinkManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 5255
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 6164
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 7073
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 7982
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 3 9094

fr/paris/lutece/plugins/document/service/attributes/ListBoxManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 8083
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 8992
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 98101
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 107110
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 3 118129
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 144
CyclomaticComplexity The method 'getValueParameters(HttpServletRequest, Locale)' has a cyclomatic complexity of 14. 3 178249
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 190
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 257
CollapsibleIfStatements These nested if statements could be combined 3 291298

fr/paris/lutece/plugins/document/service/attributes/MultilineManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 4952
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 5861
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 6770
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 7679

fr/paris/lutece/plugins/document/service/attributes/NumerictextManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 5659
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 6568
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 7477
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 8386
MissingOverride The method 'validateValue(int, String, Locale)' is missing an @Override annotation. 3 95116
ConfusingTernary Avoid if (x != y) ..; else ..; 3 99113

fr/paris/lutece/plugins/document/service/attributes/RichTextManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 5255
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 6164
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 7073
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 7982
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 3 9094

fr/paris/lutece/plugins/document/service/attributes/TextManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 5962
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 6871
MissingOverride The method 'getCreateParametersTemplate()' is missing an @Override annotation. 3 7780
MissingOverride The method 'getModifyParametersTemplate()' is missing an @Override annotation. 3 8689
MissingOverride The method 'validateValueParameters(List, Locale)' is missing an @Override annotation. 3 97124

fr/paris/lutece/plugins/document/service/attributes/UrlManager.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreateTemplate()' is missing an @Override annotation. 3 5255
MissingOverride The method 'getModifyTemplate()' is missing an @Override annotation. 3 6164
MissingOverride The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. 3 7276

fr/paris/lutece/plugins/document/service/autoarchiving/AutoArchivingDaemon.java

Rule Violation Priority Ligne
MissingOverride The method 'run()' is missing an @Override annotation. 3 4750

fr/paris/lutece/plugins/document/service/autoarchiving/AutoArchivingService.java

Rule Violation Priority Ligne
NonThreadSafeSingleton Singleton is not thread safe 3 6265
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 122 characters appended. 3 85

fr/paris/lutece/plugins/document/service/autopublication/AutoPublicationDaemon.java

Rule Violation Priority Ligne
MissingOverride The method 'run()' is missing an @Override annotation. 3 4750

fr/paris/lutece/plugins/document/service/autopublication/AutoPublicationService.java

Rule Violation Priority Ligne
NonThreadSafeSingleton Singleton is not thread safe 3 6871
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 125 characters appended. 3 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 133

fr/paris/lutece/plugins/document/service/category/CategoryService.java

Rule Violation Priority Ligne
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the CategoryService constructor if you want a default access modifier 3 6467
MissingOverride The method 'getImageResource(int)' is missing an @Override annotation. 3 8487
MissingOverride The method 'getResourceTypeId()' is missing an @Override annotation. 3 9396
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 108
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 135
ShortVariable Avoid variables with short names like i 3 169
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 186
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 291294

fr/paris/lutece/plugins/document/service/docsearch/DefaultDocSearchIndexer.java

Rule Violation Priority Ligne
UseUnderscoresInNumericLiterals Number 1000000 should separate every third digit with an underscore 3 78
MissingOverride The method 'getDocuments(Collection)' is missing an @Override annotation. 3 86102
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 89
ShortVariable Avoid variables with short names like ft 3 119
IdenticalCatchBranches 'catch' branch identical to 'SAXException' branch 3 146149
ShortVariable Avoid variables with short names like sb 3 153
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 181
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 182
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 182
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 183
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 184
ConfusingTernary Avoid if (x != y) ..; else ..; 3 190214
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 193
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 206

fr/paris/lutece/plugins/document/service/docsearch/DocSearchIndexerDaemon.java

Rule Violation Priority Ligne
MissingOverride The method 'run()' is missing an @Override annotation. 3 5054

fr/paris/lutece/plugins/document/service/docsearch/DocSearchItem.java

Rule Violation Priority Ligne
ConstructorCallsOverridableMethod Overridable method 'setId' called during object construction 1 65
ConstructorCallsOverridableMethod Overridable method 'setTitle' called during object construction 1 66
ConstructorCallsOverridableMethod Overridable method 'setSummary' called during object construction 1 67
ConstructorCallsOverridableMethod Overridable method 'setDate' called during object construction 1 68
ConstructorCallsOverridableMethod Overridable method 'setType' called during object construction 1 69
ConfusingTernary Avoid if (x != y) ..; else ..; 3 119
ConfusingTernary Avoid if (x != y) ..; else ..; 3 139

fr/paris/lutece/plugins/document/service/docsearch/DocSearchService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34624
UnusedImports Avoid unused imports such as 'org.apache.lucene.util.Version' 4 73
UnusedImports Avoid unused imports such as 'java.io.File' 4 75
GodClass Possible God Class (WMC=61, ATFD=111, TCC=8.333%) 3 94624
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 94624
UseUnderscoresInNumericLiterals Number 1000000 should separate every third digit with an underscore 3 101
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 102
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 103
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 106
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 132
NonThreadSafeSingleton Singleton is not thread safe 3 144147
CyclomaticComplexity The method 'processIndexing(boolean)' has a cyclomatic complexity of 21. 3 157360
NPathComplexity The method 'processIndexing(boolean)' has an NPath complexity of 308 3 157360
ExcessiveMethodLength Avoid really long methods. 3 157360
NcssCount The method 'processIndexing(boolean)' has a NCSS line count of 116. 3 157360
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 109 characters appended. 3 159
ConfusingTernary Avoid if (x != y) ..; else ..; 3 189328
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 196
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 4 201
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 203
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 4 205
ShortVariable Avoid variables with short names like it 3 205
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 4 209
AvoidDuplicateLiterals The String literal "\r\n" appears 5 times in this file; the first occurrence is on line 217 3 217
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 221
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 223
AvoidDuplicateLiterals The String literal "Indexing error : " appears 4 times in this file; the first occurrence is on line 228 3 228
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 237
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 4 242
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 244
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 4 246
ShortVariable Avoid variables with short names like it 3 246
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' 4 250
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 263
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 265
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 281
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 299
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 318
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 320
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 335
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 371
ShortVariable Avoid variables with short names like ir 3 373
ShortVariable Avoid variables with short names like si 3 409
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 413
NcssCount The method 'getSearchResults(String, boolean, boolean, String, DocumentType)' has a NCSS line count of 68. 3 430553
NPathComplexity The method 'getSearchResults(String, boolean, boolean, String, DocumentType)' has an NPath complexity of 4034 3 430553
ExcessiveMethodLength Avoid really long methods. 3 430553
CyclomaticComplexity The method 'getSearchResults(String, boolean, boolean, String, DocumentType)' has a cyclomatic complexity of 17. 3 430553
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 433
ShortVariable Avoid variables with short names like ir 3 435
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 439
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 440
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 441
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 493
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 493
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 494
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 499
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 499
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 500
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 503
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 520
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 547

fr/paris/lutece/plugins/document/service/history/DocumentHistoryService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 49128
MissingOverride The method 'processDocumentEvent(DocumentEvent)' is missing an @Override annotation. 3 76127
ConfusingTernary Avoid if (x != y) ..; else ..; 3 84
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 123

fr/paris/lutece/plugins/document/service/metadata/MetadataService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4697
ShortVariable Avoid variables with short names like st 3 67

fr/paris/lutece/plugins/document/service/publishing/PortletInvalider.java

Rule Violation Priority Ligne
MissingOverride The method 'processPublishingEvent(PublishingEvent)' is missing an @Override annotation. 3 5458
MissingOverride The method 'processDocumentEvent(DocumentEvent)' is missing an @Override annotation. 3 6474

fr/paris/lutece/plugins/document/service/publishing/PublishingEvent.java

Rule Violation Priority Ligne
ImmutableField Private field '_nDocumentId' could be made final; it is only initialized in the declaration or constructor. 3 47
ImmutableField Private field '_nPortletId' could be made final; it is only initialized in the declaration or constructor. 3 48
ImmutableField Private field '_nType' could be made final; it is only initialized in the declaration or constructor. 3 49

fr/paris/lutece/plugins/document/service/publishing/PublishingEventListenersManager.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the notifyListeners method if you want a default access modifier 3 7076
DefaultPackage Use explicit scoping instead of the default package private level 3 7076

fr/paris/lutece/plugins/document/service/publishing/PublishingService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 63462
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 66
CyclomaticComplexity The method 'changeDocumentOrder(int, int, int)' has a cyclomatic complexity of 10. 3 186229
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 255
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 267
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 303
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 326
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 379
ShortVariable Avoid variables with short names like i 3 385
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listDocuments' 3 402
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 415
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 433
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 434

fr/paris/lutece/plugins/document/service/resource/DocumentExtendableResourceService.java

Rule Violation Priority Ligne
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 116

fr/paris/lutece/plugins/document/service/rules/RuleEngine.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 4893
MissingOverride The method 'processDocumentEvent(DocumentEvent)' is missing an @Override annotation. 3 8592

fr/paris/lutece/plugins/document/service/search/DocumentIndexer.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34390
UseUnderscoresInNumericLiterals Number 1000000 should separate every third digit with an underscore 3 100
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 134
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 159
ShortVariable Avoid variables with short names like it 3 162
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 224
ShortVariable Avoid variables with short names like ft 3 247
IdenticalCatchBranches 'catch' branch identical to 'SAXException' branch 3 283286
ConfusingTernary Avoid if (x != y) ..; else ..; 3 328355
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 331
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 346
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 360
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 360
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 372

fr/paris/lutece/plugins/document/service/spaces/DocumentSpacesService.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=62, ATFD=58, TCC=1.471%) 3 71612
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 71612
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'xslSource' 3 191
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 216
CyclomaticComplexity The method 'findSpacesByCodeType(StringBuffer, int, AdminUser, String)' has a cyclomatic complexity of 13. 3 242327
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 263
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 284290
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 385
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 386
NPathComplexity The method 'getSpacesBrowser(HttpServletRequest, AdminUser, Locale, boolean, boolean, boolean)' has an NPath complexity of 1152 3 436531
CyclomaticComplexity The method 'getSpacesBrowser(HttpServletRequest, AdminUser, Locale, boolean, boolean, boolean)' has a cyclomatic complexity of 13. 3 436531
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 441
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 441
ShortVariable Avoid variables with short names like i 3 446
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 504
LocalVariableNamingConventions The local variable name '_template' doesn't match '[a-z][a-zA-Z0-9]*' 1 525
ControlStatementBraces This statement should have braces 3 526
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 555
LinguisticNaming Linguistics Antipattern - The getter 'getSpaceParents' should not return void linguistically 3 568581
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 603

fr/paris/lutece/plugins/document/service/spaces/SpaceRemovalListenerService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4455

fr/paris/lutece/plugins/document/service/spaces/SpaceResourceIdService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7982
MissingOverride The method 'register()' is missing an @Override annotation. 3 87121
ShortVariable Avoid variables with short names like rt 3 89
ShortVariable Avoid variables with short names like p 3 95
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 3 128131
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 3 139159

fr/paris/lutece/plugins/document/utils/ImageUtils.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like in 3 73

fr/paris/lutece/plugins/document/web/DocumentContentJspBean.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 101
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 101

fr/paris/lutece/plugins/document/web/DocumentDashboardComponent.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 114
ShortVariable Avoid variables with short names like t 3 121

fr/paris/lutece/plugins/document/web/DocumentJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341983
CyclomaticComplexity The class 'DocumentJspBean' has a total cyclomatic complexity of 204 (highest 40). 3 1241983
GodClass Possible God Class (WMC=204, ATFD=320, TCC=14.225%) 3 1241983
ExcessiveClassLength Avoid really long classes. 3 1241983
TooManyMethods This class has too many methods, consider refactoring it. 3 1251983
ImmutableField Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 3 254
CallSuperInConstructor It is a good practice to call super() in a constructor 3 262265
ExcessiveMethodLength Avoid really long methods. 3 272397
NcssCount The method 'getManageDocuments(HttpServletRequest)' has a NCSS line count of 70. 3 272397
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 274
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 305
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 305
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 340342
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 344
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 372
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 421
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 421
UnusedFormalParameter Avoid unused method parameters such as 'request'. 3 463
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 466
UnusedFormalParameter Avoid unused method parameters such as 'request'. 3 480
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 482
ConfusingTernary Avoid if (x != y) ..; else ..; 3 503
ConfusingTernary Avoid if (x != y) ..; else ..; 3 516
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 540
ConfusingTernary Avoid if (x != y) ..; else ..; 3 630631
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 632
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 632
CyclomaticComplexity The method 'doActionSelectionDocument(HttpServletRequest)' has a cyclomatic complexity of 40. 3 10911285
NcssCount The method 'doActionSelectionDocument(HttpServletRequest)' has a NCSS line count of 83. 3 10911285
ExcessiveMethodLength Avoid really long methods. 3 10911285
UnusedLocalVariable Avoid unused local variables such as 'nbDocumentsAffected'. 3 1097
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 11731176
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 12121217
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 12641269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1409
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1409
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1442
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1442
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1471
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 1480
NcssCount The method 'getMassArchivalDocument(HttpServletRequest)' has a NCSS line count of 80. 3 15241679
CyclomaticComplexity The method 'getMassArchivalDocument(HttpServletRequest)' has a cyclomatic complexity of 21. 3 15241679
NPathComplexity The method 'getMassArchivalDocument(HttpServletRequest)' has an NPath complexity of 2720 3 15241679
ExcessiveMethodLength Avoid really long methods. 3 15241679
AvoidDuplicateLiterals The String literal "to_archive" appears 4 times in this file; the first occurrence is on line 1,537 3 1537
AvoidDuplicateLiterals The String literal "jsp/admin/plugins/document/MassArchivalDocument.jsp" appears 4 times in this file; the first occurrence is on line 1,581 3 1581
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 1587
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 1588
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1638
AddEmptyString Do not add empty strings 3 1652
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1664
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1664
ConfusingTernary Avoid if (x != y) ..; else ..; 3 17091716
ConfusingTernary Avoid if (x != y) ..; else ..; 3 17531760
ConfusingTernary Avoid if (x != y) ..; else ..; 3 17881795
ConfusingTernary Avoid if (x != y) ..; else ..; 3 18241832
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1897
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1897
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 19161922
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 1949

fr/paris/lutece/plugins/document/web/DocumentLegacyServletRedirectFilter.java

Rule Violation Priority Ligne
MissingOverride The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' is missing an @Override annotation. 3 6891
ConfusingTernary Avoid if (x != y) ..; else ..; 3 7380

fr/paris/lutece/plugins/document/web/DocumentMetaPageInclude.java

Rule Violation Priority Ligne
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 3 74102
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 8697
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'sourceXsl' 3 113

fr/paris/lutece/plugins/document/web/DocumentResourceServlet.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_cache' doesn't match '[A-Z][A-Z_0-9]*' 1 75
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 154
ConfusingTernary Avoid if (x != y) ..; else ..; 3 202211
ConfusingTernary Avoid if (x != y) ..; else ..; 3 284303
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 315
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 315
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 316
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 316

fr/paris/lutece/plugins/document/web/DocumentServiceJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34439
MissingOverride The method 'getInsertServiceSelectorUI(HttpServletRequest)' is missing an @Override annotation. 3 159162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 259
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 380
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 381
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 382
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 383
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 383
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 385
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 433
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 433

fr/paris/lutece/plugins/document/web/DocumentTypeJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341014
GodClass Possible God Class (WMC=91, ATFD=176, TCC=24.923%) 3 881014
CyclomaticComplexity The class 'DocumentTypeJspBean' has a total cyclomatic complexity of 91 (highest 11). 3 881014
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 881014
TooManyMethods This class has too many methods, consider refactoring it. 3 891014
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 160
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 188
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 188
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 206
ConfusingTernary Avoid if (x != y) ..; else ..; 3 246253
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 263
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 263
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 281
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 283
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 284
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 285
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 287
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 288
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 328
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 328
LinguisticNaming Linguistics Antipattern - The getter 'getAttributeData' should not return void linguistically 3 456509
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 459
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 465
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 518
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 537
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 582
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 612613
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 615
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 615
AddEmptyString Do not add empty strings 3 641
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 739
CyclomaticComplexity The method 'getStyleSheets(MultipartHttpServletRequest)' has a cyclomatic complexity of 11. 3 817871
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 819
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 823
ConfusingTernary Avoid if (x != y) ..; else ..; 3 886893
LinguisticNaming Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' 3 916933
ShortVariable Avoid variables with short names like is 3 924
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 927

fr/paris/lutece/plugins/document/web/ResourceServletCache.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5154
MissingOverride The method 'getName()' is missing an @Override annotation. 3 6063
DefaultPackage Use explicit scoping instead of the default package private level 3 89100
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the removeFromKeyPattern method if you want a default access modifier 3 89100

fr/paris/lutece/plugins/document/web/ResourceServletContentTypeCache.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5362
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 57
MissingOverride The method 'getName()' is missing an @Override annotation. 3 6871

fr/paris/lutece/plugins/document/web/ResourceValueObject.java

Rule Violation Priority Ligne
UncommentedEmptyConstructor Document empty constructor 3 5961
MethodReturnsInternalArray Returning '_content' may expose an internal array. 3 104
ArrayIsStoredDirectly The user-supplied array 'content' is stored directly. 3 111

fr/paris/lutece/plugins/document/web/category/CategoryJspBean.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 116118
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 116118
UncommentedEmptyConstructor Document empty constructor 3 116118
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 131
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 150
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 171
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 174
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 177
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 214
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 229
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 229
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 246
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 247
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 248
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 249
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 250

fr/paris/lutece/plugins/document/web/docsearch/AdvancedSearch.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 70253
CyclomaticComplexity The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 17. 3 100211
NPathComplexity The method 'getPage(HttpServletRequest, int, Plugin)' has an NPath complexity of 1409 3 100211
ExcessiveMethodLength Avoid really long methods. 3 100211
MissingOverride The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. 3 100211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 104
ConfusingTernary Avoid if (x != y) ..; else ..; 3 109199
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 145
ShortVariable Avoid variables with short names like i 3 148
ShortVariable Avoid variables with short names like c 3 156
ShortVariable Avoid variables with short names like it 3 157
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 177
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 191
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 220
ShortVariable Avoid variables with short names like f 3 220

fr/paris/lutece/plugins/document/web/docsearch/DocSearchJspBean.java

Rule Violation Priority Ligne
NPathComplexity The method 'getSearch(HttpServletRequest)' has an NPath complexity of 408 3 105211
NcssCount The method 'getSearch(HttpServletRequest)' has a NCSS line count of 61. 3 105211
CyclomaticComplexity The method 'getSearch(HttpServletRequest)' has a cyclomatic complexity of 11. 3 105211
ExcessiveMethodLength Avoid really long methods. 3 105211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 112
ConfusingTernary Avoid if (x != y) ..; else ..; 3 125
ConfusingTernary Avoid if (x != y) ..; else ..; 3 129
ConfusingTernary Avoid if (x != y) ..; else ..; 3 137188
ConfusingTernary Avoid if (x != y) ..; else ..; 3 162171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 198199

fr/paris/lutece/plugins/document/web/history/DocumentHistoryJspBean.java

Rule Violation Priority Ligne
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 95
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 95

fr/paris/lutece/plugins/document/web/portlet/DocumentListPortletJspBean.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 3 105116
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 3 124137
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 3 145175
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 149
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 152
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 3 183230
LinguisticNaming Linguistics Antipattern - The setter 'setIdCategory' should not return any type except void linguistically 3 237255
ShortVariable Avoid variables with short names like i 3 244
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 277
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 277
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 295
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 312
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 312

fr/paris/lutece/plugins/document/web/portlet/DocumentPortletJspBean.java

Rule Violation Priority Ligne
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 3 107118
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 3 126139
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 3 147177
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 154
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 3 185231
LinguisticNaming Linguistics Antipattern - The setter 'setIdCategory' should not return any type except void linguistically 3 238256
ShortVariable Avoid variables with short names like i 3 245
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 278
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 278
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 296
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 313
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 313

fr/paris/lutece/plugins/document/web/publishing/DocumentPublishingJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341171
CyclomaticComplexity The class 'DocumentPublishingJspBean' has a total cyclomatic complexity of 110 (highest 21). 3 931171
ExcessiveClassLength Avoid really long classes. 3 931171
FieldNamingConventions The constant name 'MARk_DOCUMENT_LIST_PORTLET_LIST' doesn't match '[A-Z][A-Z_0-9]*' 1 147
CyclomaticComplexity The method 'getManageDocumentPublishing(HttpServletRequest)' has a cyclomatic complexity of 21. 3 181299
ExcessiveMethodLength Avoid really long methods. 3 181299
NPathComplexity The method 'getManageDocumentPublishing(HttpServletRequest)' has an NPath complexity of 4322 3 181299
NcssCount The method 'getManageDocumentPublishing(HttpServletRequest)' has a NCSS line count of 61. 3 181299
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 194
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 194
ConfusingTernary Avoid if (x != y) ..; else ..; 3 204205
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 221224
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 244
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 246262
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 255
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 327
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listFilteredPortlets' 3 340
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 369
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'listFilteredPortlets' 3 381
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 395
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 406
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 406
CyclomaticComplexity The method 'doAssignedDocument(HttpServletRequest)' has a cyclomatic complexity of 11. 3 436496
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 445
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 463
ConfusingTernary Avoid if (x != y) ..; else ..; 3 513520
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 535
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 536
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 546
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 546
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 3 572579
MissingBreakInSwitch A switch statement does not contain a break 3 604621
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 3 604621
ConfusingTernary Avoid if (x != y) ..; else ..; 3 624632
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 3 665683
MissingBreakInSwitch A switch statement does not contain a break 3 665683
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 768
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 768
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 883
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 883
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 928
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 928
UnusedFormalParameter Avoid unused method parameters such as 'request'. 3 1039
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1049
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1049
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1065
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1065
UnusedFormalParameter Avoid unused method parameters such as 'request'. 3 1089
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1092
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1102
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1102
ConfusingTernary Avoid if (x != y) ..; else ..; 3 1109
LinguisticNaming Linguistics Antipattern - The setter 'setFillFilter' should not return any type except void linguistically 3 11321170
ConfusingTernary Avoid if (x != y) ..; else ..; 3 11371167

fr/paris/lutece/plugins/document/web/rules/DocumentRulesJspBean.java

Rule Violation Priority Ligne
FieldNamingConventions The field name '_StrRuleAttributeSelected' doesn't match '_[a-z][a-zA-Z0-9]*' 1 92
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 142
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 153
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 153
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 179
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 179
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 233
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 233

fr/paris/lutece/plugins/document/web/spaces/DocumentSpaceJspBean.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 130
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 130
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 197
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 254
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 255
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 258
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 259
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 260
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 262
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 263
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 282285
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 304
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 315
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 328
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 385
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 386
ConfusingTernary Avoid if (x != y) ..; else ..; 3 389396
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 403
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 403
CyclomaticComplexity The method 'doMoveSpace(HttpServletRequest)' has a cyclomatic complexity of 10. 3 421471