PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/fileexport/business/FileExportDAO.java
| Violation |
Line |
| Avoid unnecessary comparisons in boolean expressions |
241 |
| Rather than using a lot of String arguments, consider using a container object for those values. |
250–251 |
| Ensure that resources like this Connection object are closed after use |
254 |
| Ensure that resources like this ResultSet object are closed after use |
265 |
| This statement may have some unnecessary parentheses |
269 |
| System.out.println is used |
271 |
| Prefer StringBuffer over += for concatenating strings |
279 |
| Avoid unused local variables such as 'f'. |
282 |
| Avoid variables with short names like f |
282 |
| Assigning an Object to null is a code smell. Consider refactoring. |
300 |
| Avoid printStackTrace(); use a logger call instead. |
307 |
| A throw statement in a finally block makes the control flow hard to understand. |
308–319 |
| New exception is thrown in catch block, original stack trace may be lost |
314–315 |
| Avoid variables with short names like f |
349 |
| Avoid empty catch blocks |
362–363 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
362 |
fr/paris/lutece/plugins/fileexport/service/FileExportConnectionService.java
| Violation |
Line |
| Consider replacing this Hashtable with the newer java.util.Map |
83 |
| Avoid using implementation types like 'Hashtable'; use the interface instead |
83 |
| Avoid using implementation types like 'Hashtable'; use the interface instead |
83 |
fr/paris/lutece/plugins/fileexport/service/FileZipService.java
| Violation |
Line |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' |
36 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' |
36 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.PluginService' |
37 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.PluginService' |
37 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' |
38 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' |
38 |
| Avoid unused imports such as 'java.io.ByteArrayInputStream' |
40 |
| Avoid unused imports such as 'java.io.ByteArrayInputStream' |
40 |
| Avoid unused imports such as 'java.util.HashMap' |
43 |
| Avoid unused imports such as 'java.util.HashMap' |
43 |
| Avoid unused imports such as 'java.util.Map' |
44 |
| Avoid unused imports such as 'java.util.Map' |
44 |
| Avoid unused imports such as 'java.util.zip.ZipEntry' |
45 |
| Avoid unused imports such as 'java.util.zip.ZipEntry' |
45 |
| Avoid unused imports such as 'javax.servlet.http.HttpSession' |
49 |
| Avoid unused imports such as 'javax.servlet.http.HttpSession' |
49 |
| Avoid unused private fields such as 'PARAM_PLUGIN_ID'. |
58 |
| Use block level rather than method level synchronization |
64–72 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
84 |
fr/paris/lutece/plugins/fileexport/web/FileexportJspBean.java
| Violation |
Line |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. |
113 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
136 |
| Do not add empty strings |
138 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
157 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
172 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
261 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
278 |
