The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'RequestId' doesn't match '[a-z][a-zA-Z0-9]*' | 247 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'RequestId' doesn't match '[a-z][a-zA-Z0-9]*' | 159 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 264 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 264 |
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 285 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 127 |
| FormalParameterNamingConventions | The method parameter name 'RequestId' doesn't match '[a-z][a-zA-Z0-9]*' | 136 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 129 |
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 140 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 160 |
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 160 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'TEMPLATE_MAIL' doesn't match '_[a-z][a-zA-Z0-9]*' | 70 |
| FieldNamingConventions | The static field name 'sw' doesn't match '_[a-z][a-zA-Z0-9]*' | 75 |
| FieldNamingConventions | The static field name 'pw' doesn't match '_[a-z][a-zA-Z0-9]*' | 76 |
| MethodNamingConventions | The static method name 'TransferFileToTargetFileService' doesn't match '[a-z][a-zA-Z0-9]*' | 78–112 |
| LocalVariableNamingConventions | The local variable name '_fileSwitcher' doesn't match '[a-z][a-zA-Z0-9]*' | 91 |
| MethodNamingConventions | The static method name 'HandleException' doesn't match '[a-z][a-zA-Z0-9]*' | 148–187 |
| FormalParameterNamingConventions | The method parameter name 'ResponseCode' doesn't match '[a-z][a-zA-Z0-9]*' | 148 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 61–63 |
| UncommentedEmptyConstructor | Document empty constructor | 61–63 |
| CommentRequired | Public method and constructor comments are required | 65–72 |
| Rule | Violation | Line |
|---|---|---|
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 213–216 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 49–164 |
| UncommentedEmptyConstructor | Document empty constructor | 57–59 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the FileStorageTransferErrorHome constructor if you want a default access modifier | 57–59 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 81–93 |
| CommentRequired | Public method and constructor comments are required | 95–98 |
| UncommentedEmptyConstructor | Document empty constructor | 95–98 |
| CommentRequired | Public method and constructor comments are required | 247–250 |
| CommentRequired | Public method and constructor comments are required | 294–297 |
| CommentRequired | Public method and constructor comments are required | 299–302 |
| CommentRequired | Public method and constructor comments are required | 304–307 |
| CommentRequired | Public method and constructor comments are required | 309–312 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 50–360 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 230–233 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Enum comments are required | 8–63 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'FileStorageTransferRequestStatus(String, String, String)': enum constructors are implicitly private | 20–25 |
| CommentRequired | Public method and constructor comments are required | 27–37 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| CommentRequired | Public method and constructor comments are required | 59–62 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–161 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–74 |
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 49 |
| CommentRequired | Public method and constructor comments are required | 51–54 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 51–54 |
| CommentRequired | Public method and constructor comments are required | 56–73 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 56–73 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 10–49 |
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 16 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 57 characters appended. | 23 |
| CommentRequired | Public method and constructor comments are required | 35–38 |
| CommentRequired | Public method and constructor comments are required | 40–47 |
| NonThreadSafeSingleton | Singleton is not thread safe | 42–45 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 58–199 |
| ShortVariable | Avoid variables with short names like sw | 75 |
| ShortVariable | Avoid variables with short names like pw | 76 |
| CommentRequired | Public method and constructor comments are required | 78–112 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 102 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 108 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strTargetFileKey' | 125 |
| UnusedPrivateMethod | Avoid unused private methods such as 'deleteFileFromTargetFileService(String,IFileStoreServiceProvider)'. | 139 |
| ShortVariable | Avoid variables with short names like e | 148 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 172 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 177–185 |
| CommentRequired | Public method and constructor comments are required | 189–192 |
| CommentRequired | Public method and constructor comments are required | 194–197 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 6–30 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 29 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 47–118 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 47–118 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 112 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 112 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 114–117 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 114–117 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 66–194 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 113 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 131–138 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 132–138 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 140–144 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 141–144 |
| CommentRequired | Public method and constructor comments are required | 178–193 |
| UnusedLocalVariable | Avoid unused local variables such as 'requestToReplay'. | 187 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 187 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 35–453 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 73–453 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 153 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 159–166 |
| CommentRequired | Public method and constructor comments are required | 177–189 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 180 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 180 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 180–187 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 197–203 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 198–203 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 205–209 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 206–209 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 230 |
| CommentRequired | Public method and constructor comments are required | 363–375 |
| CommentRequired | Public method and constructor comments are required | 378–392 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.filestoragetransfer.daemon.FileStorageTransferDaemon' | 44 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' | 51 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 49 |
| UnusedImports | Avoid unused imports such as 'java.util.Arrays' | 67 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 61–63 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 61–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 213–216 |
| FormalParameterNamingConventions | The method parameter name 'RequestId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 247 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 49–164 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 57–59 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the FileStorageTransferErrorHome constructor if you want a default access modifier | 3 | 57–59 |
| FormalParameterNamingConventions | The method parameter name 'RequestId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 159 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 81–93 |
| CommentRequired | Public method and constructor comments are required | 3 | 95–98 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 95–98 |
| CommentRequired | Public method and constructor comments are required | 3 | 247–250 |
| CommentRequired | Public method and constructor comments are required | 3 | 294–297 |
| CommentRequired | Public method and constructor comments are required | 3 | 299–302 |
| CommentRequired | Public method and constructor comments are required | 3 | 304–307 |
| CommentRequired | Public method and constructor comments are required | 3 | 309–312 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–360 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 230–233 |
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 264 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 264 |
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 285 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Enum comments are required | 3 | 8–63 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'FileStorageTransferRequestStatus(String, String, String)': enum constructors are implicitly private | 3 | 20–25 |
| CommentRequired | Public method and constructor comments are required | 3 | 27–37 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–62 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 127 |
| FormalParameterNamingConventions | The method parameter name 'RequestId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 136 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–161 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 129 |
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 140 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 160 |
| FormalParameterNamingConventions | The method parameter name 'RequestStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 160 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–74 |
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 3 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 51–54 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 51–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–73 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 56–73 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 10–49 |
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 3 | 16 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 57 characters appended. | 3 | 23 |
| CommentRequired | Public method and constructor comments are required | 3 | 35–38 |
| CommentRequired | Public method and constructor comments are required | 3 | 40–47 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 42–45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 58–199 |
| FieldNamingConventions | The static field name 'TEMPLATE_MAIL' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 70 |
| FieldNamingConventions | The static field name 'sw' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 75 |
| ShortVariable | Avoid variables with short names like sw | 3 | 75 |
| FieldNamingConventions | The static field name 'pw' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 76 |
| ShortVariable | Avoid variables with short names like pw | 3 | 76 |
| CommentRequired | Public method and constructor comments are required | 3 | 78–112 |
| MethodNamingConventions | The static method name 'TransferFileToTargetFileService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 78–112 |
| LocalVariableNamingConventions | The local variable name '_fileSwitcher' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 91 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 102 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 108 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strTargetFileKey' | 3 | 125 |
| UnusedPrivateMethod | Avoid unused private methods such as 'deleteFileFromTargetFileService(String,IFileStoreServiceProvider)'. | 3 | 139 |
| MethodNamingConventions | The static method name 'HandleException' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 148–187 |
| FormalParameterNamingConventions | The method parameter name 'ResponseCode' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 148 |
| ShortVariable | Avoid variables with short names like e | 3 | 148 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 172 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 177–185 |
| CommentRequired | Public method and constructor comments are required | 3 | 189–192 |
| CommentRequired | Public method and constructor comments are required | 3 | 194–197 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 6–30 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 3 | 29 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 4 | 37 |
| CommentRequired | Header comments are required | 3 | 47–118 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 47–118 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 112 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 112 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 114–117 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 114–117 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.filestoragetransfer.daemon.FileStorageTransferDaemon' | 4 | 44 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' | 4 | 51 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 66–194 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 113 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 131–138 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 132–138 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 140–144 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 141–144 |
| CommentRequired | Public method and constructor comments are required | 3 | 178–193 |
| UnusedLocalVariable | Avoid unused local variables such as 'requestToReplay'. | 3 | 187 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 187 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 35–453 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.i18n.I18nService' | 4 | 49 |
| UnusedImports | Avoid unused imports such as 'java.util.Arrays' | 4 | 67 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 73–453 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 153 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 159–166 |
| CommentRequired | Public method and constructor comments are required | 3 | 177–189 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 180 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 3 | 180 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 180–187 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 197–203 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 198–203 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 205–209 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 206–209 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 230 |
| CommentRequired | Public method and constructor comments are required | 3 | 363–375 |
| CommentRequired | Public method and constructor comments are required | 3 | 378–392 |
