PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/folderlisting/business/FolderListingDatabaseHome.java
| Violation |
Line |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
46–114 |
fr/paris/lutece/plugins/folderlisting/business/FolderListingHome.java
| Violation |
Line |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
55–132 |
| Avoid variables with short names like f |
72 |
| When instantiating a SimpleDateFormat object, specify a Locale |
85 |
| Do not add empty strings |
91 |
| When instantiating a SimpleDateFormat object, specify a Locale |
118 |
fr/paris/lutece/plugins/folderlisting/business/portlet/FolderListingPortlet.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
73–76 |
fr/paris/lutece/plugins/folderlisting/business/portlet/FolderListingPortletDAO.java
| Violation |
Line |
| Avoid unused imports such as 'fr.paris.lutece.portal.business.portlet.IPortletInterfaceDAO' |
36 |
| Avoid unused imports such as 'fr.paris.lutece.portal.business.portlet.IPortletInterfaceDAO' |
36 |
| Avoid variables with short names like p |
77 |
| Avoid variables with short names like p |
118 |
fr/paris/lutece/plugins/folderlisting/business/portlet/FolderListingPortletHome.java
| Violation |
Line |
| Avoid using redundant field initializer for '_singleton' |
52 |
| Possible unsafe assignment to a non-final static field in a constructor. |
52 |
| It is a good practice to call super() in a constructor |
57–63 |
| Singleton is not thread safe |
72–75 |
fr/paris/lutece/plugins/folderlisting/service/Folder.java
| Violation |
Line |
| Singleton is not thread safe |
57–61 |
fr/paris/lutece/plugins/folderlisting/service/FolderLoaderDatabase.java
| Violation |
Line |
| Use explicit scoping instead of the default package private level |
50 |
fr/paris/lutece/plugins/folderlisting/service/FolderLoaderProperties.java
| Violation |
Line |
| Private field '_strFolderFilesPath' could be made final; it is only initialized in the declaration or constructor. |
62 |
| Avoid variables with short names like is |
135 |
fr/paris/lutece/plugins/folderlisting/service/FolderService.java
| Violation |
Line |
| A class which only has private constructors should be final |
44–139 |
fr/paris/lutece/plugins/folderlisting/web/FolderListingDatabaseJspBean.java
| Violation |
Line |
| Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. |
102 |
| It is a good practice to call super() in a constructor |
104–107 |
| Do not add empty strings |
153 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
269 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
271 |
| Avoid reassigning parameters such as 'strFolderPath' |
302 |
| Avoid reassigning parameters such as 'strPath' |
322 |
| This call to String.startsWith can be rewritten using String.charAt(0) |
324 |
fr/paris/lutece/plugins/folderlisting/web/FolderListingFileJspBean.java
| Violation |
Line |
| Avoid unnecessary constructors - the compiler will generate these for you |
79–81 |
| Document empty constructor |
79–81 |
| Return an empty array rather than null. |
105–153 |
| Avoid variables with short names like in |
121 |
fr/paris/lutece/plugins/folderlisting/web/portlet/FolderListingPortletJspBean.java
| Violation |
Line |
| System.out.println is used |
93 |
| System.out.println is used |
96 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
165 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
166 |
| Use explicit scoping instead of the default package private level |
240–249 |
