Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/form/business/CaptchaFormError.java

Violation Line
It is a good practice to call super() in a constructor 6670

fr/paris/lutece/plugins/form/business/Category.java

Violation Line
Avoid unnecessary if..then..else statements when returning booleans 101104

fr/paris/lutece/plugins/form/business/CategoryDAO.java

Violation Line
Avoid excessively long variable names like SQL_QUERY_COUNT_NUMBER_OF_FORM_ASSOCIATE_TO_THE_CATEGORY 55
These nested if statements could be combined 191196

fr/paris/lutece/plugins/form/business/ExportFormat.java

Violation Line
Returning '_xsl' may expose an internal array. 121
The user-supplied array 'donnees' is stored directly. 130

fr/paris/lutece/plugins/form/business/ExportFormatDAO.java

Violation Line
Use block level rather than method level synchronization 92104

fr/paris/lutece/plugins/form/business/Form.java

Violation Line
This class has a bunch of public methods and attributes 34966
Too many fields 51966
Avoid short class names like Form 51966
A getX() method which returns a boolean should be named isX() 887890
A getX() method which returns a boolean should be named isX() 908911

fr/paris/lutece/plugins/form/business/FormDAO.java

Violation Line
The class 'FormDAO' has a Modified Cyclomatic Complexity of 4 (Highest = 20). 55638
The class 'FormDAO' has a Standard Cyclomatic Complexity of 4 (Highest = 20). 55638
The class 'FormDAO' has a Cyclomatic Complexity of 4 (Highest = 21). 55638
Avoid excessively long variable names like SQL_FILTER_STATE_BEGIN_DISPONIBILTY_AFTER_CURRENT_DATE 101
Avoid excessively long variable names like SQL_FILTER_STATE_END_DISPONIBILTY_BEFORE_CURRENT_DATE 102
Use block level rather than method level synchronization 140198
Assigning an Object to null is a code smell. Consider refactoring. 161
Assigning an Object to null is a code smell. Consider refactoring. 162
Avoid variables with short names like i 250
Assigning an Object to null is a code smell. Consider refactoring. 304
Assigning an Object to null is a code smell. Consider refactoring. 305
The method 'selectFormList' has a Cyclomatic Complexity of 21. 345510
The method 'selectFormList' has a Standard Cyclomatic Complexity of 20. 345510
The method selectFormList() has an NPath complexity of 165888 345510
Avoid really long methods. 345510
The method 'selectFormList' has a Modified Cyclomatic Complexity of 20. 345510
These nested if statements could be combined 395398
These nested if statements could be combined 405408
Avoid variables with short names like i 490
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 546

fr/paris/lutece/plugins/form/business/FormHome.java

Violation Line
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 120
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 180

fr/paris/lutece/plugins/form/business/FormSubmit.java

Violation Line
Avoid variables with short names like ip 111

fr/paris/lutece/plugins/form/business/FormSubmitDAO.java

Violation Line
The class 'FormSubmitDAO' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 51507
The class 'FormSubmitDAO' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 51507
The class 'FormSubmitDAO' has a Cyclomatic Complexity of 4 (Highest = 11). 51507
Use block level rather than method level synchronization 110127
The method 'selectStatisticFormSubmit' has a Modified Cyclomatic Complexity of 11. 314387
The method 'selectStatisticFormSubmit' has a Standard Cyclomatic Complexity of 11. 314387
The method selectStatisticFormSubmit() has an NPath complexity of 1024 314387
The method 'selectStatisticFormSubmit' has a Cyclomatic Complexity of 11. 314387
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 395

fr/paris/lutece/plugins/form/business/RecapDAO.java

Violation Line
Use block level rather than method level synchronization 84112

fr/paris/lutece/plugins/form/business/RequirementFormError.java

Violation Line
It is a good practice to call super() in a constructor 6670

fr/paris/lutece/plugins/form/business/iteration/IterationGroup.java

Violation Line
Private field '_mapIterationResponses' could be made final; it is only initialized in the declaration or constructor. 61
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 61

fr/paris/lutece/plugins/form/business/outputprocessor/OutputProcessor.java

Violation Line
Abstract classes should be named AbstractXXX 3960

fr/paris/lutece/plugins/form/business/portlet/FormPortlet.java

Violation Line
Avoid unnecessary constructors - the compiler will generate these for you 7173
Document empty constructor 7173
It is a good practice to call super() in a constructor 7173
Prefer StringBuffer over += for concatenating strings 116

fr/paris/lutece/plugins/form/business/portlet/FormPortletDAO.java

Violation Line
Avoid variables with short names like p 63
Avoid variables with short names like p 152

fr/paris/lutece/plugins/form/business/portlet/FormPortletHome.java

Violation Line
Possible unsafe assignment to a non-final static field in a constructor. 56
It is a good practice to call super() in a constructor 6167
Singleton is not thread safe 7679

fr/paris/lutece/plugins/form/business/portlet/ListFormPortlet.java

Violation Line
Avoid unused local variables such as 'locale'. 115

fr/paris/lutece/plugins/form/business/portlet/ListFormPortletDAO.java

Violation Line
Avoid variables with short names like p 62
Avoid variables with short names like p 126

fr/paris/lutece/plugins/form/business/portlet/ListFormPortletHome.java

Violation Line
Possible unsafe assignment to a non-final static field in a constructor. 52
It is a good practice to call super() in a constructor 5763
Singleton is not thread safe 7275

fr/paris/lutece/plugins/form/business/rss/FormResourceRss.java

Violation Line
Avoid unnecessary if..then..else statements when returning booleans 99102
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 234
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 273

fr/paris/lutece/plugins/form/business/rss/FormResourceRssConfigDAO.java

Violation Line
Use block level rather than method level synchronization 5969

fr/paris/lutece/plugins/form/modules/processornotifysender/business/ProcessorNotifySender.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 135
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 219
This statement may have some unnecessary parentheses 220
Avoid variables with short names like t 252
Avoid declaring a variable if it is unreferenced before a possible exit point. 274

fr/paris/lutece/plugins/form/modules/processornotifysender/service/NotifySenderResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 6568
Avoid variables with short names like rt 76
Avoid variables with short names like p 82

fr/paris/lutece/plugins/form/modules/processornotifysender/service/NotifySenderService.java

Violation Line
The class 'NotifySenderService' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 63256
The class 'NotifySenderService' has a Cyclomatic Complexity of 4 (Highest = 14). 63256
Class cannot be instantiated and does not provide any static methods or fields 63256
The class 'NotifySenderService' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 63256
Rather than using a lot of String arguments, consider using a container object for those values. 9596
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 114
The method 'sendMultiPartNotification' has a Modified Cyclomatic Complexity of 11. 137223
The method 'sendMultiPartNotification' has a Standard Cyclomatic Complexity of 11. 137223
Rather than using a lot of String arguments, consider using a container object for those values. 137138
Use block level rather than method level synchronization 137223
The method 'sendMultiPartNotification' has a Cyclomatic Complexity of 14. 137223
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 202

fr/paris/lutece/plugins/form/modules/processornotifysender/utils/FileUtils.java

Violation Line
Avoid variables with short names like sz 74
These nested if statements could be combined 8487
These nested if statements could be combined 114117
Deeply nested if..then statements are hard to read 114117
These nested if statements could be combined 136139

fr/paris/lutece/plugins/form/modules/processornotifysender/utils/ZipUtils.java

Violation Line
These nested if statements could be combined 8790
Avoid variables with short names like sz 154
Avoid variables with short names like ze 163
Avoid variables with short names like ze 182

fr/paris/lutece/plugins/form/service/CategoryResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 6265
Avoid variables with short names like rt 73
Avoid variables with short names like p 79

fr/paris/lutece/plugins/form/service/DefaultMessageResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 5861
Avoid variables with short names like rt 69
Avoid variables with short names like p 75

fr/paris/lutece/plugins/form/service/EntryTypeService.java

Violation Line
Class cannot be instantiated and does not provide any static methods or fields 47102

fr/paris/lutece/plugins/form/service/ExportFormatResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 6164
Avoid variables with short names like rt 72
Avoid variables with short names like p 78

fr/paris/lutece/plugins/form/service/FormResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 103106
Avoid variables with short names like rt 114
Avoid variables with short names like p 120

fr/paris/lutece/plugins/form/service/FormService.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34441
The class 'FormService' has a Cyclomatic Complexity of 4 (Highest = 11). 93441
Singleton is not thread safe 138141
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 155
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 172
The method 'isSessionValid' has a Cyclomatic Complexity of 11. 230272
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 302
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 392

fr/paris/lutece/plugins/form/service/OutputProcessorService.java

Violation Line
A class which only has private constructors should be final 51200
Private field '_outputProcessorSet' could be made final; it is only initialized in the declaration or constructor. 55
Singleton is not thread safe 7073

fr/paris/lutece/plugins/form/service/daemon/ExportResponsesDaemon.java

Violation Line
StringBuffer constructor is initialized with size 16, but has at least 174 characters appended. 66
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 122

fr/paris/lutece/plugins/form/service/draft/FormDraftBackupService.java

Violation Line
Use block level rather than method level synchronization 6771
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 70

fr/paris/lutece/plugins/form/service/entrytype/EntryTypeComment.java

Violation Line
Avoid unused private fields such as 'TEMPLATE_HTML_CODE_ADMIN'. 49

fr/paris/lutece/plugins/form/service/entrytype/EntryTypeGroup.java

Violation Line
Avoid excessively long variable names like MESSAGE_ERROR_MANDATORY_FIELD_NB_MINIMUM_ITERATIONS 75
Avoid declaring a variable if it is unreferenced before a possible exit point. 195
Avoid declaring a variable if it is unreferenced before a possible exit point. 196
Avoid reassigning parameters such as 'field' 294

fr/paris/lutece/plugins/form/service/entrytype/EntryTypeMandatoryCheckBox.java

Violation Line
The class 'EntryTypeMandatoryCheckBox' has a Standard Cyclomatic Complexity of 5 (Highest = 11). 57160
The class 'EntryTypeMandatoryCheckBox' has a Modified Cyclomatic Complexity of 5 (Highest = 11). 57160
The class 'EntryTypeMandatoryCheckBox' has a Cyclomatic Complexity of 5 (Highest = 11). 57160
The method 'getResponseData' has a Standard Cyclomatic Complexity of 11. 84159
The method 'getResponseData' has a Modified Cyclomatic Complexity of 11. 84159
The method 'getResponseData' has a Cyclomatic Complexity of 11. 84159
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 114

fr/paris/lutece/plugins/form/service/entrytype/EntryTypeMyLuteceUserAttribute.java

Violation Line
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 203

fr/paris/lutece/plugins/form/service/entrytype/EntryTypeSession.java

Violation Line
Avoid unused private fields such as 'TEMPLATE_HTML_CODE_ADMIN'. 55

fr/paris/lutece/plugins/form/service/export/FormExportService.java

Violation Line
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 81
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 86
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 95
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 100

fr/paris/lutece/plugins/form/service/export/FormSubmitExportService.java

Violation Line
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 88
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 93

fr/paris/lutece/plugins/form/service/parameter/FormParameterService.java

Violation Line
These nested if statements could be combined 211214

fr/paris/lutece/plugins/form/service/validator/Validator.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 3942
Abstract classes should be named AbstractXXX 3942

fr/paris/lutece/plugins/form/service/validator/ValidatorService.java

Violation Line
A class which only has private constructors should be final 48137
Singleton is not thread safe 6669

fr/paris/lutece/plugins/form/utils/EntryTypeGroupUtils.java

Violation Line
Possible God class (WMC=139, ATFD=176, TCC=0.0071301247771836) 341262
A high number of imports can indicate a high degree of coupling within an object. 341262
The class 'EntryTypeGroupUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 821262
The class 'EntryTypeGroupUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 821262
Avoid really long classes. 821262
The class 'EntryTypeGroupUtils' has a Cyclomatic Complexity of 4 (Highest = 13). 821262
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 831262
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 220
Avoid reassigning parameters such as 'sbEntryGroup' 262
Avoid reassigning parameters such as 'listFormErrors' 297
The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 404 404
The method 'getCurrentIterationEntryErrors' has a Cyclomatic Complexity of 10. 426469
Avoid declaring a variable if it is unreferenced before a possible exit point. 428
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 446
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 447
These nested if statements could be combined 517526
Avoid reassigning parameters such as 'listResponses' 591
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 613
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 614
The method 'orderResponseList' has a Cyclomatic Complexity of 13. 689775
The method 'orderResponseList' has a Standard Cyclomatic Complexity of 12. 689775
The method 'orderResponseList' has a Modified Cyclomatic Complexity of 12. 689775
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 695
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 753
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 966
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 1154
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 1192
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 1194

fr/paris/lutece/plugins/form/utils/FileUtils.java

Violation Line
Rather than using a lot of String arguments, consider using a container object for those values. 82
These nested if statements could be combined 108111
Avoid variables with short names like in 150
Avoid variables with short names like br 162
Avoid variables with short names like fw 196

fr/paris/lutece/plugins/form/utils/FormUtils.java

Violation Line
Possible God class (WMC=192, ATFD=387, TCC=0.0064754856614246065) 341962
A high number of imports can indicate a high degree of coupling within an object. 341962
This class has a bunch of public methods and attributes 341962
The class 'FormUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 17). 1251962
The class 'FormUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 17). 1251962
The class 'FormUtils' has a Cyclomatic Complexity of 4 (Highest = 22). 1251962
Avoid really long classes. 1251962
Avoid excessively long variable names like PROPERTY_NOTIFICATION_MAIL_END_DISPONIBILITY_SUBJECT 187
Avoid excessively long variable names like PROPERTY_NOTIFICATION_MAIL_END_DISPONIBILITY_SENDER_NAME 188
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 233
Avoid variables with short names like t 236
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 245
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 262
Avoid variables with short names like t 286
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 295
The method 'sameDate' has a Cyclomatic Complexity of 10. 467494
Avoid declaring a variable if it is unreferenced before a possible exit point. 553
Avoid declaring a variable if it is unreferenced before a possible exit point. 554
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 627
The method 'getHtmlEntry' has a Standard Cyclomatic Complexity of 17. 752874
The method 'getHtmlEntry' has a Modified Cyclomatic Complexity of 17. 752874
The method getHtmlEntry() has an NPath complexity of 11520 752874
Avoid really long methods. 752874
The method 'getHtmlEntry' has a Cyclomatic Complexity of 22. 752874
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 755
Avoid empty catch blocks 893896
The method 'getResponseEntry' has a Standard Cyclomatic Complexity of 15. 9501064
The method 'getResponseEntry' has a Modified Cyclomatic Complexity of 15. 9501064
The method 'getResponseEntry' has a Cyclomatic Complexity of 17. 9501064
Avoid really long methods. 9501064
The method getResponseEntry() has an NPath complexity of 1444 9501064
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 987
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 988
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1133
The method getXmlResponse() has an NPath complexity of 990 12361304
The method 'getXmlResponse' has a Cyclomatic Complexity of 15. 12361304
Avoid unused method parameters such as 'plugin'. 1236
Position literals first in String comparisons 1322
Avoid using Literals in Conditional Statements 1645
Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.form.service.entrytype.EntryTypeMyLuteceUser' due to existing import 'fr.paris.lutece.plugins.form.service.entrytype.EntryTypeMyLuteceUser' 1749
These nested if statements could be combined 18891892
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 1949
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 1950
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 1951

fr/paris/lutece/plugins/form/web/CategoryJspBean.java

Violation Line
Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 108
Avoid declaring a variable if it is unreferenced before a possible exit point. 201
Avoid declaring a variable if it is unreferenced before a possible exit point. 202
Avoid declaring a variable if it is unreferenced before a possible exit point. 203
Avoid declaring a variable if it is unreferenced before a possible exit point. 205
Avoid declaring a variable if it is unreferenced before a possible exit point. 246
Avoid declaring a variable if it is unreferenced before a possible exit point. 247
The method getCategoryData() has an NPath complexity of 200 356386
Assigning an Object to null is a code smell. Consider refactoring. 358
Assigning an Object to null is a code smell. Consider refactoring. 359

fr/paris/lutece/plugins/form/web/DefaultMessageJspBean.java

Violation Line
Avoid unused imports such as 'java.util.HashMap' 51
Avoid unused imports such as 'java.util.HashMap' 51
The class 'DefaultMessageJspBean' has a Cyclomatic Complexity of 6 (Highest = 14). 62222
The method 'getDefaultMessageData' has a Cyclomatic Complexity of 14. 162221
Avoid declaring a variable if it is unreferenced before a possible exit point. 169

fr/paris/lutece/plugins/form/web/DoDownloadGraph.java

Violation Line
The class 'DoDownloadGraph' has a Cyclomatic Complexity of 10 (Highest = 15). 75200
Private field '_responseService' could be made final; it is only initialized in the declaration or constructor. 83
The method 'doGenerateGraph' has a Cyclomatic Complexity of 15. 94174
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 168

fr/paris/lutece/plugins/form/web/ExportFormatJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34478
The class 'ExportFormatJspBean' has a Cyclomatic Complexity of 4 (Highest = 16). 80478
Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 129
Avoid declaring a variable if it is unreferenced before a possible exit point. 226
Avoid declaring a variable if it is unreferenced before a possible exit point. 227
Avoid declaring a variable if it is unreferenced before a possible exit point. 228
Avoid declaring a variable if it is unreferenced before a possible exit point. 230
Avoid declaring a variable if it is unreferenced before a possible exit point. 271
Avoid declaring a variable if it is unreferenced before a possible exit point. 272
Avoid declaring a variable if it is unreferenced before a possible exit point. 340
The method getExportFormatData() has an NPath complexity of 240 377439
The method 'getExportFormatData' has a Cyclomatic Complexity of 16. 377439
Avoid variables with short names like is 456
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 459

fr/paris/lutece/plugins/form/web/FormAdvancedParametersJspBean.java

Violation Line
Possible God class (WMC=61, ATFD=115, TCC=0.17857142857142858) 34628
A high number of imports can indicate a high degree of coupling within an object. 34628
The class 'FormAdvancedParametersJspBean' has a Modified Cyclomatic Complexity of 7 (Highest = 15). 88628
The class 'FormAdvancedParametersJspBean' has a Cyclomatic Complexity of 8 (Highest = 15). 88628
The class 'FormAdvancedParametersJspBean' has a Standard Cyclomatic Complexity of 7 (Highest = 15). 88628
The method 'getViewModifyFormAdvancedParameters' has a Cyclomatic Complexity of 13. 167265
The method 'getViewModifyFormAdvancedParameters' has a Modified Cyclomatic Complexity of 10. 167265
The method 'getViewModifyFormAdvancedParameters' has a Standard Cyclomatic Complexity of 10. 167265
The method getViewModifyFormAdvancedParameters() has an NPath complexity of 252 167265
Avoid declaring a variable if it is unreferenced before a possible exit point. 169
Avoid declaring a variable if it is unreferenced before a possible exit point. 172
Avoid declaring a variable if it is unreferenced before a possible exit point. 173
Deeply nested if..then statements are hard to read 240244
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 250
The method 'manageAdvancedParameters' has a Cyclomatic Complexity of 12. 339385
The method 'getFormAdvancedParametersData' has a Modified Cyclomatic Complexity of 15. 396511
The method 'getFormAdvancedParametersData' has a Cyclomatic Complexity of 15. 396511
Avoid really long methods. 396511
The method 'getFormAdvancedParametersData' has a Standard Cyclomatic Complexity of 15. 396511
The method getFormAdvancedParametersData() has an NPath complexity of 12288 396511
Avoid declaring a variable if it is unreferenced before a possible exit point. 398
Avoid declaring a variable if it is unreferenced before a possible exit point. 399
Avoid declaring a variable if it is unreferenced before a possible exit point. 400
Avoid declaring a variable if it is unreferenced before a possible exit point. 401
Avoid declaring a variable if it is unreferenced before a possible exit point. 402
Avoid declaring a variable if it is unreferenced before a possible exit point. 403
Avoid declaring a variable if it is unreferenced before a possible exit point. 404
Avoid declaring a variable if it is unreferenced before a possible exit point. 407
Avoid declaring a variable if it is unreferenced before a possible exit point. 408
Avoid declaring a variable if it is unreferenced before a possible exit point. 409
Avoid declaring a variable if it is unreferenced before a possible exit point. 410
Avoid declaring a variable if it is unreferenced before a possible exit point. 411
Avoid declaring a variable if it is unreferenced before a possible exit point. 412
Avoid declaring a variable if it is unreferenced before a possible exit point. 413
Avoid declaring a variable if it is unreferenced before a possible exit point. 414
Avoid declaring a variable if it is unreferenced before a possible exit point. 415

fr/paris/lutece/plugins/form/web/FormApp.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 341360
Possible God class (WMC=131, ATFD=252, TCC=0.042328042328042326) 341360
The class 'FormApp' has a Standard Cyclomatic Complexity of 4 (Highest = 14). 1131360
The class 'FormApp' has a Modified Cyclomatic Complexity of 4 (Highest = 14). 1131360
Avoid really long classes. 1131360
The class 'FormApp' has a Cyclomatic Complexity of 5 (Highest = 22). 1131360
Avoid excessively long variable names like PROPERTY_CLEAN_FORM_ANSWERS_RETURN_CODE_UNAUTHORIZED 153
Avoid declaring a variable if it is unreferenced before a possible exit point. 210
Avoid declaring a variable if it is unreferenced before a possible exit point. 211
Avoid declaring a variable if it is unreferenced before a possible exit point. 245
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 370
Avoid reassigning parameters such as 'strSessionId' 461
The method 'getResult' has a Cyclomatic Complexity of 18. 638726
The method 'getResult' has a Standard Cyclomatic Complexity of 11. 638726
The method 'getResult' has a Modified Cyclomatic Complexity of 11. 638726
The method getResult() has an NPath complexity of 432 638726
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 715
The method getForm() has an NPath complexity of 288 790874
The method 'getForm' has a Cyclomatic Complexity of 10. 790874
Avoid declaring a variable if it is unreferenced before a possible exit point. 792
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 794
Avoid declaring a variable if it is unreferenced before a possible exit point. 794
Prefer StringBuffer over += for concatenating strings 852
Avoid really long methods. 8871046
The method 'getRecap' has a Standard Cyclomatic Complexity of 14. 8871046
The method getRecap() has an NPath complexity of 24192 8871046
The method 'getRecap' has a Modified Cyclomatic Complexity of 14. 8871046
The method 'getRecap' has a Cyclomatic Complexity of 22. 8871046
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 891
Avoid declaring a variable if it is unreferenced before a possible exit point. 891
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1060
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1118
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1186
These nested if statements could be combined 12261230
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1279

fr/paris/lutece/plugins/form/web/FormDashboardComponent.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 110
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 115
Do not add empty strings 134
Avoid variables with short names like t 160

fr/paris/lutece/plugins/form/web/FormEntryJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 341848
The class 'FormEntryJspBean' has a Standard Cyclomatic Complexity of 6 (Highest = 15). 801848
Avoid really long classes. 801848
The class 'FormEntryJspBean' has a Modified Cyclomatic Complexity of 6 (Highest = 15). 801848
The class 'FormEntryJspBean' has a Cyclomatic Complexity of 8 (Highest = 19). 801848
Avoid declaring a variable if it is unreferenced before a possible exit point. 171
Avoid declaring a variable if it is unreferenced before a possible exit point. 174
Avoid declaring a variable if it is unreferenced before a possible exit point. 175
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 211
The method 'doCreateEntry' has a Standard Cyclomatic Complexity of 10. 242308
The method doCreateEntry() has an NPath complexity of 208 242308
The method 'doCreateEntry' has a Modified Cyclomatic Complexity of 10. 242308
The method 'doCreateEntry' has a Cyclomatic Complexity of 12. 242308
The method 'getModifyEntry' has a Cyclomatic Complexity of 10. 317396
Avoid declaring a variable if it is unreferenced before a possible exit point. 319
Avoid declaring a variable if it is unreferenced before a possible exit point. 320
Avoid declaring a variable if it is unreferenced before a possible exit point. 321
Avoid declaring a variable if it is unreferenced before a possible exit point. 324
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 361
The method doModifyEntry() has an NPath complexity of 324 405474
The method 'doModifyEntry' has a Modified Cyclomatic Complexity of 11. 405474
The method 'doModifyEntry' has a Standard Cyclomatic Complexity of 11. 405474
The method 'doModifyEntry' has a Cyclomatic Complexity of 13. 405474
Avoid declaring a variable if it is unreferenced before a possible exit point. 407
Avoid declaring a variable if it is unreferenced before a possible exit point. 485
Avoid declaring a variable if it is unreferenced before a possible exit point. 487
Avoid declaring a variable if it is unreferenced before a possible exit point. 489
Avoid declaring a variable if it is unreferenced before a possible exit point. 543
Avoid declaring a variable if it is unreferenced before a possible exit point. 545
Avoid declaring a variable if it is unreferenced before a possible exit point. 547
Avoid declaring a variable if it is unreferenced before a possible exit point. 620
Avoid declaring a variable if it is unreferenced before a possible exit point. 622
Avoid declaring a variable if it is unreferenced before a possible exit point. 674
Avoid declaring a variable if it is unreferenced before a possible exit point. 675
Avoid declaring a variable if it is unreferenced before a possible exit point. 676
Avoid declaring a variable if it is unreferenced before a possible exit point. 677
Avoid declaring a variable if it is unreferenced before a possible exit point. 680
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 713
Avoid declaring a variable if it is unreferenced before a possible exit point. 733
Avoid declaring a variable if it is unreferenced before a possible exit point. 734
Avoid declaring a variable if it is unreferenced before a possible exit point. 735
Avoid declaring a variable if it is unreferenced before a possible exit point. 738
Avoid declaring a variable if it is unreferenced before a possible exit point. 795
Avoid declaring a variable if it is unreferenced before a possible exit point. 796
The method 'doChangeOrderEntry' has a Modified Cyclomatic Complexity of 15. 9151045
Avoid really long methods. 9151045
The method 'doChangeOrderEntry' has a Standard Cyclomatic Complexity of 15. 9151045
The method 'doChangeOrderEntry' has a Cyclomatic Complexity of 19. 9151045
The method 'moveDownEntryOrder' has a Standard Cyclomatic Complexity of 13. 10591154
The method 'moveDownEntryOrder' has a Modified Cyclomatic Complexity of 13. 10591154
The method 'moveDownEntryOrder' has a Cyclomatic Complexity of 16. 10591154
Avoid unused method parameters such as 'plugin'. 1059
The method 'moveUpEntryOrder' has a Cyclomatic Complexity of 13. 11681246
The method 'moveUpEntryOrder' has a Modified Cyclomatic Complexity of 10. 11681246
The method 'moveUpEntryOrder' has a Standard Cyclomatic Complexity of 10. 11681246
Avoid unused method parameters such as 'plugin'. 1168
The method 'doMoveEntryConditional' has a Cyclomatic Complexity of 10. 12571324
The method doMoveEntryConditional() has an NPath complexity of 480 12571324
Avoid declaring a variable if it is unreferenced before a possible exit point. 1259
Avoid declaring a variable if it is unreferenced before a possible exit point. 1263
Avoid declaring a variable if it is unreferenced before a possible exit point. 1383
Avoid declaring a variable if it is unreferenced before a possible exit point. 1384
Avoid declaring a variable if it is unreferenced before a possible exit point. 1385
Avoid declaring a variable if it is unreferenced before a possible exit point. 1388
Avoid declaring a variable if it is unreferenced before a possible exit point. 1456
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1467
Avoid declaring a variable if it is unreferenced before a possible exit point. 1503
Avoid declaring a variable if it is unreferenced before a possible exit point. 1504
Avoid declaring a variable if it is unreferenced before a possible exit point. 1505
Avoid declaring a variable if it is unreferenced before a possible exit point. 1506
Avoid declaring a variable if it is unreferenced before a possible exit point. 1683
Avoid declaring a variable if it is unreferenced before a possible exit point. 1723
Avoid declaring a variable if it is unreferenced before a possible exit point. 1724
Avoid declaring a variable if it is unreferenced before a possible exit point. 1725
Avoid declaring a variable if it is unreferenced before a possible exit point. 1726
Avoid declaring a variable if it is unreferenced before a possible exit point. 1780
Avoid declaring a variable if it is unreferenced before a possible exit point. 1781
Avoid declaring a variable if it is unreferenced before a possible exit point. 1782
Avoid declaring a variable if it is unreferenced before a possible exit point. 1783

fr/paris/lutece/plugins/form/web/FormJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 342062
Possible God class (WMC=214, ATFD=290, TCC=0.22672672672672672) 342062
Avoid unused imports such as 'java.io.File' 37
Avoid unused imports such as 'java.io.File' 37
Avoid unused imports such as 'java.io.FileInputStream' 38
Avoid unused imports such as 'java.io.FileInputStream' 38
Avoid unused imports such as 'java.io.FileOutputStream' 39
Avoid unused imports such as 'java.io.FileOutputStream' 39
Abstract classes should be named AbstractXXX 1252062
The class 'FormJspBean' has a Standard Cyclomatic Complexity of 5 (Highest = 16). 1252062
Avoid really long classes. 1252062
The class 'FormJspBean' has a Cyclomatic Complexity of 6 (Highest = 17). 1252062
The class 'FormJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 16). 1252062
Avoid excessively long variable names like MESSAGE_CANT_ENABLE_FORM_DATE_END_DISPONIBILITY_BEFORE_CURRENT_DATE 166
The method 'getManageForm' has a Cyclomatic Complexity of 10. 292399
Avoid really long methods. 292399
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 350
Avoid declaring a variable if it is unreferenced before a possible exit point. 514
Avoid declaring a variable if it is unreferenced before a possible exit point. 516
Avoid declaring a variable if it is unreferenced before a possible exit point. 567
Avoid declaring a variable if it is unreferenced before a possible exit point. 568
Avoid declaring a variable if it is unreferenced before a possible exit point. 569
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 615
Avoid declaring a variable if it is unreferenced before a possible exit point. 634
Avoid declaring a variable if it is unreferenced before a possible exit point. 635
Avoid declaring a variable if it is unreferenced before a possible exit point. 636
Avoid declaring a variable if it is unreferenced before a possible exit point. 637
Avoid declaring a variable if it is unreferenced before a possible exit point. 682
Avoid declaring a variable if it is unreferenced before a possible exit point. 685
Avoid declaring a variable if it is unreferenced before a possible exit point. 686
Avoid declaring a variable if it is unreferenced before a possible exit point. 687
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 714
The method 'getRecapData' has a Cyclomatic Complexity of 15. 737850
Avoid really long methods. 737850
The method 'getRecapData' has a Standard Cyclomatic Complexity of 12. 737850
The method 'getRecapData' has a Modified Cyclomatic Complexity of 12. 737850
The method getRecapData() has an NPath complexity of 980 737850
Avoid declaring a variable if it is unreferenced before a possible exit point. 739
Avoid declaring a variable if it is unreferenced before a possible exit point. 740
Avoid declaring a variable if it is unreferenced before a possible exit point. 743
Avoid declaring a variable if it is unreferenced before a possible exit point. 744
Avoid declaring a variable if it is unreferenced before a possible exit point. 745
Avoid declaring a variable if it is unreferenced before a possible exit point. 746
Avoid declaring a variable if it is unreferenced before a possible exit point. 750
Avoid declaring a variable if it is unreferenced before a possible exit point. 751
Avoid declaring a variable if it is unreferenced before a possible exit point. 934
Avoid declaring a variable if it is unreferenced before a possible exit point. 936
Avoid declaring a variable if it is unreferenced before a possible exit point. 1013
Avoid declaring a variable if it is unreferenced before a possible exit point. 1014
Avoid declaring a variable if it is unreferenced before a possible exit point. 1085
Avoid declaring a variable if it is unreferenced before a possible exit point. 1086
Avoid unused method parameters such as 'plugin'. 1155
Avoid unused method parameters such as 'locale'. 1178
The method 'getResult' has a Modified Cyclomatic Complexity of 13. 11981299
The method 'getResult' has a Standard Cyclomatic Complexity of 13. 11981299
The method getResult() has an NPath complexity of 12000 11981299
Avoid really long methods. 11981299
The method 'getResult' has a Cyclomatic Complexity of 15. 11981299
Avoid declaring a variable if it is unreferenced before a possible exit point. 1200
Avoid declaring a variable if it is unreferenced before a possible exit point. 1202
Avoid declaring a variable if it is unreferenced before a possible exit point. 1203
Avoid declaring a variable if it is unreferenced before a possible exit point. 1204
Avoid declaring a variable if it is unreferenced before a possible exit point. 1205
Avoid declaring a variable if it is unreferenced before a possible exit point. 1206
Avoid declaring a variable if it is unreferenced before a possible exit point. 1208
Avoid declaring a variable if it is unreferenced before a possible exit point. 1213
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1285
Assigning an Object to null is a code smell. Consider refactoring. 1289
Assigning an Object to null is a code smell. Consider refactoring. 1291
Avoid really long methods. 13101418
The method 'doExportResult' has a Standard Cyclomatic Complexity of 11. 13101418
The method 'doExportResult' has a Modified Cyclomatic Complexity of 11. 13101418
The method doExportResult() has an NPath complexity of 961 13101418
The method 'doExportResult' has a Cyclomatic Complexity of 16. 13101418
Avoid declaring a variable if it is unreferenced before a possible exit point. 1314
Avoid declaring a variable if it is unreferenced before a possible exit point. 1335
Avoid declaring a variable if it is unreferenced before a possible exit point. 1336
Avoid declaring a variable if it is unreferenced before a possible exit point. 1337
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1380
The method doGenerateGraph() has an NPath complexity of 3840 14291549
Avoid really long methods. 14291549
The method 'doGenerateGraph' has a Modified Cyclomatic Complexity of 16. 14291549
The method 'doGenerateGraph' has a Cyclomatic Complexity of 17. 14291549
The method 'doGenerateGraph' has a Standard Cyclomatic Complexity of 16. 14291549
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1508
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1545
The method 'doDownloadFile' has a Cyclomatic Complexity of 12. 15601631
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1598
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1599
Avoid variables with short names like os 1615
Avoid declaring a variable if it is unreferenced before a possible exit point. 1644
The method 'doManageOutputProcessor' has a Modified Cyclomatic Complexity of 12. 17011771
The method 'doManageOutputProcessor' has a Cyclomatic Complexity of 16. 17011771
The method 'doManageOutputProcessor' has a Standard Cyclomatic Complexity of 12. 17011771
Avoid declaring a variable if it is unreferenced before a possible exit point. 1707
Avoid declaring a variable if it is unreferenced before a possible exit point. 1708
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1816
The method 'doModifyMessage' has a Cyclomatic Complexity of 15. 18351908
The method 'doModifyMessage' has a Standard Cyclomatic Complexity of 10. 18351908
The method 'doModifyMessage' has a Modified Cyclomatic Complexity of 10. 18351908
Avoid declaring a variable if it is unreferenced before a possible exit point. 1865
Avoid declaring a variable if it is unreferenced before a possible exit point. 1869
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1950

fr/paris/lutece/plugins/form/web/FormSessionListener.java

Violation Line
Avoid variables with short names like se 52
Avoid variables with short names like se 61

fr/paris/lutece/plugins/form/web/ModifyFormJspBean.java

Violation Line
Possible God class (WMC=100, ATFD=190, TCC=0.15204678362573099) 341054
A high number of imports can indicate a high degree of coupling within an object. 341054
Abstract classes should be named AbstractXXX 961054
The class 'ModifyFormJspBean' has a Cyclomatic Complexity of 5 (Highest = 13). 961054
Private field '_entryTypeService' could be made final; it is only initialized in the declaration or constructor. 182
Avoid declaring a variable if it is unreferenced before a possible exit point. 204
Avoid declaring a variable if it is unreferenced before a possible exit point. 206
Avoid declaring a variable if it is unreferenced before a possible exit point. 257
Avoid really long methods. 325431
Avoid declaring a variable if it is unreferenced before a possible exit point. 327
Avoid declaring a variable if it is unreferenced before a possible exit point. 328
Avoid declaring a variable if it is unreferenced before a possible exit point. 329
Avoid declaring a variable if it is unreferenced before a possible exit point. 330
Avoid declaring a variable if it is unreferenced before a possible exit point. 331
Avoid declaring a variable if it is unreferenced before a possible exit point. 334
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 365
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 373
The String literal "?id_form=" appears 4 times in this file; the first occurrence is on line 387 387
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 411
Avoid declaring a variable if it is unreferenced before a possible exit point. 492
Avoid declaring a variable if it is unreferenced before a possible exit point. 495
Avoid declaring a variable if it is unreferenced before a possible exit point. 496
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 519
Avoid declaring a variable if it is unreferenced before a possible exit point. 593
Avoid declaring a variable if it is unreferenced before a possible exit point. 594
Avoid declaring a variable if it is unreferenced before a possible exit point. 597
Avoid declaring a variable if it is unreferenced before a possible exit point. 598
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 629
The method 'doModifyFormAnswersManagement' has a Cyclomatic Complexity of 10. 647704
Avoid declaring a variable if it is unreferenced before a possible exit point. 808
The method 'getFormPublicationData' has a Cyclomatic Complexity of 13. 866926
Avoid unused method parameters such as 'plugin'. 975

fr/paris/lutece/plugins/form/web/TestFormJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34529
The class 'TestFormJspBean' has a Cyclomatic Complexity of 6 (Highest = 17). 88529
The class 'TestFormJspBean' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 88529
The class 'TestFormJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 13). 88529
The method 'doSubmitForm' has a Modified Cyclomatic Complexity of 13. 275397
The method 'doSubmitForm' has a Standard Cyclomatic Complexity of 13. 275397
The method 'doSubmitForm' has a Cyclomatic Complexity of 17. 275397
The method doSubmitForm() has an NPath complexity of 2592 275397
Avoid really long methods. 275397
Avoid declaring a variable if it is unreferenced before a possible exit point. 277
Avoid declaring a variable if it is unreferenced before a possible exit point. 278
Avoid declaring a variable if it is unreferenced before a possible exit point. 279
Avoid declaring a variable if it is unreferenced before a possible exit point. 280
Avoid declaring a variable if it is unreferenced before a possible exit point. 282
Avoid declaring a variable if it is unreferenced before a possible exit point. 283
Avoid declaring a variable if it is unreferenced before a possible exit point. 286
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 392
The method 'doExportResponses' has a Cyclomatic Complexity of 11. 409480
Avoid declaring a variable if it is unreferenced before a possible exit point. 413
Avoid declaring a variable if it is unreferenced before a possible exit point. 414
Avoid declaring a variable if it is unreferenced before a possible exit point. 420
Avoid declaring a variable if it is unreferenced before a possible exit point. 421
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 447
Avoid variables with short names like os 464
Prefer StringBuffer over += for concatenating strings 516
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 520

fr/paris/lutece/plugins/form/web/http/GroupHttpServletRequestWrapper.java

Violation Line
Returning '_strIterationParameterName' may expose an internal array. 71

fr/paris/lutece/plugins/form/web/http/GroupMultipartHttpServletRequestWrapper.java

Violation Line
Returning '_strIterationParameterName' may expose an internal array. 64