The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 73 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 74 |
| FormalParameterNamingConventions | The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' | 85 |
| LocalVariableNamingConventions | The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' | 107 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 110 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–248 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 48–248 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 51 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 64 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 90 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 91 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 119–124 |
| CollapsibleIfStatements | These nested if statements could be combined | 119–124 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 148 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 149 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 71–74 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 233–235 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 51–174 |
| CommentRequired | Header comments are required | 51–174 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 119 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 119 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 125 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 137 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 169 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–501 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_GEOJSON'. | 171 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_ID'. | 172 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_FIELDCODE'. | 173 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_TYPE'. | 174 |
| CommentRequired | Public method and constructor comments are required | 186–206 |
| CommentRequired | Public method and constructor comments are required | 210–275 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 219 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 236 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 236 |
| UnusedLocalVariable | Avoid unused local variables such as 'nCurrentItemsPerPage'. | 236 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 238 |
| AddEmptyString | Do not add empty strings | 264 |
| CommentRequired | Public method and constructor comments are required | 279–320 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 283 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 322 |
| CommentRequired | Public method and constructor comments are required | 323–374 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 332 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 351 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 384 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 388 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 466–473 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 69–254 |
| UnusedPrivateField | Avoid unused private fields such as 'TEMPLATE_CREATE_FORMSREPONSEEDITO'. | 77 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_PAGE_TITLE_CREATE_FORMSREPONSEEDITO'. | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_CONFIRM_REMOVE_FORMSREPONSEEDITO'. | 95 |
| UnusedPrivateField | Avoid unused private fields such as 'VIEW_CREATE_FORMSREPONSEEDITO'. | 102 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_CREATE_FORMSREPONSEEDITO'. | 106 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_REMOVE_FORMSREPONSEEDITO'. | 108 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_CONFIRM_REMOVE_FORMSREPONSEEDITO'. | 109 |
| UnusedPrivateField | Avoid unused private fields such as 'INFO_FORMSREPONSEEDITO_CREATED'. | 112 |
| UnusedPrivateField | Avoid unused private fields such as 'INFO_FORMSREPONSEEDITO_REMOVED'. | 114 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 122 |
| UnusedPrivateField | Avoid unused private fields such as '_optionOrderBy'. | 123 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 130 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 133 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 173–182 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 174–182 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 184–187 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 185–187 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 38 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Size' | 36 |
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotEmpty' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 36 |
| UnusedImports | Avoid unused imports such as 'java.util.Map.Entry' | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItem' | 57 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.service.IconService' | 58 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.indexer.SolrItem' | 61 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AdminUserService' | 83 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.search.SearchResult' | 88 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.DelegatePaginator' | 102 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.IPaginator' | 103 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' | 39 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' | 47 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 4 | 38 |
| CommentRequired | Header comments are required | 3 | 48–248 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 48–248 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 51 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 3 | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 3 | 64 |
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 73 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 74 |
| FormalParameterNamingConventions | The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 85 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 90 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 91 |
| LocalVariableNamingConventions | The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 107 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 119–124 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 119–124 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 148 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 149 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Size' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotEmpty' | 4 | 37 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 71–74 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 233–235 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 4 | 37 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 51–174 |
| CommentRequired | Header comments are required | 3 | 51–174 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 119 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 119 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 125 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 137 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 169 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–501 |
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'java.util.Map.Entry' | 4 | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItem' | 4 | 57 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.service.IconService' | 4 | 58 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.indexer.SolrItem' | 4 | 61 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AdminUserService' | 4 | 83 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.search.SearchResult' | 4 | 88 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.DelegatePaginator' | 4 | 102 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.IPaginator' | 4 | 103 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_GEOJSON'. | 3 | 171 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_ID'. | 3 | 172 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_FIELDCODE'. | 3 | 173 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_TYPE'. | 3 | 174 |
| CommentRequired | Public method and constructor comments are required | 3 | 186–206 |
| CommentRequired | Public method and constructor comments are required | 3 | 210–275 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 219 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 236 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 236 |
| UnusedLocalVariable | Avoid unused local variables such as 'nCurrentItemsPerPage'. | 3 | 236 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 238 |
| AddEmptyString | Do not add empty strings | 3 | 264 |
| CommentRequired | Public method and constructor comments are required | 3 | 279–320 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 283 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 322 |
| CommentRequired | Public method and constructor comments are required | 3 | 323–374 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 332 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 351 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 384 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 388 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 466–473 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' | 4 | 39 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' | 4 | 47 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 69–254 |
| UnusedPrivateField | Avoid unused private fields such as 'TEMPLATE_CREATE_FORMSREPONSEEDITO'. | 3 | 77 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_PAGE_TITLE_CREATE_FORMSREPONSEEDITO'. | 3 | 86 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_CONFIRM_REMOVE_FORMSREPONSEEDITO'. | 3 | 95 |
| UnusedPrivateField | Avoid unused private fields such as 'VIEW_CREATE_FORMSREPONSEEDITO'. | 3 | 102 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_CREATE_FORMSREPONSEEDITO'. | 3 | 106 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_REMOVE_FORMSREPONSEEDITO'. | 3 | 108 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_CONFIRM_REMOVE_FORMSREPONSEEDITO'. | 3 | 109 |
| UnusedPrivateField | Avoid unused private fields such as 'INFO_FORMSREPONSEEDITO_CREATED'. | 3 | 112 |
| UnusedPrivateField | Avoid unused private fields such as 'INFO_FORMSREPONSEEDITO_REMOVED'. | 3 | 114 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 122 |
| UnusedPrivateField | Avoid unused private fields such as '_optionOrderBy'. | 3 | 123 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 130 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 133 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 173–182 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 174–182 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 184–187 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 185–187 |
