Résultats PMD
Le document suivant contient les résultats de PMD 5.5.1.
Fichiers
fr/paris/lutece/plugins/franceconnect/oidc/IDToken.java
Violation |
Ligne |
StringBuffer constructor is initialized with size 16, but has at least 103 characters appended. |
201 |
fr/paris/lutece/plugins/franceconnect/oidc/Token.java
Violation |
Ligne |
StringBuffer constructor is initialized with size 16, but has at least 86 characters appended. |
160 |
fr/paris/lutece/plugins/franceconnect/oidc/UserInfo.java
Violation |
Ligne |
Possible God class (WMC=50, ATFD=6, TCC=0.0236734693877551) |
34–564 |
This class has a bunch of public methods and attributes |
34–564 |
Too many fields |
46–564 |
fr/paris/lutece/plugins/franceconnect/oidc/dataclient/AbstractDataClient.java
Violation |
Ligne |
The Logger variable declaration does not contain the static and final modifiers |
54 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
244 |
fr/paris/lutece/plugins/franceconnect/oidc/dataclient/UserInfoDataClient.java
Violation |
Ligne |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
61 |
fr/paris/lutece/plugins/franceconnect/oidc/jwt/JjwtJWTParser.java
Violation |
Ligne |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
90 |
fr/paris/lutece/plugins/franceconnect/oidc/jwt/MitreJWTParser.java
Violation |
Ligne |
The class 'MitreJWTParser' has a Modified Cyclomatic Complexity of 25 (Highest = 24). |
63–300 |
The class 'MitreJWTParser' has a Standard Cyclomatic Complexity of 25 (Highest = 24). |
63–300 |
The class 'MitreJWTParser' has a Cyclomatic Complexity of 27 (Highest = 26). |
63–300 |
Private field '_nTimeSkewAllowance' could be made final; it is only initialized in the declaration or constructor. |
66 |
The method 'parseJWT' has a Modified Cyclomatic Complexity of 24. |
72–299 |
The method parseJWT() has an NPath complexity of 1119744 |
72–299 |
The method 'parseJWT' has a Cyclomatic Complexity of 26. |
72–299 |
Avoid really long methods. |
72–299 |
The method 'parseJWT' has a Standard Cyclomatic Complexity of 24. |
72–299 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
76 |
These nested if statements could be combined |
105–109 |
The String literal " got " appears 4 times in this file; the first occurrence is on line 174 |
174 |
New exception is thrown in catch block, original stack trace may be lost |
240 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
296 |
fr/paris/lutece/plugins/franceconnect/service/BearerTokenAuthenticator.java
Violation |
Ligne |
Private field '_strAccessToken' could be made final; it is only initialized in the declaration or constructor. |
52 |
fr/paris/lutece/plugins/franceconnect/service/DataClientService.java
Violation |
Ligne |
The Logger variable declaration does not contain the static and final modifiers |
55 |
Use block level rather than method level synchronization |
67–76 |
fr/paris/lutece/plugins/franceconnect/service/MapperService.java
Violation |
Ligne |
Avoid variables with short names like t |
68 |
fr/paris/lutece/plugins/franceconnect/service/TokenService.java
Violation |
Ligne |
The Logger variable declaration does not contain the static and final modifiers |
58 |
Use explicit scoping instead of the default package private level |
98–101 |
fr/paris/lutece/plugins/franceconnect/web/CallbackHandler.java
Violation |
Ligne |
The Logger variable declaration does not contain the static and final modifiers |
74 |
Use explicit scoping instead of the default package private level |
115–132 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
188 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
258 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
272 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
275 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
322 |
fr/paris/lutece/plugins/franceconnect/web/OAuthLogoutServlet.java
Violation |
Ligne |
The Logger variable declaration does not contain the static and final modifiers |
55 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
73 |