The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'CartoProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 46–92 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'MapProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 46–92 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'OcrProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 46–92 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 47–108 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 56–59 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 64–67 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 73–76 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 102–105 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 160–163 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'FIELD_BEGIN_HOUR' doesn't match '_[a-z][a-zA-Z0-9]*' | 21 |
| FieldNamingConventions | The field name 'FIELD_END_HOUR' doesn't match '_[a-z][a-zA-Z0-9]*' | 22 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 369–372 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 66–69 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 75–78 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 102–105 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 120–123 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'EntryTypeServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 43–75 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 40–88 |
| FieldNamingConventions | The constant name '_instance' doesn't match '[A-Z][A-Z_0-9]*' | 42 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_oldEntryId' doesn't match '[a-z][a-zA-Z0-9]*' | 43 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_valuesMap' doesn't match '[a-z][a-zA-Z0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| ProperCloneImplementation | Object clone() should be implemented with super.clone() | 500 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–601 |
| GodClass | Possible God Class (WMC=53, ATFD=12, TCC=1.333%) | 48–601 |
| TooManyFields | Too many fields | 48–601 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 500–512 |
| CloneThrowsCloneNotSupportedException | clone() method should throw CloneNotSupportedException | 500–512 |
| CommentRequired | Public method and constructor comments are required | 514–517 |
| CommentRequired | Public method and constructor comments are required | 519–522 |
| CommentRequired | Public method and constructor comments are required | 524–527 |
| CommentRequired | Public method and constructor comments are required | 529–532 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 53–768 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 113–120 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 131–138 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 237–244 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 262–269 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 274–281 |
| CyclomaticComplexity | The method 'selectEntryListByFilter(EntryFilter, Plugin)' has a cyclomatic complexity of 12. | 297–379 |
| NPathComplexity | The method 'selectEntryListByFilter(EntryFilter, Plugin)' has an NPath complexity of 2050 | 297–379 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 314 |
| ShortVariable | Avoid variables with short names like sb | 381 |
| CyclomaticComplexity | The method 'selectNumberEntryByFilter(EntryFilter, Plugin)' has a cyclomatic complexity of 10. | 390–461 |
| NPathComplexity | The method 'selectNumberEntryByFilter(EntryFilter, Plugin)' has an NPath complexity of 513 | 390–461 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 404 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 584–608 |
| AssignmentInOperand | Avoid assignments in operands | 667 |
| AssignmentInOperand | Avoid assignments in operands | 682 |
| AssignmentInOperand | Avoid assignments in operands | 692 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 729 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–377 |
| CommentRequired | Public method and constructor comments are required | 363–366 |
| CommentRequired | Public method and constructor comments are required | 368–371 |
| CommentRequired | Public method and constructor comments are required | 373–376 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 54–394 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 99 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'entryChild' | 115 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 134 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 202 |
| NonThreadSafeSingleton | Singleton is not thread safe | 359–362 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 67–70 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 53–358 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 103–129 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 116 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 119 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like id | 74 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 117 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 197–200 |
| NonThreadSafeSingleton | Singleton is not thread safe | 302–305 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strFileName' could be made final; it is only initialized in the declaration or constructor. | 54 |
| ArrayIsStoredDirectly | The user-supplied array 'bValue' is stored directly. | 67 |
| ArrayIsStoredDirectly | The user-supplied array 'bValue' is stored directly. | 83 |
| ArrayIsStoredDirectly | The user-supplied array 'bValue' is stored directly. | 102 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 116 |
| MethodReturnsInternalArray | Returning '_bValue' may expose an internal array. | 125 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like y | 99 |
| ShortVariable | Avoid variables with short names like x | 99 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 45–191 |
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 135 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–70 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 84–123 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 94–101 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 103–110 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 174–181 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 183–190 |
| NPathComplexity | The method 'selectListByFilter(ResponseFilter, Plugin)' has an NPath complexity of 16640 | 204–286 |
| CyclomaticComplexity | The method 'selectListByFilter(ResponseFilter, Plugin)' has a cyclomatic complexity of 15. | 204–286 |
| ShortVariable | Avoid variables with short names like sb | 237 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 238 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 239 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 243 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 244 |
| ShortVariable | Avoid variables with short names like s | 397 |
| ShortVariable | Avoid variables with short names like sb | 404 |
| ShortVariable | Avoid variables with short names like c | 408 |
| CollapsibleIfStatements | These nested if statements could be combined | 413–417 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 83 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 111 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 144 |
| NonThreadSafeSingleton | Singleton is not thread safe | 209–212 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–101 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like se | 51 |
| ShortVariable | Avoid variables with short names like se | 60 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–96 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–63 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–90 |
| ImmutableField | Private field '_wildcard' could be made final; it is only initialized in the declaration or constructor. | 43 |
| ImmutableField | Private field '_helpKey' could be made final; it is only initialized in the declaration or constructor. | 44 |
| ImmutableField | Private field '_serviceName' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 69–91 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–55 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–57 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 69 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 98–114 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 432 | 83–185 |
| ExcessiveMethodLength | Avoid really long methods. | 83–185 |
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 83–185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 88 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 95 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 97 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 99 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 101 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 102 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 103 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 10. | 191–233 |
| ShortVariable | Avoid variables with short names like dt | 253 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 253 |
| ShortVariable | Avoid variables with short names like c | 258 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 277–284 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 385 |
| UseUnderscoresInNumericLiterals | Number 5242880 should separate every third digit with an underscore | 391 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 397 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_SPECIFY_BOTH_X_AND_Y'. | 109 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 11. | 173–239 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 189–200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 193–200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 268–275 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 293 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 75 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 76 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 80 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 139–151 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 53–134 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 71–74 |
| CommentRequired | Protected method constructor comments are required | 83–133 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| CommentRequired | Protected method constructor comments are required | 131–134 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 75 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 76 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 80 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 118 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveMethodLength | Avoid really long methods. | 74–176 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 19. | 74–176 |
| NPathComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has an NPath complexity of 7410 | 74–176 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 93 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 202–205 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 166 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 167 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 169 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 170 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 171 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 172 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 173 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 124 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 127 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
| NPathComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has an NPath complexity of 27648 | 190–321 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 19. | 190–321 |
| ExcessiveMethodLength | Avoid really long methods. | 190–321 |
| NcssCount | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a NCSS line count of 91. | 190–321 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 195–201 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 202–207 |
| CollapsibleIfStatements | These nested if statements could be combined | 316–318 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 386–389 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 410 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–123 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 12. | 66–137 |
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 2048 | 66–137 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 75 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 76 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 83 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 132 |
| ShortVariable | Avoid variables with short names like sb | 234 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 68 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 75 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 66 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 67 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 67 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| ShortVariable | Avoid variables with short names like id | 124 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 69 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 178 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 74 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 15–148 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 21 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the FIELD_BEGIN_HOUR field if you want a default access modifier | 21 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 22 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the FIELD_END_HOUR field if you want a default access modifier | 22 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 32 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 33 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 33 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 34 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 35 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 36 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 37 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 38 |
| CommentRequired | Protected method constructor comments are required | 122–133 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 81 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 83 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 84 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 85 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 87 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 90 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 135 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 13. | 147–234 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 18. | 74–201 |
| ExcessiveMethodLength | Avoid really long methods. | 74–201 |
| NcssCount | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a NCSS line count of 72. | 74–201 |
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 13824 | 74–201 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 77 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 84 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 87 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 92 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 100 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 101 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 175 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 247 |
| CyclomaticComplexity | The method 'checkErrors(Entry, Field, String, String, List, boolean, Locale)' has a cyclomatic complexity of 13. | 274–331 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveMethodLength | Avoid really long methods. | 66–174 |
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 768 | 66–174 |
| NcssCount | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a NCSS line count of 61. | 66–174 |
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 12. | 66–174 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 84 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 85 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 86 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 168 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–432 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 165–168 |
| CyclomaticComplexity | The method 'getResponseValueForExport(Entry, HttpServletRequest, Response, Locale)' has a cyclomatic complexity of 10. | 180–214 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 196–205 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 303 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 303 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 304 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 305 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 306 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 307 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 308 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 309 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Protected method constructor comments are required | 160–180 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The method 'canUploadFiles' indicates linguistically it returns a boolean, but it returns 'GenericAttributeError' | 288 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–88 |
| ImmutableField | Private field '_fileStoreServiceProvider' could be made final; it is only initialized in the declaration or constructor. | 43 |
| CommentRequired | Public method and constructor comments are required | 49–52 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 104–107 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 45–48 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 56–59 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 61–74 |
| CommentRequired | Public method and constructor comments are required | 61–74 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'checkFileSize(Entry, List, List, Locale)' has a cyclomatic complexity of 11. | 75–124 |
| CommentRequired | Public method and constructor comments are required | 75–124 |
| UseUnderscoresInNumericLiterals | Number 5242880 should separate every third digit with an underscore | 90 |
| CommentRequired | Public method and constructor comments are required | 126–160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 202–210 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 52–210 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 179 |
| CommentRequired | Public method and constructor comments are required | 180–193 |
| CommentRequired | Public method and constructor comments are required | 196–209 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 145–148 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 302–305 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' | 39 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' | 47 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Optional' | 42 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' | 45 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'CartoProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 46–92 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–601 |
| GodClass | Possible God Class (WMC=53, ATFD=12, TCC=1.333%) | 3 | 48–601 |
| TooManyFields | Too many fields | 3 | 48–601 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 3 | 500–512 |
| ProperCloneImplementation | Object clone() should be implemented with super.clone() | 2 | 500 |
| CloneThrowsCloneNotSupportedException | clone() method should throw CloneNotSupportedException | 3 | 500–512 |
| CommentRequired | Public method and constructor comments are required | 3 | 514–517 |
| CommentRequired | Public method and constructor comments are required | 3 | 519–522 |
| CommentRequired | Public method and constructor comments are required | 3 | 524–527 |
| CommentRequired | Public method and constructor comments are required | 3 | 529–532 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 53–768 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 113–120 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 131–138 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 237–244 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 262–269 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 274–281 |
| CyclomaticComplexity | The method 'selectEntryListByFilter(EntryFilter, Plugin)' has a cyclomatic complexity of 12. | 3 | 297–379 |
| NPathComplexity | The method 'selectEntryListByFilter(EntryFilter, Plugin)' has an NPath complexity of 2050 | 3 | 297–379 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 314 |
| ShortVariable | Avoid variables with short names like sb | 3 | 381 |
| CyclomaticComplexity | The method 'selectNumberEntryByFilter(EntryFilter, Plugin)' has a cyclomatic complexity of 10. | 3 | 390–461 |
| NPathComplexity | The method 'selectNumberEntryByFilter(EntryFilter, Plugin)' has an NPath complexity of 513 | 3 | 390–461 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 404 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 584–608 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 667 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 682 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 692 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 729 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 46–377 |
| CommentRequired | Public method and constructor comments are required | 3 | 363–366 |
| CommentRequired | Public method and constructor comments are required | 3 | 368–371 |
| CommentRequired | Public method and constructor comments are required | 3 | 373–376 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 54–394 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 3 | 99 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'entryChild' | 3 | 115 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 134 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 202 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 359–362 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 67–70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 53–358 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 103–129 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 116 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 119 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 181 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 184 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like id | 3 | 74 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 117 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 197–200 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 302–305 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_strFileName' could be made final; it is only initialized in the declaration or constructor. | 3 | 54 |
| ArrayIsStoredDirectly | The user-supplied array 'bValue' is stored directly. | 3 | 67 |
| ArrayIsStoredDirectly | The user-supplied array 'bValue' is stored directly. | 3 | 83 |
| ArrayIsStoredDirectly | The user-supplied array 'bValue' is stored directly. | 3 | 102 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 116 |
| MethodReturnsInternalArray | Returning '_bValue' may expose an internal array. | 3 | 125 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 145–148 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like y | 3 | 99 |
| ShortVariable | Avoid variables with short names like x | 3 | 99 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 45–191 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 135 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'MapProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 46–92 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'OcrProviderManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 46–92 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 47–108 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 302–305 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 84–123 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 94–101 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 103–110 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 174–181 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 183–190 |
| NPathComplexity | The method 'selectListByFilter(ResponseFilter, Plugin)' has an NPath complexity of 16640 | 3 | 204–286 |
| CyclomaticComplexity | The method 'selectListByFilter(ResponseFilter, Plugin)' has a cyclomatic complexity of 15. | 3 | 204–286 |
| ShortVariable | Avoid variables with short names like sb | 3 | 237 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 238 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 239 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 243 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 244 |
| ShortVariable | Avoid variables with short names like s | 3 | 397 |
| ShortVariable | Avoid variables with short names like sb | 3 | 404 |
| ShortVariable | Avoid variables with short names like c | 3 | 408 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 413–417 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 83 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 111 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 144 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 209–212 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–101 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like se | 3 | 51 |
| ShortVariable | Avoid variables with short names like se | 3 | 60 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–96 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–63 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–90 |
| ImmutableField | Private field '_wildcard' could be made final; it is only initialized in the declaration or constructor. | 3 | 43 |
| ImmutableField | Private field '_helpKey' could be made final; it is only initialized in the declaration or constructor. | 3 | 44 |
| ImmutableField | Private field '_serviceName' could be made final; it is only initialized in the declaration or constructor. | 3 | 45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' | 4 | 39 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' | 4 | 47 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 69–91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 69 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 98–114 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 432 | 3 | 83–185 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 83–185 |
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 3 | 83–185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 88 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 95 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 97 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 99 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 101 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 102 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 103 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 10. | 3 | 191–233 |
| ShortVariable | Avoid variables with short names like dt | 3 | 253 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 253 |
| ShortVariable | Avoid variables with short names like c | 3 | 258 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 277–284 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 385 |
| UseUnderscoresInNumericLiterals | Number 5242880 should separate every third digit with an underscore | 3 | 391 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 397 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Optional' | 4 | 42 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_SPECIFY_BOTH_X_AND_Y'. | 3 | 109 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 124 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 125 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 126 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 127 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 128 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 129 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 130 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 11. | 3 | 173–239 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 189–200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 193–200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 268–275 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 293 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 75 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 76 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 80 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 139–151 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 53–134 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 71–74 |
| CommentRequired | Protected method constructor comments are required | 3 | 83–133 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| CommentRequired | Protected method constructor comments are required | 3 | 131–134 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 75 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 76 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 80 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' | 4 | 45 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 74–176 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 19. | 3 | 74–176 |
| NPathComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has an NPath complexity of 7410 | 3 | 74–176 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 93 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 202–205 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 166 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 167 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 167 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 169 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 170 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 171 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 172 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 173 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 124 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 124 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 125 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 126 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 127 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 128 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 129 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 130 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 131 |
| NPathComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has an NPath complexity of 27648 | 3 | 190–321 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 19. | 3 | 190–321 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 190–321 |
| NcssCount | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a NCSS line count of 91. | 3 | 190–321 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 195–201 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 202–207 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 316–318 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 386–389 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 410 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 56–59 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–123 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 64–67 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 73–76 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 102–105 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 160–163 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 12. | 3 | 66–137 |
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 2048 | 3 | 66–137 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 75 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 76 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 83 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 132 |
| ShortVariable | Avoid variables with short names like sb | 3 | 234 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 68 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 66 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 67 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 67 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 67 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 68 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 69 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| ShortVariable | Avoid variables with short names like id | 3 | 124 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 69 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 178 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 15–148 |
| FieldNamingConventions | The field name 'FIELD_BEGIN_HOUR' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 21 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 21 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the FIELD_BEGIN_HOUR field if you want a default access modifier | 3 | 21 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 22 |
| FieldNamingConventions | The field name 'FIELD_END_HOUR' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 22 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the FIELD_END_HOUR field if you want a default access modifier | 3 | 22 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 32 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 33 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 33 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 34 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 35 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 36 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 37 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 38 |
| CommentRequired | Protected method constructor comments are required | 3 | 122–133 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 81 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 83 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 84 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 85 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 87 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 90 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 135 |
| CyclomaticComplexity | The method 'getResponseData(Entry, HttpServletRequest, List, Locale)' has a cyclomatic complexity of 13. | 3 | 147–234 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 18. | 3 | 74–201 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 74–201 |
| NcssCount | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a NCSS line count of 72. | 3 | 74–201 |
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 13824 | 3 | 74–201 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 77 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 84 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 87 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 92 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 100 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 101 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 175 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 247 |
| CyclomaticComplexity | The method 'checkErrors(Entry, Field, String, String, List, boolean, Locale)' has a cyclomatic complexity of 13. | 3 | 274–331 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.string.StringUtil' | 4 | 53 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 66–174 |
| NPathComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has an NPath complexity of 768 | 3 | 66–174 |
| NcssCount | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a NCSS line count of 61. | 3 | 66–174 |
| CyclomaticComplexity | The method 'getRequestData(Entry, HttpServletRequest, Locale)' has a cyclomatic complexity of 12. | 3 | 66–174 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 70 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 71 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 71 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 72 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 74 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 77 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 78 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 79 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 80 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 81 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 84 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 85 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 86 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 168 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–432 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 165–168 |
| CyclomaticComplexity | The method 'getResponseValueForExport(Entry, HttpServletRequest, Response, Locale)' has a cyclomatic complexity of 10. | 3 | 180–214 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 196–205 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 303 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 303 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 304 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 305 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 306 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 307 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 308 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 309 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 369–372 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 66–69 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 75–78 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 102–105 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 120–123 |
| CommentRequired | Protected method constructor comments are required | 3 | 160–180 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'EntryTypeServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 43–75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The method 'canUploadFiles' indicates linguistically it returns a boolean, but it returns 'GenericAttributeError' | 3 | 288 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–88 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 40–88 |
| FieldNamingConventions | The constant name '_instance' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 42 |
| ImmutableField | Private field '_fileStoreServiceProvider' could be made final; it is only initialized in the declaration or constructor. | 3 | 43 |
| CommentRequired | Public method and constructor comments are required | 3 | 49–52 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 104–107 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_oldEntryId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 43 |
| CommentRequired | Public method and constructor comments are required | 3 | 45–48 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_valuesMap' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–59 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 61–74 |
| CommentRequired | Public method and constructor comments are required | 3 | 61–74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'checkFileSize(Entry, List, List, Locale)' has a cyclomatic complexity of 11. | 3 | 75–124 |
| CommentRequired | Public method and constructor comments are required | 3 | 75–124 |
| UseUnderscoresInNumericLiterals | Number 5242880 should separate every third digit with an underscore | 3 | 90 |
| CommentRequired | Public method and constructor comments are required | 3 | 126–160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 202–210 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 52–210 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 179 |
| CommentRequired | Public method and constructor comments are required | 3 | 180–193 |
| CommentRequired | Public method and constructor comments are required | 3 | 196–209 |
