Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/geocodes/business/ICityDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 121

fr/paris/lutece/plugins/geocodes/business/ICountryDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 121

fr/paris/lutece/plugins/geocodes/rs/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3977

Priority 3

fr/paris/lutece/plugins/geocodes/business/CityDAO.java

Rule Violation Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 287289

fr/paris/lutece/plugins/geocodes/business/CountryDAO.java

Rule Violation Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 274276

fr/paris/lutece/plugins/geocodes/rs/Constants.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 45

fr/paris/lutece/plugins/geocodes/rs/CountryRest.java

Rule Violation Line
ShortVariable Avoid variables with short names like id 116

fr/paris/lutece/plugins/geocodes/rs/SwaggerRest.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 138
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 148
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 151

fr/paris/lutece/plugins/geocodes/service/GeoCodesService.java

Rule Violation Line
CommentRequired Header comments are required 1159
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 1259

fr/paris/lutece/plugins/geocodes/web/AbstractManageGeoCodesJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 50110
DefaultPackage Use explicit scoping instead of the default package private level 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 109

fr/paris/lutece/plugins/geocodes/web/CityJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 63299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 138147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 139147
ConfusingTernary Avoid if (x != y) ..; else ..; 166

fr/paris/lutece/plugins/geocodes/web/CountryJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 63299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 138147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 139147
ConfusingTernary Avoid if (x != y) ..; else ..; 166

Priority 4

fr/paris/lutece/plugins/geocodes/business/City.java

Rule Violation Line
ShortClassName Avoid short class names like City 42157

Files

fr/paris/lutece/plugins/geocodes/business/City.java

Rule Violation Priority Line
ShortClassName Avoid short class names like City 4 42157

fr/paris/lutece/plugins/geocodes/business/CityDAO.java

Rule Violation Priority Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 287289

fr/paris/lutece/plugins/geocodes/business/CountryDAO.java

Rule Violation Priority Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 274276

fr/paris/lutece/plugins/geocodes/business/ICityDAO.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 121

fr/paris/lutece/plugins/geocodes/business/ICountryDAO.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 121

fr/paris/lutece/plugins/geocodes/rs/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3977
ShortVariable Avoid variables with short names like ID 3 45

fr/paris/lutece/plugins/geocodes/rs/CountryRest.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like id 3 116

fr/paris/lutece/plugins/geocodes/rs/SwaggerRest.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 138
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 148
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 151

fr/paris/lutece/plugins/geocodes/service/GeoCodesService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 1159
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 1259

fr/paris/lutece/plugins/geocodes/web/AbstractManageGeoCodesJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 50110
DefaultPackage Use explicit scoping instead of the default package private level 3 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 109

fr/paris/lutece/plugins/geocodes/web/CityJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 63299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 138147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 139147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166

fr/paris/lutece/plugins/geocodes/web/CountryJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 63299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 138147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 139147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166