plugin-GIS - Lutece Geographic information system plugin

PMD Results

The following document contains the results of PMD 5.3.5.

Violation	Line
Avoid modifiers which are implied by the context	44
Avoid modifiers which are implied by the context	46
Avoid modifiers which are implied by the context	48

Violation	Line
Private field 'longitude' could be made final; it is only initialized in the declaration or constructor.	9
Avoid using redundant field initializer for 'longitude'	9
Avoid using redundant field initializer for 'latitude'	11
Private field 'latitude' could be made final; it is only initialized in the declaration or constructor.	11

Violation	Line
Avoid short class names like View	40–170
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation	51

Violation	Line
The class 'ViewDAO' has a Standard Cyclomatic Complexity of 4 (Highest = 10).	46–223
The class 'ViewDAO' has a Cyclomatic Complexity of 4 (Highest = 10).	46–223
The class 'ViewDAO' has a Modified Cyclomatic Complexity of 4 (Highest = 10).	46–223
The method 'findById' has a Modified Cyclomatic Complexity of 10.	75–191
The method 'findById' has a Cyclomatic Complexity of 10.	75–191
Avoid really long methods.	75–191
The method 'findById' has a Standard Cyclomatic Complexity of 10.	75–191
No need to call String.valueOf to append to a string.	79
No need to call String.valueOf to append to a string.	92
No need to call String.valueOf to append to a string.	101
No need to call String.valueOf to append to a string.	106
No need to call String.valueOf to append to a string.	108
No need to call String.valueOf to append to a string.	110
No need to call String.valueOf to append to a string.	127
No need to call String.valueOf to append to a string.	131
No need to call String.valueOf to append to a string.	144
No need to call String.valueOf to append to a string.	150
No need to call String.valueOf to append to a string.	163
No need to call String.valueOf to append to a string.	170
No need to call String.valueOf to append to a string.	185

Violation	Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	47–65

Violation	Line
Avoid unused imports such as 'fr.paris.lutece.util.html.HtmlTemplate'	40
Avoid unused imports such as 'fr.paris.lutece.util.html.HtmlTemplate'	40
Avoid using implementation types like 'HashMap'; use the interface instead	111
Avoid using implementation types like 'HashMap'; use the interface instead	111
Avoid using implementation types like 'HashMap'; use the interface instead	128
Avoid using implementation types like 'HashMap'; use the interface instead	128
Avoid using implementation types like 'HashMap'; use the interface instead	146
Avoid using implementation types like 'HashMap'; use the interface instead	146

Violation	Line
Avoid modifiers which are implied by the context	26–27
Avoid modifiers which are implied by the context	40–41

Violation	Line
Avoid using redundant field initializer for 'addressServiceFacade'	34
The Logger variable declaration does not contain the static and final modifiers	35
Avoid using redundant field initializer for 'logger'	35
Avoid using if statements without curly braces	45–46
Avoid variables with short names like x	88
Avoid variables with short names like y	89

Violation	Line
The class 'ProxyGeoServer' has a Cyclomatic Complexity of 5 (Highest = 11).	63–202
The class 'ProxyGeoServer' has a Modified Cyclomatic Complexity of 5 (Highest = 10).	63–202
The class 'ProxyGeoServer' has a Standard Cyclomatic Complexity of 5 (Highest = 10).	63–202
Avoid unused private fields such as 'servletContext'.	70
Perhaps 'servletContext' could be replaced by a local variable.	70
The Logger variable declaration does not contain the static and final modifiers	71
The method 'doPost' has a Standard Cyclomatic Complexity of 10.	107–201
The method 'doPost' has a Cyclomatic Complexity of 11.	107–201
The method doPost() has an NPath complexity of 542	107–201
The method 'doPost' has a Modified Cyclomatic Complexity of 10.	107–201
Avoid declaring a variable if it is unreferenced before a possible exit point.	116
Avoid declaring a variable if it is unreferenced before a possible exit point.	117
Avoid declaring a variable if it is unreferenced before a possible exit point.	118
Avoid declaring a variable if it is unreferenced before a possible exit point.	119
Avoid unused local variables such as 'headerText'.	119
Prefer StringBuffer over += for concatenating strings	124
Position literals first in String comparisons	155
Avoid using while statements without curly braces	160–161
Avoid using while statements without curly braces	185–186
New exception is thrown in catch block, original stack trace may be lost	196
Avoid empty finally blocks	198–200

Violation	Line
Avoid using redundant field initializer for 'gisService'	34
Rather than using a lot of String arguments, consider using a container object for those values.	71