Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/gismap/business/AddressParam.java

Violation Line
Avoid unused imports such as 'java.util.List' 36
Avoid unused imports such as 'java.util.List' 36

fr/paris/lutece/plugins/gismap/business/AddressParamHome.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4073

fr/paris/lutece/plugins/gismap/business/IMapParameterDAO.java

Violation Line
Avoid modifiers which are implied by the context 38

fr/paris/lutece/plugins/gismap/business/IViewDAO.java

Violation Line
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 47

fr/paris/lutece/plugins/gismap/business/MapParameter.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 43

fr/paris/lutece/plugins/gismap/business/MapParameterDAO.java

Violation Line
The class 'MapParameterDAO' has a Standard Cyclomatic Complexity of 5 (Highest = 11). 16292
The class 'MapParameterDAO' has a Modified Cyclomatic Complexity of 5 (Highest = 11). 16292
The class 'MapParameterDAO' has a Cyclomatic Complexity of 5 (Highest = 11). 16292
The method 'findById' has a Modified Cyclomatic Complexity of 11. 74209
The method 'findById' has a Standard Cyclomatic Complexity of 11. 74209
The method 'findById' has a Cyclomatic Complexity of 11. 74209
The method findById() has an NPath complexity of 1024 74209
Avoid really long methods. 74209
Avoid using Literals in Conditional Statements 216
Prefer StringBuffer over += for concatenating strings 222
Prefer StringBuffer over += for concatenating strings 226
Avoid using Literals in Conditional Statements 231
Avoid using Literals in Conditional Statements 246
Prefer StringBuffer over += for concatenating strings 252
Prefer StringBuffer over += for concatenating strings 256
Avoid using Literals in Conditional Statements 261

fr/paris/lutece/plugins/gismap/business/MapParameterHome.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4150

fr/paris/lutece/plugins/gismap/business/View.java

Violation Line
Avoid short class names like View 36106

fr/paris/lutece/plugins/gismap/business/ViewDAO.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.util.sql.DAOUtil' 40
Avoid unused imports such as 'fr.paris.lutece.util.sql.DAOUtil' 40
Avoid unused private fields such as 'SQL_QUERY_SELECT_RECORD_FIELD'. 48

fr/paris/lutece/plugins/gismap/business/ViewHome.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4765

fr/paris/lutece/plugins/gismap/service/GismapService.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.plugins.gismap.business.MapParameter' 41
Avoid unused imports such as 'fr.paris.lutece.plugins.gismap.business.MapParameter' 41
Avoid unused imports such as 'fr.paris.lutece.plugins.gismap.utils.GismapUtils' 44
Avoid unused imports such as 'fr.paris.lutece.plugins.gismap.utils.GismapUtils' 44
Avoid unused imports such as 'fr.paris.lutece.portal.web.l10n.LocaleService' 45
Avoid unused imports such as 'fr.paris.lutece.portal.web.l10n.LocaleService' 45
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPathService' 47
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPathService' 47
Avoid unused imports such as 'java.util.Locale' 51
Avoid unused imports such as 'java.util.Locale' 51
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 108

fr/paris/lutece/plugins/gismap/utils/GismapUtils.java

Violation Line
Avoid unused private fields such as '_dao'. 63

fr/paris/lutece/plugins/gismap/web/GismapJspBean.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85

fr/paris/lutece/plugins/gismap/web/ProxyGeoServer.java

Violation Line
The class 'ProxyGeoServer' has a Standard Cyclomatic Complexity of 5 (Highest = 10). 65205
The class 'ProxyGeoServer' has a Cyclomatic Complexity of 5 (Highest = 11). 65205
The class 'ProxyGeoServer' has a Modified Cyclomatic Complexity of 5 (Highest = 10). 65205
Avoid unused private fields such as 'servletContext'. 70
Perhaps 'servletContext' could be replaced by a local variable. 70
The Logger variable declaration does not contain the static and final modifiers 71
The method 'doPost' has a Cyclomatic Complexity of 11. 109204
The method 'doPost' has a Modified Cyclomatic Complexity of 10. 109204
The method doPost() has an NPath complexity of 542 109204
The method 'doPost' has a Standard Cyclomatic Complexity of 10. 109204
Avoid declaring a variable if it is unreferenced before a possible exit point. 118
Avoid declaring a variable if it is unreferenced before a possible exit point. 119
Avoid declaring a variable if it is unreferenced before a possible exit point. 120
Avoid unused local variables such as 'headerText'. 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 121
Prefer StringBuffer over += for concatenating strings 126
Position literals first in String comparisons 158
Avoid using while statements without curly braces 163164
Avoid using while statements without curly braces 188189
New exception is thrown in catch block, original stack trace may be lost 199
Avoid empty finally blocks 201203

fr/paris/lutece/plugins/gismap/web/rs/GisProxy.java

Violation Line
The class 'GisProxy' has a Cyclomatic Complexity of 8 (Highest = 11). 59180
The class 'GisProxy' has a Modified Cyclomatic Complexity of 8 (Highest = 11). 59180
The class 'GisProxy' has a Standard Cyclomatic Complexity of 8 (Highest = 11). 59180
The method 'manageProxyConfiguration' has a Cyclomatic Complexity of 11. 73129
The method 'manageProxyConfiguration' has a Modified Cyclomatic Complexity of 11. 73129
The method 'manageProxyConfiguration' has a Standard Cyclomatic Complexity of 11. 73129
These nested if statements could be combined 8487
Deeply nested if..then statements are hard to read 115118
These nested if statements could be combined 115118
Deeply nested if..then statements are hard to read 123126
These nested if statements could be combined 123126
String.indexOf(char) is faster than String.indexOf(String). 144
Do not add empty strings 163
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 171