PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/googleapi/business/FeedProvider.java
Violation |
Line |
Document empty constructor |
51–53 |
Avoid unnecessary constructors - the compiler will generate these for you |
51–53 |
fr/paris/lutece/plugins/googleapi/business/Item.java
Violation |
Line |
Avoid short class names like Item |
40–147 |
fr/paris/lutece/plugins/googleapi/business/VideoProvider.java
Violation |
Line |
Abstract classes should be named AbstractXXX |
42–53 |
fr/paris/lutece/plugins/googleapi/modules/youtube/business/YouTubeProvider.java
Violation |
Line |
String.indexOf(char) is faster than String.indexOf(String). |
87 |
fr/paris/lutece/plugins/googleapi/modules/youtube/service/YouTubeHandler.java
Violation |
Line |
The class 'YouTubeHandler' has a Cyclomatic Complexity of 11 (Highest = 10). |
46–76 |
The method 'startElement' has a Cyclomatic Complexity of 10. |
48–75 |
Position literals first in String comparisons |
51 |
Position literals first in String comparisons |
57 |
Position literals first in String comparisons |
61 |
These nested if statements could be combined |
63–66 |
Position literals first in String comparisons |
69 |
fr/paris/lutece/plugins/googleapi/service/FeedHandler.java
Violation |
Line |
Position literals first in String comparisons |
88 |
Position literals first in String comparisons |
94 |
Position literals first in String comparisons |
98 |
Position literals first in String comparisons |
105 |
Avoid variables with short names like ch |
147 |
fr/paris/lutece/plugins/googleapi/service/FeedsService.java
Violation |
Line |
A class which only has private constructors should be final |
65–191 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
70 |
Singleton is not thread safe |
84–87 |
fr/paris/lutece/plugins/googleapi/web/GoogleApiApp.java
Violation |
Line |
Avoid variables with short names like fp |
94 |
fr/paris/lutece/plugins/googleapi/web/GoogleApiLinkServiceJspBean.java
Violation |
Line |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
111 |
Avoid variables with short names like fp |
141 |