The following document contains the results of PMD 6.13.0.
Rule | Violation | Line |
---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 63–280 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'GrafanaConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–79 |
Rule | Violation | Line |
---|---|---|
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 167 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 195 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 269 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 47–93 |
ShortVariable | Avoid variables with short names like rt | 58 |
ShortVariable | Avoid variables with short names like p | 64 |
Rule | Violation | Line |
---|---|---|
RedundantFieldInitializer | Avoid using redundant field initializer for '_instance' | 79 |
CommentRequired | Public method and constructor comments are required | 87–94 |
NonThreadSafeSingleton | Singleton is not thread safe | 89–92 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 107 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 109 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 124–131 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 138 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 142 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 157 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 255 |
Rule | Violation | Line |
---|---|---|
UncommentedEmptyMethodBody | Document empty method body | 58–59 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 39–51 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 39–51 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 105 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 137 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 103 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 175–186 |
Rule | Violation | Line |
---|---|---|
SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 68 |
AddEmptyString | Do not add empty strings | 99 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 167 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 195 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 269 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 47–93 |
ShortVariable | Avoid variables with short names like rt | 3 | 58 |
ShortVariable | Avoid variables with short names like p | 3 | 64 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 63–280 |
RedundantFieldInitializer | Avoid using redundant field initializer for '_instance' | 3 | 79 |
CommentRequired | Public method and constructor comments are required | 3 | 87–94 |
NonThreadSafeSingleton | Singleton is not thread safe | 3 | 89–92 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 107 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 109 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 124–131 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 138 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 142 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 157 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 255 |
Rule | Violation | Priority | Line |
---|---|---|---|
UncommentedEmptyMethodBody | Document empty method body | 3 | 58–59 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 39–51 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 39–51 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'GrafanaConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–79 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 105 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 137 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 103 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 175–186 |
Rule | Violation | Priority | Line |
---|---|---|---|
SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 68 |
AddEmptyString | Do not add empty strings | 3 | 99 |