PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/graphite/business/Category.java
| Violation |
Line |
| Avoid unused imports such as 'javax.validation.constraints' |
39 |
| Avoid unused imports such as 'org.hibernate.validator.constraints' |
40 |
| Avoid using Literals in Conditional Statements |
161 |
| Avoid using Literals in Conditional Statements |
197 |
fr/paris/lutece/plugins/graphite/business/Graph.java
| Violation |
Line |
| Avoid unused imports such as 'javax.validation.constraints' |
36 |
| Avoid unused imports such as 'org.hibernate.validator.constraints' |
37 |
fr/paris/lutece/plugins/graphite/business/portlet/GraphitePortlet.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
52–55 |
fr/paris/lutece/plugins/graphite/business/portlet/GraphitePortletDAO.java
| Violation |
Line |
| Avoid variables with short names like p |
63 |
| Avoid variables with short names like p |
92 |
fr/paris/lutece/plugins/graphite/business/portlet/GraphitePortletHome.java
| Violation |
Line |
| Possible unsafe assignment to a non-final static field in a constructor. |
51 |
| It is a good practice to call super() in a constructor |
56–62 |
| Singleton is not thread safe |
84–87 |
fr/paris/lutece/plugins/graphite/web/CategoryJspBean.java
| Violation |
Line |
| Do not add empty strings |
145 |
| Assigning an Object to null is a code smell. Consider refactoring. |
191 |
| Assigning an Object to null is a code smell. Consider refactoring. |
292 |
fr/paris/lutece/plugins/graphite/web/GraphJspBean.java
| Violation |
Line |
| Do not add empty strings |
136 |
| Assigning an Object to null is a code smell. Consider refactoring. |
179 |
| Assigning an Object to null is a code smell. Consider refactoring. |
260 |
fr/paris/lutece/plugins/graphite/web/Graphite.java
| Violation |
Line |
| Avoid unnecessary comparisons in boolean expressions |
98 |
| Avoid using Literals in Conditional Statements |
100 |
| These nested if statements could be combined |
100–104 |
| Deeply nested if..then statements are hard to read |
100–104 |
| Avoid unnecessary comparisons in boolean expressions |
107 |
fr/paris/lutece/plugins/graphite/web/ManageGraphJspBean.java
| Violation |
Line |
| Abstract classes should be named AbstractXXX |
42–54 |
| No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. |
42–54 |
fr/paris/lutece/plugins/graphite/web/ViewGraphJspBean.java
| Violation |
Line |
| Abstract classes should be named AbstractXXX |
42–54 |
| No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. |
42–54 |
fr/paris/lutece/plugins/graphite/web/ViewJspBean.java
| Violation |
Line |
| Avoid unnecessary comparisons in boolean expressions |
93 |
| Deeply nested if..then statements are hard to read |
95–99 |
| These nested if statements could be combined |
95–99 |
| Avoid using Literals in Conditional Statements |
95 |
| Avoid unnecessary comparisons in boolean expressions |
102 |
fr/paris/lutece/plugins/graphite/web/portlet/GraphitePortletJspBean.java
| Violation |
Line |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
97 |