Lutece - GreetingCards – Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
22	0	2	59

Files

File	W	E
fr/paris/lutece/plugins/greetingscard/business/Domain.java	0	1
fr/paris/lutece/plugins/greetingscard/business/GreetingsCard.java	0	4
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardArchive.java	0	2
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardArchiveDAO.java	0	1
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardArchiveHome.java	0	4
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardDAO.java	0	1
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardFilter.java	0	1
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardHome.java	0	2
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardStatistic.java	0	5
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardTemplate.java	0	1
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardTemplateDAO.java	0	1
fr/paris/lutece/plugins/greetingscard/business/GreetingsCardTemplateHome.java	0	1
fr/paris/lutece/plugins/greetingscard/business/IGreetingsCardArchiveDAO.java	0	4
fr/paris/lutece/plugins/greetingscard/business/IGreetingsCardDAO.java	0	3
fr/paris/lutece/plugins/greetingscard/business/IGreetingsCardTemplateDAO.java	0	1
fr/paris/lutece/plugins/greetingscard/service/GreetingsCardResourceIdService.java	0	1
fr/paris/lutece/plugins/greetingscard/service/GreetingsCardService.java	0	5
fr/paris/lutece/plugins/greetingscard/service/GreetingsCardStatusUpdaterDaemon.java	1	3
fr/paris/lutece/plugins/greetingscard/web/GreetingsCardApp.java	0	11
fr/paris/lutece/plugins/greetingscard/web/GreetingsCardJspBean.java	1	7

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly option: `"nl"`	1	Error
coding	InnerAssignment	1	Error
	InnerAssignment	1	Error
	ReturnCount max: `"5"`	2	Warning
design	HideUtilityClassConstructor	1	Error
header	Header fileExtensions: `"java"` headerFile: `"/opt/datas/jenkins/home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"`	20	Error
imports	UnusedImports	2	Error
javadoc	JavadocMethod	22	Error
	JavadocType	1	Error
modifier	RedundantModifier	1	Error
whitespace	ParenPad option: `"space"`	8	Error
	WhitespaceAround tokens: `"ASSIGN,EQUAL"`	2	Error

Details

fr/paris/lutece/plugins/greetingscard/business/Domain.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/business/GreetingsCard.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocMethod	Unused @param tag for 'read'.	284
Error	javadoc	JavadocMethod	Expected @param tag for 'copy'.	286
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	330

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardArchive.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	166

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardArchiveDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardArchiveHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	design	HideUtilityClassConstructor	Utility classes should not have a public or default constructor.	47
Error	javadoc	JavadocMethod	Unused @param tag for 'findByYear'.	86
Error	javadoc	JavadocMethod	Expected @param tag for 'year'.	90

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardFilter.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocMethod	Unused @param tag for 'nStatus'.	188

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardStatistic.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocMethod	Unused @param tag for 'nNbCardRedInternal'.	149
Error	javadoc	JavadocMethod	Expected @param tag for 'nNbCardRedExternal'.	151
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	156
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	161

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardTemplate.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardTemplateDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/business/GreetingsCardTemplateHome.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/business/IGreetingsCardArchiveDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocType	Missing a Javadoc comment.	41
Error	javadoc	JavadocMethod	Unused @param tag for 'findByYear'.	69
Error	javadoc	JavadocMethod	Expected @param tag for 'year'.	73

fr/paris/lutece/plugins/greetingscard/business/IGreetingsCardDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocMethod	Unused @param tag for 'nStatus'.	139
Error	modifier	RedundantModifier	Redundant 'public' modifier.	154

fr/paris/lutece/plugins/greetingscard/business/IGreetingsCardTemplateDAO.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/service/GreetingsCardResourceIdService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2

fr/paris/lutece/plugins/greetingscard/service/GreetingsCardService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	coding	InnerAssignment	Inner assignments should be avoided.	99
Error	javadoc	JavadocMethod	Expected @param tag for 'strDomainName'.	160
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	173
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	182

fr/paris/lutece/plugins/greetingscard/service/GreetingsCardStatusUpdaterDaemon.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Warning	coding	ReturnCount	Return count is 2 (max allowed for void methods/constructors/lambdas is 1).	82
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	167
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	177

fr/paris/lutece/plugins/greetingscard/web/GreetingsCardApp.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	imports	UnusedImports	Unused import - fr.paris.lutece.portal.web.l10n.LocaleService.	56
Error	imports	UnusedImports	Unused import - fr.paris.lutece.portal.web.xpages.XPageApplication.	58
Error	blocks	LeftCurly	'{' at column 10 should be on a new line.	223
Error	javadoc	JavadocMethod	Expected @throws tag for 'SiteMessageException'.	403
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	512
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	512
Error	whitespace	ParenPad	'(' is not followed by whitespace.	516
Error	whitespace	ParenPad	')' is not preceded with whitespace.	516
Error	whitespace	ParenPad	'(' is not followed by whitespace.	526
Error	whitespace	ParenPad	')' is not preceded with whitespace.	526

fr/paris/lutece/plugins/greetingscard/web/GreetingsCardJspBean.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'.	2
Error	javadoc	JavadocMethod	Missing a Javadoc comment.	711
Error	whitespace	ParenPad	'(' is not followed by whitespace.	924
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1420
Warning	coding	ReturnCount	Return count is 6 (max allowed for non-void methods/lambdas is 5).	1492
Error	whitespace	ParenPad	'(' is not followed by whitespace.	1522
Error	whitespace	ParenPad	')' is not preceded with whitespace.	1579
Error	javadoc	JavadocMethod	Unused @param tag for 'request'.	2032