Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/grustoragedb/business/IDemandCategoryDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 106

fr/paris/lutece/plugins/grustoragedb/business/IDemandTypeDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 106

fr/paris/lutece/plugins/grustoragedb/business/IStatusDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 114

fr/paris/lutece/plugins/grustoragedb/utils/GrustoragedbConstants.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 43–61
ClassNamingConventions The utility class name 'GrustoragedbConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 43–61

fr/paris/lutece/plugins/grustoragedb/utils/GrustoragedbUtils.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 50–93

Priority 2

fr/paris/lutece/plugins/grustoragedb/business/DemandDAO.java

Rule Violation Ligne
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 371

fr/paris/lutece/plugins/grustoragedb/business/NotificationContentHome.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strNotificationContent' 250

fr/paris/lutece/plugins/grustoragedb/service/JsonGeneration.java

Rule Violation Ligne
SystemPrintln System.out.println is used 43
SystemPrintln System.out.println is used 60
SystemPrintln System.out.println is used 115

Priority 3

fr/paris/lutece/plugins/grustoragedb/business/DemandCategoryDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 217–219

fr/paris/lutece/plugins/grustoragedb/business/DemandDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 55–566
AvoidDuplicateLiterals The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 72 72
ControlStatementBraces This statement should have braces 163
ShortVariable Avoid variables with short names like i 449
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 479
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 484
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 487
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 523
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 528
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 532
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 535

fr/paris/lutece/plugins/grustoragedb/business/DemandHome.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as '_plugin'. 20

fr/paris/lutece/plugins/grustoragedb/business/DemandTypeDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 221–223

fr/paris/lutece/plugins/grustoragedb/business/NotificationContent.java

Rule Violation Ligne
MethodReturnsInternalArray Returning '_content' may expose an internal array. 131
ArrayIsStoredDirectly The user-supplied array 'bytes' is stored directly. 140

fr/paris/lutece/plugins/grustoragedb/business/NotificationContentDAO.java

Rule Violation Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 184

fr/paris/lutece/plugins/grustoragedb/business/NotificationDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 71–607
DefaultPackage Use explicit scoping instead of the default package private level 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _mapper field if you want a default access modifier 109
CyclomaticComplexity The method 'getFilterCriteriaClauses(String, NotificationFilter)' has a cyclomatic complexity of 13. 186–275
NPathComplexity The method 'getFilterCriteriaClauses(String, NotificationFilter)' has an NPath complexity of 2080 186–275
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 314–333
ShortVariable Avoid variables with short names like id 339
ShortVariable Avoid variables with short names like id 391
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 400

fr/paris/lutece/plugins/grustoragedb/business/NotificationEventDAO.java

Rule Violation Ligne
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 117
ConfusingTernary Avoid if (x != y) ..; else ..; 133–143
LinguisticNaming Linguistics Antipattern - The getter 'getFilterCriteriaClauses' should not return void linguistically 310–347
ShortVariable Avoid variables with short names like i 358
MissingOverride The method 'deleteBeforeDate(long)' is missing an @Override annotation. 392–403

fr/paris/lutece/plugins/grustoragedb/business/NotificationEventHome.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as '_plugin'. 20

fr/paris/lutece/plugins/grustoragedb/business/NotificationHome.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as '_plugin'. 22
ShortVariable Avoid variables with short names like id 63

fr/paris/lutece/plugins/grustoragedb/business/StatusDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 227–230
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 270

fr/paris/lutece/plugins/grustoragedb/service/DemandTypeProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 40–49

fr/paris/lutece/plugins/grustoragedb/service/DemandTypeService.java

Rule Violation Ligne
CommentRequired Header comments are required 41–96
ImmutableField Private field '_provider' could be made final; it is only initialized in the declaration or constructor. 46
NonThreadSafeSingleton Singleton is not thread safe 55–58
UselessStringValueOf No need to call String.valueOf to append to a string. 86

fr/paris/lutece/plugins/grustoragedb/service/GruStorageDbPlugin.java

Rule Violation Ligne
UncommentedEmptyMethodBody Document empty method body 54–55

fr/paris/lutece/plugins/grustoragedb/service/IDemandTypeProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 7–15
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDemandTypes': the method is declared in an interface type 13

fr/paris/lutece/plugins/grustoragedb/service/JsonGeneration.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 28–118
CommentRequired Public method and constructor comments are required 35–63
ShortVariable Avoid variables with short names like i 46
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 56

fr/paris/lutece/plugins/grustoragedb/web/AbstractManageDemandJspBean.java

Rule Violation Ligne
DefaultPackage Use explicit scoping instead of the default package private level 111
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 111

fr/paris/lutece/plugins/grustoragedb/web/AbstractManageDemandTypeJspBean.java

Rule Violation Ligne
DefaultPackage Use explicit scoping instead of the default package private level 114
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 114

fr/paris/lutece/plugins/grustoragedb/web/AbstractManageJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 50–110
DefaultPackage Use explicit scoping instead of the default package private level 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 109

fr/paris/lutece/plugins/grustoragedb/web/DemandCategoryJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 63–299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 138–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 139–147
ConfusingTernary Avoid if (x != y) ..; else ..; 166

fr/paris/lutece/plugins/grustoragedb/web/DemandJspBean.java

Rule Violation Ligne
CommentRequired Header comments are required 30–152
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 30–152
NPathComplexity The method 'getManageDemand(HttpServletRequest)' has an NPath complexity of 5824 69–139
CyclomaticComplexity The method 'getManageDemand(HttpServletRequest)' has a cyclomatic complexity of 18. 69–139
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 95–98
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 105–108
DefaultPackage Use explicit scoping instead of the default package private level 141–151
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 142–151

fr/paris/lutece/plugins/grustoragedb/web/DemandTypeJspBean.java

Rule Violation Ligne
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 128
DefaultPackage Use explicit scoping instead of the default package private level 145–154
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 146–154
ConfusingTernary Avoid if (x != y) ..; else ..; 173

fr/paris/lutece/plugins/grustoragedb/web/NotificationEventJspBean.java

Rule Violation Ligne
CommentRequired Header comments are required 29–178
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 29–178
NPathComplexity The method 'getManageNotificationEvent(HttpServletRequest)' has an NPath complexity of 46144 69–167
CyclomaticComplexity The method 'getManageNotificationEvent(HttpServletRequest)' has a cyclomatic complexity of 25. 69–167
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 104–107
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 114–117
DefaultPackage Use explicit scoping instead of the default package private level 169–177
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 170–177

fr/paris/lutece/plugins/grustoragedb/web/NotificationJspBean.java

Rule Violation Ligne
CommentRequired Header comments are required 61–227
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 61–227
NPathComplexity The method 'getManageNotification(HttpServletRequest)' has an NPath complexity of 18496 102–187
CyclomaticComplexity The method 'getManageNotification(HttpServletRequest)' has a cyclomatic complexity of 22. 102–187
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 136–139
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 146–149
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 197
DefaultPackage Use explicit scoping instead of the default package private level 215–224
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 216–224

fr/paris/lutece/plugins/grustoragedb/web/StatusJspBean.java

Rule Violation Ligne
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 128
DefaultPackage Use explicit scoping instead of the default package private level 145–154
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 146–154
ConfusingTernary Avoid if (x != y) ..; else ..; 173

Priority 4

fr/paris/lutece/plugins/grustoragedb/business/NotificationHome.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.file.IFileStoreServiceProvider' 6

fr/paris/lutece/plugins/grustoragedb/web/DemandJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.NotificationEvent' 14
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationEventHome' 17
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' 18
UnusedImports Avoid unused imports such as 'java.sql.Timestamp' 26

fr/paris/lutece/plugins/grustoragedb/web/NotificationEventJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.Notification' 13
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' 17
UnusedImports Avoid unused imports such as 'java.sql.Timestamp' 25

fr/paris/lutece/plugins/grustoragedb/web/NotificationJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.service.JsonGeneration' 50
UnusedImports Avoid unused imports such as 'java.sql.Timestamp' 57

Fichiers

fr/paris/lutece/plugins/grustoragedb/business/DemandCategoryDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 217–219

fr/paris/lutece/plugins/grustoragedb/business/DemandDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 55–566
AvoidDuplicateLiterals The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 72 3 72
ControlStatementBraces This statement should have braces 3 163
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 371
ShortVariable Avoid variables with short names like i 3 449
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 479
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 484
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 487
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 523
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 528
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 532
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 535

fr/paris/lutece/plugins/grustoragedb/business/DemandHome.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as '_plugin'. 3 20

fr/paris/lutece/plugins/grustoragedb/business/DemandTypeDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 221–223

fr/paris/lutece/plugins/grustoragedb/business/IDemandCategoryDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 106

fr/paris/lutece/plugins/grustoragedb/business/IDemandTypeDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 106

fr/paris/lutece/plugins/grustoragedb/business/IStatusDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 114

fr/paris/lutece/plugins/grustoragedb/business/NotificationContent.java

Rule Violation Priority Ligne
MethodReturnsInternalArray Returning '_content' may expose an internal array. 3 131
ArrayIsStoredDirectly The user-supplied array 'bytes' is stored directly. 3 140

fr/paris/lutece/plugins/grustoragedb/business/NotificationContentDAO.java

Rule Violation Priority Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 184

fr/paris/lutece/plugins/grustoragedb/business/NotificationContentHome.java

Rule Violation Priority Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strNotificationContent' 2 250

fr/paris/lutece/plugins/grustoragedb/business/NotificationDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 71–607
DefaultPackage Use explicit scoping instead of the default package private level 3 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _mapper field if you want a default access modifier 3 109
CyclomaticComplexity The method 'getFilterCriteriaClauses(String, NotificationFilter)' has a cyclomatic complexity of 13. 3 186–275
NPathComplexity The method 'getFilterCriteriaClauses(String, NotificationFilter)' has an NPath complexity of 2080 3 186–275
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 314–333
ShortVariable Avoid variables with short names like id 3 339
ShortVariable Avoid variables with short names like id 3 391
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 400

fr/paris/lutece/plugins/grustoragedb/business/NotificationEventDAO.java

Rule Violation Priority Ligne
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 117
ConfusingTernary Avoid if (x != y) ..; else ..; 3 133–143
LinguisticNaming Linguistics Antipattern - The getter 'getFilterCriteriaClauses' should not return void linguistically 3 310–347
ShortVariable Avoid variables with short names like i 3 358
MissingOverride The method 'deleteBeforeDate(long)' is missing an @Override annotation. 3 392–403

fr/paris/lutece/plugins/grustoragedb/business/NotificationEventHome.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as '_plugin'. 3 20

fr/paris/lutece/plugins/grustoragedb/business/NotificationHome.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.file.IFileStoreServiceProvider' 4 6
UnusedPrivateField Avoid unused private fields such as '_plugin'. 3 22
ShortVariable Avoid variables with short names like id 3 63

fr/paris/lutece/plugins/grustoragedb/business/StatusDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 227–230
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 270

fr/paris/lutece/plugins/grustoragedb/service/DemandTypeProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 40–49

fr/paris/lutece/plugins/grustoragedb/service/DemandTypeService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41–96
ImmutableField Private field '_provider' could be made final; it is only initialized in the declaration or constructor. 3 46
NonThreadSafeSingleton Singleton is not thread safe 3 55–58
UselessStringValueOf No need to call String.valueOf to append to a string. 3 86

fr/paris/lutece/plugins/grustoragedb/service/GruStorageDbPlugin.java

Rule Violation Priority Ligne
UncommentedEmptyMethodBody Document empty method body 3 54–55

fr/paris/lutece/plugins/grustoragedb/service/IDemandTypeProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 7–15
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDemandTypes': the method is declared in an interface type 3 13

fr/paris/lutece/plugins/grustoragedb/service/JsonGeneration.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 28–118
CommentRequired Public method and constructor comments are required 3 35–63
SystemPrintln System.out.println is used 2 43
ShortVariable Avoid variables with short names like i 3 46
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 56
SystemPrintln System.out.println is used 2 60
SystemPrintln System.out.println is used 2 115

fr/paris/lutece/plugins/grustoragedb/utils/GrustoragedbConstants.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 43–61
ClassNamingConventions The utility class name 'GrustoragedbConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 43–61

fr/paris/lutece/plugins/grustoragedb/utils/GrustoragedbUtils.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 50–93

fr/paris/lutece/plugins/grustoragedb/web/AbstractManageDemandJspBean.java

Rule Violation Priority Ligne
DefaultPackage Use explicit scoping instead of the default package private level 3 111
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 111

fr/paris/lutece/plugins/grustoragedb/web/AbstractManageDemandTypeJspBean.java

Rule Violation Priority Ligne
DefaultPackage Use explicit scoping instead of the default package private level 3 114
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 114

fr/paris/lutece/plugins/grustoragedb/web/AbstractManageJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 50–110
DefaultPackage Use explicit scoping instead of the default package private level 3 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 109

fr/paris/lutece/plugins/grustoragedb/web/DemandCategoryJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 63–299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 138–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 139–147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166

fr/paris/lutece/plugins/grustoragedb/web/DemandJspBean.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.NotificationEvent' 4 14
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationEventHome' 4 17
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' 4 18
UnusedImports Avoid unused imports such as 'java.sql.Timestamp' 4 26
CommentRequired Header comments are required 3 30–152
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 30–152
NPathComplexity The method 'getManageDemand(HttpServletRequest)' has an NPath complexity of 5824 3 69–139
CyclomaticComplexity The method 'getManageDemand(HttpServletRequest)' has a cyclomatic complexity of 18. 3 69–139
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 95–98
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 105–108
DefaultPackage Use explicit scoping instead of the default package private level 3 141–151
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 142–151

fr/paris/lutece/plugins/grustoragedb/web/DemandTypeJspBean.java

Rule Violation Priority Ligne
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 128
DefaultPackage Use explicit scoping instead of the default package private level 3 145–154
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 146–154
ConfusingTernary Avoid if (x != y) ..; else ..; 3 173

fr/paris/lutece/plugins/grustoragedb/web/NotificationEventJspBean.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.Notification' 4 13
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' 4 17
UnusedImports Avoid unused imports such as 'java.sql.Timestamp' 4 25
CommentRequired Header comments are required 3 29–178
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 29–178
NPathComplexity The method 'getManageNotificationEvent(HttpServletRequest)' has an NPath complexity of 46144 3 69–167
CyclomaticComplexity The method 'getManageNotificationEvent(HttpServletRequest)' has a cyclomatic complexity of 25. 3 69–167
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 104–107
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 114–117
DefaultPackage Use explicit scoping instead of the default package private level 3 169–177
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 170–177

fr/paris/lutece/plugins/grustoragedb/web/NotificationJspBean.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.service.JsonGeneration' 4 50
UnusedImports Avoid unused imports such as 'java.sql.Timestamp' 4 57
CommentRequired Header comments are required 3 61–227
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 61–227
NPathComplexity The method 'getManageNotification(HttpServletRequest)' has an NPath complexity of 18496 3 102–187
CyclomaticComplexity The method 'getManageNotification(HttpServletRequest)' has a cyclomatic complexity of 22. 3 102–187
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 136–139
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 146–149
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 197
DefaultPackage Use explicit scoping instead of the default package private level 3 215–224
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 216–224

fr/paris/lutece/plugins/grustoragedb/web/StatusJspBean.java

Rule Violation Priority Ligne
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 128
DefaultPackage Use explicit scoping instead of the default package private level 3 145–154
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 146–154
ConfusingTernary Avoid if (x != y) ..; else ..; 3 173