The following document contains the results of PMD 6.13.0.
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 106 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 106 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 114 |
Rule | Violation | Line |
---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 43–61 |
ClassNamingConventions | The utility class name 'GrustoragedbConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 43–61 |
Rule | Violation | Line |
---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 50–93 |
Rule | Violation | Line |
---|---|---|
AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 371 |
Rule | Violation | Line |
---|---|---|
AvoidReassigningParameters | Avoid reassigning parameters such as 'strNotificationContent' | 250 |
Rule | Violation | Line |
---|---|---|
SystemPrintln | System.out.println is used | 43 |
SystemPrintln | System.out.println is used | 60 |
SystemPrintln | System.out.println is used | 115 |
Rule | Violation | Line |
---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 217–219 |
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 55–566 |
AvoidDuplicateLiterals | The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 72 | 72 |
ControlStatementBraces | This statement should have braces | 163 |
ShortVariable | Avoid variables with short names like i | 449 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 479 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 484 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 487 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 523 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 528 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 532 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 535 |
Rule | Violation | Line |
---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 20 |
Rule | Violation | Line |
---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 221–223 |
Rule | Violation | Line |
---|---|---|
MethodReturnsInternalArray | Returning '_content' may expose an internal array. | 131 |
ArrayIsStoredDirectly | The user-supplied array 'bytes' is stored directly. | 140 |
Rule | Violation | Line |
---|---|---|
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 184 |
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 71–607 |
DefaultPackage | Use explicit scoping instead of the default package private level | 109 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _mapper field if you want a default access modifier | 109 |
CyclomaticComplexity | The method 'getFilterCriteriaClauses(String, NotificationFilter)' has a cyclomatic complexity of 13. | 186–275 |
NPathComplexity | The method 'getFilterCriteriaClauses(String, NotificationFilter)' has an NPath complexity of 2080 | 186–275 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 314–333 |
ShortVariable | Avoid variables with short names like id | 339 |
ShortVariable | Avoid variables with short names like id | 391 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 400 |
Rule | Violation | Line |
---|---|---|
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 117 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 133–143 |
LinguisticNaming | Linguistics Antipattern - The getter 'getFilterCriteriaClauses' should not return void linguistically | 310–347 |
ShortVariable | Avoid variables with short names like i | 358 |
MissingOverride | The method 'deleteBeforeDate(long)' is missing an @Override annotation. | 392–403 |
Rule | Violation | Line |
---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 20 |
Rule | Violation | Line |
---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 22 |
ShortVariable | Avoid variables with short names like id | 63 |
Rule | Violation | Line |
---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 227–230 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 270 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 40–49 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 41–96 |
ImmutableField | Private field '_provider' could be made final; it is only initialized in the declaration or constructor. | 46 |
NonThreadSafeSingleton | Singleton is not thread safe | 55–58 |
UselessStringValueOf | No need to call String.valueOf to append to a string. | 86 |
Rule | Violation | Line |
---|---|---|
UncommentedEmptyMethodBody | Document empty method body | 54–55 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 7–15 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getDemandTypes': the method is declared in an interface type | 13 |
Rule | Violation | Line |
---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 28–118 |
CommentRequired | Public method and constructor comments are required | 35–63 |
ShortVariable | Avoid variables with short names like i | 46 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 56 |
Rule | Violation | Line |
---|---|---|
DefaultPackage | Use explicit scoping instead of the default package private level | 111 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 111 |
Rule | Violation | Line |
---|---|---|
DefaultPackage | Use explicit scoping instead of the default package private level | 114 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 114 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 50–110 |
DefaultPackage | Use explicit scoping instead of the default package private level | 109 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 109 |
Rule | Violation | Line |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 63–299 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 121 |
DefaultPackage | Use explicit scoping instead of the default package private level | 138–147 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 139–147 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 166 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 30–152 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 30–152 |
NPathComplexity | The method 'getManageDemand(HttpServletRequest)' has an NPath complexity of 5824 | 69–139 |
CyclomaticComplexity | The method 'getManageDemand(HttpServletRequest)' has a cyclomatic complexity of 18. | 69–139 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 95–98 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 105–108 |
DefaultPackage | Use explicit scoping instead of the default package private level | 141–151 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 142–151 |
Rule | Violation | Line |
---|---|---|
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 128 |
DefaultPackage | Use explicit scoping instead of the default package private level | 145–154 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 146–154 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 173 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 29–178 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 29–178 |
NPathComplexity | The method 'getManageNotificationEvent(HttpServletRequest)' has an NPath complexity of 46144 | 69–167 |
CyclomaticComplexity | The method 'getManageNotificationEvent(HttpServletRequest)' has a cyclomatic complexity of 25. | 69–167 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 104–107 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 114–117 |
DefaultPackage | Use explicit scoping instead of the default package private level | 169–177 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 170–177 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 61–227 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 61–227 |
NPathComplexity | The method 'getManageNotification(HttpServletRequest)' has an NPath complexity of 18496 | 102–187 |
CyclomaticComplexity | The method 'getManageNotification(HttpServletRequest)' has a cyclomatic complexity of 22. | 102–187 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 136–139 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 146–149 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 197 |
DefaultPackage | Use explicit scoping instead of the default package private level | 215–224 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 216–224 |
Rule | Violation | Line |
---|---|---|
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 128 |
DefaultPackage | Use explicit scoping instead of the default package private level | 145–154 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 146–154 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 173 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.file.IFileStoreServiceProvider' | 6 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.NotificationEvent' | 14 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationEventHome' | 17 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' | 18 |
UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 26 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.Notification' | 13 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' | 17 |
UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 25 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.service.JsonGeneration' | 50 |
UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 57 |
Rule | Violation | Priority | Line |
---|---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 217–219 |
Rule | Violation | Priority | Line |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 55–566 |
AvoidDuplicateLiterals | The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 72 | 3 | 72 |
ControlStatementBraces | This statement should have braces | 3 | 163 |
AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 371 |
ShortVariable | Avoid variables with short names like i | 3 | 449 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 479 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 484 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 487 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 523 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 528 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 532 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 535 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 3 | 20 |
Rule | Violation | Priority | Line |
---|---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 221–223 |
Rule | Violation | Priority | Line |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 106 |
Rule | Violation | Priority | Line |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 106 |
Rule | Violation | Priority | Line |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 114 |
Rule | Violation | Priority | Line |
---|---|---|---|
MethodReturnsInternalArray | Returning '_content' may expose an internal array. | 3 | 131 |
ArrayIsStoredDirectly | The user-supplied array 'bytes' is stored directly. | 3 | 140 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 184 |
Rule | Violation | Priority | Line |
---|---|---|---|
AvoidReassigningParameters | Avoid reassigning parameters such as 'strNotificationContent' | 2 | 250 |
Rule | Violation | Priority | Line |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 71–607 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 109 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _mapper field if you want a default access modifier | 3 | 109 |
CyclomaticComplexity | The method 'getFilterCriteriaClauses(String, NotificationFilter)' has a cyclomatic complexity of 13. | 3 | 186–275 |
NPathComplexity | The method 'getFilterCriteriaClauses(String, NotificationFilter)' has an NPath complexity of 2080 | 3 | 186–275 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 314–333 |
ShortVariable | Avoid variables with short names like id | 3 | 339 |
ShortVariable | Avoid variables with short names like id | 3 | 391 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 400 |
Rule | Violation | Priority | Line |
---|---|---|---|
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 117 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 133–143 |
LinguisticNaming | Linguistics Antipattern - The getter 'getFilterCriteriaClauses' should not return void linguistically | 3 | 310–347 |
ShortVariable | Avoid variables with short names like i | 3 | 358 |
MissingOverride | The method 'deleteBeforeDate(long)' is missing an @Override annotation. | 3 | 392–403 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 3 | 20 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.file.IFileStoreServiceProvider' | 4 | 6 |
UnusedPrivateField | Avoid unused private fields such as '_plugin'. | 3 | 22 |
ShortVariable | Avoid variables with short names like id | 3 | 63 |
Rule | Violation | Priority | Line |
---|---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 227–230 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 270 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 40–49 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 41–96 |
ImmutableField | Private field '_provider' could be made final; it is only initialized in the declaration or constructor. | 3 | 46 |
NonThreadSafeSingleton | Singleton is not thread safe | 3 | 55–58 |
UselessStringValueOf | No need to call String.valueOf to append to a string. | 3 | 86 |
Rule | Violation | Priority | Line |
---|---|---|---|
UncommentedEmptyMethodBody | Document empty method body | 3 | 54–55 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 7–15 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getDemandTypes': the method is declared in an interface type | 3 | 13 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 28–118 |
CommentRequired | Public method and constructor comments are required | 3 | 35–63 |
SystemPrintln | System.out.println is used | 2 | 43 |
ShortVariable | Avoid variables with short names like i | 3 | 46 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 56 |
SystemPrintln | System.out.println is used | 2 | 60 |
SystemPrintln | System.out.println is used | 2 | 115 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 43–61 |
ClassNamingConventions | The utility class name 'GrustoragedbConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 43–61 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 50–93 |
Rule | Violation | Priority | Line |
---|---|---|---|
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 111 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 111 |
Rule | Violation | Priority | Line |
---|---|---|---|
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 114 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 114 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 50–110 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 109 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 109 |
Rule | Violation | Priority | Line |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 63–299 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 121 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 138–147 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 139–147 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 166 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.NotificationEvent' | 4 | 14 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationEventHome' | 4 | 17 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' | 4 | 18 |
UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 4 | 26 |
CommentRequired | Header comments are required | 3 | 30–152 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 30–152 |
NPathComplexity | The method 'getManageDemand(HttpServletRequest)' has an NPath complexity of 5824 | 3 | 69–139 |
CyclomaticComplexity | The method 'getManageDemand(HttpServletRequest)' has a cyclomatic complexity of 18. | 3 | 69–139 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 95–98 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 105–108 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 141–151 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 142–151 |
Rule | Violation | Priority | Line |
---|---|---|---|
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 128 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 145–154 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 146–154 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 173 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.Notification' | 4 | 13 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.business.NotificationHome' | 4 | 17 |
UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 4 | 25 |
CommentRequired | Header comments are required | 3 | 29–178 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 29–178 |
NPathComplexity | The method 'getManageNotificationEvent(HttpServletRequest)' has an NPath complexity of 46144 | 3 | 69–167 |
CyclomaticComplexity | The method 'getManageNotificationEvent(HttpServletRequest)' has a cyclomatic complexity of 25. | 3 | 69–167 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 104–107 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 114–117 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 169–177 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 170–177 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grustoragedb.service.JsonGeneration' | 4 | 50 |
UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 4 | 57 |
CommentRequired | Header comments are required | 3 | 61–227 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 61–227 |
NPathComplexity | The method 'getManageNotification(HttpServletRequest)' has an NPath complexity of 18496 | 3 | 102–187 |
CyclomaticComplexity | The method 'getManageNotification(HttpServletRequest)' has a cyclomatic complexity of 22. | 3 | 102–187 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 136–139 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 146–149 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 197 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 215–224 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 216–224 |
Rule | Violation | Priority | Line |
---|---|---|---|
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 128 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 145–154 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 146–154 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 173 |