PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/grustorageelastic/business/ESCustomerDTO.java
| Violation |
Line |
| Avoid long parameter lists. |
138–140 |
| A getX() method which returns a boolean should be named isX() |
363–366 |
| Avoid variables with short names like s |
483 |
fr/paris/lutece/plugins/grustorageelastic/business/ESPayload.java
| Violation |
Line |
| Avoid using implementation types like 'HashMap'; use the interface instead |
53 |
| Avoid using implementation types like 'HashMap'; use the interface instead |
53 |
| Avoid using implementation types like 'HashMap'; use the interface instead |
60 |
| Avoid using implementation types like 'HashMap'; use the interface instead |
60 |
| Avoid using implementation types like 'HashMap'; use the interface instead |
71 |
| Avoid using implementation types like 'HashMap'; use the interface instead |
71 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
83 |
| Avoid throwing null pointer exceptions. |
87 |
| Avoid catching NullPointerException; consider removing the cause of the NPE. |
104 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
104 |
fr/paris/lutece/plugins/grustorageelastic/business/ESSuggestDTO.java
| Violation |
Line |
| Consider using varargs for methods or constructors which take an array the last parameter. |
70 |
fr/paris/lutece/plugins/grustorageelastic/business/elasticsearch/ElasticSearchCustomerDAO.java
| Violation |
Line |
| The class 'ElasticSearchCustomerDAO' has a Modified Cyclomatic Complexity of 4 (Highest = 10). |
59–283 |
| The class 'ElasticSearchCustomerDAO' has a Cyclomatic Complexity of 4 (Highest = 10). |
59–283 |
| The class 'ElasticSearchCustomerDAO' has a Standard Cyclomatic Complexity of 4 (Highest = 10). |
59–283 |
| Private field '_elastic' could be made final; it is only initialized in the declaration or constructor. |
70 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
93 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
135 |
| The method 'buildCustomer' has a Standard Cyclomatic Complexity of 10. |
243–269 |
| The method buildCustomer() has an NPath complexity of 390626 |
243–269 |
| The method 'buildCustomer' has a Cyclomatic Complexity of 10. |
243–269 |
| The method 'buildCustomer' has a Modified Cyclomatic Complexity of 10. |
243–269 |
| Avoid catching NullPointerException; consider removing the cause of the NPE. |
263 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
263 |
fr/paris/lutece/plugins/grustorageelastic/business/lucene/LuceneCustomerDAO.java
| Violation |
Line |
| A high number of imports can indicate a high degree of coupling within an object. |
34–530 |
| The String literal "Error indexing customer : " appears 4 times in this file; the first occurrence is on line 170 |
170 |
| Singleton is not thread safe |
212–215 |
| Prefer StringBuffer over += for concatenating strings |
368 |
| Prefer StringBuffer over += for concatenating strings |
370 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
487 |
