Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
26 0 1 140

Files

File
 I
 W
 E
fr/paris/lutece/plugins/grusupply/business/GruSupplyEmail.java 0 0 1
fr/paris/lutece/plugins/grusupply/business/StatusMessage.java 0 0 48
fr/paris/lutece/plugins/grusupply/constant/GruSupplyConstants.java 0 0 3
fr/paris/lutece/plugins/grusupply/service/CustomerProvider.java 0 0 5
fr/paris/lutece/plugins/grusupply/service/GruSupplyPlugin.java 0 0 1
fr/paris/lutece/plugins/grusupply/service/NotificationService.java 0 0 7
fr/paris/lutece/plugins/grusupply/service/notifyers/NotifyCrmService.java 0 0 9
fr/paris/lutece/plugins/grusupply/service/notifyers/SendEmailService.java 0 0 7
fr/paris/lutece/plugins/grusupply/service/notifyers/SendSmsService.java 0 0 4
fr/paris/lutece/plugins/grusupply/service/notifyers/SendStatisticsService.java 0 0 4
fr/paris/lutece/plugins/grusupply/utils/GrusupplyUtils.java 0 0 4
fr/paris/lutece/plugins/grusupply/web/rs/DemandNotificationRestService.java 0 0 25
fr/paris/lutece/plugins/grusupply/web/rs/GRUSupplyRestService.java 0 1 22

Rules

Category Rule Violations Severity
blocks LeftCurly
  • option: "nl"
4
 Error
coding ExplicitInitialization 2
 Error
HiddenField 8
 Error
ParameterAssignment 1
 Error
ReturnCount
  • max: "5"
1
 Warning
design FinalClass 1
 Error
HideUtilityClassConstructor 2
 Error
header Header
  • fileExtensions: "java"
  • headerFile: "/opt/datas/jenkins/home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"
13
 Error
imports UnusedImports 2
 Error
javadoc JavadocMethod 54
 Error
JavadocType 7
 Error
naming ParameterName
  • format: "^[a-z][a-zA-Z0-9]*$"
8
 Error
StaticVariableName
  • format: "^_[a-z](_?[a-zA-Z0-9])*$"
2
 Error
whitespace ParenPad
  • option: "space"
36
 Error

Details

fr/paris/lutece/plugins/grusupply/business/GruSupplyEmail.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/grusupply/business/StatusMessage.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
whitespace ParenPad '(' is not followed by whitespace. 28
 Error
coding HiddenField '_strType' hides a field. 28
 Error
javadoc JavadocMethod Expected @param tag for '_strType'. 28
 Error
naming ParameterName Name '_strType' must match pattern '^[a-z][a-zA-Z0-9]*$'. 28
 Error
coding HiddenField '_strStatus' hides a field. 28
 Error
javadoc JavadocMethod Expected @param tag for '_strStatus'. 28
 Error
naming ParameterName Name '_strStatus' must match pattern '^[a-z][a-zA-Z0-9]*$'. 28
 Error
coding HiddenField '_strReason' hides a field. 28
 Error
javadoc JavadocMethod Expected @param tag for '_strReason'. 28
 Error
naming ParameterName Name '_strReason' must match pattern '^[a-z][a-zA-Z0-9]*$'. 28
 Error
coding HiddenField '_strMessage' hides a field. 28
 Error
naming ParameterName Name '_strMessage' must match pattern '^[a-z][a-zA-Z0-9]*$'. 28
 Error
whitespace ParenPad ')' is not preceded with whitespace. 28
 Error
whitespace ParenPad '(' is not followed by whitespace. 53
 Error
coding HiddenField '_strType' hides a field. 53
 Error
naming ParameterName Name '_strType' must match pattern '^[a-z][a-zA-Z0-9]*$'. 53
 Error
whitespace ParenPad ')' is not preceded with whitespace. 53
 Error
whitespace ParenPad '(' is not followed by whitespace. 73
 Error
coding HiddenField '_strStatus' hides a field. 73
 Error
naming ParameterName Name '_strStatus' must match pattern '^[a-z][a-zA-Z0-9]*$'. 73
 Error
whitespace ParenPad ')' is not preceded with whitespace. 73
 Error
whitespace ParenPad '(' is not followed by whitespace. 93
 Error
coding HiddenField '_strReason' hides a field. 93
 Error
naming ParameterName Name '_strReason' must match pattern '^[a-z][a-zA-Z0-9]*$'. 93
 Error
whitespace ParenPad ')' is not preceded with whitespace. 93
 Error
whitespace ParenPad '(' is not followed by whitespace. 113
 Error
coding HiddenField '_strMessage' hides a field. 113
 Error
naming ParameterName Name '_strMessage' must match pattern '^[a-z][a-zA-Z0-9]*$'. 113
 Error
whitespace ParenPad ')' is not preceded with whitespace. 113
 Error
whitespace ParenPad '(' is not followed by whitespace. 128
 Error
whitespace ParenPad ')' is not preceded with whitespace. 128
 Error
whitespace ParenPad '(' is not followed by whitespace. 128
 Error
whitespace ParenPad ')' is not preceded with whitespace. 128
 Error
whitespace ParenPad '(' is not followed by whitespace. 128
 Error
whitespace ParenPad ')' is not preceded with whitespace. 128
 Error
whitespace ParenPad '(' is not followed by whitespace. 128
 Error
whitespace ParenPad ')' is not preceded with whitespace. 128
 Error
whitespace ParenPad ')' is not preceded with whitespace. 128
 Error
whitespace ParenPad '(' is not followed by whitespace. 129
 Error
whitespace ParenPad ')' is not preceded with whitespace. 129
 Error
whitespace ParenPad '(' is not followed by whitespace. 129
 Error
whitespace ParenPad ')' is not preceded with whitespace. 129
 Error
whitespace ParenPad '(' is not followed by whitespace. 129
 Error
whitespace ParenPad ')' is not preceded with whitespace. 129
 Error
whitespace ParenPad '(' is not followed by whitespace. 129
 Error
whitespace ParenPad ')' is not preceded with whitespace. 129
 Error
whitespace ParenPad ')' is not preceded with whitespace. 129

fr/paris/lutece/plugins/grusupply/constant/GruSupplyConstants.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 36

fr/paris/lutece/plugins/grusupply/service/CustomerProvider.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
naming StaticVariableName Name 'bIsInitialized' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 82
 Error
coding ExplicitInitialization Variable 'bIsInitialized' explicitly initialized to 'false' (default value for its type). 82
 Error
javadoc JavadocMethod Expected @return tag. 90
 Error
coding ParameterAssignment Assignment of parameter 'strGuid' is not allowed. 148

fr/paris/lutece/plugins/grusupply/service/GruSupplyPlugin.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/grusupply/service/NotificationService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - fr.paris.lutece.plugins.crmclient.util.CRMException. 36
 Error
javadoc JavadocType Missing a Javadoc comment. 47
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 47
 Error
naming StaticVariableName Name 'bIsInitialized' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 51
 Error
coding ExplicitInitialization Variable 'bIsInitialized' explicitly initialized to 'false' (default value for its type). 51
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 90

fr/paris/lutece/plugins/grusupply/service/notifyers/NotifyCrmService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - com.fasterxml.jackson.databind.JsonMappingException. 52
 Error
javadoc JavadocType Missing a Javadoc comment. 62
 Error
javadoc JavadocMethod Expected @param tag for 'notif'. 120
 Error
javadoc JavadocMethod Expected @throws tag for 'CRMException'. 120
 Error
javadoc JavadocMethod Expected @throws tag for 'CRMException'. 187
 Error
javadoc JavadocMethod Unused @param tag for 'crmItem'. 209
 Error
javadoc JavadocMethod Expected @throws tag for 'CRMException'. 216
 Error
blocks LeftCurly '{' at column 29 should be on a new line. 310

fr/paris/lutece/plugins/grusupply/service/notifyers/SendEmailService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 46
 Error
blocks LeftCurly '{' at column 29 should be on a new line. 59
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 83
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 106
 Error
javadoc JavadocMethod Expected @param tag for 'lstEmailAdress'. 133
 Error
javadoc JavadocMethod Expected @param tag for 'email'. 158

fr/paris/lutece/plugins/grusupply/service/notifyers/SendSmsService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 43
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 55
 Error
blocks LeftCurly '{' at column 29 should be on a new line. 66

fr/paris/lutece/plugins/grusupply/service/notifyers/SendStatisticsService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 52
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 67
 Error
blocks LeftCurly '{' at column 33 should be on a new line. 112

fr/paris/lutece/plugins/grusupply/utils/GrusupplyUtils.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design FinalClass Class GrusupplyUtils should be declared as final. 49
 Error
javadoc JavadocMethod Expected @return tag. 75
 Error
javadoc JavadocMethod Expected @param tag for 'object'. 75

fr/paris/lutece/plugins/grusupply/web/rs/DemandNotificationRestService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Expected @return tag. 88
 Error
javadoc JavadocMethod Expected @param tag for 'strIdDemandType'. 91
 Error
javadoc JavadocMethod Expected @param tag for 'strIndex'. 92
 Error
javadoc JavadocMethod Expected @param tag for 'strCustomerId'. 93
 Error
javadoc JavadocMethod Expected @param tag for 'strNotificationType'. 94
 Error
javadoc JavadocMethod Expected @param tag for 'strIdDemandType'. 122
 Error
javadoc JavadocMethod Expected @param tag for 'strIndex'. 123
 Error
javadoc JavadocMethod Expected @param tag for 'strCustomerId'. 124
 Error
javadoc JavadocMethod Expected @param tag for 'strListStatus'. 125
 Error
javadoc JavadocMethod Expected @param tag for 'strNotificationType'. 126
 Error
javadoc JavadocMethod Expected @return tag. 154
 Error
javadoc JavadocMethod Expected @param tag for 'result'. 154
 Error
javadoc JavadocMethod Expected @param tag for 'nIndex'. 154
 Error
javadoc JavadocMethod Expected @param tag for 'nDefaultItemsPerPage'. 154
 Error
javadoc JavadocMethod Expected @param tag for 'listIds'. 154
 Error
javadoc JavadocMethod Expected @param tag for 'listIds'. 176
 Error
whitespace ParenPad '(' is not followed by whitespace. 188
 Error
whitespace ParenPad ')' is not preceded with whitespace. 188
 Error
javadoc JavadocMethod Expected @param tag for 'demand'. 197
 Error
javadoc JavadocMethod Expected @return tag. 231
 Error
javadoc JavadocMethod Expected @param tag for 'strIdDemand'. 234
 Error
javadoc JavadocMethod Expected @param tag for 'strIdDemandType'. 235
 Error
javadoc JavadocMethod Expected @param tag for 'strCustomerId'. 236
 Error
whitespace ParenPad ')' is not preceded with whitespace. 255

fr/paris/lutece/plugins/grusupply/web/rs/GRUSupplyRestService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 77
 Warning
coding ReturnCount Return count is 6 (max allowed for non-void methods/lambdas is 5). 114
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 248
 Error
whitespace ParenPad ')' is not preceded with whitespace. 254
 Error
javadoc JavadocMethod Expected @param tag for 'notif'. 279
 Error
javadoc JavadocMethod Expected @return tag. 315
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 315
 Error
javadoc JavadocMethod Expected @param tag for 'strResponseStatus'. 315
 Error
javadoc JavadocMethod Expected @param tag for 'strErrorMessage'. 315
 Error
whitespace ParenPad ')' is not preceded with whitespace. 315
 Error
javadoc JavadocMethod Expected @return tag. 435
 Error
javadoc JavadocMethod Expected @param tag for 'notification'. 435
 Error
javadoc JavadocMethod Unused @param tag for 'notification'. 468
 Error
javadoc JavadocMethod Expected @param tag for 'notificationEvent'. 471
 Error
javadoc JavadocMethod Unused @param tag for 'strMessage'. 481
 Error
javadoc JavadocMethod Expected @param tag for 'httpStatus'. 487
 Error
javadoc JavadocMethod Unused @param tag for 'strMessage'. 507
 Error
javadoc JavadocMethod Unused @param tag for 'ex'. 509
 Error
javadoc JavadocMethod Expected @param tag for 'warnings'. 513
 Error
whitespace ParenPad '(' is not followed by whitespace. 517
 Error
whitespace ParenPad ')' is not preceded with whitespace. 517
 Error
whitespace ParenPad ')' is not preceded with whitespace. 525