Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

fr/paris/lutece/plugins/html/business/portlet/BaseHtmlPortletDAO.java

Rule Violation Line
ShortVariable Avoid variables with short names like p 63
ShortVariable Avoid variables with short names like p 97

fr/paris/lutece/plugins/html/business/portlet/HtmlPortlet.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5558

fr/paris/lutece/plugins/html/business/portlet/HtmlPortletHome.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 50
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 50
CallSuperInConstructor It is a good practice to call super() in a constructor 5561
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 74
NonThreadSafeSingleton Singleton is not thread safe 8487

fr/paris/lutece/plugins/html/business/portlet/UntransformedHtmlPortletHome.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 50
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 50
CallSuperInConstructor It is a good practice to call super() in a constructor 5561
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 74
NonThreadSafeSingleton Singleton is not thread safe 8487

fr/paris/lutece/plugins/html/web/portlet/HtmlPortletJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 104
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 104
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 130
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 130
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strErrorUrl' 171
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 284

Priority 4

fr/paris/lutece/plugins/html/web/portlet/HtmlPortletJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.html.HtmlCleanerException' 44

Files

fr/paris/lutece/plugins/html/business/portlet/BaseHtmlPortletDAO.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like p 3 63
ShortVariable Avoid variables with short names like p 3 97

fr/paris/lutece/plugins/html/business/portlet/HtmlPortlet.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5558

fr/paris/lutece/plugins/html/business/portlet/HtmlPortletHome.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 50
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 50
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5561
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 3 74
NonThreadSafeSingleton Singleton is not thread safe 3 8487

fr/paris/lutece/plugins/html/business/portlet/UntransformedHtmlPortletHome.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 50
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 50
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5561
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 3 74
NonThreadSafeSingleton Singleton is not thread safe 3 8487

fr/paris/lutece/plugins/html/web/portlet/HtmlPortletJspBean.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.html.HtmlCleanerException' 4 44
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 104
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 104
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 130
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 130
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strErrorUrl' 3 171
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 284