Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/html2pdf/service/PdfConverterService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 42–101

fr/paris/lutece/plugins/html2pdf/utils/FontBuilder.java

Rule Violation Line
ClassNamingConventions The utility class name 'FontBuilder' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 46–86

Priority 3

fr/paris/lutece/plugins/html2pdf/service/IPdfBuilder.java

Rule Violation Line
CommentRequired Header comments are required 41–88
UnnecessaryModifier Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type 56
UnnecessaryModifier Unnecessary modifier 'public' on method 'withHtmlContent': the method is declared in an interface type 64
UnnecessaryModifier Unnecessary modifier 'public' on method 'notEditable': the method is declared in an interface type 71
UnnecessaryModifier Unnecessary modifier 'public' on method 'withOptions': the method is declared in an interface type 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'render': the method is declared in an interface type 87

fr/paris/lutece/plugins/html2pdf/service/PdfConverterService.java

Rule Violation Line
CommentRequired Header comments are required 42–101
ImmutableField Private field '_pdfBuilders' could be made final; it is only initialized in the declaration or constructor. 45
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 45
ImmutableField Private field '_currentPdfBuilder' could be made final; it is only initialized in the declaration or constructor. 46
NonThreadSafeSingleton Singleton is not thread safe 73–76

fr/paris/lutece/plugins/html2pdf/service/PdfConverterServiceException.java

Rule Violation Line
CommentRequired Header comments are required 36–52
ShortVariable Avoid variables with short names like t 48

fr/paris/lutece/plugins/html2pdf/service/impl/OpenHtmlToPdfBuilder.java

Rule Violation Line
CommentRequired Header comments are required 50–135
RedundantFieldInitializer Avoid using redundant field initializer for '_doc' 59
SingularField Perhaps '_doc' could be replaced by a local variable. 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 131

fr/paris/lutece/plugins/html2pdf/utils/FontBuilder.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 47–86
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 54
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 60–63

fr/paris/lutece/plugins/html2pdf/utils/PDDocumentUtils.java

Rule Violation Line
CommentRequired Header comments are required 49–138
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 50–138
ControlStatementBraces This statement should have braces 84

Priority 4

fr/paris/lutece/plugins/html2pdf/service/impl/OpenHtmlToPdfBuilder.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.HashMap' 38

fr/paris/lutece/plugins/html2pdf/utils/PDDocumentUtils.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.awt.image.BufferedImage' 36
UnusedImports Avoid unused imports such as 'java.nio.charset.StandardCharsets' 38
UnusedImports Avoid unused imports such as 'java.util.HashMap' 39
UnusedImports Avoid unused imports such as 'java.util.Map' 40

Files

fr/paris/lutece/plugins/html2pdf/service/IPdfBuilder.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–88
UnnecessaryModifier Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type 3 56
UnnecessaryModifier Unnecessary modifier 'public' on method 'withHtmlContent': the method is declared in an interface type 3 64
UnnecessaryModifier Unnecessary modifier 'public' on method 'notEditable': the method is declared in an interface type 3 71
UnnecessaryModifier Unnecessary modifier 'public' on method 'withOptions': the method is declared in an interface type 3 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'render': the method is declared in an interface type 3 87

fr/paris/lutece/plugins/html2pdf/service/PdfConverterService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 42–101
CommentRequired Header comments are required 3 42–101
ImmutableField Private field '_pdfBuilders' could be made final; it is only initialized in the declaration or constructor. 3 45
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 45
ImmutableField Private field '_currentPdfBuilder' could be made final; it is only initialized in the declaration or constructor. 3 46
NonThreadSafeSingleton Singleton is not thread safe 3 73–76

fr/paris/lutece/plugins/html2pdf/service/PdfConverterServiceException.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 36–52
ShortVariable Avoid variables with short names like t 3 48

fr/paris/lutece/plugins/html2pdf/service/impl/OpenHtmlToPdfBuilder.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.HashMap' 4 38
CommentRequired Header comments are required 3 50–135
RedundantFieldInitializer Avoid using redundant field initializer for '_doc' 3 59
SingularField Perhaps '_doc' could be replaced by a local variable. 3 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 131

fr/paris/lutece/plugins/html2pdf/utils/FontBuilder.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'FontBuilder' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 46–86
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 47–86
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 54
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 60–63

fr/paris/lutece/plugins/html2pdf/utils/PDDocumentUtils.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.awt.image.BufferedImage' 4 36
UnusedImports Avoid unused imports such as 'java.nio.charset.StandardCharsets' 4 38
UnusedImports Avoid unused imports such as 'java.util.HashMap' 4 39
UnusedImports Avoid unused imports such as 'java.util.Map' 4 40
CommentRequired Header comments are required 3 49–138
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 50–138
ControlStatementBraces This statement should have braces 3 84