The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 44–233 |
| FieldNamingConventions | The field name 'name' doesn't match '_[a-z][a-zA-Z0-9]*' | 47 |
| FieldNamingConventions | The field name 'description' doesn't match '_[a-z][a-zA-Z0-9]*' | 48 |
| FieldNamingConventions | The field name 'value' doesn't match '_[a-z][a-zA-Z0-9]*' | 49 |
| FieldNamingConventions | The field name 'certifier' doesn't match '_[a-z][a-zA-Z0-9]*' | 50 |
| FieldNamingConventions | The field name 'certificationLevel' doesn't match '_[a-z][a-zA-Z0-9]*' | 51 |
| FieldNamingConventions | The field name 'certificationDate' doesn't match '_[a-z][a-zA-Z0-9]*' | 52 |
| FieldNamingConventions | The field name 'mandatory' doesn't match '_[a-z][a-zA-Z0-9]*' | 53 |
| FieldNamingConventions | The field name 'allowedCertificationList' doesn't match '_[a-z][a-zA-Z0-9]*' | 54 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'tasks' doesn't match '_[a-z][a-zA-Z0-9]*' | 54 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' | 50 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' | 53 |
| FieldNamingConventions | The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' | 55 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 56 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' | 50 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'tasks' doesn't match '_[a-z][a-zA-Z0-9]*' | 44 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 15–66 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 17 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 23–82 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 24 |
| FieldNamingConventions | The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' | 25 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_serviceContractCache' doesn't match '[A-Z][A-Z_0-9]*' | 193 |
| FieldNamingConventions | The constant name '_serviceProcessusReferentialCache' doesn't match '[A-Z][A-Z_0-9]*' | 194 |
| FieldNamingConventions | The constant name '_serviceAttributeKeyReferentialCache' doesn't match '[A-Z][A-Z_0-9]*' | 196 |
| FieldNamingConventions | The final field name '_identityService' doesn't match '[a-z][a-zA-Z0-9]*' | 211 |
| FieldNamingConventions | The final field name '_accountCreationTaskMinLevel' doesn't match '[a-z][a-zA-Z0-9]*' | 212 |
| FieldNamingConventions | The final field name '_autocompleteCityEndpoint' doesn't match '[a-z][a-zA-Z0-9]*' | 213 |
| FieldNamingConventions | The final field name '_autocompleteCountryEndpoint' doesn't match '[a-z][a-zA-Z0-9]*' | 214 |
| FieldNamingConventions | The final field name '_searchRules' doesn't match '[a-z][a-zA-Z0-9]*' | 215 |
| FieldNamingConventions | The final field name '_searchAttributeKeyStrictList' doesn't match '[a-z][a-zA-Z0-9]*' | 219 |
| FieldNamingConventions | The final field name '_AttributeInfoKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 222 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 65 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 75 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 71 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 81 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 65 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 75 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 78 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'LocalAttributeDto' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=12, WMC=22) | 44–233 |
| CommentRequired | Header comments are required | 44–233 |
| ImmutableField | Private field 'name' could be made final; it is only initialized in the declaration or constructor. | 47 |
| ImmutableField | Private field 'description' could be made final; it is only initialized in the declaration or constructor. | 48 |
| ImmutableField | Private field 'mandatory' could be made final; it is only initialized in the declaration or constructor. | 53 |
| ImmutableField | Private field 'allowedCertificationList' could be made final; it is only initialized in the declaration or constructor. | 54 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 61 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 62 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 63 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 64 |
| CommentRequired | Public method and constructor comments are required | 83–86 |
| CommentRequired | Public method and constructor comments are required | 128–131 |
| CommentRequired | Public method and constructor comments are required | 138–141 |
| ControlStatementBraces | This statement should have braces | 213 |
| ControlStatementBraces | This statement should have braces | 220 |
| ControlStatementBraces | This statement should have braces | 225 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'LocalIdentityDto' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=6) | 49–87 |
| UnusedPrivateField | Avoid unused private fields such as 'lastUpdateDate'. | 52 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 58 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 60 |
| CommentRequired | Public method and constructor comments are required | 63–68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–92 |
| CommentRequired | Public method and constructor comments are required | 52–56 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 52–56 |
| CommentRequired | Public method and constructor comments are required | 58–66 |
| CommentRequired | Public method and constructor comments are required | 68–76 |
| CommentRequired | Public method and constructor comments are required | 78–85 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 49–142 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–62 |
| CommentRequired | Public method and constructor comments are required | 58–62 |
| CommentRequired | Public method and constructor comments are required | 64–72 |
| CommentRequired | Public method and constructor comments are required | 74–82 |
| CommentRequired | Public method and constructor comments are required | 84–93 |
| CommentRequired | Public method and constructor comments are required | 95–102 |
| ShortVariable | Avoid variables with short names like i1 | 116 |
| ShortVariable | Avoid variables with short names like i2 | 117 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–91 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 52–56 |
| CommentRequired | Public method and constructor comments are required | 52–56 |
| CommentRequired | Public method and constructor comments are required | 58–66 |
| CommentRequired | Public method and constructor comments are required | 68–76 |
| CommentRequired | Public method and constructor comments are required | 78–84 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–71 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 46–62 |
| CommentRequired | Public method and constructor comments are required | 46–62 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–60 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–102 |
| ShortVariable | Avoid variables with short names like rt | 59 |
| ShortVariable | Avoid variables with short names like s | 97 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 15–66 |
| ImmutableField | Private field '_currentClientCode' could be made final; it is only initialized in the declaration or constructor. | 19 |
| CommentRequired | Public method and constructor comments are required | 26–32 |
| NonThreadSafeSingleton | Singleton is not thread safe | 27–29 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 50–51 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 23–82 |
| CommentRequired | Public method and constructor comments are required | 31–39 |
| NonThreadSafeSingleton | Singleton is not thread safe | 33–36 |
| CommentRequired | Public method and constructor comments are required | 41–45 |
| CommentRequired | Public method and constructor comments are required | 47–68 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1297 |
| GodClass | Possible God Class (WMC=85, ATFD=158, TCC=28.506%) | 106–1297 |
| CyclomaticComplexity | The class 'IdentityJspBean' has a total cyclomatic complexity of 85 (highest 9). | 106–1297 |
| ExcessiveClassLength | Avoid really long classes. | 106–1297 |
| TooManyFields | Too many fields | 106–1297 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 107–1297 |
| ImmutableField | Private field '_attributeStatuses' could be made final; it is only initialized in the declaration or constructor. | 204 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_returnUrl' | 206 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _canCreateIdentity field if you want a default access modifier | 208 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 208 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_canCreateIdentity' | 208 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _canWriteIdentity field if you want a default access modifier | 209 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_canWriteIdentity' | 209 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 209 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 217 |
| CommentRequired | Public method and constructor comments are required | 229–280 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 234 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 244 |
| AvoidDuplicateLiterals | The String literal "Error while retrieving selected identity [customerId = " appears 4 times in this file; the first occurrence is on line 253 | 253 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 303 |
| CommentRequired | Public method and constructor comments are required | 345–382 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 359 |
| CommentRequired | Public method and constructor comments are required | 385–388 |
| CommentRequired | Public method and constructor comments are required | 391–394 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 405 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 406 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 412 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 433 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 481 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 641–654 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 686 |
| CyclomaticComplexity | The method 'doModifyIdentity(HttpServletRequest)' has a cyclomatic complexity of 10. | 727–802 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 749 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 778–791 |
| AvoidDuplicateLiterals | The String literal "yyyy-MM-dd" appears 4 times in this file; the first occurrence is on line 818 | 818 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 818 |
| AvoidDuplicateLiterals | The String literal "dd/MM/yyyy" appears 4 times in this file; the first occurrence is on line 819 | 819 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 819 |
| AvoidDuplicateLiterals | The String literal "Can't convert the date: " appears 4 times in this file; the first occurrence is on line 823 | 823 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 858–862 |
| NPathComplexity | The method 'collectSearchAttributes(HttpServletRequest)' has an NPath complexity of 750 | 875–936 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 896 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 897 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 923 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 957 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 958 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 1033 |
| NPathComplexity | The method 'getIdentityFromRequest(HttpServletRequest, String, Boolean)' has an NPath complexity of 320 | 1048–1101 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 1061 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 1065 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 1066 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1235 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 35, but has at least 53 characters appended. | 1251 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 97 characters appended. | 1285 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 1285 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.common.AttributeDto' | 36 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.common.IdentityDto' | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.contract.ServiceContractDto' | 38 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.collections.CollectionUtils' | 40 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.history.IdentityHistorySearchRequest' | 8 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'LocalAttributeDto' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=12, WMC=22) | 3 | 44–233 |
| CommentRequired | Header comments are required | 3 | 44–233 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 44–233 |
| FieldNamingConventions | The field name 'name' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 47 |
| ImmutableField | Private field 'name' could be made final; it is only initialized in the declaration or constructor. | 3 | 47 |
| ImmutableField | Private field 'description' could be made final; it is only initialized in the declaration or constructor. | 3 | 48 |
| FieldNamingConventions | The field name 'description' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 48 |
| FieldNamingConventions | The field name 'value' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 49 |
| FieldNamingConventions | The field name 'certifier' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 50 |
| FieldNamingConventions | The field name 'certificationLevel' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 51 |
| FieldNamingConventions | The field name 'certificationDate' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 52 |
| ImmutableField | Private field 'mandatory' could be made final; it is only initialized in the declaration or constructor. | 3 | 53 |
| FieldNamingConventions | The field name 'mandatory' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 53 |
| FieldNamingConventions | The field name 'allowedCertificationList' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 54 |
| ImmutableField | Private field 'allowedCertificationList' could be made final; it is only initialized in the declaration or constructor. | 3 | 54 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 61 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 62 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 63 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 64 |
| CommentRequired | Public method and constructor comments are required | 3 | 83–86 |
| CommentRequired | Public method and constructor comments are required | 3 | 128–131 |
| CommentRequired | Public method and constructor comments are required | 3 | 138–141 |
| ControlStatementBraces | This statement should have braces | 3 | 213 |
| ControlStatementBraces | This statement should have braces | 3 | 220 |
| ControlStatementBraces | This statement should have braces | 3 | 225 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.common.AttributeDto' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.common.IdentityDto' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.contract.ServiceContractDto' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.collections.CollectionUtils' | 4 | 40 |
| DataClass | The class 'LocalIdentityDto' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=6) | 3 | 49–87 |
| UnusedPrivateField | Avoid unused private fields such as 'lastUpdateDate'. | 3 | 52 |
| FieldNamingConventions | The field name 'tasks' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 54 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 58 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 60 |
| CommentRequired | Public method and constructor comments are required | 3 | 63–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–92 |
| FieldNamingConventions | The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 50 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–56 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 52–56 |
| CommentRequired | Public method and constructor comments are required | 3 | 58–66 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 65 |
| CommentRequired | Public method and constructor comments are required | 3 | 68–76 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 75 |
| CommentRequired | Public method and constructor comments are required | 3 | 78–85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 49–142 |
| FieldNamingConventions | The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 53 |
| FieldNamingConventions | The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 55 |
| FieldNamingConventions | The final field name '_sortedAttributeKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 56 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 58–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–72 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 71 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–82 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 81 |
| CommentRequired | Public method and constructor comments are required | 3 | 84–93 |
| CommentRequired | Public method and constructor comments are required | 3 | 95–102 |
| ShortVariable | Avoid variables with short names like i1 | 3 | 116 |
| ShortVariable | Avoid variables with short names like i2 | 3 | 117 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–91 |
| FieldNamingConventions | The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 50 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 52–56 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–56 |
| CommentRequired | Public method and constructor comments are required | 3 | 58–66 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 65 |
| CommentRequired | Public method and constructor comments are required | 3 | 68–76 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 75 |
| CommentRequired | Public method and constructor comments are required | 3 | 78–84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–71 |
| FieldNamingConventions | The field name 'tasks' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 44 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 46–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 46–62 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–60 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–102 |
| ShortVariable | Avoid variables with short names like rt | 3 | 59 |
| ShortVariable | Avoid variables with short names like s | 3 | 97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.history.IdentityHistorySearchRequest' | 4 | 8 |
| CommentRequired | Header comments are required | 3 | 15–66 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 15–66 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 17 |
| ImmutableField | Private field '_currentClientCode' could be made final; it is only initialized in the declaration or constructor. | 3 | 19 |
| CommentRequired | Public method and constructor comments are required | 3 | 26–32 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 27–29 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 50–51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 23–82 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 23–82 |
| FieldNamingConventions | The constant name '_serviceIdentity' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 24 |
| FieldNamingConventions | The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 25 |
| CommentRequired | Public method and constructor comments are required | 3 | 31–39 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 33–36 |
| CommentRequired | Public method and constructor comments are required | 3 | 41–45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47–68 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 78 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1297 |
| GodClass | Possible God Class (WMC=85, ATFD=158, TCC=28.506%) | 3 | 106–1297 |
| CyclomaticComplexity | The class 'IdentityJspBean' has a total cyclomatic complexity of 85 (highest 9). | 3 | 106–1297 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 106–1297 |
| TooManyFields | Too many fields | 3 | 106–1297 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 107–1297 |
| FieldNamingConventions | The constant name '_serviceContractCache' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 193 |
| FieldNamingConventions | The constant name '_serviceProcessusReferentialCache' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 194 |
| FieldNamingConventions | The constant name '_serviceAttributeKeyReferentialCache' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 196 |
| ImmutableField | Private field '_attributeStatuses' could be made final; it is only initialized in the declaration or constructor. | 3 | 204 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_returnUrl' | 3 | 206 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _canCreateIdentity field if you want a default access modifier | 3 | 208 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 208 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_canCreateIdentity' | 3 | 208 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _canWriteIdentity field if you want a default access modifier | 3 | 209 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_canWriteIdentity' | 3 | 209 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 209 |
| FieldNamingConventions | The final field name '_identityService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 211 |
| FieldNamingConventions | The final field name '_accountCreationTaskMinLevel' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 212 |
| FieldNamingConventions | The final field name '_autocompleteCityEndpoint' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 213 |
| FieldNamingConventions | The final field name '_autocompleteCountryEndpoint' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 214 |
| FieldNamingConventions | The final field name '_searchRules' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 215 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 217 |
| FieldNamingConventions | The final field name '_searchAttributeKeyStrictList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 219 |
| FieldNamingConventions | The final field name '_AttributeInfoKeyList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 222 |
| CommentRequired | Public method and constructor comments are required | 3 | 229–280 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 234 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 244 |
| AvoidDuplicateLiterals | The String literal "Error while retrieving selected identity [customerId = " appears 4 times in this file; the first occurrence is on line 253 | 3 | 253 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 303 |
| CommentRequired | Public method and constructor comments are required | 3 | 345–382 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 359 |
| CommentRequired | Public method and constructor comments are required | 3 | 385–388 |
| CommentRequired | Public method and constructor comments are required | 3 | 391–394 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 405 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 406 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 412 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 433 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 481 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 641–654 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 686 |
| CyclomaticComplexity | The method 'doModifyIdentity(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 727–802 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 749 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 778–791 |
| AvoidDuplicateLiterals | The String literal "yyyy-MM-dd" appears 4 times in this file; the first occurrence is on line 818 | 3 | 818 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 818 |
| AvoidDuplicateLiterals | The String literal "dd/MM/yyyy" appears 4 times in this file; the first occurrence is on line 819 | 3 | 819 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 819 |
| AvoidDuplicateLiterals | The String literal "Can't convert the date: " appears 4 times in this file; the first occurrence is on line 823 | 3 | 823 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 858–862 |
| NPathComplexity | The method 'collectSearchAttributes(HttpServletRequest)' has an NPath complexity of 750 | 3 | 875–936 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 896 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 897 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 923 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 957 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 958 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 3 | 1033 |
| NPathComplexity | The method 'getIdentityFromRequest(HttpServletRequest, String, Boolean)' has an NPath complexity of 320 | 3 | 1048–1101 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 1061 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 1065 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 1066 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1235 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 35, but has at least 53 characters appended. | 3 | 1251 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 97 characters appended. | 3 | 1285 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 1285 |
