Le document suivant contient les résultats de PMD 6.13.0.
Rule | Violation | Ligne |
---|---|---|
FieldNamingConventions | The field name 'certificateDate' doesn't match '_[a-z][a-zA-Z0-9]*' | 4 |
FieldNamingConventions | The field name 'lastUpdateClientCode' doesn't match '_[a-z][a-zA-Z0-9]*' | 5 |
FieldNamingConventions | The field name 'name' doesn't match '_[a-z][a-zA-Z0-9]*' | 6 |
FieldNamingConventions | The field name 'description' doesn't match '_[a-z][a-zA-Z0-9]*' | 7 |
FieldNamingConventions | The field name 'pivot' doesn't match '_[a-z][a-zA-Z0-9]*' | 8 |
FieldNamingConventions | The field name 'certifierCode' doesn't match '_[a-z][a-zA-Z0-9]*' | 9 |
FieldNamingConventions | The field name 'certificateExpirationDate' doesn't match '_[a-z][a-zA-Z0-9]*' | 10 |
FieldNamingConventions | The field name 'type' doesn't match '_[a-z][a-zA-Z0-9]*' | 11 |
FieldNamingConventions | The field name 'value' doesn't match '_[a-z][a-zA-Z0-9]*' | 12 |
FieldNamingConventions | The field name 'certifierName' doesn't match '_[a-z][a-zA-Z0-9]*' | 13 |
FieldNamingConventions | The field name 'key' doesn't match '_[a-z][a-zA-Z0-9]*' | 14 |
Rule | Violation | Ligne |
---|---|---|
FieldNamingConventions | The field name 'took' doesn't match '_[a-z][a-zA-Z0-9]*' | 6 |
FieldNamingConventions | The field name 'timedOut' doesn't match '_[a-z][a-zA-Z0-9]*' | 7 |
FieldNamingConventions | The field name 'shards' doesn't match '_[a-z][a-zA-Z0-9]*' | 8 |
FieldNamingConventions | The field name 'hits' doesn't match '_[a-z][a-zA-Z0-9]*' | 9 |
FieldNamingConventions | The field name '_scroll_id' doesn't match '_[a-z][a-zA-Z0-9]*' | 10 |
FieldNamingConventions | The field name 'pit_id' doesn't match '_[a-z][a-zA-Z0-9]*' | 11 |
MethodNamingConventions | The instance method name 'get_scroll_id' doesn't match '[a-z][a-zA-Z0-9]*' | 13–15 |
FormalParameterNamingConventions | The method parameter name '_scroll_id' doesn't match '[a-z][a-zA-Z0-9]*' | 17 |
MethodNamingConventions | The instance method name 'set_scroll_id' doesn't match '[a-z][a-zA-Z0-9]*' | 17–19 |
MethodNamingConventions | The instance method name 'getPit_id' doesn't match '[a-z][a-zA-Z0-9]*' | 53–55 |
FormalParameterNamingConventions | The method parameter name 'pit_id' doesn't match '[a-z][a-zA-Z0-9]*' | 57 |
MethodNamingConventions | The instance method name 'setPit_id' doesn't match '[a-z][a-zA-Z0-9]*' | 57–59 |
FieldNamingConventions | The field name 'total' doesn't match '_[a-z][a-zA-Z0-9]*' | 66 |
FieldNamingConventions | The field name 'hits' doesn't match '_[a-z][a-zA-Z0-9]*' | 67 |
FieldNamingConventions | The field name 'value' doesn't match '_[a-z][a-zA-Z0-9]*' | 87 |
FieldNamingConventions | The field name 'relation' doesn't match '_[a-z][a-zA-Z0-9]*' | 88 |
FieldNamingConventions | The field name 'sort' doesn't match '_[a-z][a-zA-Z0-9]*' | 98 |
MethodNamingConventions | The instance method name 'get_source' doesn't match '[a-z][a-zA-Z0-9]*' | 100–102 |
FormalParameterNamingConventions | The method parameter name '_source' doesn't match '[a-z][a-zA-Z0-9]*' | 103 |
MethodNamingConventions | The instance method name 'set_source' doesn't match '[a-z][a-zA-Z0-9]*' | 103–105 |
MethodNamingConventions | The instance method name 'get_score' doesn't match '[a-z][a-zA-Z0-9]*' | 106–108 |
MethodNamingConventions | The instance method name 'set_score' doesn't match '[a-z][a-zA-Z0-9]*' | 109–111 |
FormalParameterNamingConventions | The method parameter name '_score' doesn't match '[a-z][a-zA-Z0-9]*' | 109 |
MethodNamingConventions | The instance method name 'get_id' doesn't match '[a-z][a-zA-Z0-9]*' | 112–114 |
MethodNamingConventions | The instance method name 'set_id' doesn't match '[a-z][a-zA-Z0-9]*' | 115–117 |
FormalParameterNamingConventions | The method parameter name '_id' doesn't match '[a-z][a-zA-Z0-9]*' | 115 |
FieldNamingConventions | The field name 'customerId' doesn't match '_[a-z][a-zA-Z0-9]*' | 128 |
FieldNamingConventions | The field name 'connectionId' doesn't match '_[a-z][a-zA-Z0-9]*' | 129 |
FieldNamingConventions | The field name 'attributes' doesn't match '_[a-z][a-zA-Z0-9]*' | 130 |
Rule | Violation | Ligne |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 106 |
Rule | Violation | Ligne |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 106 |
Rule | Violation | Ligne |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 106 |
Rule | Violation | Ligne |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_bAutoExtract' doesn't match '[a-z][a-zA-Z0-9]*' | 152 |
FormalParameterNamingConventions | The method parameter name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' | 160 |
Rule | Violation | Ligne |
---|---|---|
ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 3–20 |
Rule | Violation | Ligne |
---|---|---|
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 39 |
Rule | Violation | Ligne |
---|---|---|
GuardLogStatement | Logger calls should be surrounded by log level guards. | 100 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 131 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 160 |
Rule | Violation | Ligne |
---|---|---|
GuardLogStatement | Logger calls should be surrounded by log level guards. | 24 |
Rule | Violation | Ligne |
---|---|---|
GuardLogStatement | Logger calls should be surrounded by log level guards. | 81 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 150 |
Rule | Violation | Ligne |
---|---|---|
SystemPrintln | System.out.println is used | 210 |
SystemPrintln | System.out.println is used | 219 |
Rule | Violation | Ligne |
---|---|---|
SystemPrintln | System.out.println is used | 219 |
SystemPrintln | System.out.println is used | 223 |
SystemPrintln | System.out.println is used | 367 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 1–317 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 40–317 |
CommentRequired | Header comments are required | 40–317 |
NPathComplexity | The method 'generateExport(int)' has an NPath complexity of 512 | 52–165 |
ExcessiveMethodLength | Avoid really long methods. | 52–165 |
CyclomaticComplexity | The method 'generateExport(int)' has a cyclomatic complexity of 13. | 52–165 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 56 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 124–143 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 203 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 206 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 207 |
LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 210 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 228–257 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 278 |
Rule | Violation | Ligne |
---|---|---|
DataClass | The class 'Attribute' is suspected to be a Data Class (WOC=0.000%, NOPA=11, NOAM=22, WMC=22) | 3–85 |
CommentRequired | Header comments are required | 3–85 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 5–154 |
DataClass | The class 'ElasticsearchResponseJSON' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=10, WMC=12) | 5–154 |
CommentRequired | Public method and constructor comments are required | 13–15 |
CommentRequired | Public method and constructor comments are required | 17–19 |
CommentRequired | Header comments are required | 61–63 |
DataClass | The class 'Hits' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) | 65–84 |
CommentRequired | Header comments are required | 65–84 |
AvoidFieldNameMatchingTypeName | It is somewhat confusing to have a field name matching the declaring class name | 67 |
CommentRequired | Header comments are required | 86–90 |
UnusedPrivateField | Avoid unused private fields such as 'value'. | 87 |
UnusedPrivateField | Avoid unused private fields such as 'relation'. | 88 |
CommentRequired | Header comments are required | 92–125 |
UnusedPrivateField | Avoid unused private fields such as '_index'. | 93 |
UnusedPrivateField | Avoid unused private fields such as '_type'. | 94 |
CommentRequired | Public method and constructor comments are required | 100–102 |
CommentRequired | Public method and constructor comments are required | 103–105 |
CommentRequired | Public method and constructor comments are required | 106–108 |
CommentRequired | Public method and constructor comments are required | 109–111 |
CommentRequired | Public method and constructor comments are required | 112–114 |
CommentRequired | Public method and constructor comments are required | 115–117 |
ArrayIsStoredDirectly | The user-supplied array 'sort' is stored directly. | 121 |
CommentRequired | Header comments are required | 127–152 |
DataClass | The class 'Source' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=6, WMC=6) | 127–152 |
Rule | Violation | Ligne |
---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 186–188 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 51–317 |
UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECTALL_ID_BY_ID_PROFIL'. | 62 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 233–235 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 46–130 |
Rule | Violation | Ligne |
---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 234–236 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Public method and constructor comments are required | 140–142 |
CommentRequired | Public method and constructor comments are required | 144–146 |
CommentRequired | Public method and constructor comments are required | 148–150 |
CommentRequired | Public method and constructor comments are required | 152–154 |
CommentRequired | Public method and constructor comments are required | 156–158 |
CommentRequired | Public method and constructor comments are required | 160–162 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 11–30 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 11–49 |
ShortVariable | Avoid variables with short names like sb | 19 |
InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 35 characters appended. | 19 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 35 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 3–20 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 23–196 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 23–196 |
AvoidDuplicateLiterals | The String literal " {\n" appears 4 times in this file; the first occurrence is on line 59 | 59 |
IdenticalCatchBranches | 'catch' branch identical to 'JsonMappingException' branch | 184–187 |
IdenticalCatchBranches | 'catch' branch identical to 'JsonMappingException' branch | 188–191 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 17–176 |
ImmutableField | Private field '_profile' could be made final; it is only initialized in the declaration or constructor. | 23 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 28–31 |
MissingOverride | The method 'getId()' is missing an @Override annotation. | 128–131 |
MissingOverride | The method 'getName()' is missing an @Override annotation. | 137–140 |
MissingOverride | The method 'getCertification()' is missing an @Override annotation. | 146–149 |
MissingOverride | The method 'getFileName()' is missing an @Override annotation. | 155–158 |
MissingOverride | The method 'isAutoExtract()' is missing an @Override annotation. | 163–166 |
MissingOverride | The method 'getPassword()' is missing an @Override annotation. | 171–174 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 5–26 |
Rule | Violation | Ligne |
---|---|---|
CommentRequired | Header comments are required | 14–58 |
ShortVariable | Avoid variables with short names like rt | 24 |
Rule | Violation | Ligne |
---|---|---|
ImmutableField | Private field '_storageDir' could be made final; it is only initialized in the declaration or constructor. | 47 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 238 |
CommentRequired | Public method and constructor comments are required | 278–281 |
CommentRequired | Public method and constructor comments are required | 283–286 |
Rule | Violation | Ligne |
---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 50–110 |
DefaultPackage | Use explicit scoping instead of the default package private level | 109 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 109 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 36–397 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 81–397 |
UnusedPrivateField | Avoid unused private fields such as 'ACTION_EXTRACTION_DATA'. | 119 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 141 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 152 |
UnusedLocalVariable | Avoid unused local variables such as 'profilsReferenceList'. | 152 |
DefaultPackage | Use explicit scoping instead of the default package private level | 166–175 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 167–175 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 194 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 199 |
UnusedLocalVariable | Avoid unused local variables such as 'lstProfils'. | 199 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 224 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 352 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 36–547 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 90–547 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 151 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 160 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 160 |
DefaultPackage | Use explicit scoping instead of the default package private level | 177–186 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 178–186 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 206 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 230 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 373 |
CommentRequired | Public method and constructor comments are required | 419–546 |
ExcessiveMethodLength | Avoid really long methods. | 419–546 |
Rule | Violation | Ligne |
---|---|---|
ShortClassName | Avoid short class names like Hits | 65–84 |
ShortClassName | Avoid short class names like Hit | 92–125 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 121 |
Rule | Violation | Ligne |
---|---|---|
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.core.JsonProcessingException' | 12 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.DeserializationFeature' | 13 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.JsonMappingException' | 14 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.JsonNode' | 15 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.ObjectMapper' | 16 |
Rule | Violation | Ligne |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 11 |
Rule | Violation | Ligne |
---|---|---|
UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' | 75 |
Rule | Violation | Ligne |
---|---|---|
UnusedImports | Avoid unused imports such as 'java.util.Collections' | 76 |
UnusedImports | Avoid unused imports such as 'java.util.Iterator' | 79 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 1–317 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 40–317 |
CommentRequired | Header comments are required | 3 | 40–317 |
NPathComplexity | The method 'generateExport(int)' has an NPath complexity of 512 | 3 | 52–165 |
ExcessiveMethodLength | Avoid really long methods. | 3 | 52–165 |
CyclomaticComplexity | The method 'generateExport(int)' has a cyclomatic complexity of 13. | 3 | 52–165 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 56 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 100 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 124–143 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 131 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 160 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 203 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 206 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 207 |
LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 210 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 228–257 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 278 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
DataClass | The class 'Attribute' is suspected to be a Data Class (WOC=0.000%, NOPA=11, NOAM=22, WMC=22) | 3 | 3–85 |
CommentRequired | Header comments are required | 3 | 3–85 |
FieldNamingConventions | The field name 'certificateDate' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 4 |
FieldNamingConventions | The field name 'lastUpdateClientCode' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 5 |
FieldNamingConventions | The field name 'name' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 6 |
FieldNamingConventions | The field name 'description' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 7 |
FieldNamingConventions | The field name 'pivot' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 8 |
FieldNamingConventions | The field name 'certifierCode' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 9 |
FieldNamingConventions | The field name 'certificateExpirationDate' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 10 |
FieldNamingConventions | The field name 'type' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 11 |
FieldNamingConventions | The field name 'value' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 12 |
FieldNamingConventions | The field name 'certifierName' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 13 |
FieldNamingConventions | The field name 'key' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 14 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 5–154 |
DataClass | The class 'ElasticsearchResponseJSON' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=10, WMC=12) | 3 | 5–154 |
FieldNamingConventions | The field name 'took' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 6 |
FieldNamingConventions | The field name 'timedOut' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 7 |
FieldNamingConventions | The field name 'shards' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 8 |
FieldNamingConventions | The field name 'hits' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 9 |
FieldNamingConventions | The field name '_scroll_id' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 10 |
FieldNamingConventions | The field name 'pit_id' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 11 |
CommentRequired | Public method and constructor comments are required | 3 | 13–15 |
MethodNamingConventions | The instance method name 'get_scroll_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 13–15 |
CommentRequired | Public method and constructor comments are required | 3 | 17–19 |
FormalParameterNamingConventions | The method parameter name '_scroll_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 17 |
MethodNamingConventions | The instance method name 'set_scroll_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 17–19 |
MethodNamingConventions | The instance method name 'getPit_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 53–55 |
FormalParameterNamingConventions | The method parameter name 'pit_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 57 |
MethodNamingConventions | The instance method name 'setPit_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 57–59 |
CommentRequired | Header comments are required | 3 | 61–63 |
DataClass | The class 'Hits' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) | 3 | 65–84 |
CommentRequired | Header comments are required | 3 | 65–84 |
ShortClassName | Avoid short class names like Hits | 4 | 65–84 |
FieldNamingConventions | The field name 'total' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 66 |
AvoidFieldNameMatchingTypeName | It is somewhat confusing to have a field name matching the declaring class name | 3 | 67 |
FieldNamingConventions | The field name 'hits' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 67 |
CommentRequired | Header comments are required | 3 | 86–90 |
FieldNamingConventions | The field name 'value' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 87 |
UnusedPrivateField | Avoid unused private fields such as 'value'. | 3 | 87 |
FieldNamingConventions | The field name 'relation' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 88 |
UnusedPrivateField | Avoid unused private fields such as 'relation'. | 3 | 88 |
ShortClassName | Avoid short class names like Hit | 4 | 92–125 |
CommentRequired | Header comments are required | 3 | 92–125 |
UnusedPrivateField | Avoid unused private fields such as '_index'. | 3 | 93 |
UnusedPrivateField | Avoid unused private fields such as '_type'. | 3 | 94 |
FieldNamingConventions | The field name 'sort' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 98 |
CommentRequired | Public method and constructor comments are required | 3 | 100–102 |
MethodNamingConventions | The instance method name 'get_source' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 100–102 |
FormalParameterNamingConventions | The method parameter name '_source' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 103 |
MethodNamingConventions | The instance method name 'set_source' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 103–105 |
CommentRequired | Public method and constructor comments are required | 3 | 103–105 |
CommentRequired | Public method and constructor comments are required | 3 | 106–108 |
MethodNamingConventions | The instance method name 'get_score' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 106–108 |
MethodNamingConventions | The instance method name 'set_score' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 109–111 |
CommentRequired | Public method and constructor comments are required | 3 | 109–111 |
FormalParameterNamingConventions | The method parameter name '_score' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 109 |
CommentRequired | Public method and constructor comments are required | 3 | 112–114 |
MethodNamingConventions | The instance method name 'get_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 112–114 |
CommentRequired | Public method and constructor comments are required | 3 | 115–117 |
MethodNamingConventions | The instance method name 'set_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 115–117 |
FormalParameterNamingConventions | The method parameter name '_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 115 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 121 |
ArrayIsStoredDirectly | The user-supplied array 'sort' is stored directly. | 3 | 121 |
CommentRequired | Header comments are required | 3 | 127–152 |
DataClass | The class 'Source' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=6, WMC=6) | 3 | 127–152 |
FieldNamingConventions | The field name 'customerId' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 128 |
FieldNamingConventions | The field name 'connectionId' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 129 |
FieldNamingConventions | The field name 'attributes' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 130 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 186–188 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–317 |
UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_SELECTALL_ID_BY_ID_PROFIL'. | 3 | 62 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 233–235 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 106 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 46–130 |
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 106 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 106 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 234–236 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
CommentRequired | Public method and constructor comments are required | 3 | 140–142 |
CommentRequired | Public method and constructor comments are required | 3 | 144–146 |
CommentRequired | Public method and constructor comments are required | 3 | 148–150 |
CommentRequired | Public method and constructor comments are required | 3 | 152–154 |
FormalParameterNamingConventions | The method parameter name '_bAutoExtract' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 152 |
CommentRequired | Public method and constructor comments are required | 3 | 156–158 |
FormalParameterNamingConventions | The method parameter name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 160 |
CommentRequired | Public method and constructor comments are required | 3 | 160–162 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 11–30 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 11–49 |
ShortVariable | Avoid variables with short names like sb | 3 | 19 |
InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 35 characters appended. | 3 | 19 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 24 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 35 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 3–20 |
ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 3–20 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.core.JsonProcessingException' | 4 | 12 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.DeserializationFeature' | 4 | 13 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.JsonMappingException' | 4 | 14 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.JsonNode' | 4 | 15 |
DuplicateImports | Avoid duplicate imports such as 'com.fasterxml.jackson.databind.ObjectMapper' | 4 | 16 |
CommentRequired | Header comments are required | 3 | 23–196 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 23–196 |
AvoidDuplicateLiterals | The String literal " {\n" appears 4 times in this file; the first occurrence is on line 59 | 3 | 59 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 81 |
GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 150 |
IdenticalCatchBranches | 'catch' branch identical to 'JsonMappingException' branch | 3 | 184–187 |
IdenticalCatchBranches | 'catch' branch identical to 'JsonMappingException' branch | 3 | 188–191 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 4 | 11 |
CommentRequired | Header comments are required | 3 | 17–176 |
ImmutableField | Private field '_profile' could be made final; it is only initialized in the declaration or constructor. | 3 | 23 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 28–31 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 39 |
MissingOverride | The method 'getId()' is missing an @Override annotation. | 3 | 128–131 |
MissingOverride | The method 'getName()' is missing an @Override annotation. | 3 | 137–140 |
MissingOverride | The method 'getCertification()' is missing an @Override annotation. | 3 | 146–149 |
MissingOverride | The method 'getFileName()' is missing an @Override annotation. | 3 | 155–158 |
MissingOverride | The method 'isAutoExtract()' is missing an @Override annotation. | 3 | 163–166 |
MissingOverride | The method 'getPassword()' is missing an @Override annotation. | 3 | 171–174 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 5–26 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 14–58 |
ShortVariable | Avoid variables with short names like rt | 3 | 24 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ImmutableField | Private field '_storageDir' could be made final; it is only initialized in the declaration or constructor. | 3 | 47 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 238 |
CommentRequired | Public method and constructor comments are required | 3 | 278–281 |
CommentRequired | Public method and constructor comments are required | 3 | 283–286 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 50–110 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 109 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 109 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 36–397 |
UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' | 4 | 75 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 81–397 |
UnusedPrivateField | Avoid unused private fields such as 'ACTION_EXTRACTION_DATA'. | 3 | 119 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 141 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 152 |
UnusedLocalVariable | Avoid unused local variables such as 'profilsReferenceList'. | 3 | 152 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 166–175 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 167–175 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 194 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 199 |
UnusedLocalVariable | Avoid unused local variables such as 'lstProfils'. | 3 | 199 |
SystemPrintln | System.out.println is used | 2 | 210 |
SystemPrintln | System.out.println is used | 2 | 219 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 224 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 352 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 36–547 |
UnusedImports | Avoid unused imports such as 'java.util.Collections' | 4 | 76 |
UnusedImports | Avoid unused imports such as 'java.util.Iterator' | 4 | 79 |
MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 90–547 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 151 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 160 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 160 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 177–186 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 178–186 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 206 |
SystemPrintln | System.out.println is used | 2 | 219 |
SystemPrintln | System.out.println is used | 2 | 223 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 230 |
SystemPrintln | System.out.println is used | 2 | 367 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 373 |
CommentRequired | Public method and constructor comments are required | 3 | 419–546 |
ExcessiveMethodLength | Avoid really long methods. | 3 | 419–546 |