Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Ligne
FieldNamingConventions The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' 69
FormalParameterNamingConventions The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' 99
FormalParameterNamingConventions The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 193

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttribute.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' 184

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 49
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 50

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 49
FormalParameterNamingConventions The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' 59
FormalParameterNamingConventions The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' 69
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 79
FormalParameterNamingConventions The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' 89

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 47

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 165

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 117

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 120

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
FieldNamingConventions The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' 87

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
FieldNamingConventions The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' 49
FieldNamingConventions The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 51

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 80
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 81
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 85

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 48160

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 58

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 46
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 51
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 53

fr/paris/lutece/plugins/identityimport/task/BatchCloseDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/plugins/identityimport/task/BatchLaunchDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 46

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Ligne
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 173
FieldNamingConventions The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 174
FieldNamingConventions The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' 183
FieldNamingConventions The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' 201
FieldNamingConventions The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' 202
FieldNamingConventions The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' 203

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' 158
FormalParameterNamingConventions The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' 168
FormalParameterNamingConventions The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' 178
FormalParameterNamingConventions The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' 218
FormalParameterNamingConventions The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' 228

Priority 2

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 102
GuardLogStatement Logger calls should be surrounded by log level guards. 111

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 66
GuardLogStatement Logger calls should be surrounded by log level guards. 76

Priority 3

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'RESOURCE_TYPE'. 48
CommentRequired Public method and constructor comments are required 192196

fr/paris/lutece/plugins/identityimport/business/BatchDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 52509
AvoidDuplicateLiterals The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 56 56
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_PURGE'. 64
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 91
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 115
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 135
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 148
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 170
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 197
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 219
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 240
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 264
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 329
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 354
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 357
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 363
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 366
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 386
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 411414
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 419
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 445
MissingOverride The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. 468479
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 470
MissingOverride The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. 484495
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 486

fr/paris/lutece/plugins/identityimport/business/BatchHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 155158
CommentRequired Public method and constructor comments are required 160163
ShortVariable Avoid variables with short names like id 160
CommentRequired Public method and constructor comments are required 200203
CommentRequired Public method and constructor comments are required 205208
CommentRequired Public method and constructor comments are required 210213
CommentRequired Public method and constructor comments are required 215218

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. 48
CommentRequired Public method and constructor comments are required 9497
CommentRequired Public method and constructor comments are required 99102
CommentRequired Public method and constructor comments are required 188191
CommentRequired Public method and constructor comments are required 193196

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 139
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 230233

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 98101

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 53357
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 81
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 104
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 125
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 141
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 176
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 197
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 223226
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 231
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 275
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 293
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 315
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 337

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Ligne
CommentRequired Header comments are required 3693
CommentRequired Public method and constructor comments are required 4447
CommentRequired Public method and constructor comments are required 4952
CommentRequired Public method and constructor comments are required 5457
CommentRequired Public method and constructor comments are required 5962
CommentRequired Public method and constructor comments are required 6467
CommentRequired Public method and constructor comments are required 6972
CommentRequired Public method and constructor comments are required 7477
CommentRequired Public method and constructor comments are required 7982
CommentRequired Public method and constructor comments are required 8487
CommentRequired Public method and constructor comments are required 8992

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 75
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 118
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 138
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 186

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Ligne
CommentRequired Header comments are required 43125
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44125

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 166169
CommentRequired Public method and constructor comments are required 171174
ShortVariable Avoid variables with short names like id 176
CommentRequired Public method and constructor comments are required 176179

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 146149
CommentRequired Public method and constructor comments are required 151154

fr/paris/lutece/plugins/identityimport/business/ClientDAO.java

Rule Violation Ligne
AvoidDuplicateLiterals The String literal "SELECT " appears 4 times in this file; the first occurrence is on line 52 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 67
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 90
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 111
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 124
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 146
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 166
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 186
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 211214
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 219
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 255

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 48194
CommentRequired Public method and constructor comments are required 167
CommentRequired Public method and constructor comments are required 169
CommentRequired Public method and constructor comments are required 171
CommentRequired Public method and constructor comments are required 173
CommentRequired Public method and constructor comments are required 175

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 119

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 46140
CommentRequired Public method and constructor comments are required 57
CommentRequired Public method and constructor comments are required 135
CommentRequired Public method and constructor comments are required 137
CommentRequired Public method and constructor comments are required 139
ShortVariable Avoid variables with short names like id 139

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityHistoryDAO.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 106

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Ligne
CommentRequired Header comments are required 3851
CommentRequired Public method and constructor comments are required 4245
CommentRequired Public method and constructor comments are required 4750

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
CommentRequired Header comments are required 81132
CommentRequired Public method and constructor comments are required 8993
CallSuperInConstructor It is a good practice to call super() in a constructor 8993
CommentRequired Public method and constructor comments are required 95103
CommentRequired Public method and constructor comments are required 105112
CommentRequired Public method and constructor comments are required 114120

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
CommentRequired Header comments are required 45101
CommentRequired Public method and constructor comments are required 5357
CallSuperInConstructor It is a good practice to call super() in a constructor 5357
CommentRequired Public method and constructor comments are required 5967
CommentRequired Public method and constructor comments are required 6977
CommentRequired Public method and constructor comments are required 7988
CommentRequired Public method and constructor comments are required 9094

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34419
CommentRequired Header comments are required 73419
UnusedPrivateField Avoid unused private fields such as 'VALIDATE_BATCH_ACTION_ID'. 79
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 85
CommentRequired Public method and constructor comments are required 8794
NonThreadSafeSingleton Singleton is not thread safe 8992
NPathComplexity The method 'importBatch(BatchDto, User, String)' has an NPath complexity of 322 96184
CyclomaticComplexity The method 'importBatch(BatchDto, User, String)' has a cyclomatic complexity of 14. 96184
CommentRequired Public method and constructor comments are required 96184
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 129
UnusedLocalVariable Avoid unused local variables such as 'batchWorkflowBean'. 129
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 175
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. 195
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 240
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. 261
ConfusingTernary Avoid if (x != y) ..; else ..; 265279
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 281
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. 298
ConfusingTernary Avoid if (x != y) ..; else ..; 302316
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 318
CommentRequired Public method and constructor comments are required 326335
CommentRequired Public method and constructor comments are required 337346
CommentRequired Public method and constructor comments are required 348418

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Ligne
CommentRequired Header comments are required 48160
CommentRequired Public method and constructor comments are required 5865
NonThreadSafeSingleton Singleton is not thread safe 6063
CommentRequired Public method and constructor comments are required 6773
CyclomaticComplexity The method 'validateBatch(BatchDto)' has a cyclomatic complexity of 21. 83144
NPathComplexity The method 'validateBatch(BatchDto)' has an NPath complexity of 704 83144

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Ligne
CommentRequired Header comments are required 56148
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 58
CommentRequired Public method and constructor comments are required 6067
NonThreadSafeSingleton Singleton is not thread safe 6265
CommentRequired Public method and constructor comments are required 69104
CommentRequired Public method and constructor comments are required 106147

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Ligne
CommentRequired Header comments are required 4369
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 48
CommentRequired Public method and constructor comments are required 5058
NonThreadSafeSingleton Singleton is not thread safe 5256

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
CommentRequired Header comments are required 48105
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 53
CommentRequired Public method and constructor comments are required 5563
NonThreadSafeSingleton Singleton is not thread safe 5761
CommentRequired Public method and constructor comments are required 6592

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Ligne
CommentRequired Header comments are required 4469
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. 53

fr/paris/lutece/plugins/identityimport/web/AbstractManageItemsJspBean.java

Rule Violation Ligne
DefaultPackage Use explicit scoping instead of the default package private level 110
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 110

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34684
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 91684
TooManyFields Too many fields 91684
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 228
ConfusingTernary Avoid if (x != y) ..; else ..; 234
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 344
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 505
ConfusingTernary Avoid if (x != y) ..; else ..; 539574
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 548
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 579
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 580
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 581
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 583
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 614
CommentRequired Protected method constructor comments are required 650664
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 668

fr/paris/lutece/plugins/identityimport/web/ClientJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 61299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 139146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 140146
ConfusingTernary Avoid if (x != y) ..; else ..; 166

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 54131
CommentRequired Public method and constructor comments are required 5965

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 52123
CommentRequired Public method and constructor comments are required 5763

fr/paris/lutece/plugins/identityimport/web/rs/BatchRestService.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 7173
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 9294

fr/paris/lutece/plugins/identityimport/web/rs/CustomMapper.java

Rule Violation Ligne
CommentRequired Header comments are required 4463
CommentRequired Public method and constructor comments are required 4956

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 60

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtIdentityStoreExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 59

fr/paris/lutece/plugins/identityimport/wf/IResource.java

Rule Violation Ligne
CommentRequired Header comments are required 3651
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type 50

fr/paris/lutece/plugins/identityimport/wf/LuteceWorkflowResourceAnnotationProcessor.java

Rule Violation Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 4850
CommentRequired Header comments are required 5279

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Ligne
CommentRequired Header comments are required 45232
ImmutableField Private field '_resource' could be made final; it is only initialized in the declaration or constructor. 48
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 49
ImmutableField Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. 50
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 51
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 52
CommentRequired Public method and constructor comments are required 213216
CommentRequired Public method and constructor comments are required 218221
CommentRequired Public method and constructor comments are required 223226
CommentRequired Public method and constructor comments are required 228231

fr/paris/lutece/plugins/identityimport/wf/WorkflowBeanService.java

Rule Violation Ligne
CommentRequired Header comments are required 51306
TooManyMethods This class has too many methods, consider refactoring it. 52306
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 73
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 74
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 207
ConfusingTernary Avoid if (x != y) ..; else ..; 236248
CommentRequired Public method and constructor comments are required 302305

Priority 4

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'javax.validation.constraints.NotNull' 37

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.contract.ServiceContractDto' 44

Fichiers

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'javax.validation.constraints.NotNull' 4 37
UnusedPrivateField Avoid unused private fields such as 'RESOURCE_TYPE'. 3 48
CommentRequired Public method and constructor comments are required 3 192196

fr/paris/lutece/plugins/identityimport/business/BatchDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 52509
AvoidDuplicateLiterals The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 56 3 56
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_PURGE'. 3 64
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 91
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 115
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 135
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 148
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 170
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 197
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 219
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 240
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 264
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 329
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 354
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 357
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 363
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 366
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 386
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 411414
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 419
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 445
MissingOverride The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. 3 468479
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 470
MissingOverride The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. 3 484495
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 486

fr/paris/lutece/plugins/identityimport/business/BatchHome.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 155158
CommentRequired Public method and constructor comments are required 3 160163
ShortVariable Avoid variables with short names like id 3 160
CommentRequired Public method and constructor comments are required 3 200203
CommentRequired Public method and constructor comments are required 3 205208
CommentRequired Public method and constructor comments are required 3 210213
CommentRequired Public method and constructor comments are required 3 215218

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. 3 48
FieldNamingConventions The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' 1 69
CommentRequired Public method and constructor comments are required 3 9497
FormalParameterNamingConventions The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' 1 99
CommentRequired Public method and constructor comments are required 3 99102
CommentRequired Public method and constructor comments are required 3 188191
FormalParameterNamingConventions The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 193
CommentRequired Public method and constructor comments are required 3 193196

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttribute.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' 1 184

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 139
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 230233

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 49
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 50
CommentRequired Public method and constructor comments are required 3 98101

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 53357
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 81
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 104
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 125
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 141
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 176
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 197
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 223226
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 231
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 275
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 293
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 315
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 337

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3693
CommentRequired Public method and constructor comments are required 3 4447
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
CommentRequired Public method and constructor comments are required 3 4952
CommentRequired Public method and constructor comments are required 3 5457
CommentRequired Public method and constructor comments are required 3 5962
FormalParameterNamingConventions The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
CommentRequired Public method and constructor comments are required 3 6467
FormalParameterNamingConventions The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
CommentRequired Public method and constructor comments are required 3 6972
CommentRequired Public method and constructor comments are required 3 7477
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 1 79
CommentRequired Public method and constructor comments are required 3 7982
CommentRequired Public method and constructor comments are required 3 8487
CommentRequired Public method and constructor comments are required 3 8992
FormalParameterNamingConventions The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' 1 89

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 75
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 118
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 138
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 186

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43125
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 44125
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 47

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHome.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 166169
CommentRequired Public method and constructor comments are required 3 171174
ShortVariable Avoid variables with short names like id 3 176
CommentRequired Public method and constructor comments are required 3 176179

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 146149
CommentRequired Public method and constructor comments are required 3 151154

fr/paris/lutece/plugins/identityimport/business/ClientDAO.java

Rule Violation Priority Ligne
AvoidDuplicateLiterals The String literal "SELECT " appears 4 times in this file; the first occurrence is on line 52 3 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 67
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 90
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 111
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 124
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 146
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 166
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 186
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 211214
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 219
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 255

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 48194
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 165
CommentRequired Public method and constructor comments are required 3 167
CommentRequired Public method and constructor comments are required 3 169
CommentRequired Public method and constructor comments are required 3 171
CommentRequired Public method and constructor comments are required 3 173
CommentRequired Public method and constructor comments are required 3 175

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 117
CommentRequired Public method and constructor comments are required 3 119

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 46140
CommentRequired Public method and constructor comments are required 3 57
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 120
CommentRequired Public method and constructor comments are required 3 135
CommentRequired Public method and constructor comments are required 3 137
CommentRequired Public method and constructor comments are required 3 139
ShortVariable Avoid variables with short names like id 3 139

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 106

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3851
CommentRequired Public method and constructor comments are required 3 4245
CommentRequired Public method and constructor comments are required 3 4750
FormalParameterNamingConventions The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' 1 47

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 81132
FieldNamingConventions The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
CommentRequired Public method and constructor comments are required 3 8993
CallSuperInConstructor It is a good practice to call super() in a constructor 3 8993
CommentRequired Public method and constructor comments are required 3 95103
GuardLogStatement Logger calls should be surrounded by log level guards. 2 102
CommentRequired Public method and constructor comments are required 3 105112
GuardLogStatement Logger calls should be surrounded by log level guards. 2 111
CommentRequired Public method and constructor comments are required 3 114120

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45101
FieldNamingConventions The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
FieldNamingConventions The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
CommentRequired Public method and constructor comments are required 3 5357
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5357
CommentRequired Public method and constructor comments are required 3 5967
GuardLogStatement Logger calls should be surrounded by log level guards. 2 66
CommentRequired Public method and constructor comments are required 3 6977
GuardLogStatement Logger calls should be surrounded by log level guards. 2 76
CommentRequired Public method and constructor comments are required 3 7988
CommentRequired Public method and constructor comments are required 3 9094

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34419
CommentRequired Header comments are required 3 73419
UnusedPrivateField Avoid unused private fields such as 'VALIDATE_BATCH_ACTION_ID'. 3 79
FieldNamingConventions The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 80
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 81
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 85
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 85
CommentRequired Public method and constructor comments are required 3 8794
NonThreadSafeSingleton Singleton is not thread safe 3 8992
NPathComplexity The method 'importBatch(BatchDto, User, String)' has an NPath complexity of 322 3 96184
CyclomaticComplexity The method 'importBatch(BatchDto, User, String)' has a cyclomatic complexity of 14. 3 96184
CommentRequired Public method and constructor comments are required 3 96184
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 129
UnusedLocalVariable Avoid unused local variables such as 'batchWorkflowBean'. 3 129
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 175
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. 3 195
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 240
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. 3 261
ConfusingTernary Avoid if (x != y) ..; else ..; 3 265279
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 281
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. 3 298
ConfusingTernary Avoid if (x != y) ..; else ..; 3 302316
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 318
CommentRequired Public method and constructor comments are required 3 326335
CommentRequired Public method and constructor comments are required 3 337346
CommentRequired Public method and constructor comments are required 3 348418

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 48160
CommentRequired Header comments are required 3 48160
CommentRequired Public method and constructor comments are required 3 5865
NonThreadSafeSingleton Singleton is not thread safe 3 6063
CommentRequired Public method and constructor comments are required 3 6773
CyclomaticComplexity The method 'validateBatch(BatchDto)' has a cyclomatic complexity of 21. 3 83144
NPathComplexity The method 'validateBatch(BatchDto)' has an NPath complexity of 704 3 83144

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.contract.ServiceContractDto' 4 44
CommentRequired Header comments are required 3 56148
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 58
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 58
CommentRequired Public method and constructor comments are required 3 6067
NonThreadSafeSingleton Singleton is not thread safe 3 6265
CommentRequired Public method and constructor comments are required 3 69104
CommentRequired Public method and constructor comments are required 3 106147

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4369
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 1 46
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 48
CommentRequired Public method and constructor comments are required 3 5058
NonThreadSafeSingleton Singleton is not thread safe 3 5256

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 48105
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 53
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 53
CommentRequired Public method and constructor comments are required 3 5563
NonThreadSafeSingleton Singleton is not thread safe 3 5761
CommentRequired Public method and constructor comments are required 3 6592

fr/paris/lutece/plugins/identityimport/task/BatchCloseDaemon.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/identityimport/task/BatchLaunchDaemon.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4469
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 46
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. 3 53

fr/paris/lutece/plugins/identityimport/web/AbstractManageItemsJspBean.java

Rule Violation Priority Ligne
DefaultPackage Use explicit scoping instead of the default package private level 3 110
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 110

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34684
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 91684
TooManyFields Too many fields 3 91684
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 173
FieldNamingConventions The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 174
FieldNamingConventions The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' 1 183
FieldNamingConventions The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' 1 201
FieldNamingConventions The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' 1 202
FieldNamingConventions The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' 1 203
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 228
ConfusingTernary Avoid if (x != y) ..; else ..; 3 234
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 344
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 505
ConfusingTernary Avoid if (x != y) ..; else ..; 3 539574
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 548
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 579
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 580
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 581
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 583
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 614
CommentRequired Protected method constructor comments are required 3 650664
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 668

fr/paris/lutece/plugins/identityimport/web/ClientJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 61299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 139146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 140146
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 54131
CommentRequired Public method and constructor comments are required 3 5965

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 52123
CommentRequired Public method and constructor comments are required 3 5763

fr/paris/lutece/plugins/identityimport/web/rs/BatchRestService.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 7173
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 9294

fr/paris/lutece/plugins/identityimport/web/rs/CustomMapper.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4463
CommentRequired Public method and constructor comments are required 3 4956

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 60

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtIdentityStoreExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 59

fr/paris/lutece/plugins/identityimport/wf/IResource.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3651
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type 3 50

fr/paris/lutece/plugins/identityimport/wf/LuteceWorkflowResourceAnnotationProcessor.java

Rule Violation Priority Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 4850
CommentRequired Header comments are required 3 5279

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45232
ImmutableField Private field '_resource' could be made final; it is only initialized in the declaration or constructor. 3 48
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 3 49
ImmutableField Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. 3 50
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 3 51
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 3 52
FormalParameterNamingConventions The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' 1 158
FormalParameterNamingConventions The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' 1 168
FormalParameterNamingConventions The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' 1 178
CommentRequired Public method and constructor comments are required 3 213216
FormalParameterNamingConventions The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' 1 218
CommentRequired Public method and constructor comments are required 3 218221
CommentRequired Public method and constructor comments are required 3 223226
CommentRequired Public method and constructor comments are required 3 228231
FormalParameterNamingConventions The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' 1 228

fr/paris/lutece/plugins/identityimport/wf/WorkflowBeanService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 51306
TooManyMethods This class has too many methods, consider refactoring it. 3 52306
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 3 73
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 3 74
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 207
ConfusingTernary Avoid if (x != y) ..; else ..; 3 236248
CommentRequired Public method and constructor comments are required 3 302305