Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 175

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Ligne
FieldNamingConventions The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' 69
FormalParameterNamingConventions The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' 99
FormalParameterNamingConventions The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 193

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttribute.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' 183

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 49
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 50

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 49
FormalParameterNamingConventions The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' 59
FormalParameterNamingConventions The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' 69
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 79
FormalParameterNamingConventions The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' 89

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 47

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 129

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 165

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 117

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 120

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
FieldNamingConventions The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' 87

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
FieldNamingConventions The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' 49
FieldNamingConventions The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 51

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 87
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 88
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 92

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 50–198

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 57

fr/paris/lutece/plugins/identityimport/service/ImportClientService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 12–86

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 46
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 57
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 63

fr/paris/lutece/plugins/identityimport/task/BatchCloseDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/plugins/identityimport/task/BatchLaunchDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 46

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Ligne
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 192
FieldNamingConventions The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 193
FieldNamingConventions The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' 204
FieldNamingConventions The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' 223
FieldNamingConventions The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' 224
FieldNamingConventions The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' 225

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 57
FieldNamingConventions The final field name '_strHeaderAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 58
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 60

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 56
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 59

fr/paris/lutece/plugins/identityimport/web/validator/BatchRequestValidator.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' 158
FormalParameterNamingConventions The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' 168
FormalParameterNamingConventions The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' 178
FormalParameterNamingConventions The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' 218
FormalParameterNamingConventions The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' 228

Priority 2

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 102
GuardLogStatement Logger calls should be surrounded by log level guards. 111

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 66
GuardLogStatement Logger calls should be surrounded by log level guards. 76

Priority 3

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'RESOURCE_TYPE'. 47
CommentRequired Public method and constructor comments are required 171–173
CommentRequired Public method and constructor comments are required 175–177
CommentRequired Public method and constructor comments are required 200–204

fr/paris/lutece/plugins/identityimport/business/BatchDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 53–544
AvoidDuplicateLiterals The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 57 57
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_PURGE'. 65
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 122
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 178
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 207
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 229
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 250
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 274
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 339
CyclomaticComplexity The method 'selectIdBatchsList(Integer, String, String, String, Plugin)' has a cyclomatic complexity of 12. 357–411
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 364
AvoidDuplicateLiterals The String literal " AND " appears 7 times in this file; the first occurrence is on line 367 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 371
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 375
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 383
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 388
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 389
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 394
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 395
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 398
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 400
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 420
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 445–448
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 453
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 479
MissingOverride The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. 502–513
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 504
MissingOverride The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. 518–529
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 520

fr/paris/lutece/plugins/identityimport/business/BatchHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 155–158
CommentRequired Public method and constructor comments are required 160–163
ShortVariable Avoid variables with short names like id 160
CommentRequired Public method and constructor comments are required 200–203
CommentRequired Public method and constructor comments are required 205–208
CommentRequired Public method and constructor comments are required 210–213
CommentRequired Public method and constructor comments are required 215–218

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. 48
CommentRequired Public method and constructor comments are required 94–97
CommentRequired Public method and constructor comments are required 99–102
CommentRequired Public method and constructor comments are required 188–191
CommentRequired Public method and constructor comments are required 193–196

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 138
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 229–232

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 98–101

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 53–362
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 82
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 105
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 126
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 177
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 198
ConfusingTernary Avoid if (x != y) ..; else ..; 198
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 228–231
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 236
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 280
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 298
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 320
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 342

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Ligne
CommentRequired Header comments are required 36–93
CommentRequired Public method and constructor comments are required 44–47
CommentRequired Public method and constructor comments are required 49–52
CommentRequired Public method and constructor comments are required 54–57
CommentRequired Public method and constructor comments are required 59–62
CommentRequired Public method and constructor comments are required 64–67
CommentRequired Public method and constructor comments are required 69–72
CommentRequired Public method and constructor comments are required 74–77
CommentRequired Public method and constructor comments are required 79–82
CommentRequired Public method and constructor comments are required 84–87
CommentRequired Public method and constructor comments are required 89–92

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 75
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 118
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 138
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 186

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Ligne
CommentRequired Header comments are required 43–125
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44–125

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 166–169
CommentRequired Public method and constructor comments are required 171–174
CommentRequired Public method and constructor comments are required 176–179
ShortVariable Avoid variables with short names like id 176

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 125–127
CommentRequired Public method and constructor comments are required 129–131
CommentRequired Public method and constructor comments are required 133–136
CommentRequired Public method and constructor comments are required 138–141

fr/paris/lutece/plugins/identityimport/business/ClientDAO.java

Rule Violation Ligne
AvoidDuplicateLiterals The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 52 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 68
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 91
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 112
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 125
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 147
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 187
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 212–215
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 220
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 256
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 274

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 48–194
CommentRequired Public method and constructor comments are required 167
CommentRequired Public method and constructor comments are required 169
CommentRequired Public method and constructor comments are required 171
CommentRequired Public method and constructor comments are required 173
CommentRequired Public method and constructor comments are required 175

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 119

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 46–140
CommentRequired Public method and constructor comments are required 57
CommentRequired Public method and constructor comments are required 135
CommentRequired Public method and constructor comments are required 137
ShortVariable Avoid variables with short names like id 139
CommentRequired Public method and constructor comments are required 139

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityHistoryDAO.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 106

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Ligne
CommentRequired Header comments are required 38–51
CommentRequired Public method and constructor comments are required 42–45
CommentRequired Public method and constructor comments are required 47–50

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
CommentRequired Header comments are required 81–132
CallSuperInConstructor It is a good practice to call super() in a constructor 89–93
CommentRequired Public method and constructor comments are required 89–93
CommentRequired Public method and constructor comments are required 95–103
CommentRequired Public method and constructor comments are required 105–112
CommentRequired Public method and constructor comments are required 114–120

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
CommentRequired Header comments are required 45–101
CallSuperInConstructor It is a good practice to call super() in a constructor 53–57
CommentRequired Public method and constructor comments are required 53–57
CommentRequired Public method and constructor comments are required 59–67
CommentRequired Public method and constructor comments are required 69–77
CommentRequired Public method and constructor comments are required 79–88
CommentRequired Public method and constructor comments are required 90–94

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResource.java

Rule Violation Ligne
CommentRequired Header comments are required 5–27

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResourceIdService.java

Rule Violation Ligne
CommentRequired Header comments are required 16–67
ShortVariable Avoid variables with short names like rt 27

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–474
CommentRequired Header comments are required 76–474
GodClass Possible God Class (WMC=50, ATFD=103, TCC=22.222%) 76–474
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 92
CommentRequired Public method and constructor comments are required 94–101
NonThreadSafeSingleton Singleton is not thread safe 96–99
CommentRequired Public method and constructor comments are required 103–152
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 147
NPathComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has an NPath complexity of 324 154–245
CyclomaticComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has a cyclomatic complexity of 16. 154–245
CommentRequired Public method and constructor comments are required 154–245
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 232
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 239
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. 256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 301
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. 322
ConfusingTernary Avoid if (x != y) ..; else ..; 326–340
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 342
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. 359
ConfusingTernary Avoid if (x != y) ..; else ..; 363–377
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 379
CommentRequired Public method and constructor comments are required 387–397
CommentRequired Public method and constructor comments are required 399–409
CommentRequired Public method and constructor comments are required 411–473

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Ligne
CommentRequired Header comments are required 50–198
TooManyMethods This class has too many methods, consider refactoring it. 51–198
CommentRequired Public method and constructor comments are required 71–78
NonThreadSafeSingleton Singleton is not thread safe 73–76
CommentRequired Public method and constructor comments are required 80–87
CommentRequired Public method and constructor comments are required 111–116
CommentRequired Public method and constructor comments are required 118–123
CommentRequired Public method and constructor comments are required 125–130
CommentRequired Public method and constructor comments are required 132–137
CommentRequired Public method and constructor comments are required 139–146
CommentRequired Public method and constructor comments are required 148–181
CyclomaticComplexity The method 'validateIdentities(BatchDto)' has a cyclomatic complexity of 11. 148–181

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Ligne
CommentRequired Header comments are required 55–147
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 57
CommentRequired Public method and constructor comments are required 59–66
NonThreadSafeSingleton Singleton is not thread safe 61–64
CommentRequired Public method and constructor comments are required 68–103
CommentRequired Public method and constructor comments are required 105–146

fr/paris/lutece/plugins/identityimport/service/ImportClientService.java

Rule Violation Ligne
CommentRequired Header comments are required 12–86
CommentRequired Public method and constructor comments are required 16–21
NonThreadSafeSingleton Singleton is not thread safe 17–19
CyclomaticComplexity The method 'getClient(String, String)' has a cyclomatic complexity of 13. 38–71
ConfusingTernary Avoid if (x != y) ..; else ..; 51–55
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 57
CommentRequired Public method and constructor comments are required 73–75
CommentRequired Public method and constructor comments are required 77–85

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Ligne
CommentRequired Header comments are required 43–69
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 48
CommentRequired Public method and constructor comments are required 50–58
NonThreadSafeSingleton Singleton is not thread safe 52–56

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
CommentRequired Header comments are required 54–145
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 63
CommentRequired Public method and constructor comments are required 65–73
NonThreadSafeSingleton Singleton is not thread safe 67–71
CommentRequired Public method and constructor comments are required 75–85
CommentRequired Public method and constructor comments are required 87–111
CommentRequired Public method and constructor comments are required 135–137
CommentRequired Public method and constructor comments are required 139–144

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Ligne
CommentRequired Header comments are required 44–69
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. 53

fr/paris/lutece/plugins/identityimport/web/AbstractManageItemsJspBean.java

Rule Violation Ligne
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 110
DefaultPackage Use explicit scoping instead of the default package private level 110

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–761
TooManyFields Too many fields 98–761
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 98–761
UnusedPrivateField Avoid unused private fields such as 'VIEW_CREATE_BATCH'. 171
SingularField Perhaps '_availableClients' could be replaced by a local variable. 218
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 250
ConfusingTernary Avoid if (x != y) ..; else ..; 256
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 373
CyclomaticComplexity The method 'doImportBatch(HttpServletRequest)' has a cyclomatic complexity of 12. 466–536
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 524
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 564
ConfusingTernary Avoid if (x != y) ..; else ..; 599–647
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 608
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 652
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 653
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 654
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 656
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 689
CommentRequired Protected method constructor comments are required 731–741
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 745

fr/paris/lutece/plugins/identityimport/web/ClientJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 61–299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 139–146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 140–146
ConfusingTernary Avoid if (x != y) ..; else ..; 166

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 55–119
CommentRequired Public method and constructor comments are required 62–68

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 54–112
CommentRequired Public method and constructor comments are required 61–67

fr/paris/lutece/plugins/identityimport/web/rs/BatchRestService.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 71–73
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 90–92

fr/paris/lutece/plugins/identityimport/web/rs/CustomMapper.java

Rule Violation Ligne
CommentRequired Header comments are required 44–63
CommentRequired Public method and constructor comments are required 49–56

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtClientAuthorizationExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtDuplicatesConsistencyExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 60

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtIdentityStoreExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 59

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtJerseyExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 18

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestContentFormattingExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestFormatExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceConsistencyExceptionMapper.java

Rule Violation Ligne
CommentRequired Header comments are required 13–42
ShortVariable Avoid variables with short names like e 18
ShortVariable Avoid variables with short names like e 27

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceNotFoundExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/validator/BatchRequestValidator.java

Rule Violation Ligne
CommentRequired Header comments are required 11–63
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_ERROR_PROVIDED_BATCH_EMPTY'. 15
NonThreadSafeSingleton Singleton is not thread safe 30–32
CommentRequired Public method and constructor comments are required 37–44
CommentRequired Public method and constructor comments are required 46–50
CommentRequired Public method and constructor comments are required 52–62
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 60

fr/paris/lutece/plugins/identityimport/wf/IResource.java

Rule Violation Ligne
CommentRequired Header comments are required 36–51
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type 50

fr/paris/lutece/plugins/identityimport/wf/LuteceWorkflowResourceAnnotationProcessor.java

Rule Violation Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 48–50
CommentRequired Header comments are required 52–79

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Ligne
CommentRequired Header comments are required 45–232
ImmutableField Private field '_resource' could be made final; it is only initialized in the declaration or constructor. 48
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 49
ImmutableField Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. 50
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 51
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 52
CommentRequired Public method and constructor comments are required 213–216
CommentRequired Public method and constructor comments are required 218–221
CommentRequired Public method and constructor comments are required 223–226
CommentRequired Public method and constructor comments are required 228–231

fr/paris/lutece/plugins/identityimport/wf/WorkflowBeanService.java

Rule Violation Ligne
CommentRequired Header comments are required 51–306
TooManyMethods This class has too many methods, consider refactoring it. 52–306
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 73
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 74
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 207
ConfusingTernary Avoid if (x != y) ..; else ..; 236–248
CommentRequired Public method and constructor comments are required 302–305

Priority 4

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.sql.Date' 68

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.Client' 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.ClientHome' 37
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 49

Fichiers

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as 'RESOURCE_TYPE'. 3 47
CommentRequired Public method and constructor comments are required 3 171–173
FormalParameterNamingConventions The method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 175
CommentRequired Public method and constructor comments are required 3 175–177
CommentRequired Public method and constructor comments are required 3 200–204

fr/paris/lutece/plugins/identityimport/business/BatchDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 53–544
AvoidDuplicateLiterals The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 57 3 57
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_PURGE'. 3 65
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 122
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 178
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 207
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 229
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 250
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 274
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 339
CyclomaticComplexity The method 'selectIdBatchsList(Integer, String, String, String, Plugin)' has a cyclomatic complexity of 12. 3 357–411
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 364
AvoidDuplicateLiterals The String literal " AND " appears 7 times in this file; the first occurrence is on line 367 3 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 371
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 375
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 383
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 388
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 389
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 394
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 395
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 398
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 400
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 420
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 445–448
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 453
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 479
MissingOverride The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. 3 502–513
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 504
MissingOverride The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. 3 518–529
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 520

fr/paris/lutece/plugins/identityimport/business/BatchHome.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 155–158
CommentRequired Public method and constructor comments are required 3 160–163
ShortVariable Avoid variables with short names like id 3 160
CommentRequired Public method and constructor comments are required 3 200–203
CommentRequired Public method and constructor comments are required 3 205–208
CommentRequired Public method and constructor comments are required 3 210–213
CommentRequired Public method and constructor comments are required 3 215–218

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. 3 48
FieldNamingConventions The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' 1 69
CommentRequired Public method and constructor comments are required 3 94–97
FormalParameterNamingConventions The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' 1 99
CommentRequired Public method and constructor comments are required 3 99–102
CommentRequired Public method and constructor comments are required 3 188–191
CommentRequired Public method and constructor comments are required 3 193–196
FormalParameterNamingConventions The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 193

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttribute.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' 1 183

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 138
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 229–232

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 49
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 50
CommentRequired Public method and constructor comments are required 3 98–101

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 53–362
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 82
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 105
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 126
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 177
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 198
ConfusingTernary Avoid if (x != y) ..; else ..; 3 198
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 228–231
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 236
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 280
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 298
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 320
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 342

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 36–93
CommentRequired Public method and constructor comments are required 3 44–47
CommentRequired Public method and constructor comments are required 3 49–52
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
CommentRequired Public method and constructor comments are required 3 54–57
FormalParameterNamingConventions The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
CommentRequired Public method and constructor comments are required 3 59–62
CommentRequired Public method and constructor comments are required 3 64–67
CommentRequired Public method and constructor comments are required 3 69–72
FormalParameterNamingConventions The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
CommentRequired Public method and constructor comments are required 3 74–77
CommentRequired Public method and constructor comments are required 3 79–82
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 1 79
CommentRequired Public method and constructor comments are required 3 84–87
CommentRequired Public method and constructor comments are required 3 89–92
FormalParameterNamingConventions The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' 1 89

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 75
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 118
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 138
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 186

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43–125
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 44–125
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 47

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHome.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 166–169
CommentRequired Public method and constructor comments are required 3 171–174
CommentRequired Public method and constructor comments are required 3 176–179
ShortVariable Avoid variables with short names like id 3 176

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 125–127
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 129
CommentRequired Public method and constructor comments are required 3 129–131
CommentRequired Public method and constructor comments are required 3 133–136
CommentRequired Public method and constructor comments are required 3 138–141

fr/paris/lutece/plugins/identityimport/business/ClientDAO.java

Rule Violation Priority Ligne
AvoidDuplicateLiterals The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 52 3 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 68
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 91
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 112
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 125
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 147
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 187
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 212–215
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 220
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 256
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 274

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 48–194
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 165
CommentRequired Public method and constructor comments are required 3 167
CommentRequired Public method and constructor comments are required 3 169
CommentRequired Public method and constructor comments are required 3 171
CommentRequired Public method and constructor comments are required 3 173
CommentRequired Public method and constructor comments are required 3 175

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 117
CommentRequired Public method and constructor comments are required 3 119

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 46–140
CommentRequired Public method and constructor comments are required 3 57
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 120
CommentRequired Public method and constructor comments are required 3 135
CommentRequired Public method and constructor comments are required 3 137
ShortVariable Avoid variables with short names like id 3 139
CommentRequired Public method and constructor comments are required 3 139

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 106

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–51
CommentRequired Public method and constructor comments are required 3 42–45
FormalParameterNamingConventions The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' 1 47
CommentRequired Public method and constructor comments are required 3 47–50

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 81–132
FieldNamingConventions The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
CallSuperInConstructor It is a good practice to call super() in a constructor 3 89–93
CommentRequired Public method and constructor comments are required 3 89–93
CommentRequired Public method and constructor comments are required 3 95–103
GuardLogStatement Logger calls should be surrounded by log level guards. 2 102
CommentRequired Public method and constructor comments are required 3 105–112
GuardLogStatement Logger calls should be surrounded by log level guards. 2 111
CommentRequired Public method and constructor comments are required 3 114–120

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45–101
FieldNamingConventions The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
FieldNamingConventions The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
CallSuperInConstructor It is a good practice to call super() in a constructor 3 53–57
CommentRequired Public method and constructor comments are required 3 53–57
CommentRequired Public method and constructor comments are required 3 59–67
GuardLogStatement Logger calls should be surrounded by log level guards. 2 66
CommentRequired Public method and constructor comments are required 3 69–77
GuardLogStatement Logger calls should be surrounded by log level guards. 2 76
CommentRequired Public method and constructor comments are required 3 79–88
CommentRequired Public method and constructor comments are required 3 90–94

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResource.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 5–27

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResourceIdService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 16–67
ShortVariable Avoid variables with short names like rt 3 27

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–474
UnusedImports Avoid unused imports such as 'java.sql.Date' 4 68
CommentRequired Header comments are required 3 76–474
GodClass Possible God Class (WMC=50, ATFD=103, TCC=22.222%) 3 76–474
FieldNamingConventions The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 88
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 92
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 92
CommentRequired Public method and constructor comments are required 3 94–101
NonThreadSafeSingleton Singleton is not thread safe 3 96–99
CommentRequired Public method and constructor comments are required 3 103–152
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 147
NPathComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has an NPath complexity of 324 3 154–245
CyclomaticComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has a cyclomatic complexity of 16. 3 154–245
CommentRequired Public method and constructor comments are required 3 154–245
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 232
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 239
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. 3 256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 301
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. 3 322
ConfusingTernary Avoid if (x != y) ..; else ..; 3 326–340
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 342
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. 3 359
ConfusingTernary Avoid if (x != y) ..; else ..; 3 363–377
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 379
CommentRequired Public method and constructor comments are required 3 387–397
CommentRequired Public method and constructor comments are required 3 399–409
CommentRequired Public method and constructor comments are required 3 411–473

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 50–198
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 50–198
TooManyMethods This class has too many methods, consider refactoring it. 3 51–198
CommentRequired Public method and constructor comments are required 3 71–78
NonThreadSafeSingleton Singleton is not thread safe 3 73–76
CommentRequired Public method and constructor comments are required 3 80–87
CommentRequired Public method and constructor comments are required 3 111–116
CommentRequired Public method and constructor comments are required 3 118–123
CommentRequired Public method and constructor comments are required 3 125–130
CommentRequired Public method and constructor comments are required 3 132–137
CommentRequired Public method and constructor comments are required 3 139–146
CommentRequired Public method and constructor comments are required 3 148–181
CyclomaticComplexity The method 'validateIdentities(BatchDto)' has a cyclomatic complexity of 11. 3 148–181

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 55–147
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 57
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 57
CommentRequired Public method and constructor comments are required 3 59–66
NonThreadSafeSingleton Singleton is not thread safe 3 61–64
CommentRequired Public method and constructor comments are required 3 68–103
CommentRequired Public method and constructor comments are required 3 105–146

fr/paris/lutece/plugins/identityimport/service/ImportClientService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 12–86
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 12–86
CommentRequired Public method and constructor comments are required 3 16–21
NonThreadSafeSingleton Singleton is not thread safe 3 17–19
CyclomaticComplexity The method 'getClient(String, String)' has a cyclomatic complexity of 13. 3 38–71
ConfusingTernary Avoid if (x != y) ..; else ..; 3 51–55
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 57
CommentRequired Public method and constructor comments are required 3 73–75
CommentRequired Public method and constructor comments are required 3 77–85

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43–69
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 1 46
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 48
CommentRequired Public method and constructor comments are required 3 50–58
NonThreadSafeSingleton Singleton is not thread safe 3 52–56

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.Client' 4 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.ClientHome' 4 37
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 49
CommentRequired Header comments are required 3 54–145
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 63
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 63
CommentRequired Public method and constructor comments are required 3 65–73
NonThreadSafeSingleton Singleton is not thread safe 3 67–71
CommentRequired Public method and constructor comments are required 3 75–85
CommentRequired Public method and constructor comments are required 3 87–111
CommentRequired Public method and constructor comments are required 3 135–137
CommentRequired Public method and constructor comments are required 3 139–144

fr/paris/lutece/plugins/identityimport/task/BatchCloseDaemon.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/identityimport/task/BatchLaunchDaemon.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44–69
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 46
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. 3 53

fr/paris/lutece/plugins/identityimport/web/AbstractManageItemsJspBean.java

Rule Violation Priority Ligne
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 110
DefaultPackage Use explicit scoping instead of the default package private level 3 110

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–761
TooManyFields Too many fields 3 98–761
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 98–761
UnusedPrivateField Avoid unused private fields such as 'VIEW_CREATE_BATCH'. 3 171
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 192
FieldNamingConventions The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 193
FieldNamingConventions The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' 1 204
SingularField Perhaps '_availableClients' could be replaced by a local variable. 3 218
FieldNamingConventions The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' 1 223
FieldNamingConventions The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' 1 224
FieldNamingConventions The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' 1 225
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 250
ConfusingTernary Avoid if (x != y) ..; else ..; 3 256
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 373
CyclomaticComplexity The method 'doImportBatch(HttpServletRequest)' has a cyclomatic complexity of 12. 3 466–536
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 524
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 564
ConfusingTernary Avoid if (x != y) ..; else ..; 3 599–647
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 608
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 652
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 653
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 654
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 656
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 689
CommentRequired Protected method constructor comments are required 3 731–741
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 745

fr/paris/lutece/plugins/identityimport/web/ClientJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 61–299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 139–146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 140–146
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 55–119
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
FieldNamingConventions The final field name '_strHeaderAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 58
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 1 60
CommentRequired Public method and constructor comments are required 3 62–68

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 54–112
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 56
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 1 59
CommentRequired Public method and constructor comments are required 3 61–67

fr/paris/lutece/plugins/identityimport/web/rs/BatchRestService.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 71–73
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 90–92

fr/paris/lutece/plugins/identityimport/web/rs/CustomMapper.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44–63
CommentRequired Public method and constructor comments are required 3 49–56

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtClientAuthorizationExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtDuplicatesConsistencyExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 60

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtIdentityStoreExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 59

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtJerseyExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 18

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestContentFormattingExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestFormatExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceConsistencyExceptionMapper.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 13–42
ShortVariable Avoid variables with short names like e 3 18
ShortVariable Avoid variables with short names like e 3 27

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceNotFoundExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/validator/BatchRequestValidator.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 11–63
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_ERROR_PROVIDED_BATCH_EMPTY'. 3 15
NonThreadSafeSingleton Singleton is not thread safe 3 30–32
CommentRequired Public method and constructor comments are required 3 37–44
CommentRequired Public method and constructor comments are required 3 46–50
CommentRequired Public method and constructor comments are required 3 52–62
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 60

fr/paris/lutece/plugins/identityimport/wf/IResource.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 36–51
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type 3 50

fr/paris/lutece/plugins/identityimport/wf/LuteceWorkflowResourceAnnotationProcessor.java

Rule Violation Priority Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 48–50
CommentRequired Header comments are required 3 52–79

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45–232
ImmutableField Private field '_resource' could be made final; it is only initialized in the declaration or constructor. 3 48
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 3 49
ImmutableField Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. 3 50
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 3 51
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 3 52
FormalParameterNamingConventions The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' 1 158
FormalParameterNamingConventions The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' 1 168
FormalParameterNamingConventions The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' 1 178
CommentRequired Public method and constructor comments are required 3 213–216
CommentRequired Public method and constructor comments are required 3 218–221
FormalParameterNamingConventions The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' 1 218
CommentRequired Public method and constructor comments are required 3 223–226
CommentRequired Public method and constructor comments are required 3 228–231
FormalParameterNamingConventions The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' 1 228

fr/paris/lutece/plugins/identityimport/wf/WorkflowBeanService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 51–306
TooManyMethods This class has too many methods, consider refactoring it. 3 52–306
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 3 73
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 3 74
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 207
ConfusingTernary Avoid if (x != y) ..; else ..; 3 236–248
CommentRequired Public method and constructor comments are required 3 302–305