Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 175

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Ligne
FieldNamingConventions The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' 69
FormalParameterNamingConventions The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' 99
FormalParameterNamingConventions The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 193

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttribute.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' 183

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 49
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 50

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 49
FormalParameterNamingConventions The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' 59
FormalParameterNamingConventions The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' 69
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 79
FormalParameterNamingConventions The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' 89

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 47

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 129

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 165

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 117

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 120

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
FieldNamingConventions The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' 87

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
FieldNamingConventions The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' 49
FieldNamingConventions The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 51

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 87
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 88
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 92

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 50198

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 57

fr/paris/lutece/plugins/identityimport/service/ImportClientService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1286

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 46
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 57
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 63

fr/paris/lutece/plugins/identityimport/task/BatchCloseDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/plugins/identityimport/task/BatchLaunchDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 46

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Ligne
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 192
FieldNamingConventions The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 193
FieldNamingConventions The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' 204
FieldNamingConventions The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' 223
FieldNamingConventions The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' 224
FieldNamingConventions The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' 225

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 57
FieldNamingConventions The final field name '_strHeaderAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 58
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 60

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 56
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 59

fr/paris/lutece/plugins/identityimport/web/validator/BatchRequestValidator.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' 158
FormalParameterNamingConventions The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' 168
FormalParameterNamingConventions The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' 178
FormalParameterNamingConventions The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' 218
FormalParameterNamingConventions The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' 228

Priority 2

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 102
GuardLogStatement Logger calls should be surrounded by log level guards. 111

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 66
GuardLogStatement Logger calls should be surrounded by log level guards. 76

Priority 3

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'RESOURCE_TYPE'. 47
CommentRequired Public method and constructor comments are required 171173
CommentRequired Public method and constructor comments are required 175177
CommentRequired Public method and constructor comments are required 200204

fr/paris/lutece/plugins/identityimport/business/BatchDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 53544
AvoidDuplicateLiterals The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 57 57
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_PURGE'. 65
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 122
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 178
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 207
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 229
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 250
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 274
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 339
CyclomaticComplexity The method 'selectIdBatchsList(Integer, String, String, String, Plugin)' has a cyclomatic complexity of 12. 357411
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 364
AvoidDuplicateLiterals The String literal " AND " appears 7 times in this file; the first occurrence is on line 367 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 371
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 375
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 383
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 388
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 389
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 394
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 395
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 398
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 400
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 420
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 445448
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 453
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 479
MissingOverride The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. 502513
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 504
MissingOverride The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. 518529
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 520

fr/paris/lutece/plugins/identityimport/business/BatchHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 155158
CommentRequired Public method and constructor comments are required 160163
ShortVariable Avoid variables with short names like id 160
CommentRequired Public method and constructor comments are required 200203
CommentRequired Public method and constructor comments are required 205208
CommentRequired Public method and constructor comments are required 210213
CommentRequired Public method and constructor comments are required 215218

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. 48
CommentRequired Public method and constructor comments are required 9497
CommentRequired Public method and constructor comments are required 99102
CommentRequired Public method and constructor comments are required 188191
CommentRequired Public method and constructor comments are required 193196

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 138
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 229232

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 98101

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 53362
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 82
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 105
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 126
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 177
ConfusingTernary Avoid if (x != y) ..; else ..; 198
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 198
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 228231
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 236
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 280
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 298
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 320
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 342

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Ligne
CommentRequired Header comments are required 3693
CommentRequired Public method and constructor comments are required 4447
CommentRequired Public method and constructor comments are required 4952
CommentRequired Public method and constructor comments are required 5457
CommentRequired Public method and constructor comments are required 5962
CommentRequired Public method and constructor comments are required 6467
CommentRequired Public method and constructor comments are required 6972
CommentRequired Public method and constructor comments are required 7477
CommentRequired Public method and constructor comments are required 7982
CommentRequired Public method and constructor comments are required 8487
CommentRequired Public method and constructor comments are required 8992

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 75
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 118
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 138
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 186

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Ligne
CommentRequired Header comments are required 43125
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44125

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHome.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 166169
CommentRequired Public method and constructor comments are required 171174
CommentRequired Public method and constructor comments are required 176179
ShortVariable Avoid variables with short names like id 176

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 125127
CommentRequired Public method and constructor comments are required 129131
CommentRequired Public method and constructor comments are required 133136
CommentRequired Public method and constructor comments are required 138141

fr/paris/lutece/plugins/identityimport/business/ClientDAO.java

Rule Violation Ligne
AvoidDuplicateLiterals The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 52 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 68
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 91
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 112
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 125
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 147
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 187
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 212215
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 220
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 256
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 274

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 48194
CommentRequired Public method and constructor comments are required 167
CommentRequired Public method and constructor comments are required 169
CommentRequired Public method and constructor comments are required 171
CommentRequired Public method and constructor comments are required 173
CommentRequired Public method and constructor comments are required 175

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 119

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 46140
CommentRequired Public method and constructor comments are required 57
CommentRequired Public method and constructor comments are required 135
CommentRequired Public method and constructor comments are required 137
ShortVariable Avoid variables with short names like id 139
CommentRequired Public method and constructor comments are required 139

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityHistoryDAO.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 106

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Ligne
CommentRequired Header comments are required 3851
CommentRequired Public method and constructor comments are required 4245
CommentRequired Public method and constructor comments are required 4750

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Ligne
CommentRequired Header comments are required 81132
CommentRequired Public method and constructor comments are required 8993
CallSuperInConstructor It is a good practice to call super() in a constructor 8993
CommentRequired Public method and constructor comments are required 95103
CommentRequired Public method and constructor comments are required 105112
CommentRequired Public method and constructor comments are required 114120

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Ligne
CommentRequired Header comments are required 45101
CallSuperInConstructor It is a good practice to call super() in a constructor 5357
CommentRequired Public method and constructor comments are required 5357
CommentRequired Public method and constructor comments are required 5967
CommentRequired Public method and constructor comments are required 6977
CommentRequired Public method and constructor comments are required 7988
CommentRequired Public method and constructor comments are required 9094

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResource.java

Rule Violation Ligne
CommentRequired Header comments are required 527

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResourceIdService.java

Rule Violation Ligne
CommentRequired Header comments are required 1667
ShortVariable Avoid variables with short names like rt 27

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34474
CommentRequired Header comments are required 76474
GodClass Possible God Class (WMC=50, ATFD=103, TCC=22.222%) 76474
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 92
CommentRequired Public method and constructor comments are required 94101
NonThreadSafeSingleton Singleton is not thread safe 9699
CommentRequired Public method and constructor comments are required 103152
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 147
CommentRequired Public method and constructor comments are required 154245
NPathComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has an NPath complexity of 324 154245
CyclomaticComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has a cyclomatic complexity of 16. 154245
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 232
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 239
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. 256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 301
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. 322
ConfusingTernary Avoid if (x != y) ..; else ..; 326340
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 342
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. 359
ConfusingTernary Avoid if (x != y) ..; else ..; 363377
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 379
CommentRequired Public method and constructor comments are required 387397
CommentRequired Public method and constructor comments are required 399409
CommentRequired Public method and constructor comments are required 411473

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Ligne
CommentRequired Header comments are required 50198
TooManyMethods This class has too many methods, consider refactoring it. 51198
CommentRequired Public method and constructor comments are required 7178
NonThreadSafeSingleton Singleton is not thread safe 7376
CommentRequired Public method and constructor comments are required 8087
CommentRequired Public method and constructor comments are required 111116
CommentRequired Public method and constructor comments are required 118123
CommentRequired Public method and constructor comments are required 125130
CommentRequired Public method and constructor comments are required 132137
CommentRequired Public method and constructor comments are required 139146
CommentRequired Public method and constructor comments are required 148181
CyclomaticComplexity The method 'validateIdentities(BatchDto)' has a cyclomatic complexity of 11. 148181

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Ligne
CommentRequired Header comments are required 55147
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 57
CommentRequired Public method and constructor comments are required 5966
NonThreadSafeSingleton Singleton is not thread safe 6164
CommentRequired Public method and constructor comments are required 68103
CommentRequired Public method and constructor comments are required 105146

fr/paris/lutece/plugins/identityimport/service/ImportClientService.java

Rule Violation Ligne
CommentRequired Header comments are required 1286
CommentRequired Public method and constructor comments are required 1621
NonThreadSafeSingleton Singleton is not thread safe 1719
CyclomaticComplexity The method 'getClient(String, String)' has a cyclomatic complexity of 13. 3871
ConfusingTernary Avoid if (x != y) ..; else ..; 5155
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 57
CommentRequired Public method and constructor comments are required 7375
CommentRequired Public method and constructor comments are required 7785

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Ligne
CommentRequired Header comments are required 4369
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 48
CommentRequired Public method and constructor comments are required 5058
NonThreadSafeSingleton Singleton is not thread safe 5256

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
CommentRequired Header comments are required 54145
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 63
CommentRequired Public method and constructor comments are required 6573
NonThreadSafeSingleton Singleton is not thread safe 6771
CommentRequired Public method and constructor comments are required 7585
CommentRequired Public method and constructor comments are required 87111
CommentRequired Public method and constructor comments are required 135137
CommentRequired Public method and constructor comments are required 139144

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Ligne
CommentRequired Header comments are required 4469
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. 53

fr/paris/lutece/plugins/identityimport/web/AbstractManageItemsJspBean.java

Rule Violation Ligne
DefaultPackage Use explicit scoping instead of the default package private level 110
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 110

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34761
TooManyFields Too many fields 98761
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 98761
UnusedPrivateField Avoid unused private fields such as 'VIEW_CREATE_BATCH'. 171
SingularField Perhaps '_availableClients' could be replaced by a local variable. 218
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 250
ConfusingTernary Avoid if (x != y) ..; else ..; 256
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 373
CyclomaticComplexity The method 'doImportBatch(HttpServletRequest)' has a cyclomatic complexity of 12. 466536
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 524
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 564
ConfusingTernary Avoid if (x != y) ..; else ..; 599647
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 608
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 652
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 653
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 654
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 656
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 689
CommentRequired Protected method constructor comments are required 731741
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 745

fr/paris/lutece/plugins/identityimport/web/ClientJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 61299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 139146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 140146
ConfusingTernary Avoid if (x != y) ..; else ..; 166

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 55119
CommentRequired Public method and constructor comments are required 6268

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 54112
CommentRequired Public method and constructor comments are required 6167

fr/paris/lutece/plugins/identityimport/web/rs/BatchRestService.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 7173
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 9092

fr/paris/lutece/plugins/identityimport/web/rs/CustomMapper.java

Rule Violation Ligne
CommentRequired Header comments are required 4463
CommentRequired Public method and constructor comments are required 4956

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtClientAuthorizationExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtDuplicatesConsistencyExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 60

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtIdentityStoreExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 59

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtJerseyExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 18

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestContentFormattingExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestFormatExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceConsistencyExceptionMapper.java

Rule Violation Ligne
CommentRequired Header comments are required 1342
ShortVariable Avoid variables with short names like e 18
ShortVariable Avoid variables with short names like e 27

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceNotFoundExceptionMapper.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like e 24
ShortVariable Avoid variables with short names like e 34

fr/paris/lutece/plugins/identityimport/web/validator/BatchRequestValidator.java

Rule Violation Ligne
CommentRequired Header comments are required 1163
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_ERROR_PROVIDED_BATCH_EMPTY'. 15
NonThreadSafeSingleton Singleton is not thread safe 3032
CommentRequired Public method and constructor comments are required 3744
CommentRequired Public method and constructor comments are required 4650
CommentRequired Public method and constructor comments are required 5262
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 60

fr/paris/lutece/plugins/identityimport/wf/IResource.java

Rule Violation Ligne
CommentRequired Header comments are required 3651
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type 50

fr/paris/lutece/plugins/identityimport/wf/LuteceWorkflowResourceAnnotationProcessor.java

Rule Violation Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 4850
CommentRequired Header comments are required 5279

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Ligne
CommentRequired Header comments are required 45232
ImmutableField Private field '_resource' could be made final; it is only initialized in the declaration or constructor. 48
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 49
ImmutableField Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. 50
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 51
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 52
CommentRequired Public method and constructor comments are required 213216
CommentRequired Public method and constructor comments are required 218221
CommentRequired Public method and constructor comments are required 223226
CommentRequired Public method and constructor comments are required 228231

fr/paris/lutece/plugins/identityimport/wf/WorkflowBeanService.java

Rule Violation Ligne
CommentRequired Header comments are required 51306
TooManyMethods This class has too many methods, consider refactoring it. 52306
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 73
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 74
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 207
ConfusingTernary Avoid if (x != y) ..; else ..; 236248
CommentRequired Public method and constructor comments are required 302305

Priority 4

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.sql.Date' 68

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.Client' 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.ClientHome' 37
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 49

Fichiers

fr/paris/lutece/plugins/identityimport/business/Batch.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as 'RESOURCE_TYPE'. 3 47
CommentRequired Public method and constructor comments are required 3 171173
CommentRequired Public method and constructor comments are required 3 175177
FormalParameterNamingConventions The method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 175
CommentRequired Public method and constructor comments are required 3 200204

fr/paris/lutece/plugins/identityimport/business/BatchDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 53544
AvoidDuplicateLiterals The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 57 3 57
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_PURGE'. 3 65
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 122
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 178
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 207
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 229
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 250
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 274
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 339
CyclomaticComplexity The method 'selectIdBatchsList(Integer, String, String, String, Plugin)' has a cyclomatic complexity of 12. 3 357411
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 364
AvoidDuplicateLiterals The String literal " AND " appears 7 times in this file; the first occurrence is on line 367 3 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 367
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 371
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 375
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 383
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 388
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 389
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 394
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 395
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 398
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 400
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 420
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 445448
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 453
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 479
MissingOverride The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. 3 502513
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 504
MissingOverride The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. 3 518529
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 520

fr/paris/lutece/plugins/identityimport/business/BatchHome.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 155158
CommentRequired Public method and constructor comments are required 3 160163
ShortVariable Avoid variables with short names like id 3 160
CommentRequired Public method and constructor comments are required 3 200203
CommentRequired Public method and constructor comments are required 3 205208
CommentRequired Public method and constructor comments are required 3 210213
CommentRequired Public method and constructor comments are required 3 215218

fr/paris/lutece/plugins/identityimport/business/CandidateIdentity.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. 3 48
FieldNamingConventions The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' 1 69
CommentRequired Public method and constructor comments are required 3 9497
CommentRequired Public method and constructor comments are required 3 99102
FormalParameterNamingConventions The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' 1 99
CommentRequired Public method and constructor comments are required 3 188191
CommentRequired Public method and constructor comments are required 3 193196
FormalParameterNamingConventions The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 193

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttribute.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' 1 183

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 138
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 229232

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityAttributeHome.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 49
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 50
CommentRequired Public method and constructor comments are required 3 98101

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 53362
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 82
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 105
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 126
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 142
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 155
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 177
ConfusingTernary Avoid if (x != y) ..; else ..; 3 198
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 198
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 228231
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 236
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 280
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 298
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 320
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 342

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistory.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3693
CommentRequired Public method and constructor comments are required 3 4447
CommentRequired Public method and constructor comments are required 3 4952
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
CommentRequired Public method and constructor comments are required 3 5457
FormalParameterNamingConventions The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
CommentRequired Public method and constructor comments are required 3 5962
CommentRequired Public method and constructor comments are required 3 6467
FormalParameterNamingConventions The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
CommentRequired Public method and constructor comments are required 3 6972
CommentRequired Public method and constructor comments are required 3 7477
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 1 79
CommentRequired Public method and constructor comments are required 3 7982
CommentRequired Public method and constructor comments are required 3 8487
CommentRequired Public method and constructor comments are required 3 8992
FormalParameterNamingConventions The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' 1 89

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 75
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 118
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 138
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 154
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 186

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHistoryHome.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43125
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 44125
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 47

fr/paris/lutece/plugins/identityimport/business/CandidateIdentityHome.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 166169
CommentRequired Public method and constructor comments are required 3 171174
CommentRequired Public method and constructor comments are required 3 176179
ShortVariable Avoid variables with short names like id 3 176

fr/paris/lutece/plugins/identityimport/business/Client.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 125127
CommentRequired Public method and constructor comments are required 3 129131
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 129
CommentRequired Public method and constructor comments are required 3 133136
CommentRequired Public method and constructor comments are required 3 138141

fr/paris/lutece/plugins/identityimport/business/ClientDAO.java

Rule Violation Priority Ligne
AvoidDuplicateLiterals The String literal "SELECT " appears 5 times in this file; the first occurrence is on line 52 3 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 68
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 91
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 112
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 125
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 147
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 167
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 187
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 212215
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 220
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 256
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 274

fr/paris/lutece/plugins/identityimport/business/IBatchDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 48194
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 165
CommentRequired Public method and constructor comments are required 3 167
CommentRequired Public method and constructor comments are required 3 169
CommentRequired Public method and constructor comments are required 3 171
CommentRequired Public method and constructor comments are required 3 173
CommentRequired Public method and constructor comments are required 3 175

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityAttributeDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 117
CommentRequired Public method and constructor comments are required 3 119

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 46140
CommentRequired Public method and constructor comments are required 3 57
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 120
CommentRequired Public method and constructor comments are required 3 135
CommentRequired Public method and constructor comments are required 3 137
ShortVariable Avoid variables with short names like id 3 139
CommentRequired Public method and constructor comments are required 3 139

fr/paris/lutece/plugins/identityimport/business/ICandidateIdentityHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 106

fr/paris/lutece/plugins/identityimport/business/ResourceState.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3851
CommentRequired Public method and constructor comments are required 3 4245
CommentRequired Public method and constructor comments are required 3 4750
FormalParameterNamingConventions The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' 1 47

fr/paris/lutece/plugins/identityimport/cache/ReferentialCache.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 81132
FieldNamingConventions The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
CommentRequired Public method and constructor comments are required 3 8993
CallSuperInConstructor It is a good practice to call super() in a constructor 3 8993
CommentRequired Public method and constructor comments are required 3 95103
GuardLogStatement Logger calls should be surrounded by log level guards. 2 102
CommentRequired Public method and constructor comments are required 3 105112
GuardLogStatement Logger calls should be surrounded by log level guards. 2 111
CommentRequired Public method and constructor comments are required 3 114120

fr/paris/lutece/plugins/identityimport/cache/ServiceContractCache.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45101
FieldNamingConventions The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
FieldNamingConventions The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5357
CommentRequired Public method and constructor comments are required 3 5357
CommentRequired Public method and constructor comments are required 3 5967
GuardLogStatement Logger calls should be surrounded by log level guards. 2 66
CommentRequired Public method and constructor comments are required 3 6977
GuardLogStatement Logger calls should be surrounded by log level guards. 2 76
CommentRequired Public method and constructor comments are required 3 7988
CommentRequired Public method and constructor comments are required 3 9094

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResource.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 527

fr/paris/lutece/plugins/identityimport/rbac/AccessImportBatchResourceIdService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 1667
ShortVariable Avoid variables with short names like rt 3 27

fr/paris/lutece/plugins/identityimport/service/BatchService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34474
UnusedImports Avoid unused imports such as 'java.sql.Date' 4 68
CommentRequired Header comments are required 3 76474
GodClass Possible God Class (WMC=50, ATFD=103, TCC=22.222%) 3 76474
FieldNamingConventions The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 88
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 92
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 92
CommentRequired Public method and constructor comments are required 3 94101
NonThreadSafeSingleton Singleton is not thread safe 3 9699
CommentRequired Public method and constructor comments are required 3 103152
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 147
CommentRequired Public method and constructor comments are required 3 154245
NPathComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has an NPath complexity of 324 3 154245
CyclomaticComplexity The method 'importBatchFromIhm(BatchDto, User, String)' has a cyclomatic complexity of 16. 3 154245
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 232
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 239
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. 3 256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 301
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. 3 322
ConfusingTernary Avoid if (x != y) ..; else ..; 3 326340
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 342
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. 3 359
ConfusingTernary Avoid if (x != y) ..; else ..; 3 363377
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 379
CommentRequired Public method and constructor comments are required 3 387397
CommentRequired Public method and constructor comments are required 3 399409
CommentRequired Public method and constructor comments are required 3 411473

fr/paris/lutece/plugins/identityimport/service/BatchValidationService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 50198
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 50198
TooManyMethods This class has too many methods, consider refactoring it. 3 51198
CommentRequired Public method and constructor comments are required 3 7178
NonThreadSafeSingleton Singleton is not thread safe 3 7376
CommentRequired Public method and constructor comments are required 3 8087
CommentRequired Public method and constructor comments are required 3 111116
CommentRequired Public method and constructor comments are required 3 118123
CommentRequired Public method and constructor comments are required 3 125130
CommentRequired Public method and constructor comments are required 3 132137
CommentRequired Public method and constructor comments are required 3 139146
CommentRequired Public method and constructor comments are required 3 148181
CyclomaticComplexity The method 'validateIdentities(BatchDto)' has a cyclomatic complexity of 11. 3 148181

fr/paris/lutece/plugins/identityimport/service/CandidateIdentityService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 55147
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 57
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 57
CommentRequired Public method and constructor comments are required 3 5966
NonThreadSafeSingleton Singleton is not thread safe 3 6164
CommentRequired Public method and constructor comments are required 3 68103
CommentRequired Public method and constructor comments are required 3 105146

fr/paris/lutece/plugins/identityimport/service/ImportClientService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 1286
CommentRequired Header comments are required 3 1286
CommentRequired Public method and constructor comments are required 3 1621
NonThreadSafeSingleton Singleton is not thread safe 3 1719
CyclomaticComplexity The method 'getClient(String, String)' has a cyclomatic complexity of 13. 3 3871
ConfusingTernary Avoid if (x != y) ..; else ..; 3 5155
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 57
CommentRequired Public method and constructor comments are required 3 7375
CommentRequired Public method and constructor comments are required 3 7785

fr/paris/lutece/plugins/identityimport/service/ReferentialService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4369
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 1 46
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 48
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
CommentRequired Public method and constructor comments are required 3 5058
NonThreadSafeSingleton Singleton is not thread safe 3 5256

fr/paris/lutece/plugins/identityimport/service/ServiceContractService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.Client' 4 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identityimport.business.ClientHome' 4 37
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 49
CommentRequired Header comments are required 3 54145
FieldNamingConventions The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 63
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 63
CommentRequired Public method and constructor comments are required 3 6573
NonThreadSafeSingleton Singleton is not thread safe 3 6771
CommentRequired Public method and constructor comments are required 3 7585
CommentRequired Public method and constructor comments are required 3 87111
CommentRequired Public method and constructor comments are required 3 135137
CommentRequired Public method and constructor comments are required 3 139144

fr/paris/lutece/plugins/identityimport/task/BatchCloseDaemon.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/identityimport/task/BatchLaunchDaemon.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/identityimport/task/BatchPurgeDaemon.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4469
FieldNamingConventions The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 46
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. 3 53

fr/paris/lutece/plugins/identityimport/web/AbstractManageItemsJspBean.java

Rule Violation Priority Ligne
DefaultPackage Use explicit scoping instead of the default package private level 3 110
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 110

fr/paris/lutece/plugins/identityimport/web/BatchJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34761
TooManyFields Too many fields 3 98761
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 98761
UnusedPrivateField Avoid unused private fields such as 'VIEW_CREATE_BATCH'. 3 171
FieldNamingConventions The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 192
FieldNamingConventions The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' 1 193
FieldNamingConventions The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' 1 204
SingularField Perhaps '_availableClients' could be replaced by a local variable. 3 218
FieldNamingConventions The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' 1 223
FieldNamingConventions The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' 1 224
FieldNamingConventions The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' 1 225
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 250
ConfusingTernary Avoid if (x != y) ..; else ..; 3 256
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 373
CyclomaticComplexity The method 'doImportBatch(HttpServletRequest)' has a cyclomatic complexity of 12. 3 466536
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 524
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 564
ConfusingTernary Avoid if (x != y) ..; else ..; 3 599647
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 608
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 652
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 653
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 654
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 656
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 689
CommentRequired Protected method constructor comments are required 3 731741
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 745

fr/paris/lutece/plugins/identityimport/web/ClientJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 61299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 139146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 140146
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchImportRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 55119
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
FieldNamingConventions The final field name '_strHeaderAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 58
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 1 60
CommentRequired Public method and constructor comments are required 3 6268

fr/paris/lutece/plugins/identityimport/web/request/IdentityBatchStatusRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 54112
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 56
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 1 59
CommentRequired Public method and constructor comments are required 3 6167

fr/paris/lutece/plugins/identityimport/web/rs/BatchRestService.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 7173
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 9092

fr/paris/lutece/plugins/identityimport/web/rs/CustomMapper.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4463
CommentRequired Public method and constructor comments are required 3 4956

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtClientAuthorizationExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtDuplicatesConsistencyExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 60

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtIdentityStoreExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 59

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtJerseyExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 18

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestContentFormattingExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtRequestFormatExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceConsistencyExceptionMapper.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 1342
ShortVariable Avoid variables with short names like e 3 18
ShortVariable Avoid variables with short names like e 3 27

fr/paris/lutece/plugins/identityimport/web/rs/error/UncaughtResourceNotFoundExceptionMapper.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like e 3 24
ShortVariable Avoid variables with short names like e 3 34

fr/paris/lutece/plugins/identityimport/web/validator/BatchRequestValidator.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 1163
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_ERROR_PROVIDED_BATCH_EMPTY'. 3 15
NonThreadSafeSingleton Singleton is not thread safe 3 3032
CommentRequired Public method and constructor comments are required 3 3744
CommentRequired Public method and constructor comments are required 3 4650
CommentRequired Public method and constructor comments are required 3 5262
FormalParameterNamingConventions The final method parameter name '_strClientCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 60

fr/paris/lutece/plugins/identityimport/wf/IResource.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3651
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type 3 50

fr/paris/lutece/plugins/identityimport/wf/LuteceWorkflowResourceAnnotationProcessor.java

Rule Violation Priority Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 4850
CommentRequired Header comments are required 3 5279

fr/paris/lutece/plugins/identityimport/wf/WorkflowBean.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45232
ImmutableField Private field '_resource' could be made final; it is only initialized in the declaration or constructor. 3 48
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 3 49
ImmutableField Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. 3 50
ImmutableField Private field '_user' could be made final; it is only initialized in the declaration or constructor. 3 51
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 3 52
FormalParameterNamingConventions The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' 1 158
FormalParameterNamingConventions The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' 1 168
FormalParameterNamingConventions The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' 1 178
CommentRequired Public method and constructor comments are required 3 213216
CommentRequired Public method and constructor comments are required 3 218221
FormalParameterNamingConventions The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' 1 218
CommentRequired Public method and constructor comments are required 3 223226
CommentRequired Public method and constructor comments are required 3 228231
FormalParameterNamingConventions The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' 1 228

fr/paris/lutece/plugins/identityimport/wf/WorkflowBeanService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 51306
TooManyMethods This class has too many methods, consider refactoring it. 3 52306
ImmutableField Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. 3 73
ImmutableField Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. 3 74
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 207
ConfusingTernary Avoid if (x != y) ..; else ..; 3 236248
CommentRequired Public method and constructor comments are required 3 302305