The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' | 69 |
| FormalParameterNamingConventions | The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' | 99 |
| FormalParameterNamingConventions | The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' | 193 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' | 184 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
| FieldNamingConventions | The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' | 50 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' | 49 |
| FormalParameterNamingConventions | The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' | 59 |
| FormalParameterNamingConventions | The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' | 69 |
| FormalParameterNamingConventions | The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 79 |
| FormalParameterNamingConventions | The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' | 89 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' | 46 |
| FieldNamingConventions | The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' | 47 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 165 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 117 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 120 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' | 47 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' | 87 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' | 49 |
| FieldNamingConventions | The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' | 51 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 80 |
| FieldNamingConventions | The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 81 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 85 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 48–160 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 58 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' | 46 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 48 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' | 51 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 53 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' | 46 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 173 |
| FieldNamingConventions | The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 174 |
| FieldNamingConventions | The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' | 183 |
| FieldNamingConventions | The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' | 201 |
| FieldNamingConventions | The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' | 202 |
| FieldNamingConventions | The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' | 203 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' | 158 |
| FormalParameterNamingConventions | The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' | 168 |
| FormalParameterNamingConventions | The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' | 178 |
| FormalParameterNamingConventions | The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' | 218 |
| FormalParameterNamingConventions | The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' | 228 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 102 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 111 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 66 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 76 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'RESOURCE_TYPE'. | 48 |
| CommentRequired | Public method and constructor comments are required | 192–196 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–509 |
| AvoidDuplicateLiterals | The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 56 | 56 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_PURGE'. | 64 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 91 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 115 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 135 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 170 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 197 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 219 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 240 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 264 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 329 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 354 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 357 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 363 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 366 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 386 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 411–414 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 419 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 445 |
| MissingOverride | The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. | 468–479 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 470 |
| MissingOverride | The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. | 484–495 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 486 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 155–158 |
| CommentRequired | Public method and constructor comments are required | 160–163 |
| ShortVariable | Avoid variables with short names like id | 160 |
| CommentRequired | Public method and constructor comments are required | 200–203 |
| CommentRequired | Public method and constructor comments are required | 205–208 |
| CommentRequired | Public method and constructor comments are required | 210–213 |
| CommentRequired | Public method and constructor comments are required | 215–218 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. | 48 |
| CommentRequired | Public method and constructor comments are required | 94–97 |
| CommentRequired | Public method and constructor comments are required | 99–102 |
| CommentRequired | Public method and constructor comments are required | 188–191 |
| CommentRequired | Public method and constructor comments are required | 193–196 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 139 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 230–233 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 98–101 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 53–357 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 81 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 104 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 125 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 141 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 154 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 176 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 197 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 223–226 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 231 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 275 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 293 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 315 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 337 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–93 |
| CommentRequired | Public method and constructor comments are required | 44–47 |
| CommentRequired | Public method and constructor comments are required | 49–52 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| CommentRequired | Public method and constructor comments are required | 59–62 |
| CommentRequired | Public method and constructor comments are required | 64–67 |
| CommentRequired | Public method and constructor comments are required | 69–72 |
| CommentRequired | Public method and constructor comments are required | 74–77 |
| CommentRequired | Public method and constructor comments are required | 79–82 |
| CommentRequired | Public method and constructor comments are required | 84–87 |
| CommentRequired | Public method and constructor comments are required | 89–92 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 75 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 97 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 118 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 138 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 154 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 167 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 186 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–125 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 44–125 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 166–169 |
| CommentRequired | Public method and constructor comments are required | 171–174 |
| ShortVariable | Avoid variables with short names like id | 176 |
| CommentRequired | Public method and constructor comments are required | 176–179 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 146–149 |
| CommentRequired | Public method and constructor comments are required | 151–154 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDuplicateLiterals | The String literal "SELECT " appears 4 times in this file; the first occurrence is on line 52 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 67 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 90 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 111 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 124 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 146 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 166 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 186 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 211–214 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 219 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 255 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–194 |
| CommentRequired | Public method and constructor comments are required | 167 |
| CommentRequired | Public method and constructor comments are required | 169 |
| CommentRequired | Public method and constructor comments are required | 171 |
| CommentRequired | Public method and constructor comments are required | 173 |
| CommentRequired | Public method and constructor comments are required | 175 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 119 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–140 |
| CommentRequired | Public method and constructor comments are required | 57 |
| CommentRequired | Public method and constructor comments are required | 135 |
| CommentRequired | Public method and constructor comments are required | 137 |
| CommentRequired | Public method and constructor comments are required | 139 |
| ShortVariable | Avoid variables with short names like id | 139 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 106 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–51 |
| CommentRequired | Public method and constructor comments are required | 42–45 |
| CommentRequired | Public method and constructor comments are required | 47–50 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 81–132 |
| CommentRequired | Public method and constructor comments are required | 89–93 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 89–93 |
| CommentRequired | Public method and constructor comments are required | 95–103 |
| CommentRequired | Public method and constructor comments are required | 105–112 |
| CommentRequired | Public method and constructor comments are required | 114–120 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–101 |
| CommentRequired | Public method and constructor comments are required | 53–57 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 53–57 |
| CommentRequired | Public method and constructor comments are required | 59–67 |
| CommentRequired | Public method and constructor comments are required | 69–77 |
| CommentRequired | Public method and constructor comments are required | 79–88 |
| CommentRequired | Public method and constructor comments are required | 90–94 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–419 |
| CommentRequired | Header comments are required | 73–419 |
| UnusedPrivateField | Avoid unused private fields such as 'VALIDATE_BATCH_ACTION_ID'. | 79 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 85 |
| CommentRequired | Public method and constructor comments are required | 87–94 |
| NonThreadSafeSingleton | Singleton is not thread safe | 89–92 |
| NPathComplexity | The method 'importBatch(BatchDto, User, String)' has an NPath complexity of 322 | 96–184 |
| CyclomaticComplexity | The method 'importBatch(BatchDto, User, String)' has a cyclomatic complexity of 14. | 96–184 |
| CommentRequired | Public method and constructor comments are required | 96–184 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 129 |
| UnusedLocalVariable | Avoid unused local variables such as 'batchWorkflowBean'. | 129 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 175 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. | 195 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 240 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. | 261 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 265–279 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 281 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. | 298 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 302–316 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 318 |
| CommentRequired | Public method and constructor comments are required | 326–335 |
| CommentRequired | Public method and constructor comments are required | 337–346 |
| CommentRequired | Public method and constructor comments are required | 348–418 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–160 |
| CommentRequired | Public method and constructor comments are required | 58–65 |
| NonThreadSafeSingleton | Singleton is not thread safe | 60–63 |
| CommentRequired | Public method and constructor comments are required | 67–73 |
| CyclomaticComplexity | The method 'validateBatch(BatchDto)' has a cyclomatic complexity of 21. | 83–144 |
| NPathComplexity | The method 'validateBatch(BatchDto)' has an NPath complexity of 704 | 83–144 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 56–148 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 58 |
| CommentRequired | Public method and constructor comments are required | 60–67 |
| NonThreadSafeSingleton | Singleton is not thread safe | 62–65 |
| CommentRequired | Public method and constructor comments are required | 69–104 |
| CommentRequired | Public method and constructor comments are required | 106–147 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–69 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 48 |
| CommentRequired | Public method and constructor comments are required | 50–58 |
| NonThreadSafeSingleton | Singleton is not thread safe | 52–56 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–105 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 53 |
| CommentRequired | Public method and constructor comments are required | 55–63 |
| NonThreadSafeSingleton | Singleton is not thread safe | 57–61 |
| CommentRequired | Public method and constructor comments are required | 65–92 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–69 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. | 53 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 110 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 110 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–684 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 91–684 |
| TooManyFields | Too many fields | 91–684 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 228 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 234 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 344 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 505 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 539–574 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 548 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 579 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 580 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 581 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 583 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 614 |
| CommentRequired | Protected method constructor comments are required | 650–664 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 668 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 61–299 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 121 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 139–146 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 140–146 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 166 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 54–131 |
| CommentRequired | Public method and constructor comments are required | 59–65 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 52–123 |
| CommentRequired | Public method and constructor comments are required | 57–63 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 71–73 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 92–94 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–63 |
| CommentRequired | Public method and constructor comments are required | 49–56 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like e | 60 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like e | 59 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type | 43 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type | 50 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 48–50 |
| CommentRequired | Header comments are required | 52–79 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–232 |
| ImmutableField | Private field '_resource' could be made final; it is only initialized in the declaration or constructor. | 48 |
| ImmutableField | Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. | 49 |
| ImmutableField | Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. | 50 |
| ImmutableField | Private field '_user' could be made final; it is only initialized in the declaration or constructor. | 51 |
| ImmutableField | Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. | 52 |
| CommentRequired | Public method and constructor comments are required | 213–216 |
| CommentRequired | Public method and constructor comments are required | 218–221 |
| CommentRequired | Public method and constructor comments are required | 223–226 |
| CommentRequired | Public method and constructor comments are required | 228–231 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–306 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–306 |
| ImmutableField | Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. | 73 |
| ImmutableField | Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. | 74 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 207 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 236–248 |
| CommentRequired | Public method and constructor comments are required | 302–305 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotNull' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.contract.ServiceContractDto' | 44 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotNull' | 4 | 37 |
| UnusedPrivateField | Avoid unused private fields such as 'RESOURCE_TYPE'. | 3 | 48 |
| CommentRequired | Public method and constructor comments are required | 3 | 192–196 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–509 |
| AvoidDuplicateLiterals | The String literal "SELECT " appears 7 times in this file; the first occurrence is on line 56 | 3 | 56 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_PURGE'. | 3 | 64 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 91 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 115 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 135 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 170 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 197 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 219 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 240 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 264 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 329 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 354 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 357 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 363 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 366 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 386 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 411–414 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 419 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 445 |
| MissingOverride | The method 'getBatchInitialActionId(Plugin)' is missing an @Override annotation. | 3 | 468–479 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 470 |
| MissingOverride | The method 'getBatchInTreatmentActionId(Plugin)' is missing an @Override annotation. | 3 | 484–495 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 486 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 155–158 |
| CommentRequired | Public method and constructor comments are required | 3 | 160–163 |
| ShortVariable | Avoid variables with short names like id | 3 | 160 |
| CommentRequired | Public method and constructor comments are required | 3 | 200–203 |
| CommentRequired | Public method and constructor comments are required | 3 | 205–208 |
| CommentRequired | Public method and constructor comments are required | 3 | 210–213 |
| CommentRequired | Public method and constructor comments are required | 3 | 215–218 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'CONSTANT_RESOURCE_IDENTITY_CANDIDATE'. | 3 | 48 |
| FieldNamingConventions | The field name 'strStatus' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 69 |
| CommentRequired | Public method and constructor comments are required | 3 | 94–97 |
| FormalParameterNamingConventions | The method parameter name '_nWorkflowResourceId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 99 |
| CommentRequired | Public method and constructor comments are required | 3 | 99–102 |
| CommentRequired | Public method and constructor comments are required | 3 | 188–191 |
| FormalParameterNamingConventions | The method parameter name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 193 |
| CommentRequired | Public method and constructor comments are required | 3 | 193–196 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nIdIdentity' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 184 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 139 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 230–233 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 49 |
| FieldNamingConventions | The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 50 |
| CommentRequired | Public method and constructor comments are required | 3 | 98–101 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 53–357 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 81 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 104 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 125 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 141 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 154 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 176 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 197 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 223–226 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 231 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 275 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 293 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 315 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 337 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–93 |
| CommentRequired | Public method and constructor comments are required | 3 | 44–47 |
| FormalParameterNamingConventions | The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 49–52 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–62 |
| FormalParameterNamingConventions | The method parameter name '_nCandidateIdentityId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 59 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–67 |
| FormalParameterNamingConventions | The method parameter name '_nWfResourceHistoryId' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 69 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–72 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–77 |
| FormalParameterNamingConventions | The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 79 |
| CommentRequired | Public method and constructor comments are required | 3 | 79–82 |
| CommentRequired | Public method and constructor comments are required | 3 | 84–87 |
| CommentRequired | Public method and constructor comments are required | 3 | 89–92 |
| FormalParameterNamingConventions | The method parameter name '_strComment' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 75 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 97 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 118 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 138 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 154 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 167 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 186 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–125 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 44–125 |
| FieldNamingConventions | The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 46 |
| FieldNamingConventions | The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 47 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 166–169 |
| CommentRequired | Public method and constructor comments are required | 3 | 171–174 |
| ShortVariable | Avoid variables with short names like id | 3 | 176 |
| CommentRequired | Public method and constructor comments are required | 3 | 176–179 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 146–149 |
| CommentRequired | Public method and constructor comments are required | 3 | 151–154 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDuplicateLiterals | The String literal "SELECT " appears 4 times in this file; the first occurrence is on line 52 | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 67 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 90 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 111 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 124 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 146 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 166 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 186 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 211–214 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 219 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 255 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–194 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 165 |
| CommentRequired | Public method and constructor comments are required | 3 | 167 |
| CommentRequired | Public method and constructor comments are required | 3 | 169 |
| CommentRequired | Public method and constructor comments are required | 3 | 171 |
| CommentRequired | Public method and constructor comments are required | 3 | 173 |
| CommentRequired | Public method and constructor comments are required | 3 | 175 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The final method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 117 |
| CommentRequired | Public method and constructor comments are required | 3 | 119 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 46–140 |
| CommentRequired | Public method and constructor comments are required | 3 | 57 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 120 |
| CommentRequired | Public method and constructor comments are required | 3 | 135 |
| CommentRequired | Public method and constructor comments are required | 3 | 137 |
| CommentRequired | Public method and constructor comments are required | 3 | 139 |
| ShortVariable | Avoid variables with short names like id | 3 | 139 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–51 |
| CommentRequired | Public method and constructor comments are required | 3 | 42–45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47–50 |
| FormalParameterNamingConventions | The method parameter name '_nResourceCount' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 47 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 81–132 |
| FieldNamingConventions | The final field name '_referentialService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 87 |
| CommentRequired | Public method and constructor comments are required | 3 | 89–93 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 89–93 |
| CommentRequired | Public method and constructor comments are required | 3 | 95–103 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 102 |
| CommentRequired | Public method and constructor comments are required | 3 | 105–112 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 111 |
| CommentRequired | Public method and constructor comments are required | 3 | 114–120 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–101 |
| FieldNamingConventions | The final field name '_serviceContractService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 49 |
| FieldNamingConventions | The final field name '_currentClientCode' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 51 |
| CommentRequired | Public method and constructor comments are required | 3 | 53–57 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 53–57 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–67 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 66 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–77 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 76 |
| CommentRequired | Public method and constructor comments are required | 3 | 79–88 |
| CommentRequired | Public method and constructor comments are required | 3 | 90–94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–419 |
| CommentRequired | Header comments are required | 3 | 73–419 |
| UnusedPrivateField | Avoid unused private fields such as 'VALIDATE_BATCH_ACTION_ID'. | 3 | 79 |
| FieldNamingConventions | The final field name '_wfIdentityBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 80 |
| FieldNamingConventions | The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 81 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 85 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 3 | 85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–94 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 89–92 |
| NPathComplexity | The method 'importBatch(BatchDto, User, String)' has an NPath complexity of 322 | 3 | 96–184 |
| CyclomaticComplexity | The method 'importBatch(BatchDto, User, String)' has a cyclomatic complexity of 14. | 3 | 96–184 |
| CommentRequired | Public method and constructor comments are required | 3 | 96–184 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 129 |
| UnusedLocalVariable | Avoid unused local variables such as 'batchWorkflowBean'. | 3 | 129 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 175 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. | 3 | 195 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 240 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 56 characters appended. | 3 | 261 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 265–279 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 281 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. | 3 | 298 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 302–316 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 318 |
| CommentRequired | Public method and constructor comments are required | 3 | 326–335 |
| CommentRequired | Public method and constructor comments are required | 3 | 337–346 |
| CommentRequired | Public method and constructor comments are required | 3 | 348–418 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 48–160 |
| CommentRequired | Header comments are required | 3 | 48–160 |
| CommentRequired | Public method and constructor comments are required | 3 | 58–65 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–73 |
| CyclomaticComplexity | The method 'validateBatch(BatchDto)' has a cyclomatic complexity of 21. | 3 | 83–144 |
| NPathComplexity | The method 'validateBatch(BatchDto)' has an NPath complexity of 704 | 3 | 83–144 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.contract.ServiceContractDto' | 4 | 44 |
| CommentRequired | Header comments are required | 3 | 56–148 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 58 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 3 | 58 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–67 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 62–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–104 |
| CommentRequired | Public method and constructor comments are required | 3 | 106–147 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–69 |
| FieldNamingConventions | The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 46 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 48 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 3 | 48 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–58 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 52–56 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 48–105 |
| FieldNamingConventions | The final field name '_cache' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 51 |
| AvoidFieldNameMatchingMethodName | Field instance has the same name as a method | 3 | 53 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 53 |
| CommentRequired | Public method and constructor comments are required | 3 | 55–63 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 57–61 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–92 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–69 |
| FieldNamingConventions | The constant name '_batchLimit' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 46 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 51 characters appended. | 3 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 110 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–684 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 91–684 |
| TooManyFields | Too many fields | 3 | 91–684 |
| FieldNamingConventions | The final field name '_wfBatchBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 173 |
| FieldNamingConventions | The final field name '_wfIdentitiesBeanService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 174 |
| FieldNamingConventions | The field name '_current_batch_state' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 183 |
| FieldNamingConventions | The final field name 'DUPLICATE_RULE_CODES' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 201 |
| FieldNamingConventions | The final field name 'NB_ITEMS_PER_PAGES' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 202 |
| FieldNamingConventions | The final field name 'IMPORT_CLIENT_CODE' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 203 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 228 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 234 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 344 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 505 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 539–574 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 548 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 579 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 580 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 581 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 583 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 614 |
| CommentRequired | Protected method constructor comments are required | 3 | 650–664 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 668 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 61–299 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 121 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 139–146 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 140–146 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 166 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 54–131 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 52–123 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–63 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 71–73 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 92–94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 49–56 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like e | 3 | 60 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like e | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResourceType': the method is declared in an interface type | 3 | 43 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResourceId': the method is declared in an interface type | 3 | 50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 48–50 |
| CommentRequired | Header comments are required | 3 | 52–79 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–232 |
| ImmutableField | Private field '_resource' could be made final; it is only initialized in the declaration or constructor. | 3 | 48 |
| ImmutableField | Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. | 3 | 49 |
| ImmutableField | Private field '_nResourceId' could be made final; it is only initialized in the declaration or constructor. | 3 | 50 |
| ImmutableField | Private field '_user' could be made final; it is only initialized in the declaration or constructor. | 3 | 51 |
| ImmutableField | Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. | 3 | 52 |
| FormalParameterNamingConventions | The method parameter name '_state' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 158 |
| FormalParameterNamingConventions | The method parameter name '_listActions' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 168 |
| FormalParameterNamingConventions | The method parameter name '_strHistory' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 178 |
| CommentRequired | Public method and constructor comments are required | 3 | 213–216 |
| FormalParameterNamingConventions | The method parameter name '_nNbSubResource' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 218 |
| CommentRequired | Public method and constructor comments are required | 3 | 218–221 |
| CommentRequired | Public method and constructor comments are required | 3 | 223–226 |
| CommentRequired | Public method and constructor comments are required | 3 | 228–231 |
| FormalParameterNamingConventions | The method parameter name '_listSubResourceStates' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 228 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–306 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–306 |
| ImmutableField | Private field '_nWorkflowKey' could be made final; it is only initialized in the declaration or constructor. | 3 | 73 |
| ImmutableField | Private field '_strResourceType' could be made final; it is only initialized in the declaration or constructor. | 3 | 74 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 207 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 236–248 |
| CommentRequired | Public method and constructor comments are required | 3 | 302–305 |
