Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/identitypicker/business/IdentitySearchCriteria.java

Rule Violation Line
FieldNamingConventions The field name 'commonEmail' doesn't match '_[a-z][a-zA-Z0-9]*' 8
FieldNamingConventions The field name 'commonLastName' doesn't match '_[a-z][a-zA-Z0-9]*' 11
FieldNamingConventions The field name 'firstName' doesn't match '_[a-z][a-zA-Z0-9]*' 14
FieldNamingConventions The field name 'birthDate' doesn't match '_[a-z][a-zA-Z0-9]*' 17

fr/paris/lutece/plugins/identitypicker/business/Referential.java

Rule Violation Line
FieldNamingConventions The field name 'processList' doesn't match '_[a-z][a-zA-Z0-9]*' 9
FieldNamingConventions The field name 'levelList' doesn't match '_[a-z][a-zA-Z0-9]*' 10
FieldNamingConventions The field name 'attributeKeyList' doesn't match '_[a-z][a-zA-Z0-9]*' 11

fr/paris/lutece/plugins/identitypicker/business/Rules.java

Rule Violation Line
FieldNamingConventions The field name 'referential' doesn't match '_[a-z][a-zA-Z0-9]*' 7
FieldNamingConventions The field name 'contract' doesn't match '_[a-z][a-zA-Z0-9]*' 8

fr/paris/lutece/plugins/identitypicker/service/IdentityPickerService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 66276
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 75

fr/paris/lutece/plugins/identitypicker/service/rs/IdentityRestConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'IdentityRestConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3653

Priority 3

fr/paris/lutece/plugins/identitypicker/business/IdentitySearchCriteria.java

Rule Violation Line
CommentRequired Header comments are required 589
DataClass The class 'IdentitySearchCriteria' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=8, WMC=13) 589
CommentRequired Public method and constructor comments are required 2022
UncommentedEmptyConstructor Document empty constructor 2022
CommentRequired Public method and constructor comments are required 2531
CommentRequired Public method and constructor comments are required 3437
CommentRequired Public method and constructor comments are required 3942

fr/paris/lutece/plugins/identitypicker/business/Referential.java

Rule Violation Line
CommentRequired Header comments are required 734
ImmutableField Private field 'processList' could be made final; it is only initialized in the declaration or constructor. 9
ImmutableField Private field 'levelList' could be made final; it is only initialized in the declaration or constructor. 10
ImmutableField Private field 'attributeKeyList' could be made final; it is only initialized in the declaration or constructor. 11
CommentRequired Public method and constructor comments are required 1318

fr/paris/lutece/plugins/identitypicker/business/Rules.java

Rule Violation Line
CommentRequired Header comments are required 526
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the referential field if you want a default access modifier 7
DefaultPackage Use explicit scoping instead of the default package private level 7
DefaultPackage Use explicit scoping instead of the default package private level 8
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the contract field if you want a default access modifier 8
CommentRequired Public method and constructor comments are required 1014

fr/paris/lutece/plugins/identitypicker/service/IdentityPickerResourceService.java

Rule Violation Line
DataClass The class 'IdentityPickerResourceService' is suspected to be a Data Class (WOC=0.000%, NOPA=5, NOAM=0, WMC=2) 1498
CallSuperInConstructor It is a good practice to call super() in a constructor 2932

fr/paris/lutece/plugins/identitypicker/service/IdentityPickerService.java

Rule Violation Line
CommentRequired Header comments are required 66276
ImmutableField Private field '_referentialService' could be made final; it is only initialized in the declaration or constructor. 79
ImmutableField Private field '_serviceContract' could be made final; it is only initialized in the declaration or constructor. 80
NonThreadSafeSingleton Singleton is not thread safe 98102

fr/paris/lutece/plugins/identitypicker/service/rs/IdentityRestConstants.java

Rule Violation Line
CommentRequired Header comments are required 3653

fr/paris/lutece/plugins/identitypicker/service/rs/IdentityRestService.java

Rule Violation Line
CommentRequired Header comments are required 62221
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 99
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 190
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 199

Files

fr/paris/lutece/plugins/identitypicker/business/IdentitySearchCriteria.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 589
DataClass The class 'IdentitySearchCriteria' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=8, WMC=13) 3 589
FieldNamingConventions The field name 'commonEmail' doesn't match '_[a-z][a-zA-Z0-9]*' 1 8
FieldNamingConventions The field name 'commonLastName' doesn't match '_[a-z][a-zA-Z0-9]*' 1 11
FieldNamingConventions The field name 'firstName' doesn't match '_[a-z][a-zA-Z0-9]*' 1 14
FieldNamingConventions The field name 'birthDate' doesn't match '_[a-z][a-zA-Z0-9]*' 1 17
CommentRequired Public method and constructor comments are required 3 2022
UncommentedEmptyConstructor Document empty constructor 3 2022
CommentRequired Public method and constructor comments are required 3 2531
CommentRequired Public method and constructor comments are required 3 3437
CommentRequired Public method and constructor comments are required 3 3942

fr/paris/lutece/plugins/identitypicker/business/Referential.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 734
FieldNamingConventions The field name 'processList' doesn't match '_[a-z][a-zA-Z0-9]*' 1 9
ImmutableField Private field 'processList' could be made final; it is only initialized in the declaration or constructor. 3 9
ImmutableField Private field 'levelList' could be made final; it is only initialized in the declaration or constructor. 3 10
FieldNamingConventions The field name 'levelList' doesn't match '_[a-z][a-zA-Z0-9]*' 1 10
FieldNamingConventions The field name 'attributeKeyList' doesn't match '_[a-z][a-zA-Z0-9]*' 1 11
ImmutableField Private field 'attributeKeyList' could be made final; it is only initialized in the declaration or constructor. 3 11
CommentRequired Public method and constructor comments are required 3 1318

fr/paris/lutece/plugins/identitypicker/business/Rules.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 526
FieldNamingConventions The field name 'referential' doesn't match '_[a-z][a-zA-Z0-9]*' 1 7
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the referential field if you want a default access modifier 3 7
DefaultPackage Use explicit scoping instead of the default package private level 3 7
DefaultPackage Use explicit scoping instead of the default package private level 3 8
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the contract field if you want a default access modifier 3 8
FieldNamingConventions The field name 'contract' doesn't match '_[a-z][a-zA-Z0-9]*' 1 8
CommentRequired Public method and constructor comments are required 3 1014

fr/paris/lutece/plugins/identitypicker/service/IdentityPickerResourceService.java

Rule Violation Priority Line
DataClass The class 'IdentityPickerResourceService' is suspected to be a Data Class (WOC=0.000%, NOPA=5, NOAM=0, WMC=2) 3 1498
CallSuperInConstructor It is a good practice to call super() in a constructor 3 2932

fr/paris/lutece/plugins/identitypicker/service/IdentityPickerService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 66276
CommentRequired Header comments are required 3 66276
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 75
ImmutableField Private field '_referentialService' could be made final; it is only initialized in the declaration or constructor. 3 79
ImmutableField Private field '_serviceContract' could be made final; it is only initialized in the declaration or constructor. 3 80
NonThreadSafeSingleton Singleton is not thread safe 3 98102

fr/paris/lutece/plugins/identitypicker/service/rs/IdentityRestConstants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'IdentityRestConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3653
CommentRequired Header comments are required 3 3653

fr/paris/lutece/plugins/identitypicker/service/rs/IdentityRestService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 62221
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 99
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 190
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 199