PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/identitystoreagent/IdentityStoreAgentPlugin.java
| Violation |
Line |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
44–51 |
fr/paris/lutece/plugins/identitystoreagent/service/IdentityAgentManagementResourceIdService.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
62–65 |
| Avoid variables with short names like rt |
73 |
| Avoid variables with short names like p |
79 |
fr/paris/lutece/plugins/identitystoreagent/utils/IdentityUtils.java
| Violation |
Line |
| The class 'IdentityUtils' has a Cyclomatic Complexity of 5 (Highest = 11). |
61–235 |
| The field name indicates a constant but its modifiers do not |
66 |
| The field name indicates a constant but its modifiers do not |
67 |
| The method 'updateIdentity' has a Cyclomatic Complexity of 11. |
116–179 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() |
119 |
| Deeply nested if..then statements are hard to read |
156–159 |
| The method 'agentCertification' has a Cyclomatic Complexity of 11. |
181–234 |
fr/paris/lutece/plugins/identitystoreagent/web/ManageCustomerIdentityJspBean.java
| Violation |
Line |
| The class 'ManageCustomerIdentityJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 10). |
67–396 |
| The class 'ManageCustomerIdentityJspBean' has a Cyclomatic Complexity of 6 (Highest = 14). |
67–396 |
| The class 'ManageCustomerIdentityJspBean' has a Standard Cyclomatic Complexity of 5 (Highest = 10). |
67–396 |
| Private field '_mapReferenceList' could be made final; it is only initialized in the declaration or constructor. |
83 |
| It is a good practice to call super() in a constructor |
91–141 |
| Assigning an Object to null is a code smell. Consider refactoring. |
140 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
207 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
225 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
244 |
| The method 'initFromRequest' has a Cyclomatic Complexity of 14. |
344–395 |
| The method 'initFromRequest' has a Modified Cyclomatic Complexity of 10. |
344–395 |
| The method 'initFromRequest' has a Standard Cyclomatic Complexity of 10. |
344–395 |
