Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/importexport/business/importdata/ImportResult.java

Rule Violation Ligne
ConstructorCallsOverridableMethod Overridable method 'setListImportMessage' called during object construction 73

fr/paris/lutece/plugins/importexport/service/export/ExportManager.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'ExportManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 58284
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 241

fr/paris/lutece/plugins/importexport/service/importdata/csvimportsource/CSVImportSource.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 115

Priority 2

fr/paris/lutece/plugins/importexport/service/importdata/RunnableImportService.java

Rule Violation Ligne
AvoidUsingVolatile Use of modifier volatile is not recommended. 59

Priority 3

fr/paris/lutece/plugins/importexport/business/AbstractImportExportDAO.java

Rule Violation Ligne
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 52222
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 87
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 92
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 99
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 112
AssignmentInOperand Avoid assignments in operands 119
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 131
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 152
CyclomaticComplexity The method 'getJavaTypeFromSqlString(String)' has a cyclomatic complexity of 16. 169221
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 171
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 176

fr/paris/lutece/plugins/importexport/business/export/AutomaticExportConfigDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 94
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 123143
LinguisticNaming Linguistics Antipattern - The getter 'getListColumns' should not return void linguistically 192208
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 198

fr/paris/lutece/plugins/importexport/business/export/ExportDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 79
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 87
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 136
CyclomaticComplexity The method 'getElementValue(DAOUtil, ColumnType, int)' has a cyclomatic complexity of 11. 152197
MissingBreakInSwitch A switch statement does not contain a break 155195

fr/paris/lutece/plugins/importexport/business/importdata/ImportDataDAO.java

Rule Violation Ligne
CyclomaticComplexity The class 'ImportDataDAO' has a total cyclomatic complexity of 108 (highest 24). 65741
ImmutableField Private field '_listTableColumns' could be made final; it is only initialized in the declaration or constructor. 94
ImmutableField Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. 95
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 97
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 98
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 115
CallSuperInConstructor It is a good practice to call super() in a constructor 115136
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 121
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 150
CyclomaticComplexity The method 'insertElement(List)' has a cyclomatic complexity of 11. 150181
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 195
CyclomaticComplexity The method 'updateElement(List)' has a cyclomatic complexity of 16. 195244
ConfusingTernary Avoid if (x != y) ..; else ..; 309318
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 312
ConfusingTernary Avoid if (x != y) ..; else ..; 326335
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 329
NcssCount The method 'addSqlParameter(int, String, ColumnType)' has a NCSS line count of 64. 352473
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 352
CyclomaticComplexity The method 'addSqlParameter(int, String, ColumnType)' has a cyclomatic complexity of 24. 352473
ExcessiveMethodLength Avoid really long methods. 352473
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 395
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 423
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 442
ExceptionAsFlowControl Avoid using exceptions as flow control. 468
ExceptionAsFlowControl Avoid using exceptions as flow control. 468
ExceptionAsFlowControl Avoid using exceptions as flow control. 468
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 491
ExcessiveMethodLength Avoid really long methods. 491598
CyclomaticComplexity The method 'addSqlParameter(int, String, ColumnType, DAOUtil)' has a cyclomatic complexity of 22. 491598
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 534
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 552
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 562
ExceptionAsFlowControl Avoid using exceptions as flow control. 593
ExceptionAsFlowControl Avoid using exceptions as flow control. 593
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 613
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 614
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 621
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 622
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 623
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 630
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 649
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 704
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 705
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 706
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 707
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 708

fr/paris/lutece/plugins/importexport/business/importdata/ImportMessage.java

Rule Violation Ligne
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 168
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 169

fr/paris/lutece/plugins/importexport/business/importdata/ImportResult.java

Rule Violation Ligne
UncommentedEmptyConstructor Document empty constructor 5154

fr/paris/lutece/plugins/importexport/service/export/ExportManager.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 71
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 71
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 97
ConfusingTernary Avoid if (x != y) ..; else ..; 102109
CollapsibleIfStatements These nested if statements could be combined 185189
CyclomaticComplexity The method 'doProcessExportIntoFile(String, String, List, int, Plugin)' has a cyclomatic complexity of 11. 210283
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 247
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 248
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 252

fr/paris/lutece/plugins/importexport/service/export/RunnableExportService.java

Rule Violation Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 47
ImmutableField Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. 59
ImmutableField Private field '_listColumns' could be made final; it is only initialized in the declaration or constructor. 60
ImmutableField Private field '_nXSLStylesheetId' could be made final; it is only initialized in the declaration or constructor. 61
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 62
ImmutableField Private field '_strExportKey' could be made final; it is only initialized in the declaration or constructor. 63
ImmutableField Private field '_strFileExtention' could be made final; it is only initialized in the declaration or constructor. 64
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 102

fr/paris/lutece/plugins/importexport/service/export/daemon/ExportCleanerDaemon.java

Rule Violation Ligne
UseUnderscoresInNumericLiterals Number 7200000l should separate every third digit with an underscore 55

fr/paris/lutece/plugins/importexport/service/export/daemon/ExportDaemon.java

Rule Violation Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 102
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 121

fr/paris/lutece/plugins/importexport/service/importdata/ImportManager.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 63
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 67
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 67
CyclomaticComplexity The method 'doProcessImport(IImportSource, String, boolean, boolean, boolean, Plugin, Locale)' has a cyclomatic complexity of 14. 170268
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 173
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 174
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 175
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 176
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 177
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 189
IdenticalCatchBranches 'catch' branch identical to 'AppException' branch 202205
AssignmentInOperand Avoid assignments in operands 208
IdenticalCatchBranches 'catch' branch identical to 'AppException' branch 246256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 260
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 352

fr/paris/lutece/plugins/importexport/service/importdata/RunnableImportService.java

Rule Violation Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 45
ImmutableField Private field '_importSource' could be made final; it is only initialized in the declaration or constructor. 51
ImmutableField Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. 52
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 53
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 54
ImmutableField Private field '_bUpdateExistingRows' could be made final; it is only initialized in the declaration or constructor. 55
ImmutableField Private field '_bStopOnErrors' could be made final; it is only initialized in the declaration or constructor. 56
ImmutableField Private field '_bEmptyTable' could be made final; it is only initialized in the declaration or constructor. 57
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 102

fr/paris/lutece/plugins/importexport/service/importdata/csvimportsource/CSVImportSource.java

Rule Violation Ligne
UseUnderscoresInNumericLiterals Number 65279 should separate every third digit with an underscore 61
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 155
ShortVariable Avoid variables with short names like i 161
CyclomaticComplexity The method 'getColumnsName()' has a cyclomatic complexity of 10. 179235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 202
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 210
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 215224
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 221
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 248

fr/paris/lutece/plugins/importexport/service/importdata/csvimportsource/CSVImportSourceFactory.java

Rule Violation Ligne
ImmutableField Private field '_strSeparator' could be made final; it is only initialized in the declaration or constructor. 55
ImmutableField Private field '_strQuote' could be made final; it is only initialized in the declaration or constructor. 56

fr/paris/lutece/plugins/importexport/service/importdata/daemon/ImportDaemon.java

Rule Violation Ligne
CyclomaticComplexity The method 'run()' has a cyclomatic complexity of 20. 68143
NPathComplexity The method 'run()' has an NPath complexity of 232 68143
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 76
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 112133

fr/paris/lutece/plugins/importexport/web/ExportDataJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34655
ImmutableField Private field '_automaticExportConfigDAO' could be made final; it is only initialized in the declaration or constructor. 138
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 143145
UncommentedEmptyConstructor Document empty constructor 143145
CallSuperInConstructor It is a good practice to call super() in a constructor 143145
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 168
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 168
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 212
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 213
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 228
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 228
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 258
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 259
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 280
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 371372
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 381
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 381
ShortVariable Avoid variables with short names like df 383
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 383
ShortVariable Avoid variables with short names like df 415
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 415
NcssCount The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a NCSS line count of 64. 438542
NPathComplexity The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has an NPath complexity of 648 438542
CyclomaticComplexity The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 15. 438542
ExcessiveMethodLength Avoid really long methods. 438542
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 468
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 468
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 613

fr/paris/lutece/plugins/importexport/web/ImportDataJspBean.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 115117
UncommentedEmptyConstructor Document empty constructor 115117
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 115117
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 146
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 146
CyclomaticComplexity The method 'doImportData(HttpServletRequest)' has a cyclomatic complexity of 11. 184240
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 198
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 199
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 200
UseUnderscoresInNumericLiterals Number 1048576l should separate every third digit with an underscore 224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 226232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 286
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 286

Priority 4

fr/paris/lutece/plugins/importexport/business/TableColumn.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 8891

Fichiers

fr/paris/lutece/plugins/importexport/business/AbstractImportExportDAO.java

Rule Violation Priority Ligne
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 52222
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 87
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 92
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 99
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 112
AssignmentInOperand Avoid assignments in operands 3 119
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 131
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 152
CyclomaticComplexity The method 'getJavaTypeFromSqlString(String)' has a cyclomatic complexity of 16. 3 169221
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 171
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 176

fr/paris/lutece/plugins/importexport/business/TableColumn.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 8891

fr/paris/lutece/plugins/importexport/business/export/AutomaticExportConfigDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 94
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 123143
LinguisticNaming Linguistics Antipattern - The getter 'getListColumns' should not return void linguistically 3 192208
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 198

fr/paris/lutece/plugins/importexport/business/export/ExportDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 79
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 87
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 136
CyclomaticComplexity The method 'getElementValue(DAOUtil, ColumnType, int)' has a cyclomatic complexity of 11. 3 152197
MissingBreakInSwitch A switch statement does not contain a break 3 155195

fr/paris/lutece/plugins/importexport/business/importdata/ImportDataDAO.java

Rule Violation Priority Ligne
CyclomaticComplexity The class 'ImportDataDAO' has a total cyclomatic complexity of 108 (highest 24). 3 65741
ImmutableField Private field '_listTableColumns' could be made final; it is only initialized in the declaration or constructor. 3 94
ImmutableField Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. 3 95
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 3 97
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 3 98
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 115
CallSuperInConstructor It is a good practice to call super() in a constructor 3 115136
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 121
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 150
CyclomaticComplexity The method 'insertElement(List)' has a cyclomatic complexity of 11. 3 150181
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 195
CyclomaticComplexity The method 'updateElement(List)' has a cyclomatic complexity of 16. 3 195244
ConfusingTernary Avoid if (x != y) ..; else ..; 3 309318
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 312
ConfusingTernary Avoid if (x != y) ..; else ..; 3 326335
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 329
NcssCount The method 'addSqlParameter(int, String, ColumnType)' has a NCSS line count of 64. 3 352473
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 352
CyclomaticComplexity The method 'addSqlParameter(int, String, ColumnType)' has a cyclomatic complexity of 24. 3 352473
ExcessiveMethodLength Avoid really long methods. 3 352473
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 395
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 423
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 442
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 468
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 468
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 468
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 491
ExcessiveMethodLength Avoid really long methods. 3 491598
CyclomaticComplexity The method 'addSqlParameter(int, String, ColumnType, DAOUtil)' has a cyclomatic complexity of 22. 3 491598
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 534
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 552
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 562
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 593
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 593
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 613
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 614
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 621
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 622
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 623
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 630
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 649
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 704
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 705
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 706
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 707
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 708

fr/paris/lutece/plugins/importexport/business/importdata/ImportMessage.java

Rule Violation Priority Ligne
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 168
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 169

fr/paris/lutece/plugins/importexport/business/importdata/ImportResult.java

Rule Violation Priority Ligne
UncommentedEmptyConstructor Document empty constructor 3 5154
ConstructorCallsOverridableMethod Overridable method 'setListImportMessage' called during object construction 1 73

fr/paris/lutece/plugins/importexport/service/export/ExportManager.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'ExportManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 58284
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 71
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 71
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 97
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102109
CollapsibleIfStatements These nested if statements could be combined 3 185189
CyclomaticComplexity The method 'doProcessExportIntoFile(String, String, List, int, Plugin)' has a cyclomatic complexity of 11. 3 210283
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 241
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 247
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 248
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 252

fr/paris/lutece/plugins/importexport/service/export/RunnableExportService.java

Rule Violation Priority Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 47
ImmutableField Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. 3 59
ImmutableField Private field '_listColumns' could be made final; it is only initialized in the declaration or constructor. 3 60
ImmutableField Private field '_nXSLStylesheetId' could be made final; it is only initialized in the declaration or constructor. 3 61
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 3 62
ImmutableField Private field '_strExportKey' could be made final; it is only initialized in the declaration or constructor. 3 63
ImmutableField Private field '_strFileExtention' could be made final; it is only initialized in the declaration or constructor. 3 64
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 102

fr/paris/lutece/plugins/importexport/service/export/daemon/ExportCleanerDaemon.java

Rule Violation Priority Ligne
UseUnderscoresInNumericLiterals Number 7200000l should separate every third digit with an underscore 3 55

fr/paris/lutece/plugins/importexport/service/export/daemon/ExportDaemon.java

Rule Violation Priority Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 102
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 121

fr/paris/lutece/plugins/importexport/service/importdata/ImportManager.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 63
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 67
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 67
CyclomaticComplexity The method 'doProcessImport(IImportSource, String, boolean, boolean, boolean, Plugin, Locale)' has a cyclomatic complexity of 14. 3 170268
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 173
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 174
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 175
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 176
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 177
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 189
IdenticalCatchBranches 'catch' branch identical to 'AppException' branch 3 202205
AssignmentInOperand Avoid assignments in operands 3 208
IdenticalCatchBranches 'catch' branch identical to 'AppException' branch 3 246256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 260
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 352

fr/paris/lutece/plugins/importexport/service/importdata/RunnableImportService.java

Rule Violation Priority Ligne
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 45
ImmutableField Private field '_importSource' could be made final; it is only initialized in the declaration or constructor. 3 51
ImmutableField Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. 3 52
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 3 53
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 3 54
ImmutableField Private field '_bUpdateExistingRows' could be made final; it is only initialized in the declaration or constructor. 3 55
ImmutableField Private field '_bStopOnErrors' could be made final; it is only initialized in the declaration or constructor. 3 56
ImmutableField Private field '_bEmptyTable' could be made final; it is only initialized in the declaration or constructor. 3 57
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 59
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 102

fr/paris/lutece/plugins/importexport/service/importdata/csvimportsource/CSVImportSource.java

Rule Violation Priority Ligne
UseUnderscoresInNumericLiterals Number 65279 should separate every third digit with an underscore 3 61
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 115
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 155
ShortVariable Avoid variables with short names like i 3 161
CyclomaticComplexity The method 'getColumnsName()' has a cyclomatic complexity of 10. 3 179235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 202
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 210
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 215224
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 221
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 248

fr/paris/lutece/plugins/importexport/service/importdata/csvimportsource/CSVImportSourceFactory.java

Rule Violation Priority Ligne
ImmutableField Private field '_strSeparator' could be made final; it is only initialized in the declaration or constructor. 3 55
ImmutableField Private field '_strQuote' could be made final; it is only initialized in the declaration or constructor. 3 56

fr/paris/lutece/plugins/importexport/service/importdata/daemon/ImportDaemon.java

Rule Violation Priority Ligne
CyclomaticComplexity The method 'run()' has a cyclomatic complexity of 20. 3 68143
NPathComplexity The method 'run()' has an NPath complexity of 232 3 68143
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 76
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 112133

fr/paris/lutece/plugins/importexport/web/ExportDataJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34655
ImmutableField Private field '_automaticExportConfigDAO' could be made final; it is only initialized in the declaration or constructor. 3 138
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 143145
UncommentedEmptyConstructor Document empty constructor 3 143145
CallSuperInConstructor It is a good practice to call super() in a constructor 3 143145
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 168
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 168
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 212
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 213
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 228
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 228
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 258
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 259
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 280
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 371372
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 381
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 381
ShortVariable Avoid variables with short names like df 3 383
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 383
ShortVariable Avoid variables with short names like df 3 415
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 415
NcssCount The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a NCSS line count of 64. 3 438542
NPathComplexity The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has an NPath complexity of 648 3 438542
CyclomaticComplexity The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 15. 3 438542
ExcessiveMethodLength Avoid really long methods. 3 438542
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 468
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 468
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 613

fr/paris/lutece/plugins/importexport/web/ImportDataJspBean.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 115117
UncommentedEmptyConstructor Document empty constructor 3 115117
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 115117
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 146
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 146
CyclomaticComplexity The method 'doImportData(HttpServletRequest)' has a cyclomatic complexity of 11. 3 184240
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 198
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 199
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 200
UseUnderscoresInNumericLiterals Number 1048576l should separate every third digit with an underscore 3 224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 226232
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 286
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 286