The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'setListImportMessage' called during object construction | 73 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ExportManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 58–284 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 241 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 115 |
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 59 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 52–222 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 87 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 92 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 99 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 112 |
| AssignmentInOperand | Avoid assignments in operands | 119 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 131 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 152 |
| CyclomaticComplexity | The method 'getJavaTypeFromSqlString(String)' has a cyclomatic complexity of 16. | 169–221 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 171 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 176 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 94 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 123–143 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getListColumns' should not return void linguistically | 192–208 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 198 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 79 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 87 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 136 |
| CyclomaticComplexity | The method 'getElementValue(DAOUtil, ColumnType, int)' has a cyclomatic complexity of 11. | 152–197 |
| MissingBreakInSwitch | A switch statement does not contain a break | 155–195 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The class 'ImportDataDAO' has a total cyclomatic complexity of 108 (highest 24). | 65–741 |
| ImmutableField | Private field '_listTableColumns' could be made final; it is only initialized in the declaration or constructor. | 94 |
| ImmutableField | Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. | 95 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 97 |
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 98 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 115 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 115–136 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 121 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 150 |
| CyclomaticComplexity | The method 'insertElement(List)' has a cyclomatic complexity of 11. | 150–181 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 195 |
| CyclomaticComplexity | The method 'updateElement(List)' has a cyclomatic complexity of 16. | 195–244 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 309–318 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 326–335 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 329 |
| NcssCount | The method 'addSqlParameter(int, String, ColumnType)' has a NCSS line count of 64. | 352–473 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 352 |
| CyclomaticComplexity | The method 'addSqlParameter(int, String, ColumnType)' has a cyclomatic complexity of 24. | 352–473 |
| ExcessiveMethodLength | Avoid really long methods. | 352–473 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 395 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 423 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 442 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 468 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 468 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 468 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 491 |
| ExcessiveMethodLength | Avoid really long methods. | 491–598 |
| CyclomaticComplexity | The method 'addSqlParameter(int, String, ColumnType, DAOUtil)' has a cyclomatic complexity of 22. | 491–598 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 534 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 552 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 562 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 593 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 593 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 613 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 614 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 621 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 622 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 623 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 630 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 649 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 704 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 705 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 706 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 707 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 708 |
| Rule | Violation | Line |
|---|---|---|
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 168 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 169 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 51–54 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 71 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 71 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 97 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 97 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 102–109 |
| CollapsibleIfStatements | These nested if statements could be combined | 185–189 |
| CyclomaticComplexity | The method 'doProcessExportIntoFile(String, String, List, int, Plugin)' has a cyclomatic complexity of 11. | 210–283 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 247 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 248 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 252 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 47 |
| ImmutableField | Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. | 59 |
| ImmutableField | Private field '_listColumns' could be made final; it is only initialized in the declaration or constructor. | 60 |
| ImmutableField | Private field '_nXSLStylesheetId' could be made final; it is only initialized in the declaration or constructor. | 61 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 62 |
| ImmutableField | Private field '_strExportKey' could be made final; it is only initialized in the declaration or constructor. | 63 |
| ImmutableField | Private field '_strFileExtention' could be made final; it is only initialized in the declaration or constructor. | 64 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 102 |
| Rule | Violation | Line |
|---|---|---|
| UseUnderscoresInNumericLiterals | Number 7200000l should separate every third digit with an underscore | 55 |
| Rule | Violation | Line |
|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 102 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 121 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 63 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 67 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 67 |
| CyclomaticComplexity | The method 'doProcessImport(IImportSource, String, boolean, boolean, boolean, Plugin, Locale)' has a cyclomatic complexity of 14. | 170–268 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 173 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 174 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 175 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 176 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 177 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 189 |
| IdenticalCatchBranches | 'catch' branch identical to 'AppException' branch | 202–205 |
| AssignmentInOperand | Avoid assignments in operands | 208 |
| IdenticalCatchBranches | 'catch' branch identical to 'AppException' branch | 246–256 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 260 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 352 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 45 |
| ImmutableField | Private field '_importSource' could be made final; it is only initialized in the declaration or constructor. | 51 |
| ImmutableField | Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. | 52 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 53 |
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 54 |
| ImmutableField | Private field '_bUpdateExistingRows' could be made final; it is only initialized in the declaration or constructor. | 55 |
| ImmutableField | Private field '_bStopOnErrors' could be made final; it is only initialized in the declaration or constructor. | 56 |
| ImmutableField | Private field '_bEmptyTable' could be made final; it is only initialized in the declaration or constructor. | 57 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 102 |
| Rule | Violation | Line |
|---|---|---|
| UseUnderscoresInNumericLiterals | Number 65279 should separate every third digit with an underscore | 61 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 155 |
| ShortVariable | Avoid variables with short names like i | 161 |
| CyclomaticComplexity | The method 'getColumnsName()' has a cyclomatic complexity of 10. | 179–235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 202 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 210 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 215–224 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 221 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 248 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strSeparator' could be made final; it is only initialized in the declaration or constructor. | 55 |
| ImmutableField | Private field '_strQuote' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'run()' has a cyclomatic complexity of 20. | 68–143 |
| NPathComplexity | The method 'run()' has an NPath complexity of 232 | 68–143 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 76 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 112–133 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–655 |
| ImmutableField | Private field '_automaticExportConfigDAO' could be made final; it is only initialized in the declaration or constructor. | 138 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 143–145 |
| UncommentedEmptyConstructor | Document empty constructor | 143–145 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 143–145 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 168 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 212 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 213 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 228 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 228 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 258 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 259 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 280 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 371–372 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 381 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 381 |
| ShortVariable | Avoid variables with short names like df | 383 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 383 |
| ShortVariable | Avoid variables with short names like df | 415 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 415 |
| NcssCount | The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a NCSS line count of 64. | 438–542 |
| NPathComplexity | The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has an NPath complexity of 648 | 438–542 |
| CyclomaticComplexity | The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 15. | 438–542 |
| ExcessiveMethodLength | Avoid really long methods. | 438–542 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 468 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 468 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 613 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 115–117 |
| UncommentedEmptyConstructor | Document empty constructor | 115–117 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 115–117 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 146 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 146 |
| CyclomaticComplexity | The method 'doImportData(HttpServletRequest)' has a cyclomatic complexity of 11. | 184–240 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 197 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 199 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 200 |
| UseUnderscoresInNumericLiterals | Number 1048576l should separate every third digit with an underscore | 224 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 226–232 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 286 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 286 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 88–91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 52–222 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 87 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 92 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 99 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 112 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 119 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 131 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 152 |
| CyclomaticComplexity | The method 'getJavaTypeFromSqlString(String)' has a cyclomatic complexity of 16. | 3 | 169–221 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 171 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 176 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 88–91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 94 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 123–143 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getListColumns' should not return void linguistically | 3 | 192–208 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 198 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 79 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 87 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 136 |
| CyclomaticComplexity | The method 'getElementValue(DAOUtil, ColumnType, int)' has a cyclomatic complexity of 11. | 3 | 152–197 |
| MissingBreakInSwitch | A switch statement does not contain a break | 3 | 155–195 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The class 'ImportDataDAO' has a total cyclomatic complexity of 108 (highest 24). | 3 | 65–741 |
| ImmutableField | Private field '_listTableColumns' could be made final; it is only initialized in the declaration or constructor. | 3 | 94 |
| ImmutableField | Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. | 3 | 95 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 3 | 97 |
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 3 | 98 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 115 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 115–136 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 121 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 150 |
| CyclomaticComplexity | The method 'insertElement(List)' has a cyclomatic complexity of 11. | 3 | 150–181 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 195 |
| CyclomaticComplexity | The method 'updateElement(List)' has a cyclomatic complexity of 16. | 3 | 195–244 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 309–318 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 326–335 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 329 |
| NcssCount | The method 'addSqlParameter(int, String, ColumnType)' has a NCSS line count of 64. | 3 | 352–473 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 352 |
| CyclomaticComplexity | The method 'addSqlParameter(int, String, ColumnType)' has a cyclomatic complexity of 24. | 3 | 352–473 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 352–473 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 395 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 423 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 442 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 3 | 468 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 3 | 468 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 3 | 468 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 491 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 491–598 |
| CyclomaticComplexity | The method 'addSqlParameter(int, String, ColumnType, DAOUtil)' has a cyclomatic complexity of 22. | 3 | 491–598 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 534 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 552 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 562 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 3 | 593 |
| ExceptionAsFlowControl | Avoid using exceptions as flow control. | 3 | 593 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 613 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 614 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 621 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 622 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 623 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 630 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 649 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 704 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 705 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 706 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 707 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 708 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 168 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 169 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 3 | 51–54 |
| ConstructorCallsOverridableMethod | Overridable method 'setListImportMessage' called during object construction | 1 | 73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'ExportManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 58–284 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 71 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 71 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 97 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 97 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 102–109 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 185–189 |
| CyclomaticComplexity | The method 'doProcessExportIntoFile(String, String, List, int, Plugin)' has a cyclomatic complexity of 11. | 3 | 210–283 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 241 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 247 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 248 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 252 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 47 |
| ImmutableField | Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. | 3 | 59 |
| ImmutableField | Private field '_listColumns' could be made final; it is only initialized in the declaration or constructor. | 3 | 60 |
| ImmutableField | Private field '_nXSLStylesheetId' could be made final; it is only initialized in the declaration or constructor. | 3 | 61 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 3 | 62 |
| ImmutableField | Private field '_strExportKey' could be made final; it is only initialized in the declaration or constructor. | 3 | 63 |
| ImmutableField | Private field '_strFileExtention' could be made final; it is only initialized in the declaration or constructor. | 3 | 64 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 102 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUnderscoresInNumericLiterals | Number 7200000l should separate every third digit with an underscore | 3 | 55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 102 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 121 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 63 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 67 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 67 |
| CyclomaticComplexity | The method 'doProcessImport(IImportSource, String, boolean, boolean, boolean, Plugin, Locale)' has a cyclomatic complexity of 14. | 3 | 170–268 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 173 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 174 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 175 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 176 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 177 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 189 |
| IdenticalCatchBranches | 'catch' branch identical to 'AppException' branch | 3 | 202–205 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 208 |
| IdenticalCatchBranches | 'catch' branch identical to 'AppException' branch | 3 | 246–256 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 260 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 352 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 45 |
| ImmutableField | Private field '_importSource' could be made final; it is only initialized in the declaration or constructor. | 3 | 51 |
| ImmutableField | Private field '_strTableName' could be made final; it is only initialized in the declaration or constructor. | 3 | 52 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 3 | 53 |
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 3 | 54 |
| ImmutableField | Private field '_bUpdateExistingRows' could be made final; it is only initialized in the declaration or constructor. | 3 | 55 |
| ImmutableField | Private field '_bStopOnErrors' could be made final; it is only initialized in the declaration or constructor. | 3 | 56 |
| ImmutableField | Private field '_bEmptyTable' could be made final; it is only initialized in the declaration or constructor. | 3 | 57 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 59 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 102 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUnderscoresInNumericLiterals | Number 65279 should separate every third digit with an underscore | 3 | 61 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 115 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 155 |
| ShortVariable | Avoid variables with short names like i | 3 | 161 |
| CyclomaticComplexity | The method 'getColumnsName()' has a cyclomatic complexity of 10. | 3 | 179–235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 202 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 210 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 215–224 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 221 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 248 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_strSeparator' could be made final; it is only initialized in the declaration or constructor. | 3 | 55 |
| ImmutableField | Private field '_strQuote' could be made final; it is only initialized in the declaration or constructor. | 3 | 56 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'run()' has a cyclomatic complexity of 20. | 3 | 68–143 |
| NPathComplexity | The method 'run()' has an NPath complexity of 232 | 3 | 68–143 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 76 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 112–133 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–655 |
| ImmutableField | Private field '_automaticExportConfigDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 138 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 143–145 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 143–145 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 143–145 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 168 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 168 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 212 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 213 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 228 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 228 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 258 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 259 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 280 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 371–372 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 381 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 381 |
| ShortVariable | Avoid variables with short names like df | 3 | 383 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 383 |
| ShortVariable | Avoid variables with short names like df | 3 | 415 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 415 |
| NcssCount | The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a NCSS line count of 64. | 3 | 438–542 |
| NPathComplexity | The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has an NPath complexity of 648 | 3 | 438–542 |
| CyclomaticComplexity | The method 'getCreateModifyExportConfig(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 15. | 3 | 438–542 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 438–542 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 468 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 468 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 613 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 115–117 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 115–117 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 115–117 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 146 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 146 |
| CyclomaticComplexity | The method 'doImportData(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 184–240 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 197 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 198 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 199 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 200 |
| UseUnderscoresInNumericLiterals | Number 1048576l should separate every third digit with an underscore | 3 | 224 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 226–232 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 286 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 286 |
