PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/insertajax/business/Image.java
Violation |
Line |
Avoid variables with short names like id |
38 |
Avoid unnecessary constructors - the compiler will generate these for you |
41–43 |
Document empty constructor |
41–43 |
Avoid variables with short names like id |
49 |
fr/paris/lutece/plugins/insertajax/business/InsertAjax.java
Violation |
Line |
Document empty constructor |
62–64 |
Avoid unnecessary constructors - the compiler will generate these for you |
62–64 |
Singleton is not thread safe |
72–76 |
Avoid variables with short names like id |
177 |
Do not add empty strings |
180 |
fr/paris/lutece/plugins/insertajax/business/InsertAjaxDAO.java
Violation |
Line |
Avoid variables with short names like id |
96 |
fr/paris/lutece/plugins/insertajax/business/InsertAjaxHome.java
Violation |
Line |
A class which only has private constructors should be final |
44–137 |
fr/paris/lutece/plugins/insertajax/service/InsertAjaxWorkgroupRemovalListener.java
Violation |
Line |
Document empty constructor |
86–88 |
Avoid unnecessary constructors - the compiler will generate these for you |
86–88 |
fr/paris/lutece/plugins/insertajax/web/InsertAjaxInsertServiceJspBean.java
Violation |
Line |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
98 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
112 |
Use opposite operator instead of the logic complement operator. |
115 |
fr/paris/lutece/plugins/insertajax/web/InsertAjaxJspBean.java
Violation |
Line |
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. |
111 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
134 |
Do not add empty strings |
135 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
154 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
178 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
179 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
180 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
181 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
241 |
fr/paris/lutece/plugins/insertajax/web/InsertAjaxResult.java
Violation |
Line |
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
47–83 |
Avoid variables with short names like ia |
64 |
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
78 |