The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 66–69 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 67–70 |
| Avoid variables with short names like p | 82 |
| Avoid variables with short names like p | 136 |
| Violation | Line |
|---|---|
| Possible unsafe assignment to a non-final static field in a constructor. | 47 |
| Avoid using redundant field initializer for '_singleton' | 47 |
| It is a good practice to call super() in a constructor | 52–58 |
| Singleton is not thread safe | 80–83 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 83–142 |
| Violation | Line |
|---|---|
| Private field '_servletOutputStream' could be made final; it is only initialized in the declaration or constructor. | 57 |
| Private field '_printWriter' could be made final; it is only initialized in the declaration or constructor. | 58 |
| Private field '_buffer' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Avoid variables with short names like b | 74 |
| Avoid throwing raw exception types. | 99 |
| New exception is thrown in catch block, original stack trace may be lost | 99 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 281 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 296 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like CONFIG_SERVICES_PORTLETDEF_WEBXML_RESSOURCE_DEFAULT | 79 |
| Avoid excessively long variable names like CONFIG_SERVICES_PORTLETDEF_PORTLETXML_MAPPING_DEFAULT | 83 |
| Avoid excessively long variable names like CONFIG_SERVICES_PORTLETDEF_PORTLETXML_RESSOURCE_DEFAULT | 85 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–492 |
| A catch statement should never catch throwable since it includes errors. | 181 |
| Document empty method | 204–205 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 218 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 219 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 227 |
| A catch statement should never catch throwable since it includes errors. | 259 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 297 |
| Avoid variables with short names like it | 312 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 390 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 391 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 398 |
| A catch statement should never catch throwable since it includes errors. | 431 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 450 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 75–89 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 85 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 92 |
| The Logger variable declaration does not contain the static and final modifiers | 96 |
| Avoid using redundant field initializer for 'log' | 96 |
| Avoid variables with short names like b | 112 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 173 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 246 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 260 |
| Violation | Line |
|---|---|
| Perhaps '_env' could be replaced by a local variable. | 117 |
| Private field '_env' could be made final; it is only initialized in the declaration or constructor. | 117 |
| Avoid unused private fields such as '_env'. | 117 |
| Violation | Line |
|---|---|
| Private field '_staticProvider' could be made final; it is only initialized in the declaration or constructor. | 111 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 150 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 150 |
| Document empty method | 151–152 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 157 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 157 |
| Document empty method | 158–159 |
| Violation | Line |
|---|---|
| Private field '_properties' could be made final; it is only initialized in the declaration or constructor. | 119 |
| Avoid variables with short names like m | 191 |
| Avoid calling toString() on String objects; this is unnecessary. | 198 |
| Avoid variables with short names like s | 211 |
| Avoid calling toString() on String objects; this is unnecessary. | 218 |
| Avoid unused private methods such as 'reset(String)'. | 232 |
| Avoid instantiating String objects; this is usually unnecessary. | 234 |
| Violation | Line |
|---|---|
| The class 'PortalURL' has a Cyclomatic Complexity of 2 (Highest = 11). | 53–457 |
| The method buildParams() has an NPath complexity of 243 | 172–219 |
| The method 'buildParams' has a Cyclomatic Complexity of 11. | 172–219 |
| Violation | Line |
|---|---|
| Private field '_services' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Violation | Line |
|---|---|
| Avoid using Literals in Conditional Statements | 80 |
| Avoid using Literals in Conditional Statements | 91 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 100 |
| Avoid unused private fields such as '_provider'. | 101 |
| Perhaps '_provider' could be replaced by a local variable. | 101 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 101 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 102 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 107 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 112 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 118 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 123 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 124 |
| Avoid unused private fields such as '_clearParameters'. | 124 |
| Perhaps '_clearParameters' could be replaced by a local variable. | 124 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 125 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 199 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 200 |
| Use explicit scoping instead of the default package private level | 242–245 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 259 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 260 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 296 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 297 |
| Violation | Line |
|---|---|
| Perhaps '_portletWindow' could be replaced by a local variable. | 103 |
| Avoid unused private fields such as '_portletWindow'. | 103 |
| Private field '_portletWindow' could be made final; it is only initialized in the declaration or constructor. | 103 |
| Private field '_strBase' could be made final; it is only initialized in the declaration or constructor. | 105 |
| Avoid unused constructor parameters such as 'provider'. | 113 |
| Avoid using Literals in Conditional Statements | 142 |
| New exception is thrown in catch block, original stack trace may be lost | 150 |
| Violation | Line |
|---|---|
| Private field '_provider' could be made final; it is only initialized in the declaration or constructor. | 103 |
| Violation | Line |
|---|---|
| The class 'FactoryManagerServiceImpl' has a Cyclomatic Complexity of 3 (Highest = 10). | 112–292 |
| Private field '_mapFactory' could be made final; it is only initialized in the declaration or constructor. | 114 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 114 |
| Private field '_lstFactory' could be made final; it is only initialized in the declaration or constructor. | 115 |
| The method 'init' has a Cyclomatic Complexity of 10. | 128–227 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 129 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 129 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 133 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 134 |
| Avoid using final local variables, turn them into fields | 174 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 219 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 246 |
| Avoid variables with short names like t | 288 |
| Violation | Line |
|---|---|
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 112 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 120 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–266 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionImpl' | 42 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionImpl' | 42 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionSetImpl' | 43 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionSetImpl' | 43 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameImpl' | 44 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameImpl' | 44 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameSetImpl' | 45 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameSetImpl' | 45 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.LanguageSetImpl' | 46 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.LanguageSetImpl' | 46 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.ParameterImpl' | 47 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.ParameterImpl' | 47 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceImpl' | 48 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceImpl' | 48 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceSetImpl' | 49 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceSetImpl' | 49 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.ContentTypeImpl' | 50 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.ContentTypeImpl' | 50 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.PortletDefinitionImpl' | 53 |
| Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.PortletDefinitionImpl' | 53 |
| It is a good practice to call super() in a constructor | 101–105 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 111 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 111 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 129 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 150 |
| Avoid variables with short names like id | 172 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 185 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 185 |
| Use ArrayList instead of Vector | 214 |
| Consider replacing this Vector with the newer java.util.List | 214 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 146–149 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 155 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 155 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 173 |
| Avoid variables with short names like id | 194 |
| Avoid variables with short names like f | 206 |
| New exception is thrown in catch block, original stack trace may be lost | 230 |
| New exception is thrown in catch block, original stack trace may be lost | 235 |
| New exception is thrown in catch block, original stack trace may be lost | 240 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 242 |
| New exception is thrown in catch block, original stack trace may be lost | 245 |
| New exception is thrown in catch block, original stack trace may be lost | 298 |
| New exception is thrown in catch block, original stack trace may be lost | 303 |
| New exception is thrown in catch block, original stack trace may be lost | 308 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 310 |
| New exception is thrown in catch block, original stack trace may be lost | 313 |
| Violation | Line |
|---|---|
| Document empty method | 108–109 |
| Document empty method | 115–116 |
| Violation | Line |
|---|---|
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 120 |
| Overridable method 'getParameterNames' called during object construction | 130 |
| Overridable method 'getParameterValues' called during object construction | 134 |
| Avoid using final local variables, turn them into fields | 136 |
| Prefer StringBuffer over += for concatenating strings | 165 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 69–72 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 63–66 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 54–58 |
| Use explicit scoping instead of the default package private level | 65–68 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'COMBO_PORTLETS_LIST'. | 75 |
| It is a good practice to call super() in a constructor | 80–82 |
| Document empty constructor | 80–82 |
| Avoid unnecessary constructors - the compiler will generate these for you | 80–82 |
| System.out.println is used | 102 |
| System.out.println is used | 108 |
| System.out.println is used | 109 |
| System.out.println is used | 115 |
| System.out.println is used | 116 |
| System.out.println is used | 117 |
| Avoid using Literals in Conditional Statements | 159 |
| Avoid using Literals in Conditional Statements | 199 |
| Use explicit scoping instead of the default package private level | 240–249 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 48–77 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 53 |
| Avoid variables with short names like ct | 54 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 37–298 |
| Avoid unused imports such as 'javax.servlet.RequestDispatcher' | 69 |
| Avoid unused imports such as 'javax.servlet.RequestDispatcher' | 69 |
| The class 'PortletInvokerImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). | 80–298 |
| The class 'PortletInvokerImpl' has a Cyclomatic Complexity of 2 (Highest = 10). | 80–298 |
| The class 'PortletInvokerImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). | 80–298 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 83 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 84 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 85 |
| Private field 'servletConfig' could be made final; it is only initialized in the declaration or constructor. | 86 |
| Private field 'portletDefinition' could be made final; it is only initialized in the declaration or constructor. | 87 |
| Avoid using redundant field initializer for 'log' | 95 |
| The Logger variable declaration does not contain the static and final modifiers | 95 |
| Unnecessary use of fully qualified name 'javax.servlet.ServletConfig' due to existing import 'javax.servlet.ServletConfig' | 97 |
| The method 'invoke' has a Cyclomatic Complexity of 10. | 136–249 |
| Avoid really long methods. | 136–249 |
| The method 'invoke' has a Standard Cyclomatic Complexity of 10. | 136–249 |
| The method 'invoke' has a Modified Cyclomatic Complexity of 10. | 136–249 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 146 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 148 |
| Avoid unused local variables such as 'servletDefinition'. | 148 |
| Avoid unused local variables such as 'servletContext'. | 149 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 149 |
| Avoid empty if statements | 241–243 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 34 |
| A high number of imports can indicate a high degree of coupling within an object. | 34–653 |
| The class 'Deploy' has a Modified Cyclomatic Complexity of 11 (Highest = 22). | 99–653 |
| The class 'Deploy' has a Standard Cyclomatic Complexity of 11 (Highest = 22). | 99–653 |
| The class 'Deploy' has a Cyclomatic Complexity of 12 (Highest = 23). | 99–653 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 100–653 |
| Avoid using redundant field initializer for 'debug' | 101 |
| The String literal "WEB-INF" appears 4 times in this file; the first occurrence is on line 103 | 103 |
| The method 'deployArchive' has a Modified Cyclomatic Complexity of 11. | 108–194 |
| The method 'deployArchive' has a Standard Cyclomatic Complexity of 11. | 108–194 |
| The method 'deployArchive' has a Cyclomatic Complexity of 13. | 108–194 |
| String.indexOf(char) is faster than String.indexOf(String). | 113 |
| String.indexOf(char) is faster than String.indexOf(String). | 115 |
| String.indexOf(char) is faster than String.indexOf(String). | 125 |
| System.out.println is used | 128 |
| Avoid variables with short names like is | 144 |
| Avoid variables with short names like r | 145 |
| Avoid variables with short names like st | 146 |
| Position literals first in String comparisons | 157 |
| Deeply nested if..then statements are hard to read | 157–164 |
| System.out.println is used | 159 |
| System.out.println is used | 193 |
| The method prepareWebArchive() has an NCSS line count of 145 | 196–500 |
| Avoid really long methods. | 196–500 |
| The method 'prepareWebArchive' has a Standard Cyclomatic Complexity of 22. | 196–500 |
| The method prepareWebArchive() has an NPath complexity of 258592 | 196–500 |
| The method 'prepareWebArchive' has a Modified Cyclomatic Complexity of 22. | 196–500 |
| The method 'prepareWebArchive' has a Cyclomatic Complexity of 23. | 196–500 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 197 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 197 |
| String.indexOf(char) is faster than String.indexOf(String). | 201 |
| String.indexOf(char) is faster than String.indexOf(String). | 203 |
| String.indexOf(char) is faster than String.indexOf(String). | 213 |
| System.out.println is used | 216 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 219 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 230 |
| System.out.println is used | 232 |
| New exception is thrown in catch block, original stack trace may be lost | 233–234 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 237 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 248 |
| New exception is thrown in catch block, original stack trace may be lost | 250–251 |
| Use ArrayList instead of Vector | 270 |
| Consider replacing this Vector with the newer java.util.List | 270 |
| System.out.println is used | 278 |
| System.out.println is used | 335 |
| Avoid variables with short names like p | 423 |
| System.out.println is used | 432 |
| System.out.println is used | 445 |
| System.out.println is used | 459 |
| Avoid variables with short names like of | 462 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 479 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 493 |
| System.out.println is used | 499 |
| Avoid variables with short names like to | 502 |
| Avoid variables with short names like f | 504 |
| The method 'main' has a Modified Cyclomatic Complexity of 14. | 520–604 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 520 |
| The method main() has an NPath complexity of 7488 | 520–604 |
| The method 'main' has a Cyclomatic Complexity of 18. | 520–604 |
| The method 'main' has a Standard Cyclomatic Complexity of 14. | 520–604 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 522 |
| Avoid using Literals in Conditional Statements | 524 |
| System.out.println is used | 526 |
| System.out.println is used | 527 |
| Avoid using Literals in Conditional Statements | 533 |
| These nested if statements could be combined | 535–538 |
| System.out.println is used | 545 |
| Avoid using Literals in Conditional Statements | 572 |
| A catch statement that catches an exception only to rethrow it should be avoided. | 595–598 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 599 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 606 |
| Avoid variables with short names like o | 611 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 647 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 34 |
| Avoid variables with short names like id | 64 |
| Use block level rather than method level synchronization | 99–142 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 106 |
| debug logging that involves string concatenation should be guarded with isDebugEnabled() checks | 108 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 119 |
| Avoid variables with short names like id | 211 |
| Assigning an Object to null is a code smell. Consider refactoring. | 214 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 37 |
| The class 'ServiceManager' has a Modified Cyclomatic Complexity of 6 (Highest = 14). | 96–413 |
| The class 'ServiceManager' has a Cyclomatic Complexity of 6 (Highest = 14). | 96–413 |
| The class 'ServiceManager' has a Standard Cyclomatic Complexity of 6 (Highest = 14). | 96–413 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 97–413 |
| Use of modifier volatile is not recommended. | 98 |
| Avoid using redundant field initializer for '_bInitialized' | 98 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 99 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 114 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 114 |
| The method 'init' has a Modified Cyclomatic Complexity of 14. | 133–280 |
| The method init() has an NPath complexity of 1344 | 133–280 |
| The method 'init' has a Cyclomatic Complexity of 14. | 133–280 |
| The method 'init' has a Standard Cyclomatic Complexity of 14. | 133–280 |
| Avoid really long methods. | 133–280 |
| Avoid throwing null pointer exceptions. | 138 |
| Avoid throwing null pointer exceptions. | 145 |
| Avoid using final local variables, turn them into fields | 168 |
| Avoid using final local variables, turn them into fields | 192 |
| Avoid using final local variables, turn them into fields | 206 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 252 |
| The String literal " successful)." appears 6 times in this file; the first occurrence is on line 271 | 271 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 324 |
| Avoid unused local variables such as 'context'. | 371 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 387 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 34 |
| Possible God class (WMC=54, ATFD=14, TCC=0.03508771929824561) | 34–423 |
| Abstract classes should be named AbstractXXX | 50–423 |
| This abstract class does not have any abstract methods | 50–423 |
| Private field 'iEntries' could be made final; it is only initialized in the declaration or constructor. | 53 |
| Document empty constructor | 56–58 |
| This statement may have some unnecessary parentheses | 68 |
| This statement may have some unnecessary parentheses | 82 |
| This statement may have some unnecessary parentheses | 105 |
| This statement may have some unnecessary parentheses | 128 |
| This statement may have some unnecessary parentheses | 133 |
| This statement may have some unnecessary parentheses | 147 |
| This statement may have some unnecessary parentheses | 161 |
| This statement may have some unnecessary parentheses | 166 |
| This statement may have some unnecessary parentheses | 180 |
| This statement may have some unnecessary parentheses | 185 |
| Avoid instantiation through private constructors from outside of the constructors class. | 190 |
| This statement may have some unnecessary parentheses | 190 |
| This statement may have some unnecessary parentheses | 195 |
| This statement may have some unnecessary parentheses | 205 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 215 |
| This statement may have some unnecessary parentheses | 219 |
| This statement may have some unnecessary parentheses | 224 |
| This statement may have some unnecessary parentheses | 231 |
| This statement may have some unnecessary parentheses | 258 |
| This statement may have some unnecessary parentheses | 280 |
| This statement may have some unnecessary parentheses | 287 |
| This statement may have some unnecessary parentheses | 323 |
| Use explicit scoping instead of the default package private level | 326–329 |
| Use explicit scoping instead of the default package private level | 331–334 |
| Use explicit scoping instead of the default package private level | 338 |
| Use explicit scoping instead of the default package private level | 339 |
| The user-supplied array 'aValues' is stored directly. | 341 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 341 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 351 |
| This statement may have some unnecessary parentheses | 364 |
| This statement may have some unnecessary parentheses | 387 |
| This statement may have some unnecessary parentheses | 397 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 37 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 56–176 |
| Unnecessary use of fully qualified name 'org.w3c.dom.Document' due to existing import 'org.w3c.dom.Document' | 57 |
| System.out.println is used | 71 |
| Unnecessary use of fully qualified name 'org.w3c.dom.Document' due to existing import 'org.w3c.dom.Document' | 90 |
| Avoid using redundant field initializer for 'publicDTD' | 136 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 147 |
| The user-supplied array 'resourceDTDNames' is stored directly. | 147 |
| The user-supplied array 'resourceDTDs' is stored directly. | 147 |
| Avoid variables with short names like is | 161 |
| Unnecessary use of fully qualified name 'java.io.InputStream' due to existing import 'java.io.InputStream' | 161 |
