Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/library/business/LibraryMappingHome.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 4281

fr/paris/lutece/plugins/library/business/MediaAttributeHome.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 4281

fr/paris/lutece/plugins/library/web/LibraryInsertServiceJspBean.java

Rule Violation Ligne
FieldNamingConventions The field name 'first' doesn't match '_[a-z][a-zA-Z0-9]*' 693
FieldNamingConventions The field name 'second' doesn't match '_[a-z][a-zA-Z0-9]*' 694

fr/paris/lutece/plugins/library/web/UploadInsertServiceJspBean.java

Rule Violation Ligne
LocalVariableNamingConventions The local variable name '_listAttributesAssociation' doesn't match '[a-z][a-zA-Z0-9]*' 466
LocalVariableNamingConventions The local variable name 'docType_code' doesn't match '[a-z][a-zA-Z0-9]*' 485
LocalVariableNamingConventions The local variable name '_docAttr' doesn't match '[a-z][a-zA-Z0-9]*' 486

Priority 3

fr/paris/lutece/plugins/library/business/ILibraryMappingDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 4154
CommentRequired Public method and constructor comments are required 43
CommentRequired Public method and constructor comments are required 45
CommentRequired Public method and constructor comments are required 47
CommentRequired Public method and constructor comments are required 49
CommentRequired Public method and constructor comments are required 51
CommentRequired Public method and constructor comments are required 53

fr/paris/lutece/plugins/library/business/ILibraryMediaDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 4152
CommentRequired Public method and constructor comments are required 43
CommentRequired Public method and constructor comments are required 45
CommentRequired Public method and constructor comments are required 47
CommentRequired Public method and constructor comments are required 49
CommentRequired Public method and constructor comments are required 51

fr/paris/lutece/plugins/library/business/IMediaAttributeDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 4154
CommentRequired Public method and constructor comments are required 43
CommentRequired Public method and constructor comments are required 45
CommentRequired Public method and constructor comments are required 47
CommentRequired Public method and constructor comments are required 49
CommentRequired Public method and constructor comments are required 51
CommentRequired Public method and constructor comments are required 53

fr/paris/lutece/plugins/library/business/LibraryMapping.java

Rule Violation Ligne
CommentRequired Header comments are required 40137
CommentRequired Public method and constructor comments are required 4750
CommentRequired Public method and constructor comments are required 5255
CommentRequired Public method and constructor comments are required 5760
CommentRequired Public method and constructor comments are required 6265
CommentRequired Public method and constructor comments are required 6770
CommentRequired Public method and constructor comments are required 7275
CommentRequired Public method and constructor comments are required 7780
CommentRequired Public method and constructor comments are required 8285
CommentRequired Public method and constructor comments are required 8799
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 95
CommentRequired Header comments are required 101136
CommentRequired Public method and constructor comments are required 107110
CommentRequired Public method and constructor comments are required 112115
CommentRequired Public method and constructor comments are required 117120
CommentRequired Public method and constructor comments are required 122125
CommentRequired Public method and constructor comments are required 127130
CommentRequired Public method and constructor comments are required 132135

fr/paris/lutece/plugins/library/business/LibraryMappingDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 44229
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 5770
CommentRequired Public method and constructor comments are required 5770
CommentRequired Public method and constructor comments are required 7298
MissingOverride The method 'insert(LibraryMapping, Plugin)' is missing an @Override annotation. 7298
CommentRequired Public method and constructor comments are required 100127
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 100127
MissingOverride The method 'selectByMedia(int, Plugin)' is missing an @Override annotation. 129162
CommentRequired Public method and constructor comments are required 129162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 131
MissingOverride The method 'store(LibraryMapping, Plugin)' is missing an @Override annotation. 164196
CommentRequired Public method and constructor comments are required 164196
CommentRequired Public method and constructor comments are required 221228
MissingOverride The method 'deleteAttributeAssociation(int, Plugin)' is missing an @Override annotation. 221228

fr/paris/lutece/plugins/library/business/LibraryMappingHome.java

Rule Violation Ligne
CommentRequired Header comments are required 4281
CommentRequired Public method and constructor comments are required 5255
CommentRequired Public method and constructor comments are required 5760
CommentRequired Public method and constructor comments are required 6265
CommentRequired Public method and constructor comments are required 6770
CommentRequired Public method and constructor comments are required 7275
CommentRequired Public method and constructor comments are required 7780

fr/paris/lutece/plugins/library/business/LibraryMedia.java

Rule Violation Ligne
CommentRequired Header comments are required 41115
CommentRequired Public method and constructor comments are required 5053
CommentRequired Public method and constructor comments are required 5558
CommentRequired Public method and constructor comments are required 6063
CommentRequired Public method and constructor comments are required 6568
CommentRequired Public method and constructor comments are required 7073
CommentRequired Public method and constructor comments are required 7578
CommentRequired Public method and constructor comments are required 8083
CommentRequired Public method and constructor comments are required 8588
CommentRequired Public method and constructor comments are required 100104
CommentRequired Public method and constructor comments are required 106109
CommentRequired Public method and constructor comments are required 111114

fr/paris/lutece/plugins/library/business/LibraryMediaDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 43153
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 5258
CommentRequired Public method and constructor comments are required 5258
CommentRequired Public method and constructor comments are required 6073
MissingOverride The method 'insert(LibraryMedia, Plugin)' is missing an @Override annotation. 6073
CommentRequired Public method and constructor comments are required 7595
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 7595
MissingOverride The method 'selectAll(Plugin)' is missing an @Override annotation. 97116
CommentRequired Public method and constructor comments are required 97116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 99
CommentRequired Public method and constructor comments are required 118128
MissingOverride The method 'store(LibraryMedia, Plugin)' is missing an @Override annotation. 118128

fr/paris/lutece/plugins/library/business/LibraryMediaHome.java

Rule Violation Ligne
CommentRequired Header comments are required 4276
CommentRequired Public method and constructor comments are required 5255
CommentRequired Public method and constructor comments are required 5760
CommentRequired Public method and constructor comments are required 6265
CommentRequired Public method and constructor comments are required 6770
CommentRequired Public method and constructor comments are required 7275

fr/paris/lutece/plugins/library/business/MediaAttribute.java

Rule Violation Ligne
CommentRequired Header comments are required 42177
CommentRequired Public method and constructor comments are required 6265
CommentRequired Public method and constructor comments are required 6770
CommentRequired Public method and constructor comments are required 7275
CommentRequired Public method and constructor comments are required 7780
CommentRequired Public method and constructor comments are required 8285
CommentRequired Public method and constructor comments are required 8790
CommentRequired Public method and constructor comments are required 9295
CommentRequired Public method and constructor comments are required 97100
CommentRequired Public method and constructor comments are required 102106
CommentRequired Public method and constructor comments are required 108111
CommentRequired Public method and constructor comments are required 113116
CommentRequired Public method and constructor comments are required 118151
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 153156

fr/paris/lutece/plugins/library/business/MediaAttributeDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 43167
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 5359
CommentRequired Public method and constructor comments are required 5359
CommentRequired Public method and constructor comments are required 6173
MissingOverride The method 'insert(MediaAttribute, Plugin)' is missing an @Override annotation. 6173
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 7596
CommentRequired Public method and constructor comments are required 7596
CommentRequired Public method and constructor comments are required 98120
MissingOverride The method 'selectAllAttributesForMedia(int, Plugin)' is missing an @Override annotation. 98120
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 100
CommentRequired Public method and constructor comments are required 122135
MissingOverride The method 'store(MediaAttribute, Plugin)' is missing an @Override annotation. 122135
CommentRequired Public method and constructor comments are required 160166
MissingOverride The method 'deleteAllForMedia(int, Plugin)' is missing an @Override annotation. 160166

fr/paris/lutece/plugins/library/business/MediaAttributeHome.java

Rule Violation Ligne
CommentRequired Header comments are required 4281
CommentRequired Public method and constructor comments are required 5255
CommentRequired Public method and constructor comments are required 5760
CommentRequired Public method and constructor comments are required 6265
CommentRequired Public method and constructor comments are required 6770
CommentRequired Public method and constructor comments are required 7275
CommentRequired Public method and constructor comments are required 7780

fr/paris/lutece/plugins/library/business/SelectedMedia.java

Rule Violation Ligne
CommentRequired Header comments are required 41184
ShortVariable Avoid variables with short names like o 175

fr/paris/lutece/plugins/library/web/LibraryInsertServiceJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34712
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_PAGE_INDEX'. 104
UnusedPrivateField Avoid unused private fields such as 'DEFAULT_RESULTS_PER_PAGE'. 136
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 150
CommentRequired Public method and constructor comments are required 152164
MissingOverride The method 'getInsertServiceSelectorUI(HttpServletRequest)' is missing an @Override annotation. 152164
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 155
CyclomaticComplexity The method 'getSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 11. 166254
CommentRequired Public method and constructor comments are required 166254
NPathComplexity The method 'getSelectMedia(HttpServletRequest)' has an NPath complexity of 256 166254
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 199
SimplifiedTernary Ternary operators that can be simplified with || or && 249
ConfusingTernary Avoid if (x != y) ..; else ..; 249
CommentRequired Public method and constructor comments are required 256296
CyclomaticComplexity The method 'doSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 10. 298368
CommentRequired Public method and constructor comments are required 298368
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 304
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 319
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 331
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 344
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 355
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 357
CommentRequired Public method and constructor comments are required 370425
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 383
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 385
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'document' 399
CommentRequired Public method and constructor comments are required 427488
CommentRequired Public method and constructor comments are required 490570
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 557
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 560
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 567
ShortVariable Avoid variables with short names like m 572
UnusedFormalParameter Avoid unused method parameters such as 'nSpaceId'. 595
ShortVariable Avoid variables with short names like m 595
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 599
ShortVariable Avoid variables with short names like m 614
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 616
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 645
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 647
IdempotentOperations Avoid idempotent operations (like assigning a variable to itself). 664
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 686687
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'paginator' 688
CommentRequired Header comments are required 691711
ImmutableField Private field 'first' could be made final; it is only initialized in the declaration or constructor. 693
ImmutableField Private field 'second' could be made final; it is only initialized in the declaration or constructor. 694
CommentRequired Public method and constructor comments are required 696700
ShortVariable Avoid variables with short names like x 696
ShortVariable Avoid variables with short names like y 696

fr/paris/lutece/plugins/library/web/LibraryJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34724
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 146
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 146
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 258
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 258
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 278
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 315
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 315
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 335
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 372
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 394
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 524
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 524
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 534
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 534
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 563
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 563
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 636
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 636

fr/paris/lutece/plugins/library/web/UploadInsertServiceJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34565
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 181
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 183
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 305
AddEmptyString Do not add empty strings 306
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 343
ConfusingTernary Avoid if (x != y) ..; else ..; 408415
ConfusingTernary Avoid if (x != y) ..; else ..; 428435
ConfusingTernary Avoid if (x != y) ..; else ..; 477490
ControlStatementBraces This statement should have braces 487
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 514
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 517
ShortVariable Avoid variables with short names like m 553
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 555

Priority 4

fr/paris/lutece/plugins/library/business/LibraryMedia.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 106109

fr/paris/lutece/plugins/library/web/LibraryInsertServiceJspBean.java

Rule Violation Ligne
ShortClassName Avoid short class names like Pair 691711

Fichiers

fr/paris/lutece/plugins/library/business/ILibraryMappingDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4154
CommentRequired Public method and constructor comments are required 3 43
CommentRequired Public method and constructor comments are required 3 45
CommentRequired Public method and constructor comments are required 3 47
CommentRequired Public method and constructor comments are required 3 49
CommentRequired Public method and constructor comments are required 3 51
CommentRequired Public method and constructor comments are required 3 53

fr/paris/lutece/plugins/library/business/ILibraryMediaDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4152
CommentRequired Public method and constructor comments are required 3 43
CommentRequired Public method and constructor comments are required 3 45
CommentRequired Public method and constructor comments are required 3 47
CommentRequired Public method and constructor comments are required 3 49
CommentRequired Public method and constructor comments are required 3 51

fr/paris/lutece/plugins/library/business/IMediaAttributeDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4154
CommentRequired Public method and constructor comments are required 3 43
CommentRequired Public method and constructor comments are required 3 45
CommentRequired Public method and constructor comments are required 3 47
CommentRequired Public method and constructor comments are required 3 49
CommentRequired Public method and constructor comments are required 3 51
CommentRequired Public method and constructor comments are required 3 53

fr/paris/lutece/plugins/library/business/LibraryMapping.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 40137
CommentRequired Public method and constructor comments are required 3 4750
CommentRequired Public method and constructor comments are required 3 5255
CommentRequired Public method and constructor comments are required 3 5760
CommentRequired Public method and constructor comments are required 3 6265
CommentRequired Public method and constructor comments are required 3 6770
CommentRequired Public method and constructor comments are required 3 7275
CommentRequired Public method and constructor comments are required 3 7780
CommentRequired Public method and constructor comments are required 3 8285
CommentRequired Public method and constructor comments are required 3 8799
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 95
CommentRequired Header comments are required 3 101136
CommentRequired Public method and constructor comments are required 3 107110
CommentRequired Public method and constructor comments are required 3 112115
CommentRequired Public method and constructor comments are required 3 117120
CommentRequired Public method and constructor comments are required 3 122125
CommentRequired Public method and constructor comments are required 3 127130
CommentRequired Public method and constructor comments are required 3 132135

fr/paris/lutece/plugins/library/business/LibraryMappingDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44229
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 3 5770
CommentRequired Public method and constructor comments are required 3 5770
CommentRequired Public method and constructor comments are required 3 7298
MissingOverride The method 'insert(LibraryMapping, Plugin)' is missing an @Override annotation. 3 7298
CommentRequired Public method and constructor comments are required 3 100127
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 3 100127
MissingOverride The method 'selectByMedia(int, Plugin)' is missing an @Override annotation. 3 129162
CommentRequired Public method and constructor comments are required 3 129162
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 131
MissingOverride The method 'store(LibraryMapping, Plugin)' is missing an @Override annotation. 3 164196
CommentRequired Public method and constructor comments are required 3 164196
CommentRequired Public method and constructor comments are required 3 221228
MissingOverride The method 'deleteAttributeAssociation(int, Plugin)' is missing an @Override annotation. 3 221228

fr/paris/lutece/plugins/library/business/LibraryMappingHome.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4281
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 4281
CommentRequired Public method and constructor comments are required 3 5255
CommentRequired Public method and constructor comments are required 3 5760
CommentRequired Public method and constructor comments are required 3 6265
CommentRequired Public method and constructor comments are required 3 6770
CommentRequired Public method and constructor comments are required 3 7275
CommentRequired Public method and constructor comments are required 3 7780

fr/paris/lutece/plugins/library/business/LibraryMedia.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41115
CommentRequired Public method and constructor comments are required 3 5053
CommentRequired Public method and constructor comments are required 3 5558
CommentRequired Public method and constructor comments are required 3 6063
CommentRequired Public method and constructor comments are required 3 6568
CommentRequired Public method and constructor comments are required 3 7073
CommentRequired Public method and constructor comments are required 3 7578
CommentRequired Public method and constructor comments are required 3 8083
CommentRequired Public method and constructor comments are required 3 8588
CommentRequired Public method and constructor comments are required 3 100104
CommentRequired Public method and constructor comments are required 3 106109
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 106109
CommentRequired Public method and constructor comments are required 3 111114

fr/paris/lutece/plugins/library/business/LibraryMediaDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43153
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 3 5258
CommentRequired Public method and constructor comments are required 3 5258
CommentRequired Public method and constructor comments are required 3 6073
MissingOverride The method 'insert(LibraryMedia, Plugin)' is missing an @Override annotation. 3 6073
CommentRequired Public method and constructor comments are required 3 7595
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 3 7595
MissingOverride The method 'selectAll(Plugin)' is missing an @Override annotation. 3 97116
CommentRequired Public method and constructor comments are required 3 97116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 99
CommentRequired Public method and constructor comments are required 3 118128
MissingOverride The method 'store(LibraryMedia, Plugin)' is missing an @Override annotation. 3 118128

fr/paris/lutece/plugins/library/business/LibraryMediaHome.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4276
CommentRequired Public method and constructor comments are required 3 5255
CommentRequired Public method and constructor comments are required 3 5760
CommentRequired Public method and constructor comments are required 3 6265
CommentRequired Public method and constructor comments are required 3 6770
CommentRequired Public method and constructor comments are required 3 7275

fr/paris/lutece/plugins/library/business/MediaAttribute.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 42177
CommentRequired Public method and constructor comments are required 3 6265
CommentRequired Public method and constructor comments are required 3 6770
CommentRequired Public method and constructor comments are required 3 7275
CommentRequired Public method and constructor comments are required 3 7780
CommentRequired Public method and constructor comments are required 3 8285
CommentRequired Public method and constructor comments are required 3 8790
CommentRequired Public method and constructor comments are required 3 9295
CommentRequired Public method and constructor comments are required 3 97100
CommentRequired Public method and constructor comments are required 3 102106
CommentRequired Public method and constructor comments are required 3 108111
CommentRequired Public method and constructor comments are required 3 113116
CommentRequired Public method and constructor comments are required 3 118151
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 3 153156

fr/paris/lutece/plugins/library/business/MediaAttributeDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43167
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 3 5359
CommentRequired Public method and constructor comments are required 3 5359
CommentRequired Public method and constructor comments are required 3 6173
MissingOverride The method 'insert(MediaAttribute, Plugin)' is missing an @Override annotation. 3 6173
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 3 7596
CommentRequired Public method and constructor comments are required 3 7596
CommentRequired Public method and constructor comments are required 3 98120
MissingOverride The method 'selectAllAttributesForMedia(int, Plugin)' is missing an @Override annotation. 3 98120
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 100
CommentRequired Public method and constructor comments are required 3 122135
MissingOverride The method 'store(MediaAttribute, Plugin)' is missing an @Override annotation. 3 122135
CommentRequired Public method and constructor comments are required 3 160166
MissingOverride The method 'deleteAllForMedia(int, Plugin)' is missing an @Override annotation. 3 160166

fr/paris/lutece/plugins/library/business/MediaAttributeHome.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4281
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 4281
CommentRequired Public method and constructor comments are required 3 5255
CommentRequired Public method and constructor comments are required 3 5760
CommentRequired Public method and constructor comments are required 3 6265
CommentRequired Public method and constructor comments are required 3 6770
CommentRequired Public method and constructor comments are required 3 7275
CommentRequired Public method and constructor comments are required 3 7780

fr/paris/lutece/plugins/library/business/SelectedMedia.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41184
ShortVariable Avoid variables with short names like o 3 175

fr/paris/lutece/plugins/library/web/LibraryInsertServiceJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34712
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_PAGE_INDEX'. 3 104
UnusedPrivateField Avoid unused private fields such as 'DEFAULT_RESULTS_PER_PAGE'. 3 136
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 150
CommentRequired Public method and constructor comments are required 3 152164
MissingOverride The method 'getInsertServiceSelectorUI(HttpServletRequest)' is missing an @Override annotation. 3 152164
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 155
CyclomaticComplexity The method 'getSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 11. 3 166254
CommentRequired Public method and constructor comments are required 3 166254
NPathComplexity The method 'getSelectMedia(HttpServletRequest)' has an NPath complexity of 256 3 166254
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 199
SimplifiedTernary Ternary operators that can be simplified with || or && 3 249
ConfusingTernary Avoid if (x != y) ..; else ..; 3 249
CommentRequired Public method and constructor comments are required 3 256296
CyclomaticComplexity The method 'doSelectMedia(HttpServletRequest)' has a cyclomatic complexity of 10. 3 298368
CommentRequired Public method and constructor comments are required 3 298368
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 304
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 319
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 331
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 344
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 355
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 357
CommentRequired Public method and constructor comments are required 3 370425
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 383
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 385
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'document' 3 399
CommentRequired Public method and constructor comments are required 3 427488
CommentRequired Public method and constructor comments are required 3 490570
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 557
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 560
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 567
ShortVariable Avoid variables with short names like m 3 572
UnusedFormalParameter Avoid unused method parameters such as 'nSpaceId'. 3 595
ShortVariable Avoid variables with short names like m 3 595
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 599
ShortVariable Avoid variables with short names like m 3 614
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 616
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 645
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 647
IdempotentOperations Avoid idempotent operations (like assigning a variable to itself). 3 664
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 686687
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'paginator' 3 688
CommentRequired Header comments are required 3 691711
ShortClassName Avoid short class names like Pair 4 691711
ImmutableField Private field 'first' could be made final; it is only initialized in the declaration or constructor. 3 693
FieldNamingConventions The field name 'first' doesn't match '_[a-z][a-zA-Z0-9]*' 1 693
FieldNamingConventions The field name 'second' doesn't match '_[a-z][a-zA-Z0-9]*' 1 694
ImmutableField Private field 'second' could be made final; it is only initialized in the declaration or constructor. 3 694
CommentRequired Public method and constructor comments are required 3 696700
ShortVariable Avoid variables with short names like x 3 696
ShortVariable Avoid variables with short names like y 3 696

fr/paris/lutece/plugins/library/web/LibraryJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34724
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 146
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 146
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 258
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 258
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 278
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 315
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 315
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 335
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 372
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 394
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 524
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 524
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 534
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 534
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 563
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 563
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 636
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 636

fr/paris/lutece/plugins/library/web/UploadInsertServiceJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34565
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 181
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 183
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 305
AddEmptyString Do not add empty strings 3 306
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 343
ConfusingTernary Avoid if (x != y) ..; else ..; 3 408415
ConfusingTernary Avoid if (x != y) ..; else ..; 3 428435
LocalVariableNamingConventions The local variable name '_listAttributesAssociation' doesn't match '[a-z][a-zA-Z0-9]*' 1 466
ConfusingTernary Avoid if (x != y) ..; else ..; 3 477490
LocalVariableNamingConventions The local variable name 'docType_code' doesn't match '[a-z][a-zA-Z0-9]*' 1 485
LocalVariableNamingConventions The local variable name '_docAttr' doesn't match '[a-z][a-zA-Z0-9]*' 1 486
ControlStatementBraces This statement should have braces 3 487
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 514
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 517
ShortVariable Avoid variables with short names like m 3 553
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 555