The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| IntegerInstantiation | Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 100 |
| Rule | Violation | Line |
|---|---|---|
| IntegerInstantiation | Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 266 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 50–140 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 55 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 70 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 70 |
| CommentRequired | Public method and constructor comments are required | 70 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 85 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 123 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 123 |
| CommentRequired | Public method and constructor comments are required | 123 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 63–66 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 74–113 |
| ShortVariable | Avoid variables with short names like i | 79 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 98–103 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 98 |
| UnnecessaryConversionTemporary | Avoid unnecessary temporaries when converting primitives to Strings | 100 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 121–124 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 137–140 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 50–335 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 68–70 |
| CommentRequired | Public method and constructor comments are required | 68–70 |
| UncommentedEmptyMethodBody | Document empty method body | 69–70 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 77–83 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 91–108 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 110 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 110–112 |
| CommentRequired | Public method and constructor comments are required | 110–112 |
| UncommentedEmptyMethodBody | Document empty method body | 111–112 |
| MissingOverride | The method 'selectLinkPagesList()' is missing an @Override annotation. | 119–134 |
| MissingOverride | The method 'selectMaxOrder(int)' is missing an @Override annotation. | 142–157 |
| MissingOverride | The method 'selectLinkPagesInPortletList(int)' is missing an @Override annotation. | 165–190 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 171 |
| MissingOverride | The method 'selectLinkPageOrder(int, int)' is missing an @Override annotation. | 199–215 |
| MissingOverride | The method 'selectLinkPageIdByOrder(int, int)' is missing an @Override annotation. | 224–241 |
| MissingOverride | The method 'storeLinkPageOrder(int, int, int)' is missing an @Override annotation. | 250–258 |
| MissingOverride | The method 'deleteLinkPage(int, int)' is missing an @Override annotation. | 266–276 |
| MissingOverride | The method 'deleteAllLinkPages(int)' is missing an @Override annotation. | 283–289 |
| MissingOverride | The method 'testDuplicate(int, int)' is missing an @Override annotation. | 298–314 |
| MissingOverride | The method 'insertLinkPage(int, int, int)' is missing an @Override annotation. | 323–334 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 56 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_singleton' | 56 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 61–67 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 74–80 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 79 |
| NonThreadSafeSingleton | Singleton is not thread safe | 89–92 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 102–105 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 62–440 |
| ImmutableField | Private field '_pageService' could be made final; it is only initialized in the declaration or constructor. | 93 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 112–119 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 127–163 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 171–192 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 175 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 200–220 |
| UnusedLocalVariable | Avoid unused local variables such as 'nIdPage'. | 258 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 372 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 374 |
| ShortVariable | Avoid variables with short names like i | 424 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–140 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 55 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 70 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 70 |
| CommentRequired | Public method and constructor comments are required | 3 | 70 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 85 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 123 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 123 |
| CommentRequired | Public method and constructor comments are required | 3 | 123 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 63–66 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 3 | 74–113 |
| ShortVariable | Avoid variables with short names like i | 3 | 79 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 98–103 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 98 |
| IntegerInstantiation | Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 2 | 100 |
| UnnecessaryConversionTemporary | Avoid unnecessary temporaries when converting primitives to Strings | 3 | 100 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 3 | 121–124 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 3 | 137–140 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–335 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 68–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 68–70 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 69–70 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 77–83 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 91–108 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 110 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 110–112 |
| CommentRequired | Public method and constructor comments are required | 3 | 110–112 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 111–112 |
| MissingOverride | The method 'selectLinkPagesList()' is missing an @Override annotation. | 3 | 119–134 |
| MissingOverride | The method 'selectMaxOrder(int)' is missing an @Override annotation. | 3 | 142–157 |
| MissingOverride | The method 'selectLinkPagesInPortletList(int)' is missing an @Override annotation. | 3 | 165–190 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 171 |
| MissingOverride | The method 'selectLinkPageOrder(int, int)' is missing an @Override annotation. | 3 | 199–215 |
| MissingOverride | The method 'selectLinkPageIdByOrder(int, int)' is missing an @Override annotation. | 3 | 224–241 |
| MissingOverride | The method 'storeLinkPageOrder(int, int, int)' is missing an @Override annotation. | 3 | 250–258 |
| MissingOverride | The method 'deleteLinkPage(int, int)' is missing an @Override annotation. | 3 | 266–276 |
| MissingOverride | The method 'deleteAllLinkPages(int)' is missing an @Override annotation. | 3 | 283–289 |
| MissingOverride | The method 'testDuplicate(int, int)' is missing an @Override annotation. | 3 | 298–314 |
| MissingOverride | The method 'insertLinkPage(int, int, int)' is missing an @Override annotation. | 3 | 323–334 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 3 | 56 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_singleton' | 3 | 56 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 61–67 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 3 | 74–80 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 3 | 79 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 89–92 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 3 | 102–105 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 62–440 |
| ImmutableField | Private field '_pageService' could be made final; it is only initialized in the declaration or constructor. | 3 | 93 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 112–119 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 127–163 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 171–192 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 175 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 200–220 |
| UnusedLocalVariable | Avoid unused local variables such as 'nIdPage'. | 3 | 258 |
| IntegerInstantiation | Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 2 | 266 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 372 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 374 |
| ShortVariable | Avoid variables with short names like i | 3 | 424 |
