Fork me on GitHub

SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.5.3

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
33 21 0 0

Files

Class Bugs
fr.paris.lutece.plugins.menus.business.CustomMenu 2
fr.paris.lutece.plugins.menus.business.CustomMenuItem 2
fr.paris.lutece.plugins.menus.business.MenuItem 2
fr.paris.lutece.plugins.menus.service.MainTreeMenuAllPagesService 1
fr.paris.lutece.plugins.menus.service.MainTreeMenuService 1
fr.paris.lutece.plugins.menus.service.cache.MainTreeMenuAllPagesCacheService 1
fr.paris.lutece.plugins.menus.service.cache.MainTreeMenuCacheService 1
fr.paris.lutece.plugins.menus.web.AccessibilityAnchorMenuInclude 1
fr.paris.lutece.plugins.menus.web.CustomMenusJspBean 1
fr.paris.lutece.plugins.menus.web.PaginatedJspBean 1
fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm 8

fr.paris.lutece.plugins.menus.business.CustomMenu

Bug Category Details Line Priority
fr.paris.lutece.plugins.menus.business.CustomMenu.getListItems() may expose internal representation by returning CustomMenu._listItems MALICIOUS_CODE EI_EXPOSE_REP 194 Medium
fr.paris.lutece.plugins.menus.business.CustomMenu.setListItems(List) may expose internal representation by storing an externally mutable object into CustomMenu._listItems MALICIOUS_CODE EI_EXPOSE_REP2 205 Medium

fr.paris.lutece.plugins.menus.business.CustomMenuItem

Bug Category Details Line Priority
fr.paris.lutece.plugins.menus.business.CustomMenuItem.getSubMenu() may expose internal representation by returning CustomMenuItem._subMenu MALICIOUS_CODE EI_EXPOSE_REP 290 Medium
fr.paris.lutece.plugins.menus.business.CustomMenuItem.setSubMenu(CustomMenu) may expose internal representation by storing an externally mutable object into CustomMenuItem._subMenu MALICIOUS_CODE EI_EXPOSE_REP2 302 Medium

fr.paris.lutece.plugins.menus.business.MenuItem

Bug Category Details Line Priority
fr.paris.lutece.plugins.menus.business.MenuItem.getChilds() may expose internal representation by returning MenuItem._listItems MALICIOUS_CODE EI_EXPOSE_REP 90 Medium
fr.paris.lutece.plugins.menus.business.MenuItem.getPage() may expose internal representation by returning MenuItem._page MALICIOUS_CODE EI_EXPOSE_REP 58 Medium

fr.paris.lutece.plugins.menus.service.MainTreeMenuAllPagesService

Bug Category Details Line Priority
fr.paris.lutece.plugins.menus.service.MainTreeMenuAllPagesService.getCacheService() may expose internal representation by returning MainTreeMenuAllPagesService._cacheService MALICIOUS_CODE EI_EXPOSE_REP 223 Medium

fr.paris.lutece.plugins.menus.service.MainTreeMenuService

Bug Category Details Line Priority
fr.paris.lutece.plugins.menus.service.MainTreeMenuService.getCacheService() may expose internal representation by returning MainTreeMenuService._cacheService MALICIOUS_CODE EI_EXPOSE_REP 217 Medium

fr.paris.lutece.plugins.menus.service.cache.MainTreeMenuAllPagesCacheService

Bug Category Details Line Priority
Public static fr.paris.lutece.plugins.menus.service.cache.MainTreeMenuAllPagesCacheService.getInstance() may expose internal representation by returning MainTreeMenuAllPagesCacheService._instance MALICIOUS_CODE MS_EXPOSE_REP 66 Medium

fr.paris.lutece.plugins.menus.service.cache.MainTreeMenuCacheService

Bug Category Details Line Priority
Public static fr.paris.lutece.plugins.menus.service.cache.MainTreeMenuCacheService.getInstance() may expose internal representation by returning MainTreeMenuCacheService._instance MALICIOUS_CODE MS_EXPOSE_REP 66 Medium

fr.paris.lutece.plugins.menus.web.AccessibilityAnchorMenuInclude

Bug Category Details Line Priority
Possible null pointer dereference of request in fr.paris.lutece.plugins.menus.web.AccessibilityAnchorMenuInclude.getAccessibilityTemplate(int, HttpServletRequest) CORRECTNESS NP_NULL_ON_SOME_PATH 119 Medium

fr.paris.lutece.plugins.menus.web.CustomMenusJspBean

Bug Category Details Line Priority
Class fr.paris.lutece.plugins.menus.web.CustomMenusJspBean defines non-transient non-serializable instance field _itemValidator BAD_PRACTICE SE_BAD_FIELD Not available Medium

fr.paris.lutece.plugins.menus.web.PaginatedJspBean

Bug Category Details Line Priority
Unread field: fr.paris.lutece.plugins.menus.web.PaginatedJspBean.PROPERTY_SUFFIX_DEFAULT_LIST_ITEM_PER_PAGE; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 57 Medium

fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm

Bug Category Details Line Priority
fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.getListErrors() may expose internal representation by returning ValidatorCustomItemForm._listErrors MALICIOUS_CODE EI_EXPOSE_REP 189 Medium
Unread field: fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.MESSAGE_DYNAMIC_PAGE_LABEL_NOT_EMPTY; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 66 Medium
Unread field: fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.MESSAGE_LABEL_NOT_EMPTY; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 65 Medium
Unread field: fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.MESSAGE_PARENT_MENU_NOT_VALID; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 62 Medium
Unread field: fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.MESSAGE_SUBMENU_NOT_EMPTY; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 63 Medium
Unread field: fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.MESSAGE_TYPE_NOT_EMPTY; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 60 Medium
Unread field: fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.MESSAGE_TYPE_NOT_VALID; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 61 Medium
Unread field: fr.paris.lutece.plugins.menus.web.validator.ValidatorCustomItemForm.MESSAGE_URL_NOT_EMPTY; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 64 Medium