Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/modulenotifygrumappingmanager/service/NotifygruMappingManagerService.java

Rule Violation Line
FieldNamingConventions The static field name 'MESSAGE_MAPPING_NONE' doesn't match '_[a-z][a-zA-Z0-9]*' 17

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/rs/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 37–46

Priority 2

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/NotifygruMappingManagerJspBean.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 341–342

Priority 3

fr/paris/lutece/plugins/modulenotifygrumappingmanager/business/NotifygruMappingManagerHome.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 114–117

fr/paris/lutece/plugins/modulenotifygrumappingmanager/service/NotifygruMappingManagerService.java

Rule Violation Line
CommentRequired Header comments are required 13–55
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 14–55
CommentRequired Public method and constructor comments are required 19–35
CommentRequired Public method and constructor comments are required 37–53
SimplifyConditional No need to check for null before an instanceof 47

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/ManageModulenotifygrumappingmanagerJspBean.java

Rule Violation Line
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 64
AddEmptyString Do not add empty strings 95

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/NotifygruMappingManagerJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 140
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 145
ConfusingTernary Avoid if (x != y) ..; else ..; 171
ConfusingTernary Avoid if (x != y) ..; else ..; 182–193
ConfusingTernary Avoid if (x != y) ..; else ..; 216
CommentRequired Protected method constructor comments are required 240–271

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/rs/Constants.java

Rule Violation Line
CommentRequired Header comments are required 37–46

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/rs/NotifygruMappingManagerRest.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 74–88
CommentRequired Public method and constructor comments are required 90–119
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 113

Priority 4

fr/paris/lutece/plugins/modulenotifygrumappingmanager/business/NotifygruMappingManager.java

Rule Violation Line
DuplicateImports Avoid duplicate imports such as 'javax.validation.constraints.NotEmpty' 37

Files

fr/paris/lutece/plugins/modulenotifygrumappingmanager/business/NotifygruMappingManager.java

Rule Violation Priority Line
DuplicateImports Avoid duplicate imports such as 'javax.validation.constraints.NotEmpty' 4 37

fr/paris/lutece/plugins/modulenotifygrumappingmanager/business/NotifygruMappingManagerHome.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 114–117

fr/paris/lutece/plugins/modulenotifygrumappingmanager/service/NotifygruMappingManagerService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 13–55
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 14–55
FieldNamingConventions The static field name 'MESSAGE_MAPPING_NONE' doesn't match '_[a-z][a-zA-Z0-9]*' 1 17
CommentRequired Public method and constructor comments are required 3 19–35
CommentRequired Public method and constructor comments are required 3 37–53
SimplifyConditional No need to check for null before an instanceof 3 47

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/ManageModulenotifygrumappingmanagerJspBean.java

Rule Violation Priority Line
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 64
AddEmptyString Do not add empty strings 3 95

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/NotifygruMappingManagerJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 140
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 171
ConfusingTernary Avoid if (x != y) ..; else ..; 3 182–193
ConfusingTernary Avoid if (x != y) ..; else ..; 3 216
CommentRequired Protected method constructor comments are required 3 240–271
GuardLogStatement Logger calls should be surrounded by log level guards. 2 341–342

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/rs/Constants.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 37–46
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 37–46

fr/paris/lutece/plugins/modulenotifygrumappingmanager/web/rs/NotifygruMappingManagerRest.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 74–88
CommentRequired Public method and constructor comments are required 3 90–119
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 113