PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/myapps/business/MyApps.java
| Violation |
Line |
| Abstract classes should be named AbstractXXX |
47–208 |
| Avoid variables with short names like o |
182 |
fr/paris/lutece/plugins/myapps/business/MyAppsUser.java
| Violation |
Line |
| Abstract classes should be named AbstractXXX |
40–105 |
| This abstract class does not have any abstract methods |
40–105 |
fr/paris/lutece/plugins/myapps/business/portlet/MyAppsPortlet.java
| Violation |
Line |
| Avoid unnecessary constructors - the compiler will generate these for you |
98–100 |
| It is a good practice to call super() in a constructor |
98–100 |
| Document empty constructor |
98–100 |
fr/paris/lutece/plugins/myapps/business/portlet/MyAppsPortletHome.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
56–58 |
| Document empty constructor |
56–58 |
| Avoid unnecessary constructors - the compiler will generate these for you |
56–58 |
| Singleton is not thread safe |
67–70 |
fr/paris/lutece/plugins/myapps/service/MyAppsManager.java
| Violation |
Line |
| Private field '_listRegisteredProviders' could be made final; it is only initialized in the declaration or constructor. |
55 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
55 |
| Use block level rather than method level synchronization |
69–77 |
fr/paris/lutece/plugins/myapps/service/MyAppsPlugin.java
| Violation |
Line |
| Document empty method |
50–51 |
fr/paris/lutece/plugins/myapps/service/MyAppsResourceIdService.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
62–65 |
| Avoid variables with short names like rt |
72 |
| Avoid variables with short names like p |
78 |
fr/paris/lutece/plugins/myapps/service/MyAppsService.java
| Violation |
Line |
| Use block level rather than method level synchronization |
56–64 |
fr/paris/lutece/plugins/myapps/service/parameter/MyAppsParameterService.java
| Violation |
Line |
| Use block level rather than method level synchronization |
56–64 |
| Document empty method |
70–71 |
fr/paris/lutece/plugins/myapps/service/portlet/MyAppsPortletService.java
| Violation |
Line |
| Avoid unnecessary constructors - the compiler will generate these for you |
52–54 |
| Document empty constructor |
52–54 |
| Use block level rather than method level synchronization |
61–69 |
fr/paris/lutece/plugins/myapps/util/crypto/CryptoUtil.java
| Violation |
Line |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
104 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
129 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
152 |
fr/paris/lutece/plugins/myapps/web/MyAppsAdminDashboardComponent.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
85 |
fr/paris/lutece/plugins/myapps/web/MyAppsApp.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
135 |
