Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/mylutece/authentication/AbstractAuthentication.java

Rule Violation Ligne
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 95100
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 109114

fr/paris/lutece/plugins/mylutece/authentication/ExternalAuthentication.java

Rule Violation Ligne
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 7881
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 8891
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 98101
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 108111
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 118121
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 128131
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 137140
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 177180
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 189192
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 201204
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 201204
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 242245
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 252254

fr/paris/lutece/plugins/mylutece/authentication/MultiLuteceAuthentication.java

Rule Violation Ligne
FieldNamingConventions The constant name '_mapAuthentications' doesn't match '[A-Z][A-Z_0-9]*' 66
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 412422

fr/paris/lutece/plugins/mylutece/authentication/PortalAuthentication.java

Rule Violation Ligne
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 162165
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 202205
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 214218
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 227230
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 227230
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 267269

fr/paris/lutece/plugins/mylutece/business/LuteceUserRoleDescription.java

Rule Violation Ligne
ConstructorCallsOverridableMethod Overridable method 'setType' called during object construction 75
ConstructorCallsOverridableMethod Overridable method 'setComplementaryDescription' called during object construction 76
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 94
FormalParameterNamingConventions The method parameter name '_strComplementaryDescription' doesn't match '[a-z][a-zA-Z0-9]*' 112

fr/paris/lutece/plugins/mylutece/service/MyLuteceExternalIdentityService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'ATTRIBUTE_USER_MAPPING' doesn't match '_[a-z][a-zA-Z0-9]*' 54

fr/paris/lutece/plugins/mylutece/util/SecurityUtils.java

Rule Violation Ligne
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 870880

Priority 2

fr/paris/lutece/plugins/mylutece/service/MyLuteceExternalIdentityService.java

Rule Violation Ligne
AvoidUsingVolatile Use of modifier volatile is not recommended. 56
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 121

fr/paris/lutece/plugins/mylutece/service/MyluteceExternalRoleService.java

Rule Violation Ligne
AvoidUsingVolatile Use of modifier volatile is not recommended. 22

fr/paris/lutece/plugins/mylutece/util/SecurityUtils.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strValue' 589

fr/paris/lutece/plugins/mylutece/web/security/AuthenticationFilterJspBean.java

Rule Violation Ligne
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 257

Priority 3

fr/paris/lutece/plugins/mylutece/authentication/AbstractAuthentication.java

Rule Violation Ligne
CommentRequired Header comments are required 47116

fr/paris/lutece/plugins/mylutece/authentication/ExternalAuthentication.java

Rule Violation Ligne
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 5760
MissingOverride The method 'isDelegatedAuthentication()' is missing an @Override annotation. 6871
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 7881
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 8891
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 98101
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 108111
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 118121
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 128131
MissingOverride The method 'getAccessDeniedTemplate()' is missing an @Override annotation. 147150
MissingOverride The method 'getAccessControledTemplate()' is missing an @Override annotation. 157160
MissingOverride The method 'isUsersListAvailable()' is missing an @Override annotation. 167170
MissingOverride The method 'getUsers()' is missing an @Override annotation. 177180
MissingOverride The method 'getUser(String)' is missing an @Override annotation. 189192
MissingOverride The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. 201204
MissingOverride The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. 213216
MissingOverride The method 'getIconUrl()' is missing an @Override annotation. 222225
UncommentedEmptyMethodBody Document empty method body 253254

fr/paris/lutece/plugins/mylutece/authentication/MultiLuteceAuthentication.java

Rule Violation Ligne
GodClass Possible God Class (WMC=64, ATFD=64, TCC=22.727%) 62685
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 66
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 66
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 106123
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 131148
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 156173
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 181198
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 206223
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 302319
MissingOverride The method 'getAccessDeniedTemplate()' is missing an @Override annotation. 326329
MissingOverride The method 'getAccessControledTemplate()' is missing an @Override annotation. 336339
MissingOverride The method 'getAnonymousUser()' is missing an @Override annotation. 345360
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 351357
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the AnonymousUser constructor if you want a default access modifier 353356
MissingOverride The method 'getAuthServiceName()' is missing an @Override annotation. 366369
MissingOverride The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. 375378
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 388406
MissingOverride The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. 412422
MissingOverride The method 'getUser(String)' is missing an @Override annotation. 433447
MissingOverride The method 'getUsers()' is missing an @Override annotation. 455470
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 457
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 476479
MissingOverride The method 'isUserInRole(LuteceUser, HttpServletRequest, String)' is missing an @Override annotation. 485500
MissingOverride The method 'isUsersListAvailable()' is missing an @Override annotation. 508511
MissingOverride The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. 517547
ConfusingTernary Avoid if (x != y) ..; else ..; 522544
ConfusingTernary Avoid if (x != y) ..; else ..; 526539
MissingOverride The method 'logout(LuteceUser)' is missing an @Override annotation. 553577
ConfusingTernary Avoid if (x != y) ..; else ..; 555576
ConfusingTernary Avoid if (x != y) ..; else ..; 559571
MissingOverride The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. 583586
MissingOverride The method 'isDelegatedAuthentication()' is missing an @Override annotation. 604607
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 616
MissingOverride The method 'getIconUrl()' is missing an @Override annotation. 641644
MissingOverride The method 'getName()' is missing an @Override annotation. 652655
MissingOverride The method 'getPluginName()' is missing an @Override annotation. 663666

fr/paris/lutece/plugins/mylutece/authentication/PortalAuthentication.java

Rule Violation Ligne
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 5760
MissingOverride The method 'isDelegatedAuthentication()' is missing an @Override annotation. 6669
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 7578
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 8487
MissingOverride The method 'findResetPassword(HttpServletRequest, String)' is missing an @Override annotation. 9396
MissingOverride The method 'getResetPasswordPageUrl(HttpServletRequest)' is missing an @Override annotation. 101104
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 111114
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 121124
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 149152
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 162165
MissingOverride The method 'getAccessDeniedTemplate()' is missing an @Override annotation. 172175
MissingOverride The method 'getAccessControledTemplate()' is missing an @Override annotation. 182185
MissingOverride The method 'isUsersListAvailable()' is missing an @Override annotation. 192195
MissingOverride The method 'getUsers()' is missing an @Override annotation. 202205
MissingOverride The method 'getUser(String)' is missing an @Override annotation. 214218
MissingOverride The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. 227230
MissingOverride The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. 238241
MissingOverride The method 'getIconUrl()' is missing an @Override annotation. 247250
UncommentedEmptyMethodBody Document empty method body 268269

fr/paris/lutece/plugins/mylutece/business/LuteceUserAttributeDescription.java

Rule Violation Ligne
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 61
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 64
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 67

fr/paris/lutece/plugins/mylutece/business/LuteceUserRoleDescription.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 7177

fr/paris/lutece/plugins/mylutece/business/attribute/AbstractAttribute.java

Rule Violation Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7880
UncommentedEmptyConstructor Document empty constructor 7880
MissingOverride The method 'getIdAttribute()' is missing an @Override annotation. 8790
MissingOverride The method 'setIdAttribute(int)' is missing an @Override annotation. 98101
MissingOverride The method 'isMandatory()' is missing an @Override annotation. 108111
MissingOverride The method 'setMandatory(boolean)' is missing an @Override annotation. 119122
MissingOverride The method 'getListAttributeFields()' is missing an @Override annotation. 129132
MissingOverride The method 'setListAttributeFields(List)' is missing an @Override annotation. 140143
MissingOverride The method 'getTitle()' is missing an @Override annotation. 150153
MissingOverride The method 'setTitle(String)' is missing an @Override annotation. 161164
MissingOverride The method 'getHelpMessage()' is missing an @Override annotation. 171174
MissingOverride The method 'setHelpMessage(String)' is missing an @Override annotation. 182185
MissingOverride The method 'getPosition()' is missing an @Override annotation. 192195
MissingOverride The method 'setPosition(int)' is missing an @Override annotation. 203206
MissingOverride The method 'getAttributeType()' is missing an @Override annotation. 213216
MissingOverride The method 'setAttributeType(AttributeType)' is missing an @Override annotation. 224227
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 238
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 238
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 257
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 257
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 277
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 277
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 281
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 283
MissingOverride The method 'getPlugin()' is missing an @Override annotation. 307310
MissingOverride The method 'setPlugin(Plugin)' is missing an @Override annotation. 318321
MissingOverride The method 'getAnonymize()' is missing an @Override annotation. 328331
MissingOverride The method 'setAnonymize(boolean)' is missing an @Override annotation. 339342
MissingOverride The method 'isShownInSearch()' is missing an @Override annotation. 349352
MissingOverride The method 'setShownInSearch(boolean)' is missing an @Override annotation. 360363
MissingOverride The method 'getUserFieldsData(HttpServletRequest, int)' is missing an @Override annotation. 374379

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeComboBox.java

Rule Violation Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8284
CallSuperInConstructor It is a good practice to call super() in a constructor 8284
UncommentedEmptyConstructor Document empty constructor 8284
MissingOverride The method 'getTemplateCreateAttribute()' is missing an @Override annotation. 9194
MissingOverride The method 'getTemplateModifyAttribute()' is missing an @Override annotation. 101104
MissingOverride The method 'getTemplateHtmlFormAttribute()' is missing an @Override annotation. 111114
MissingOverride The method 'getTemplateHtmlFormSearchAttribute()' is missing an @Override annotation. 121124
MissingOverride The method 'getPropertyCreatePageTitle()' is missing an @Override annotation. 131134
MissingOverride The method 'getPropertyModifyPageTitle()' is missing an @Override annotation. 141144
MissingOverride The method 'setAttributeData(HttpServletRequest)' is missing an @Override annotation. 153182
LinguisticNaming Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically 153182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 156
ConfusingTernary Avoid if (x != y) ..; else ..; 156
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 157
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 158
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 173
MissingOverride The method 'setAttributeType(Locale)' is missing an @Override annotation. 190197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 205
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 216
MissingOverride The method 'isAnonymizable()' is missing an @Override annotation. 254257

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 53461
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 407

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeFieldDAO.java

Rule Violation Ligne
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 135162
MissingOverride The method 'selectAttributeByIdField(int, Plugin)' is missing an @Override annotation. 173208
MissingOverride The method 'selectAttributeFieldsByIdAttribute(int, Plugin)' is missing an @Override annotation. 219248
MissingOverride The method 'insert(AttributeField, Plugin)' is missing an @Override annotation. 259279
MissingOverride The method 'store(AttributeField, Plugin)' is missing an @Override annotation. 289305
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 315323
MissingOverride The method 'deleteAttributeFieldsFromIdAttribute(int, Plugin)' is missing an @Override annotation. 333341

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeFieldHome.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 47144

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeHome.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 49221
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 49221

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeText.java

Rule Violation Ligne
UncommentedEmptyConstructor Document empty constructor 8587
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8587
CallSuperInConstructor It is a good practice to call super() in a constructor 8587
MissingOverride The method 'getTemplateCreateAttribute()' is missing an @Override annotation. 9497
MissingOverride The method 'getTemplateModifyAttribute()' is missing an @Override annotation. 104107
MissingOverride The method 'getTemplateHtmlFormAttribute()' is missing an @Override annotation. 114117
MissingOverride The method 'getTemplateHtmlFormSearchAttribute()' is missing an @Override annotation. 124127
MissingOverride The method 'getPropertyCreatePageTitle()' is missing an @Override annotation. 134137
MissingOverride The method 'getPropertyModifyPageTitle()' is missing an @Override annotation. 144147
MissingOverride The method 'setAttributeData(HttpServletRequest)' is missing an @Override annotation. 156219
LinguisticNaming Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically 156219
ConfusingTernary Avoid if (x != y) ..; else ..; 159
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 159
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 160
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 161
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 162
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 163
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 208
MissingOverride The method 'setAttributeType(Locale)' is missing an @Override annotation. 227234
MissingOverride The method 'getUserFieldsData(String, int)' is missing an @Override annotation. 245270
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 247
MissingOverride The method 'isAnonymizable()' is missing an @Override annotation. 277280

fr/paris/lutece/plugins/mylutece/business/attribute/IAttribute.java

Rule Violation Ligne
LinguisticNaming Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically 266

fr/paris/lutece/plugins/mylutece/business/attribute/IAttributeDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 48182

fr/paris/lutece/plugins/mylutece/business/attribute/MyLuteceUserFieldDAO.java

Rule Violation Ligne
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 338

fr/paris/lutece/plugins/mylutece/business/attribute/MyLuteceUserFieldFilter.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 104
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 143
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 173

fr/paris/lutece/plugins/mylutece/business/attribute/MyLuteceUserFieldHome.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 48174

fr/paris/lutece/plugins/mylutece/business/portlet/IMyLutecePortletDAO.java

Rule Violation Ligne
MissingOverride The method 'delete(int)' is missing an @Override annotation. 51
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 59
MissingOverride The method 'load(int)' is missing an @Override annotation. 68
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 76

fr/paris/lutece/plugins/mylutece/business/portlet/MyLutecePortlet.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 7779
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7779
UncommentedEmptyConstructor Document empty constructor 7779
ExcessiveMethodLength Avoid really long methods. 88192
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 88192
CyclomaticComplexity The method 'getXml(HttpServletRequest)' has a cyclomatic complexity of 13. 88192
ConfusingTernary Avoid if (x != y) ..; else ..; 104187
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 113
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113
ConfusingTernary Avoid if (x != y) ..; else ..; 135136
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 157
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 157
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 201204
MissingOverride The method 'remove()' is missing an @Override annotation. 217220

fr/paris/lutece/plugins/mylutece/business/portlet/MyLutecePortletDAO.java

Rule Violation Ligne
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 5255
MissingOverride The method 'delete(int)' is missing an @Override annotation. 6366
MissingOverride The method 'load(int)' is missing an @Override annotation. 7581
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'portlet' 80
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 8992

fr/paris/lutece/plugins/mylutece/business/portlet/MyLutecePortletHome.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 50
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 50
CallSuperInConstructor It is a good practice to call super() in a constructor 5561
NonThreadSafeSingleton Singleton is not thread safe 7073
MissingOverride The method 'getDAO()' is missing an @Override annotation. 8386
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 9399
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 98

fr/paris/lutece/plugins/mylutece/service/AbstractAccountLifeTimeDaemon.java

Rule Violation Ligne
NcssCount The method 'run()' has a NCSS line count of 148. 99355
NPathComplexity The method 'run()' has an NPath complexity of 255024 99355
ExcessiveMethodLength Avoid really long methods. 99355
CyclomaticComplexity The method 'run()' has a cyclomatic complexity of 38. 99355
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 134 characters appended. 110
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 113
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 133
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 133
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 147
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 155
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 160
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 171
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 177
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 197
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 197
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 204
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 218
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 223
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 235
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 242
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 263
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 270
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 285
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 290
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 301
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 322
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 322
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 340
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 345
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 351

fr/paris/lutece/plugins/mylutece/service/AbstractAnonymizationDaemon.java

Rule Violation Ligne
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 76

fr/paris/lutece/plugins/mylutece/service/IMyLuteceExternalIdentityProviderService.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIdentityInformations': the method is declared in an interface type 55

fr/paris/lutece/plugins/mylutece/service/IMyLuteceExternalIdentityService.java

Rule Violation Ligne
CommentRequired Header comments are required 4278
CommentRequired Public method and constructor comments are required 76

fr/paris/lutece/plugins/mylutece/service/MyLuteceDefaultRoleProvider.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 6976
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85
ConfusingTernary Avoid if (x != y) ..; else ..; 90102

fr/paris/lutece/plugins/mylutece/service/MyLuteceExternalIdentityService.java

Rule Violation Ligne
CommentRequired Header comments are required 49182
NonThreadSafeSingleton Singleton is not thread safe 6696
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 73
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 8093
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 8492
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 149
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 153
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 159163
MissingOverride The method 'getProviders()' is missing an @Override annotation. 175180

fr/paris/lutece/plugins/mylutece/service/MyLutecePlugin.java

Rule Violation Ligne
MissingOverride The method 'init()' is missing an @Override annotation. 5153
UncommentedEmptyMethodBody Document empty method body 5253

fr/paris/lutece/plugins/mylutece/service/MyLuteceResourceIdService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 6568
MissingOverride The method 'register()' is missing an @Override annotation. 73102
ShortVariable Avoid variables with short names like rt 75
ShortVariable Avoid variables with short names like p 81
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 111114
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 125128

fr/paris/lutece/plugins/mylutece/service/MyLuteceUserAttributesService.java

Rule Violation Ligne
MissingOverride The method 'getAttribute(String, String)' is missing an @Override annotation. 5566
MissingOverride The method 'getAttributes(String)' is missing an @Override annotation. 7182
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 73
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 73

fr/paris/lutece/plugins/mylutece/service/MyLuteceUserService.java

Rule Violation Ligne
CommentRequired Header comments are required 4790
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4890
ConfusingTernary Avoid if (x != y) ..; else ..; 70

fr/paris/lutece/plugins/mylutece/service/MyluteceExternalRoleService.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 3442

fr/paris/lutece/plugins/mylutece/service/RoleResourceIdService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 5962
MissingOverride The method 'register()' is missing an @Override annotation. 6781
ShortVariable Avoid variables with short names like rt 69
ShortVariable Avoid variables with short names like p 75
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 9093
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 104114

fr/paris/lutece/plugins/mylutece/service/attribute/MyLuteceUserFieldListenerService.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 53
ImmutableField Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. 53

fr/paris/lutece/plugins/mylutece/service/attribute/MyLuteceUserFieldService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 60218

fr/paris/lutece/plugins/mylutece/service/security/AuthenticationFilterService.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 93
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 93
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 116

fr/paris/lutece/plugins/mylutece/util/SecurityUtils.java

Rule Violation Ligne
GodClass Possible God Class (WMC=65, ATFD=72, TCC=13.547%) 67928
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 68928
TooManyMethods This class has too many methods, consider refactoring it. 68928
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'nValue' 428
SimplifiedTernary Ternary operators that can be simplified with || or && 451
CyclomaticComplexity The method 'checkPasswordForFrontOffice(IUserParameterService, Plugin, String, int)' has a cyclomatic complexity of 10. 731790
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 755758
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 760763
SimplifiedTernary Ternary operators that can be simplified with || or && 925926

fr/paris/lutece/plugins/mylutece/web/AbstractManageMyluteceJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 5098

fr/paris/lutece/plugins/mylutece/web/ManageMyLuteceJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 65173
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 104
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 105
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 105

fr/paris/lutece/plugins/mylutece/web/MyLuteceApp.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34715
GodClass Possible God Class (WMC=60, ATFD=88, TCC=6.719%) 82715
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 82715
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 160162
UncommentedEmptyConstructor Document empty constructor 160162
MissingOverride The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. 175203
CyclomaticComplexity The method 'getLoginPage(XPage, HttpServletRequest)' has a cyclomatic complexity of 10. 214291
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 216
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 216
NPathComplexity The method 'doLogin(HttpServletRequest)' has an NPath complexity of 360 301407
CyclomaticComplexity The method 'doLogin(HttpServletRequest)' has a cyclomatic complexity of 16. 301407
ExcessiveMethodLength Avoid really long methods. 301407
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 317
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 347
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 351
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 357
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 360
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 370
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 374
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 380
ConfusingTernary Avoid if (x != y) ..; else ..; 396404
LinguisticNaming Linguistics Antipattern - The method 'isUserAuthenticated' indicates linguistically it returns a boolean, but it returns 'String' 416434
ConfusingTernary Avoid if (x != y) ..; else ..; 424431
UnusedFormalParameter Avoid unused method parameters such as 'request'. 551
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 553
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 553
ShortVariable Avoid variables with short names like t 561
ShortVariable Avoid variables with short names like t 580
ShortVariable Avoid variables with short names like t 599
ShortVariable Avoid variables with short names like t 618
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strNextUrl' 690

fr/paris/lutece/plugins/mylutece/web/attribute/AttributeFieldJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 63364
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 111
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 111
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 160
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 185
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 185
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 208
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 236
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 278
ShortVariable Avoid variables with short names like it 300
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 320
ShortVariable Avoid variables with short names like it 342
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 362

fr/paris/lutece/plugins/mylutece/web/attribute/AttributeJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 66432
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 119
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 119
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 150155
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 156160
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 167
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 167
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 201206
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 207211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 263
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 334
ShortVariable Avoid variables with short names like it 374
ShortVariable Avoid variables with short names like it 412

fr/paris/lutece/plugins/mylutece/web/includes/UserLoginInclude.java

Rule Violation Ligne
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 86151
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 91
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 91
CollapsibleIfStatements These nested if statements could be combined 95145
ConfusingTernary Avoid if (x != y) ..; else ..; 104122
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 115118
ShortVariable Avoid variables with short names like t 124

fr/paris/lutece/plugins/mylutece/web/portlet/MyLutecePortletJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 47155
CallSuperInConstructor It is a good practice to call super() in a constructor 6163
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6163
UncommentedEmptyConstructor Document empty constructor 6163
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 7279
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 8896
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 105125
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 134154

fr/paris/lutece/plugins/mylutece/web/security/AuthenticationFilterJspBean.java

Rule Violation Ligne
AvoidDuplicateLiterals The String literal "User " appears 7 times in this file; the first occurrence is on line 107 107
AvoidDuplicateLiterals The String literal " is not authorized to permission " appears 7 times in this file; the first occurrence is on line 107 107
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 257
ConfusingTernary Avoid if (x != y) ..; else ..; 302303
ConfusingTernary Avoid if (x != y) ..; else ..; 304305

fr/paris/lutece/plugins/mylutece/web/security/MyluteceAuthFilter.java

Rule Violation Ligne
UncommentedEmptyMethodBody Document empty method body 8384
CyclomaticComplexity The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' has a cyclomatic complexity of 10. 99145
CyclomaticComplexity The method 'filterAccess(HttpServletRequest)' has a cyclomatic complexity of 13. 171225
CollapsibleIfStatements These nested if statements could be combined 182187
ConfusingTernary Avoid if (x != y) ..; else ..; 320327

Priority 4

fr/paris/lutece/plugins/mylutece/authentication/logs/ConnectionLogDAO.java

Rule Violation Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 60
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 60
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 61
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 61

fr/paris/lutece/plugins/mylutece/business/attribute/AbstractAttribute.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 328331

fr/paris/lutece/plugins/mylutece/business/attribute/IAttribute.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 173

fr/paris/lutece/plugins/mylutece/util/SecurityUtils.java

Rule Violation Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 775

fr/paris/lutece/plugins/mylutece/web/ManageMyLuteceJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' 53

fr/paris/lutece/plugins/mylutece/web/MyLuteceApp.java

Rule Violation Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 343

Fichiers

fr/paris/lutece/plugins/mylutece/authentication/AbstractAuthentication.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 47116
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 95100
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 109114

fr/paris/lutece/plugins/mylutece/authentication/ExternalAuthentication.java

Rule Violation Priority Ligne
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 3 5760
MissingOverride The method 'isDelegatedAuthentication()' is missing an @Override annotation. 3 6871
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 7881
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 3 7881
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 3 8891
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 8891
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 98101
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 3 98101
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 3 108111
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 108111
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 3 118121
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 118121
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 128131
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 3 128131
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 137140
MissingOverride The method 'getAccessDeniedTemplate()' is missing an @Override annotation. 3 147150
MissingOverride The method 'getAccessControledTemplate()' is missing an @Override annotation. 3 157160
MissingOverride The method 'isUsersListAvailable()' is missing an @Override annotation. 3 167170
MissingOverride The method 'getUsers()' is missing an @Override annotation. 3 177180
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 177180
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 189192
MissingOverride The method 'getUser(String)' is missing an @Override annotation. 3 189192
MissingOverride The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. 3 201204
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 201204
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 201204
MissingOverride The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. 3 213216
MissingOverride The method 'getIconUrl()' is missing an @Override annotation. 3 222225
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 242245
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 252254
UncommentedEmptyMethodBody Document empty method body 3 253254

fr/paris/lutece/plugins/mylutece/authentication/MultiLuteceAuthentication.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=64, ATFD=64, TCC=22.727%) 3 62685
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 66
FieldNamingConventions The constant name '_mapAuthentications' doesn't match '[A-Z][A-Z_0-9]*' 1 66
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 66
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 3 106123
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 3 131148
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 3 156173
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 3 181198
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 3 206223
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 3 302319
MissingOverride The method 'getAccessDeniedTemplate()' is missing an @Override annotation. 3 326329
MissingOverride The method 'getAccessControledTemplate()' is missing an @Override annotation. 3 336339
MissingOverride The method 'getAnonymousUser()' is missing an @Override annotation. 3 345360
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 351357
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the AnonymousUser constructor if you want a default access modifier 3 353356
MissingOverride The method 'getAuthServiceName()' is missing an @Override annotation. 3 366369
MissingOverride The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. 3 375378
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 3 388406
MissingOverride The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. 3 412422
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 412422
MissingOverride The method 'getUser(String)' is missing an @Override annotation. 3 433447
MissingOverride The method 'getUsers()' is missing an @Override annotation. 3 455470
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 457
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 3 476479
MissingOverride The method 'isUserInRole(LuteceUser, HttpServletRequest, String)' is missing an @Override annotation. 3 485500
MissingOverride The method 'isUsersListAvailable()' is missing an @Override annotation. 3 508511
MissingOverride The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. 3 517547
ConfusingTernary Avoid if (x != y) ..; else ..; 3 522544
ConfusingTernary Avoid if (x != y) ..; else ..; 3 526539
MissingOverride The method 'logout(LuteceUser)' is missing an @Override annotation. 3 553577
ConfusingTernary Avoid if (x != y) ..; else ..; 3 555576
ConfusingTernary Avoid if (x != y) ..; else ..; 3 559571
MissingOverride The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. 3 583586
MissingOverride The method 'isDelegatedAuthentication()' is missing an @Override annotation. 3 604607
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 616
MissingOverride The method 'getIconUrl()' is missing an @Override annotation. 3 641644
MissingOverride The method 'getName()' is missing an @Override annotation. 3 652655
MissingOverride The method 'getPluginName()' is missing an @Override annotation. 3 663666

fr/paris/lutece/plugins/mylutece/authentication/PortalAuthentication.java

Rule Violation Priority Ligne
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 3 5760
MissingOverride The method 'isDelegatedAuthentication()' is missing an @Override annotation. 3 6669
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 3 7578
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 3 8487
MissingOverride The method 'findResetPassword(HttpServletRequest, String)' is missing an @Override annotation. 3 9396
MissingOverride The method 'getResetPasswordPageUrl(HttpServletRequest)' is missing an @Override annotation. 3 101104
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 3 111114
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 3 121124
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 3 149152
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 162165
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 3 162165
MissingOverride The method 'getAccessDeniedTemplate()' is missing an @Override annotation. 3 172175
MissingOverride The method 'getAccessControledTemplate()' is missing an @Override annotation. 3 182185
MissingOverride The method 'isUsersListAvailable()' is missing an @Override annotation. 3 192195
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 202205
MissingOverride The method 'getUsers()' is missing an @Override annotation. 3 202205
MissingOverride The method 'getUser(String)' is missing an @Override annotation. 3 214218
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 214218
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 227230
MissingOverride The method 'getRolesByUser(LuteceUser)' is missing an @Override annotation. 3 227230
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 227230
MissingOverride The method 'isMultiAuthenticationSupported()' is missing an @Override annotation. 3 238241
MissingOverride The method 'getIconUrl()' is missing an @Override annotation. 3 247250
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 267269
UncommentedEmptyMethodBody Document empty method body 3 268269

fr/paris/lutece/plugins/mylutece/authentication/logs/ConnectionLogDAO.java

Rule Violation Priority Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 60
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 60
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 61
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 61

fr/paris/lutece/plugins/mylutece/business/LuteceUserAttributeDescription.java

Rule Violation Priority Ligne
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 61
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 64
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 67

fr/paris/lutece/plugins/mylutece/business/LuteceUserRoleDescription.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7177
ConstructorCallsOverridableMethod Overridable method 'setType' called during object construction 1 75
ConstructorCallsOverridableMethod Overridable method 'setComplementaryDescription' called during object construction 1 76
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 1 94
FormalParameterNamingConventions The method parameter name '_strComplementaryDescription' doesn't match '[a-z][a-zA-Z0-9]*' 1 112

fr/paris/lutece/plugins/mylutece/business/attribute/AbstractAttribute.java

Rule Violation Priority Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7880
UncommentedEmptyConstructor Document empty constructor 3 7880
MissingOverride The method 'getIdAttribute()' is missing an @Override annotation. 3 8790
MissingOverride The method 'setIdAttribute(int)' is missing an @Override annotation. 3 98101
MissingOverride The method 'isMandatory()' is missing an @Override annotation. 3 108111
MissingOverride The method 'setMandatory(boolean)' is missing an @Override annotation. 3 119122
MissingOverride The method 'getListAttributeFields()' is missing an @Override annotation. 3 129132
MissingOverride The method 'setListAttributeFields(List)' is missing an @Override annotation. 3 140143
MissingOverride The method 'getTitle()' is missing an @Override annotation. 3 150153
MissingOverride The method 'setTitle(String)' is missing an @Override annotation. 3 161164
MissingOverride The method 'getHelpMessage()' is missing an @Override annotation. 3 171174
MissingOverride The method 'setHelpMessage(String)' is missing an @Override annotation. 3 182185
MissingOverride The method 'getPosition()' is missing an @Override annotation. 3 192195
MissingOverride The method 'setPosition(int)' is missing an @Override annotation. 3 203206
MissingOverride The method 'getAttributeType()' is missing an @Override annotation. 3 213216
MissingOverride The method 'setAttributeType(AttributeType)' is missing an @Override annotation. 3 224227
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 238
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 238
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 257
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 257
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 277
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 277
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 281
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 283
MissingOverride The method 'getPlugin()' is missing an @Override annotation. 3 307310
MissingOverride The method 'setPlugin(Plugin)' is missing an @Override annotation. 3 318321
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 328331
MissingOverride The method 'getAnonymize()' is missing an @Override annotation. 3 328331
MissingOverride The method 'setAnonymize(boolean)' is missing an @Override annotation. 3 339342
MissingOverride The method 'isShownInSearch()' is missing an @Override annotation. 3 349352
MissingOverride The method 'setShownInSearch(boolean)' is missing an @Override annotation. 3 360363
MissingOverride The method 'getUserFieldsData(HttpServletRequest, int)' is missing an @Override annotation. 3 374379

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeComboBox.java

Rule Violation Priority Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 8284
CallSuperInConstructor It is a good practice to call super() in a constructor 3 8284
UncommentedEmptyConstructor Document empty constructor 3 8284
MissingOverride The method 'getTemplateCreateAttribute()' is missing an @Override annotation. 3 9194
MissingOverride The method 'getTemplateModifyAttribute()' is missing an @Override annotation. 3 101104
MissingOverride The method 'getTemplateHtmlFormAttribute()' is missing an @Override annotation. 3 111114
MissingOverride The method 'getTemplateHtmlFormSearchAttribute()' is missing an @Override annotation. 3 121124
MissingOverride The method 'getPropertyCreatePageTitle()' is missing an @Override annotation. 3 131134
MissingOverride The method 'getPropertyModifyPageTitle()' is missing an @Override annotation. 3 141144
MissingOverride The method 'setAttributeData(HttpServletRequest)' is missing an @Override annotation. 3 153182
LinguisticNaming Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically 3 153182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 156
ConfusingTernary Avoid if (x != y) ..; else ..; 3 156
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 157
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 158
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 173
MissingOverride The method 'setAttributeType(Locale)' is missing an @Override annotation. 3 190197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 205
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 3 216
MissingOverride The method 'isAnonymizable()' is missing an @Override annotation. 3 254257

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 53461
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 407

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeFieldDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 3 135162
MissingOverride The method 'selectAttributeByIdField(int, Plugin)' is missing an @Override annotation. 3 173208
MissingOverride The method 'selectAttributeFieldsByIdAttribute(int, Plugin)' is missing an @Override annotation. 3 219248
MissingOverride The method 'insert(AttributeField, Plugin)' is missing an @Override annotation. 3 259279
MissingOverride The method 'store(AttributeField, Plugin)' is missing an @Override annotation. 3 289305
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 3 315323
MissingOverride The method 'deleteAttributeFieldsFromIdAttribute(int, Plugin)' is missing an @Override annotation. 3 333341

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeFieldHome.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 47144

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeHome.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 49221
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 49221

fr/paris/lutece/plugins/mylutece/business/attribute/AttributeText.java

Rule Violation Priority Ligne
UncommentedEmptyConstructor Document empty constructor 3 8587
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 8587
CallSuperInConstructor It is a good practice to call super() in a constructor 3 8587
MissingOverride The method 'getTemplateCreateAttribute()' is missing an @Override annotation. 3 9497
MissingOverride The method 'getTemplateModifyAttribute()' is missing an @Override annotation. 3 104107
MissingOverride The method 'getTemplateHtmlFormAttribute()' is missing an @Override annotation. 3 114117
MissingOverride The method 'getTemplateHtmlFormSearchAttribute()' is missing an @Override annotation. 3 124127
MissingOverride The method 'getPropertyCreatePageTitle()' is missing an @Override annotation. 3 134137
MissingOverride The method 'getPropertyModifyPageTitle()' is missing an @Override annotation. 3 144147
MissingOverride The method 'setAttributeData(HttpServletRequest)' is missing an @Override annotation. 3 156219
LinguisticNaming Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically 3 156219
ConfusingTernary Avoid if (x != y) ..; else ..; 3 159
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 159
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 160
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 161
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 162
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 163
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 208
MissingOverride The method 'setAttributeType(Locale)' is missing an @Override annotation. 3 227234
MissingOverride The method 'getUserFieldsData(String, int)' is missing an @Override annotation. 3 245270
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 247
MissingOverride The method 'isAnonymizable()' is missing an @Override annotation. 3 277280

fr/paris/lutece/plugins/mylutece/business/attribute/IAttribute.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 173
LinguisticNaming Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically 3 266

fr/paris/lutece/plugins/mylutece/business/attribute/IAttributeDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 48182

fr/paris/lutece/plugins/mylutece/business/attribute/MyLuteceUserFieldDAO.java

Rule Violation Priority Ligne
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 338

fr/paris/lutece/plugins/mylutece/business/attribute/MyLuteceUserFieldFilter.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 104
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 143
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 173

fr/paris/lutece/plugins/mylutece/business/attribute/MyLuteceUserFieldHome.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 48174

fr/paris/lutece/plugins/mylutece/business/portlet/IMyLutecePortletDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 51
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 59
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 68
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 76

fr/paris/lutece/plugins/mylutece/business/portlet/MyLutecePortlet.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7779
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7779
UncommentedEmptyConstructor Document empty constructor 3 7779
ExcessiveMethodLength Avoid really long methods. 3 88192
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 3 88192
CyclomaticComplexity The method 'getXml(HttpServletRequest)' has a cyclomatic complexity of 13. 3 88192
ConfusingTernary Avoid if (x != y) ..; else ..; 3 104187
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 113
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
ConfusingTernary Avoid if (x != y) ..; else ..; 3 135136
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 157
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 157
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 3 201204
MissingOverride The method 'remove()' is missing an @Override annotation. 3 217220

fr/paris/lutece/plugins/mylutece/business/portlet/MyLutecePortletDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 5255
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 6366
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 7581
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'portlet' 3 80
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 8992

fr/paris/lutece/plugins/mylutece/business/portlet/MyLutecePortletHome.java

Rule Violation Priority Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 50
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 50
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5561
NonThreadSafeSingleton Singleton is not thread safe 3 7073
MissingOverride The method 'getDAO()' is missing an @Override annotation. 3 8386
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 3 9399
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 3 98

fr/paris/lutece/plugins/mylutece/service/AbstractAccountLifeTimeDaemon.java

Rule Violation Priority Ligne
NcssCount The method 'run()' has a NCSS line count of 148. 3 99355
NPathComplexity The method 'run()' has an NPath complexity of 255024 3 99355
ExcessiveMethodLength Avoid really long methods. 3 99355
CyclomaticComplexity The method 'run()' has a cyclomatic complexity of 38. 3 99355
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 134 characters appended. 3 110
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 113
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 133
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 133
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 147
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 155
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 160
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 171
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 177
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 197
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 197
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 204
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 218
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 223
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 235
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 242
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 263
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 270
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 285
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 290
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 301
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 322
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 322
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 340
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 345
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 351

fr/paris/lutece/plugins/mylutece/service/AbstractAnonymizationDaemon.java

Rule Violation Priority Ligne
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 76

fr/paris/lutece/plugins/mylutece/service/IMyLuteceExternalIdentityProviderService.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIdentityInformations': the method is declared in an interface type 3 55

fr/paris/lutece/plugins/mylutece/service/IMyLuteceExternalIdentityService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4278
CommentRequired Public method and constructor comments are required 3 76

fr/paris/lutece/plugins/mylutece/service/MyLuteceDefaultRoleProvider.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 6976
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85
ConfusingTernary Avoid if (x != y) ..; else ..; 3 90102

fr/paris/lutece/plugins/mylutece/service/MyLuteceExternalIdentityService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 49182
FieldNamingConventions The static field name 'ATTRIBUTE_USER_MAPPING' doesn't match '_[a-z][a-zA-Z0-9]*' 1 54
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 56
NonThreadSafeSingleton Singleton is not thread safe 3 6696
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 73
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 8093
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 8492
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 116
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 121
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 149
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 153
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 159163
MissingOverride The method 'getProviders()' is missing an @Override annotation. 3 175180

fr/paris/lutece/plugins/mylutece/service/MyLutecePlugin.java

Rule Violation Priority Ligne
MissingOverride The method 'init()' is missing an @Override annotation. 3 5153
UncommentedEmptyMethodBody Document empty method body 3 5253

fr/paris/lutece/plugins/mylutece/service/MyLuteceResourceIdService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6568
MissingOverride The method 'register()' is missing an @Override annotation. 3 73102
ShortVariable Avoid variables with short names like rt 3 75
ShortVariable Avoid variables with short names like p 3 81
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 3 111114
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 3 125128

fr/paris/lutece/plugins/mylutece/service/MyLuteceUserAttributesService.java

Rule Violation Priority Ligne
MissingOverride The method 'getAttribute(String, String)' is missing an @Override annotation. 3 5566
MissingOverride The method 'getAttributes(String)' is missing an @Override annotation. 3 7182
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 73
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 73

fr/paris/lutece/plugins/mylutece/service/MyLuteceUserService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4790
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4890
ConfusingTernary Avoid if (x != y) ..; else ..; 3 70

fr/paris/lutece/plugins/mylutece/service/MyluteceExternalRoleService.java

Rule Violation Priority Ligne
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 22
NonThreadSafeSingleton Singleton is not thread safe 3 3442

fr/paris/lutece/plugins/mylutece/service/RoleResourceIdService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5962
MissingOverride The method 'register()' is missing an @Override annotation. 3 6781
ShortVariable Avoid variables with short names like rt 3 69
ShortVariable Avoid variables with short names like p 3 75
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 3 9093
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 3 104114

fr/paris/lutece/plugins/mylutece/service/attribute/MyLuteceUserFieldListenerService.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 53
ImmutableField Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. 3 53

fr/paris/lutece/plugins/mylutece/service/attribute/MyLuteceUserFieldService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 60218

fr/paris/lutece/plugins/mylutece/service/security/AuthenticationFilterService.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 93
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 93
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 116

fr/paris/lutece/plugins/mylutece/util/SecurityUtils.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=65, ATFD=72, TCC=13.547%) 3 67928
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 68928
TooManyMethods This class has too many methods, consider refactoring it. 3 68928
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'nValue' 3 428
SimplifiedTernary Ternary operators that can be simplified with || or && 3 451
AvoidReassigningParameters Avoid reassigning parameters such as 'strValue' 2 589
CyclomaticComplexity The method 'checkPasswordForFrontOffice(IUserParameterService, Plugin, String, int)' has a cyclomatic complexity of 10. 3 731790
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 755758
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 760763
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 4 775
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 870880
SimplifiedTernary Ternary operators that can be simplified with || or && 3 925926

fr/paris/lutece/plugins/mylutece/web/AbstractManageMyluteceJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 5098

fr/paris/lutece/plugins/mylutece/web/ManageMyLuteceJspBean.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' 4 53
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 65173
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 104
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 105
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 105

fr/paris/lutece/plugins/mylutece/web/MyLuteceApp.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34715
GodClass Possible God Class (WMC=60, ATFD=88, TCC=6.719%) 3 82715
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 82715
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 160162
UncommentedEmptyConstructor Document empty constructor 3 160162
MissingOverride The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. 3 175203
CyclomaticComplexity The method 'getLoginPage(XPage, HttpServletRequest)' has a cyclomatic complexity of 10. 3 214291
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 216
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 216
NPathComplexity The method 'doLogin(HttpServletRequest)' has an NPath complexity of 360 3 301407
CyclomaticComplexity The method 'doLogin(HttpServletRequest)' has a cyclomatic complexity of 16. 3 301407
ExcessiveMethodLength Avoid really long methods. 3 301407
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 317
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 343
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 347
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 351
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 357
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 360
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 370
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 374
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 380
ConfusingTernary Avoid if (x != y) ..; else ..; 3 396404
LinguisticNaming Linguistics Antipattern - The method 'isUserAuthenticated' indicates linguistically it returns a boolean, but it returns 'String' 3 416434
ConfusingTernary Avoid if (x != y) ..; else ..; 3 424431
UnusedFormalParameter Avoid unused method parameters such as 'request'. 3 551
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 553
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 553
ShortVariable Avoid variables with short names like t 3 561
ShortVariable Avoid variables with short names like t 3 580
ShortVariable Avoid variables with short names like t 3 599
ShortVariable Avoid variables with short names like t 3 618
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strNextUrl' 3 690

fr/paris/lutece/plugins/mylutece/web/attribute/AttributeFieldJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 63364
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 111
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 111
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 3 160
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 185
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 185
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 208
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 3 236
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 3 278
ShortVariable Avoid variables with short names like it 3 300
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 3 320
ShortVariable Avoid variables with short names like it 3 342
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 3 362

fr/paris/lutece/plugins/mylutece/web/attribute/AttributeJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 66432
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 119
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 119
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 3 150155
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 3 156160
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 167
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 167
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 3 201206
IdenticalCatchBranches 'catch' branch identical to 'ClassNotFoundException' branch 3 207211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 263
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strUrl' 3 334
ShortVariable Avoid variables with short names like it 3 374
ShortVariable Avoid variables with short names like it 3 412

fr/paris/lutece/plugins/mylutece/web/includes/UserLoginInclude.java

Rule Violation Priority Ligne
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 3 86151
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 91
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 91
CollapsibleIfStatements These nested if statements could be combined 3 95145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 104122
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 115118
ShortVariable Avoid variables with short names like t 3 124

fr/paris/lutece/plugins/mylutece/web/portlet/MyLutecePortletJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 47155
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6163
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 6163
UncommentedEmptyConstructor Document empty constructor 3 6163
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 3 7279
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 3 8896
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 3 105125
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 3 134154

fr/paris/lutece/plugins/mylutece/web/security/AuthenticationFilterJspBean.java

Rule Violation Priority Ligne
AvoidDuplicateLiterals The String literal "User " appears 7 times in this file; the first occurrence is on line 107 3 107
AvoidDuplicateLiterals The String literal " is not authorized to permission " appears 7 times in this file; the first occurrence is on line 107 3 107
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 3 257
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 257
ConfusingTernary Avoid if (x != y) ..; else ..; 3 302303
ConfusingTernary Avoid if (x != y) ..; else ..; 3 304305

fr/paris/lutece/plugins/mylutece/web/security/MyluteceAuthFilter.java

Rule Violation Priority Ligne
UncommentedEmptyMethodBody Document empty method body 3 8384
CyclomaticComplexity The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' has a cyclomatic complexity of 10. 3 99145
CyclomaticComplexity The method 'filterAccess(HttpServletRequest)' has a cyclomatic complexity of 13. 3 171225
CollapsibleIfStatements These nested if statements could be combined 3 182187
ConfusingTernary Avoid if (x != y) ..; else ..; 3 320327