The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strBackUrlParameter' doesn't match '[a-z][a-zA-Z0-9]*' | 334 |
| FormalParameterNamingConventions | The method parameter name '_nPriorityOrder' doesn't match '[a-z][a-zA-Z0-9]*' | 372 |
| FormalParameterNamingConventions | The method parameter name '_bEncodeBackUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 390 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 14–17 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'MARK_LOCALE'. | 93 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_WEBAPP_URL'. | 96 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_singleton' | 126 |
| NonThreadSafeSingleton | Singleton is not thread safe | 147–154 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 169 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 249 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 249 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 281–285 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 319–326 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 361 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 365 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 366 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 373–387 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 418 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 446 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 50–98 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 73–74 |
| CyclomaticComplexity | The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' has a cyclomatic complexity of 11. | 89–134 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 101 |
| UnusedPrivateMethod | Avoid unused private methods such as 'isInPublicUrlList(HttpServletRequest)'. | 172 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 67–680 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 68–680 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 212 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 231 |
| AvoidDuplicateLiterals | The String literal "Invalid security token" appears 4 times in this file; the first occurrence is on line 261 | 261 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 539 |
| CollapsibleIfStatements | These nested if statements could be combined | 554–559 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 583 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.List' | 37 |
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Null' | 40 |
| ShortClassName | Avoid short class names like Rule | 51–393 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 189–192 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 40 |
| UnusedImports | Avoid unused imports such as 'javax.servlet.http.HttpSession' | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.service.MyLuteceUserService' | 50 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.service.MyluteceExternalRoleService' | 51 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Arrays' | 37 |
| UnusedImports | Avoid unused imports such as 'java.util.Comparator' | 38 |
| UnusedImports | Avoid unused imports such as 'java.util.Optional' | 41 |
| UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 42 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' | 58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.List' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Null' | 4 | 40 |
| ShortClassName | Avoid short class names like Rule | 4 | 51–393 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 189–192 |
| FormalParameterNamingConventions | The method parameter name '_strBackUrlParameter' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 334 |
| FormalParameterNamingConventions | The method parameter name '_nPriorityOrder' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 372 |
| FormalParameterNamingConventions | The method parameter name '_bEncodeBackUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 390 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 14–17 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 4 | 40 |
| UnusedImports | Avoid unused imports such as 'javax.servlet.http.HttpSession' | 4 | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.service.MyLuteceUserService' | 4 | 50 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.service.MyluteceExternalRoleService' | 4 | 51 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_LOCALE'. | 3 | 93 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_WEBAPP_URL'. | 3 | 96 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_singleton' | 3 | 126 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 147–154 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 169 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 249 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 249 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 281–285 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 319–326 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 3 | 361 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 3 | 365 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 366 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 373–387 |
| SimplifyStartsWith | This call to String.startsWith can be rewritten using String.charAt(0) | 3 | 418 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 446 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 50–98 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 73–74 |
| CyclomaticComplexity | The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' has a cyclomatic complexity of 11. | 3 | 89–134 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 101 |
| UnusedPrivateMethod | Avoid unused private methods such as 'isInPublicUrlList(HttpServletRequest)'. | 3 | 172 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Arrays' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'java.util.Comparator' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'java.util.Optional' | 4 | 41 |
| UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 4 | 42 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' | 4 | 58 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 67–680 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 68–680 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 212 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 231 |
| AvoidDuplicateLiterals | The String literal "Invalid security token" appears 4 times in this file; the first occurrence is on line 261 | 3 | 261 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 539 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 554–559 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 583 |
