SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 65 |
31 |
0 |
0 |
fr.paris.lutece.plugins.newsletter.business.NewsLetter
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.newsletter.business.NewsLetter.getDateLastSending() may expose internal representation by returning NewsLetter._dateLastSending |
MALICIOUS_CODE |
EI_EXPOSE_REP |
255 |
Medium |
| fr.paris.lutece.plugins.newsletter.business.NewsLetter.setDateLastSending(Timestamp) may expose internal representation by storing an externally mutable object into NewsLetter._dateLastSending |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
245 |
Medium |
fr.paris.lutece.plugins.newsletter.business.SendingNewsLetter
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.newsletter.business.SendingNewsLetter.getDate() may expose internal representation by returning SendingNewsLetter._date |
MALICIOUS_CODE |
EI_EXPOSE_REP |
154 |
Medium |
| fr.paris.lutece.plugins.newsletter.business.SendingNewsLetter.setDate(Timestamp) may expose internal representation by storing an externally mutable object into SendingNewsLetter._date |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
144 |
Medium |
fr.paris.lutece.plugins.newsletter.business.Subscriber
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.newsletter.business.Subscriber.getDateSubscription() may expose internal representation by returning Subscriber._dDateSubscription |
MALICIOUS_CODE |
EI_EXPOSE_REP |
99 |
Medium |
| fr.paris.lutece.plugins.newsletter.business.Subscriber.setDateSubscription(Timestamp) may expose internal representation by storing an externally mutable object into Subscriber._dDateSubscription |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
110 |
Medium |
fr.paris.lutece.plugins.newsletter.business.portlet.NewsLetterArchivePortletHome
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.newsletter.business.portlet.NewsLetterArchivePortletHome.getDAO() may expose internal representation by returning NewsLetterArchivePortletHome._dao |
MALICIOUS_CODE |
EI_EXPOSE_REP |
96 |
Medium |
| Public static fr.paris.lutece.plugins.newsletter.business.portlet.NewsLetterArchivePortletHome.getInstance() may expose internal representation by returning NewsLetterArchivePortletHome._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
86 |
Medium |
| Static initializer for fr.paris.lutece.plugins.newsletter.business.portlet.NewsLetterArchivePortletHome creates instance before all static final fields assigned |
BAD_PRACTICE |
SI_INSTANCE_BEFORE_FINALS_ASSIGNED |
50 |
Medium |
fr.paris.lutece.plugins.newsletter.business.portlet.NewsLetterSubscriptionPortletHome
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.newsletter.business.portlet.NewsLetterSubscriptionPortletHome.getDAO() may expose internal representation by returning NewsLetterSubscriptionPortletHome._dao |
MALICIOUS_CODE |
EI_EXPOSE_REP |
84 |
Medium |
| Public static fr.paris.lutece.plugins.newsletter.business.portlet.NewsLetterSubscriptionPortletHome.getInstance() may expose internal representation by returning NewsLetterSubscriptionPortletHome._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
74 |
Medium |
fr.paris.lutece.plugins.newsletter.service.NewsLetterArchiveService
| Bug |
Category |
Details |
Line |
Priority |
| Static initializer for fr.paris.lutece.plugins.newsletter.service.NewsLetterArchiveService creates instance before all static final fields assigned |
BAD_PRACTICE |
SI_INSTANCE_BEFORE_FINALS_ASSIGNED |
64 |
Medium |
fr.paris.lutece.plugins.newsletter.service.NewsLetterRegistrationService
| Bug |
Category |
Details |
Line |
Priority |
| Random object created and used only once in fr.paris.lutece.plugins.newsletter.service.NewsLetterRegistrationService.doSubscription(HttpServletRequest) |
BAD_PRACTICE |
DMI_RANDOM_USED_ONLY_ONCE |
193 |
High |
| Static initializer for fr.paris.lutece.plugins.newsletter.service.NewsLetterRegistrationService creates instance before all static final fields assigned |
BAD_PRACTICE |
SI_INSTANCE_BEFORE_FINALS_ASSIGNED |
93 |
Medium |
fr.paris.lutece.plugins.newsletter.service.NewsletterService
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.service.NewsletterService.generateNewsletterHtmlCode(NewsLetter, int, String, AdminUser, Locale): new String(byte[]) |
I18N |
DM_DEFAULT_ENCODING |
370 |
High |
fr.paris.lutece.plugins.newsletter.web.NewsLetterApp
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.newsletter.web.NewsLetterApp defines non-transient non-serializable instance field _captchaService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.newsletter.web.NewsletterJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.web.NewsletterJspBean.doImportSubscribers(HttpServletRequest): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
1900 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.web.NewsletterJspBean.getTextFileContent(String): new java.io.FileReader(String) |
I18N |
DM_DEFAULT_ENCODING |
2514 |
High |
| Useless object stored in variable sending of method fr.paris.lutece.plugins.newsletter.web.NewsletterJspBean.doTestNewsLetter(HttpServletRequest) |
STYLE |
UC_USELESS_OBJECT |
1650 |
Medium |
fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.doModifyNewsletterTemplateFile(HttpServletRequest): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
653 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.getModifyNewsLetterTemplateFile(HttpServletRequest): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
537 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.getModifyNewsLetterTemplateFile(HttpServletRequest): new java.io.FileReader(String) |
I18N |
DM_DEFAULT_ENCODING |
547 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.getModifyNewsLetterTemplateFile(HttpServletRequest): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
534 |
High |
| Found reliance on default encoding in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.getModifyNewsLetterTemplateFile(HttpServletRequest): new String(byte[]) |
I18N |
DM_DEFAULT_ENCODING |
535 |
High |
| fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.getModifyNewsLetterTemplateFile(HttpServletRequest) may fail to clean up java.io.Writer on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
534 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.doModifyNewsletterTemplate(HttpServletRequest) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
447 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.doModifyNewsletterTemplateFile(HttpServletRequest) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
644 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.doRemoveNewsLetterTemplate(HttpServletRequest) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
769 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.newsletter.web.NewsletterTemplateJspBean.getModifyNewsLetterTemplateFile(HttpServletRequest) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
539 |
Medium |
fr.paris.lutece.plugins.newsletter.web.portlet.NewsLetterArchivePortletJspBean
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.newsletter.web.portlet.NewsLetterArchivePortletJspBean.modifySendings(HttpServletRequest, NewsLetterArchivePortlet) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
267 |
Medium |
fr.paris.lutece.plugins.newsletter.web.portlet.NewsLetterSubscriptionPortletJspBean
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.newsletter.web.portlet.NewsLetterSubscriptionPortletJspBean.modifySubscriptions(HttpServletRequest, NewsLetterSubscriptionPortlet) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
277 |
Medium |
