SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 54 |
24 |
0 |
0 |
fr.paris.lutece.plugins.notificationstore.business.AbstractFilterDao
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.notificationstore.business.AbstractFilterDao._listTypeAllowedForSearch is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
75 |
Medium |
fr.paris.lutece.plugins.notificationstore.service.CustomerProvider
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.notificationstore.service.CustomerProvider.instance() may expose internal representation by returning CustomerProvider._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
116 |
Medium |
fr.paris.lutece.plugins.notificationstore.service.DemandService
| Bug |
Category |
Details |
Line |
Priority |
| new fr.paris.lutece.plugins.notificationstore.service.DemandService(IDemandDAO, INotificationDAO, INotificationEventDAO, ITemporaryStatusDAO) may expose internal representation by storing an externally mutable object into DemandService._demandDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
105 |
Medium |
| new fr.paris.lutece.plugins.notificationstore.service.DemandService(IDemandDAO, INotificationDAO, INotificationEventDAO, ITemporaryStatusDAO) may expose internal representation by storing an externally mutable object into DemandService._notificationDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
106 |
Medium |
| new fr.paris.lutece.plugins.notificationstore.service.DemandService(IDemandDAO, INotificationDAO, INotificationEventDAO, ITemporaryStatusDAO) may expose internal representation by storing an externally mutable object into DemandService._notificationEventDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
107 |
Medium |
| new fr.paris.lutece.plugins.notificationstore.service.DemandService(IDemandDAO, INotificationDAO, INotificationEventDAO, ITemporaryStatusDAO) may expose internal representation by storing an externally mutable object into DemandService._statusDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
108 |
Medium |
| fr.paris.lutece.plugins.notificationstore.service.DemandService.setDemandDao(IDemandDAO) may expose internal representation by storing an externally mutable object into DemandService._demandDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
383 |
Medium |
| fr.paris.lutece.plugins.notificationstore.service.DemandService.setNotificationDao(INotificationDAO) may expose internal representation by storing an externally mutable object into DemandService._notificationDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
395 |
Medium |
| fr.paris.lutece.plugins.notificationstore.service.DemandService.setNotificationEventDao(INotificationEventDAO) may expose internal representation by storing an externally mutable object into DemandService._notificationEventDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
389 |
Medium |
| fr.paris.lutece.plugins.notificationstore.service.DemandService.setStatusDao(ITemporaryStatusDAO) may expose internal representation by storing an externally mutable object into DemandService._statusDao |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
401 |
Medium |
fr.paris.lutece.plugins.notificationstore.service.JsonGeneration
| Bug |
Category |
Details |
Line |
Priority |
| Hard coded reference to an absolute pathname in fr.paris.lutece.plugins.notificationstore.service.JsonGeneration.generateJson(List) |
STYLE |
DMI_HARDCODED_ABSOLUTE_FILENAME |
73 |
High |
fr.paris.lutece.plugins.notificationstore.service.NotificationService
| Bug |
Category |
Details |
Line |
Priority |
| Do not catch NullPointerException like in fr.paris.lutece.plugins.notificationstore.service.NotificationService.newNotification(String) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
184 |
Medium |
| Do not catch NullPointerException like in fr.paris.lutece.plugins.notificationstore.service.NotificationService.newNotificationEvent(String) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
399 |
Medium |
| Do not catch NullPointerException like in fr.paris.lutece.plugins.notificationstore.service.NotificationService.reassignNotifications(String) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
364 |
Medium |
| Public static fr.paris.lutece.plugins.notificationstore.service.NotificationService.instance() may expose internal representation by returning NotificationService._instance |
MALICIOUS_CODE |
MS_EXPOSE_REP |
139 |
Medium |
fr.paris.lutece.plugins.notificationstore.service.TemporaryStatusCacheService
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.notificationstore.service.TemporaryStatusCacheService.getInstance() may expose internal representation by returning TemporaryStatusCacheService._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
73 |
Medium |
fr.paris.lutece.plugins.notificationstore.service.TemporaryStatusService
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.notificationstore.service.TemporaryStatusService.getInstance() may expose internal representation by returning TemporaryStatusService._instance |
MALICIOUS_CODE |
MS_EXPOSE_REP |
85 |
Medium |
fr.paris.lutece.plugins.notificationstore.utils.NotificationStoreUtils
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.notificationstore.utils.NotificationStoreUtils.getMapper() may expose internal representation by returning NotificationStoreUtils._mapper |
MALICIOUS_CODE |
MS_EXPOSE_REP |
89 |
Medium |
fr.paris.lutece.plugins.notificationstore.web.DemandJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.notificationstore.web.DemandJspBean defines non-transient non-serializable instance field _currentFilter |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.notificationstore.web.DemandTypeJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.notificationstore.web.DemandTypeJspBean defines non-transient non-serializable instance field _demandtype |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.notificationstore.web.NotificationEventJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.notificationstore.web.NotificationEventJspBean defines non-transient non-serializable instance field _currentFilter |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.notificationstore.web.NotificationJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.notificationstore.web.NotificationJspBean defines non-transient non-serializable instance field _currentFilter |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
