Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/openagenda/utils/OpenagendaUtils.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 55–153

Priority 3

fr/paris/lutece/plugins/openagenda/api/mapping/v2/Accessibility.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 89–92
CommentRequired Public method and constructor comments are required 104–107
CommentRequired Public method and constructor comments are required 119–122
CommentRequired Public method and constructor comments are required 134–137

fr/paris/lutece/plugins/openagenda/api/mapping/v2/EventData.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34–529
TooManyFields Too many fields 46–529

fr/paris/lutece/plugins/openagenda/api/mapping/v2/Keywords.java

Rule Violation Line
DataClass The class 'Keywords' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=12, WMC=12) 46–168

fr/paris/lutece/plugins/openagenda/api/mapping/v2/LocationData.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34–587
TooManyFields Too many fields 46–587

fr/paris/lutece/plugins/openagenda/business/portlet/OpenagendaPortlet.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 70
ConfusingTernary Avoid if (x != y) ..; else ..; 76

fr/paris/lutece/plugins/openagenda/business/portlet/OpenagendaPortletHome.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 47
NonThreadSafeSingleton Singleton is not thread safe 56–59

fr/paris/lutece/plugins/openagenda/client/v2/EventsFilters.java

Rule Violation Line
CommentRequired Header comments are required 40–318

fr/paris/lutece/plugins/openagenda/client/v2/EventsService.java

Rule Violation Line
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 70

fr/paris/lutece/plugins/openagenda/service/OpenagendaV2Service.java

Rule Violation Line
ImmutableField Private field '_agendasService' could be made final; it is only initialized in the declaration or constructor. 56
ImmutableField Private field '_eventsService' could be made final; it is only initialized in the declaration or constructor. 57
ImmutableField Private field '_locationsService' could be made final; it is only initialized in the declaration or constructor. 58
CommentRequired Public method and constructor comments are required 62–70
NonThreadSafeSingleton Singleton is not thread safe 64–67

fr/paris/lutece/plugins/openagenda/utils/OpenagendaUtils.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 75
ShortVariable Avoid variables with short names like sb 75
ConfusingTernary Avoid if (x != y) ..; else ..; 90–98

fr/paris/lutece/plugins/openagenda/web/AgendaJspBean.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 109–116
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 111
ConfusingTernary Avoid if (x != y) ..; else ..; 128

fr/paris/lutece/plugins/openagenda/web/AgendaXPage.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 86–92
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 94
CommentRequired Public method and constructor comments are required 95–104
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 106
CommentRequired Public method and constructor comments are required 107–132

fr/paris/lutece/plugins/openagenda/web/ManageOpenagendaJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 48–82
CommentRequired Protected method constructor comments are required 62–81
AddEmptyString Do not add empty strings 76

fr/paris/lutece/plugins/openagenda/web/portlet/OpenagendaPortletJspBean.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 71

Priority 4

fr/paris/lutece/plugins/openagenda/api/mapping/v2/Age.java

Rule Violation Line
ShortClassName Avoid short class names like Age 42–84

Files

fr/paris/lutece/plugins/openagenda/api/mapping/v2/Accessibility.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 89–92
CommentRequired Public method and constructor comments are required 3 104–107
CommentRequired Public method and constructor comments are required 3 119–122
CommentRequired Public method and constructor comments are required 3 134–137

fr/paris/lutece/plugins/openagenda/api/mapping/v2/Age.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Age 4 42–84

fr/paris/lutece/plugins/openagenda/api/mapping/v2/EventData.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34–529
TooManyFields Too many fields 3 46–529

fr/paris/lutece/plugins/openagenda/api/mapping/v2/Keywords.java

Rule Violation Priority Line
DataClass The class 'Keywords' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=12, WMC=12) 3 46–168

fr/paris/lutece/plugins/openagenda/api/mapping/v2/LocationData.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34–587
TooManyFields Too many fields 3 46–587

fr/paris/lutece/plugins/openagenda/business/portlet/OpenagendaPortlet.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 70
ConfusingTernary Avoid if (x != y) ..; else ..; 3 76

fr/paris/lutece/plugins/openagenda/business/portlet/OpenagendaPortletHome.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 47
NonThreadSafeSingleton Singleton is not thread safe 3 56–59

fr/paris/lutece/plugins/openagenda/client/v2/EventsFilters.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 40–318

fr/paris/lutece/plugins/openagenda/client/v2/EventsService.java

Rule Violation Priority Line
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 70

fr/paris/lutece/plugins/openagenda/service/OpenagendaV2Service.java

Rule Violation Priority Line
ImmutableField Private field '_agendasService' could be made final; it is only initialized in the declaration or constructor. 3 56
ImmutableField Private field '_eventsService' could be made final; it is only initialized in the declaration or constructor. 3 57
ImmutableField Private field '_locationsService' could be made final; it is only initialized in the declaration or constructor. 3 58
CommentRequired Public method and constructor comments are required 3 62–70
NonThreadSafeSingleton Singleton is not thread safe 3 64–67

fr/paris/lutece/plugins/openagenda/utils/OpenagendaUtils.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 55–153
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 75
ShortVariable Avoid variables with short names like sb 3 75
ConfusingTernary Avoid if (x != y) ..; else ..; 3 90–98

fr/paris/lutece/plugins/openagenda/web/AgendaJspBean.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 109–116
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 111
ConfusingTernary Avoid if (x != y) ..; else ..; 3 128

fr/paris/lutece/plugins/openagenda/web/AgendaXPage.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 86–92
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 94
CommentRequired Public method and constructor comments are required 3 95–104
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 106
CommentRequired Public method and constructor comments are required 3 107–132

fr/paris/lutece/plugins/openagenda/web/ManageOpenagendaJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 48–82
CommentRequired Protected method constructor comments are required 3 62–81
AddEmptyString Do not add empty strings 3 76

fr/paris/lutece/plugins/openagenda/web/portlet/OpenagendaPortletJspBean.java

Rule Violation Priority Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 71