The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 44 |
| Document empty constructor | 50–51 |
| Avoid variables with short names like id | 54 |
| Avoid variables with short names like id | 78 |
| Avoid using redundant field initializer for '__equalsCalc' | 122 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 122 |
| Use block level rather than method level synchronization | 123–145 |
| Avoid using if statements without curly braces | 124 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
| Avoid using if statements without curly braces | 126 |
| Avoid using if statements without curly braces | 127 |
| Use equals() to compare object references. | 129 |
| Assigning an Object to null is a code smell. Consider refactoring. | 143 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 147 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 147 |
| Use block level rather than method level synchronization | 148–165 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 168–169 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 44 |
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid variables with short names like id | 46 |
| Violation | Line |
|---|---|
| Document empty constructor | 44–45 |
| It is a good practice to call super() in a constructor | 44–45 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 53 |
| Avoid using redundant field initializer for '__equalsCalc' | 53 |
| Use block level rather than method level synchronization | 54–67 |
| Avoid using if statements without curly braces | 55 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 56 |
| Avoid unused local variables such as 'other'. | 56 |
| Avoid using if statements without curly braces | 57 |
| Avoid using if statements without curly braces | 58 |
| Use equals() to compare object references. | 60 |
| Assigning an Object to null is a code smell. Consider refactoring. | 65 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 69 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 69 |
| Use block level rather than method level synchronization | 70–78 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 81–82 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
| Violation | Line |
|---|---|
| Document empty constructor | 45–46 |
| It is a good practice to call super() in a constructor | 45–46 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 58 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 65 |
| The String literal "SearchAssetService" appears 4 times in this file; the first occurrence is on line 65 | 65 |
| Avoid using implementation types like 'java.util.HashSet'; use the interface instead | 144 |
| Avoid using redundant field initializer for 'ports' | 144 |
| Avoid using implementation types like 'java.util.HashSet'; use the interface instead | 144 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 144 |
| Violation | Line |
|---|---|
| The class 'SearchAssetServiceSoapBindingStub' has a Cyclomatic Complexity of 5 (Highest = 13). | 43–399 |
| The class 'SearchAssetServiceSoapBindingStub' has a Modified Cyclomatic Complexity of 5 (Highest = 13). | 43–399 |
| The class 'SearchAssetServiceSoapBindingStub' has a Standard Cyclomatic Complexity of 5 (Highest = 13). | 43–399 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 44 |
| Private field 'cachedSerClasses' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Use ArrayList instead of Vector | 44 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 44 |
| Private field 'cachedSerQNames' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Use ArrayList instead of Vector | 45 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 45 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 45 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 46 |
| Use ArrayList instead of Vector | 46 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 46 |
| Private field 'cachedSerFactories' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Use ArrayList instead of Vector | 47 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 47 |
| Private field 'cachedDeserFactories' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 47 |
| Use explicit scoping instead of the default package private level | 49 |
| Method names should not contain underscores | 56 |
| The String literal "http://www.w3.org/2001/XMLSchema" appears 9 times in this file; the first occurrence is on line 61 | 61 |
| The String literal "int" appears 4 times in this file; the first occurrence is on line 61 | 61 |
| The String literal "http://common.service.searchengine.server.tvnavig.com" appears 5 times in this file; the first occurrence is on line 65 | 65 |
| The String literal "http://searchengine.server.tvnavig.com" appears 15 times in this file; the first occurrence is on line 71 | 71 |
| The String literal "SearchAssetServiceException" appears 4 times in this file; the first occurrence is on line 73 | 73 |
| It is a good practice to call super() in a constructor | 133–215 |
| Avoid unused local variables such as 'enumsf'. | 145 |
| Avoid unused local variables such as 'enumdf'. | 146 |
| Avoid unused local variables such as 'arraysf'. | 147 |
| Avoid unused local variables such as 'arraydf'. | 148 |
| Avoid unused local variables such as 'simplesf'. | 149 |
| Avoid unused local variables such as 'simpledf'. | 150 |
| Avoid unused local variables such as 'simplelistsf'. | 151 |
| Avoid unused local variables such as 'simplelistdf'. | 152 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 197 |
| The method createCall() has an NPath complexity of 641 | 217–280 |
| The method 'createCall' has a Modified Cyclomatic Complexity of 13. | 217–280 |
| The method 'createCall' has a Standard Cyclomatic Complexity of 13. | 217–280 |
| The method 'createCall' has a Cyclomatic Complexity of 13. | 217–280 |
| Avoid variables with short names like x | 257 |
| Avoid variables with short names like sf | 259 |
| Avoid variables with short names like df | 261 |
| Avoid variables with short names like sf | 266 |
| Avoid variables with short names like df | 268 |
| Avoid variables with short names like id | 282 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 295 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 295 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 334 |
| Avoid variables with short names like id | 360 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 373 |
| Violation | Line |
|---|---|
| Possible God class (WMC=68, ATFD=56, TCC=0.043478260869565216) | 41–461 |
| The class 'AssetOGC' has a Cyclomatic Complexity of 2 (Highest = 16). | 45–461 |
| The class 'AssetOGC' has a Modified Cyclomatic Complexity of 2 (Highest = 14). | 45–461 |
| The class 'AssetOGC' has a Standard Cyclomatic Complexity of 2 (Highest = 14). | 45–461 |
| Document empty constructor | 67–68 |
| The user-supplied array 'formats' is stored directly. | 74 |
| The user-supplied array 'metaValues' is stored directly. | 75 |
| Returning 'formats' may expose an internal array. | 157 |
| The user-supplied array 'formats' is stored directly. | 166 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 166 |
| Returning 'metaValues' may expose an internal array. | 177 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 186 |
| The user-supplied array 'metaValues' is stored directly. | 186 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 270 |
| Avoid using redundant field initializer for '__equalsCalc' | 270 |
| Use block level rather than method level synchronization | 271–309 |
| Avoid using if statements without curly braces | 272 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 273 |
| Avoid using if statements without curly braces | 274 |
| Avoid using if statements without curly braces | 275 |
| Use equals() to compare object references. | 277 |
| Assigning an Object to null is a code smell. Consider refactoring. | 307 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 311 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 311 |
| The method 'hashCode' has a Modified Cyclomatic Complexity of 14. | 312–361 |
| The method hashCode() has an NPath complexity of 3200 | 312–361 |
| The method 'hashCode' has a Cyclomatic Complexity of 16. | 312–361 |
| The method 'hashCode' has a Standard Cyclomatic Complexity of 14. | 312–361 |
| Use block level rather than method level synchronization | 312–361 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 364–365 |
| The String literal "http://www.w3.org/2001/XMLSchema" appears 8 times in this file; the first occurrence is on line 372 | 372 |
| The String literal "string" appears 6 times in this file; the first occurrence is on line 384 | 384 |
| Violation | Line |
|---|---|
| Document empty constructor | 48–49 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 98 |
| Avoid using redundant field initializer for '__equalsCalc' | 98 |
| Use block level rather than method level synchronization | 99–118 |
| Avoid using if statements without curly braces | 100 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 101 |
| Avoid using if statements without curly braces | 102 |
| Avoid using if statements without curly braces | 103 |
| Use equals() to compare object references. | 105 |
| Assigning an Object to null is a code smell. Consider refactoring. | 116 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 120 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 120 |
| Use block level rather than method level synchronization | 121–135 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 138–139 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 47 |
| Violation | Line |
|---|---|
| Document empty constructor | 44–45 |
| It is a good practice to call super() in a constructor | 44–45 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 53 |
| Avoid using redundant field initializer for '__equalsCalc' | 53 |
| Use block level rather than method level synchronization | 54–67 |
| Avoid using if statements without curly braces | 55 |
| Avoid unused local variables such as 'other'. | 56 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 56 |
| Avoid using if statements without curly braces | 57 |
| Avoid using if statements without curly braces | 58 |
| Use equals() to compare object references. | 60 |
| Assigning an Object to null is a code smell. Consider refactoring. | 65 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 69 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 69 |
| Use block level rather than method level synchronization | 70–78 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 81–82 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 45–46 |
| Document empty constructor | 45–46 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 58 |
| The String literal "UserService" appears 4 times in this file; the first occurrence is on line 65 | 65 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 65 |
| Avoid using implementation types like 'java.util.HashSet'; use the interface instead | 144 |
| Avoid using implementation types like 'java.util.HashSet'; use the interface instead | 144 |
| Avoid using redundant field initializer for 'ports' | 144 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 144 |
| Violation | Line |
|---|---|
| The class 'UserServiceSoapBindingStub' has a Cyclomatic Complexity of 5 (Highest = 13). | 43–443 |
| The class 'UserServiceSoapBindingStub' has a Modified Cyclomatic Complexity of 5 (Highest = 13). | 43–443 |
| The class 'UserServiceSoapBindingStub' has a Standard Cyclomatic Complexity of 5 (Highest = 13). | 43–443 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 44 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 44 |
| Private field 'cachedSerClasses' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Use ArrayList instead of Vector | 44 |
| Use ArrayList instead of Vector | 45 |
| Private field 'cachedSerQNames' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 45 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 45 |
| Use ArrayList instead of Vector | 46 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 46 |
| Private field 'cachedSerFactories' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 46 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 47 |
| Avoid using implementation types like 'java.util.Vector'; use the interface instead | 47 |
| Use ArrayList instead of Vector | 47 |
| Private field 'cachedDeserFactories' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Use explicit scoping instead of the default package private level | 49 |
| Method names should not contain underscores | 56 |
| The String literal "http://www.w3.org/2001/XMLSchema" appears 5 times in this file; the first occurrence is on line 68 | 68 |
| The String literal "http://common.service.user.server.tvnavig.com" appears 10 times in this file; the first occurrence is on line 72 | 72 |
| The String literal "http://user.server.tvnavig.com" appears 16 times in this file; the first occurrence is on line 78 | 78 |
| The String literal "UserServiceException" appears 4 times in this file; the first occurrence is on line 80 | 80 |
| It is a good practice to call super() in a constructor | 130–235 |
| Avoid unused local variables such as 'enumsf'. | 142 |
| Avoid unused local variables such as 'enumdf'. | 143 |
| Avoid unused local variables such as 'arraysf'. | 144 |
| Avoid unused local variables such as 'arraydf'. | 145 |
| Avoid unused local variables such as 'simplesf'. | 146 |
| Avoid unused local variables such as 'simpledf'. | 147 |
| Avoid unused local variables such as 'simplelistsf'. | 148 |
| Avoid unused local variables such as 'simplelistdf'. | 149 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 199 |
| Assigning an Object to null is a code smell. Consider refactoring. | 208 |
| Assigning an Object to null is a code smell. Consider refactoring. | 217 |
| The method createCall() has an NPath complexity of 641 | 237–300 |
| The method 'createCall' has a Modified Cyclomatic Complexity of 13. | 237–300 |
| The method 'createCall' has a Cyclomatic Complexity of 13. | 237–300 |
| The method 'createCall' has a Standard Cyclomatic Complexity of 13. | 237–300 |
| Avoid variables with short names like x | 277 |
| Avoid variables with short names like sf | 279 |
| Avoid variables with short names like df | 281 |
| Avoid variables with short names like sf | 286 |
| Avoid variables with short names like df | 288 |
| A catch statement that catches an exception only to rethrow it should be avoided. | 321–323 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 378 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 417 |
| Violation | Line |
|---|---|
| Document empty constructor | 52–53 |
| The user-supplied array 'valueList' is stored directly. | 59 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 59 |
| Returning 'valueList' may expose an internal array. | 133 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 142 |
| The user-supplied array 'valueList' is stored directly. | 142 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 146 |
| Avoid using redundant field initializer for '__equalsCalc' | 146 |
| Use block level rather than method level synchronization | 147–168 |
| Avoid using if statements without curly braces | 148 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 149 |
| Avoid using if statements without curly braces | 150 |
| Avoid using if statements without curly braces | 151 |
| Use equals() to compare object references. | 153 |
| Assigning an Object to null is a code smell. Consider refactoring. | 166 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 170 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 170 |
| Use block level rather than method level synchronization | 171–195 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 198–199 |
| The String literal "http://www.w3.org/2001/XMLSchema" appears 4 times in this file; the first occurrence is on line 206 | 206 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 44 |
| Document empty constructor | 48–49 |
| Avoid variables with short names like id | 52 |
| Avoid variables with short names like id | 74 |
| Avoid using redundant field initializer for '__equalsCalc' | 98 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 98 |
| Use block level rather than method level synchronization | 99–118 |
| Avoid using if statements without curly braces | 100 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 101 |
| Avoid using if statements without curly braces | 102 |
| Avoid using if statements without curly braces | 103 |
| Use equals() to compare object references. | 105 |
| Assigning an Object to null is a code smell. Consider refactoring. | 116 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 120 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 120 |
| Use block level rather than method level synchronization | 121–135 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 138–139 |
| Violation | Line |
|---|---|
| Document empty constructor | 50–51 |
| Avoid using redundant field initializer for '__equalsCalc' | 122 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 122 |
| Use block level rather than method level synchronization | 123–145 |
| Avoid using if statements without curly braces | 124 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 125 |
| Avoid using if statements without curly braces | 126 |
| Avoid using if statements without curly braces | 127 |
| Use equals() to compare object references. | 129 |
| Assigning an Object to null is a code smell. Consider refactoring. | 143 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 147 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 147 |
| Use block level rather than method level synchronization | 148–165 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 168–169 |
| Violation | Line |
|---|---|
| The class 'UserGroupandMetaDataResult' has a Cyclomatic Complexity of 2 (Highest = 10). | 43–204 |
| Document empty constructor | 48–49 |
| The user-supplied array 'metaDataList' is stored directly. | 52 |
| The user-supplied array 'userGroupList' is stored directly. | 53 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 53 |
| Returning 'metaDataList' may expose an internal array. | 65 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 74 |
| The user-supplied array 'metaDataList' is stored directly. | 74 |
| Returning 'userGroupList' may expose an internal array. | 85 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 94 |
| The user-supplied array 'userGroupList' is stored directly. | 94 |
| Avoid using redundant field initializer for '__equalsCalc' | 98 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 98 |
| Use block level rather than method level synchronization | 99–118 |
| Avoid using if statements without curly braces | 100 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 101 |
| Avoid using if statements without curly braces | 102 |
| Avoid using if statements without curly braces | 103 |
| Use equals() to compare object references. | 105 |
| Assigning an Object to null is a code smell. Consider refactoring. | 116 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 120 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 120 |
| Use block level rather than method level synchronization | 121–151 |
| The method 'hashCode' has a Cyclomatic Complexity of 10. | 121–151 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 154–155 |
| Violation | Line |
|---|---|
| Document empty constructor | 54–55 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 170 |
| Avoid using redundant field initializer for '__equalsCalc' | 170 |
| Use block level rather than method level synchronization | 171–199 |
| Avoid using if statements without curly braces | 172 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 173 |
| Avoid using if statements without curly braces | 174 |
| Avoid using if statements without curly braces | 175 |
| Use equals() to compare object references. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 197 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 201 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 201 |
| Use block level rather than method level synchronization | 202–225 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 228–229 |
| The String literal "string" appears 4 times in this file; the first occurrence is on line 236 | 236 |
| The String literal "http://www.w3.org/2001/XMLSchema" appears 5 times in this file; the first occurrence is on line 236 | 236 |
| Violation | Line |
|---|---|
| Document empty constructor | 46–47 |
| It is a good practice to call super() in a constructor | 46–47 |
| It is a good practice to call super() in a constructor | 49–52 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 50 |
| The user-supplied array 'error' is stored directly. | 50 |
| Returning 'error' may expose an internal array. | 61 |
| The user-supplied array 'error' is stored directly. | 70 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 70 |
| Avoid using redundant field initializer for '__equalsCalc' | 74 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 74 |
| Use block level rather than method level synchronization | 75–91 |
| Avoid using if statements without curly braces | 76 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 77 |
| Avoid using if statements without curly braces | 78 |
| Avoid using if statements without curly braces | 79 |
| Use equals() to compare object references. | 81 |
| Assigning an Object to null is a code smell. Consider refactoring. | 89 |
| Avoid using redundant field initializer for '__hashCodeCalc' | 93 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 93 |
| Use block level rather than method level synchronization | 94–113 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 116–117 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 54 |
| Avoid using if...else statements without curly braces | 62 |
| Avoid using if...else statements without curly braces | 64 |
| Avoid using if...else statements without curly braces | 75 |
| Avoid using if...else statements without curly braces | 77 |
| Avoid using if...else statements without curly braces | 88 |
| Avoid using if...else statements without curly braces | 90 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 89 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 45–65 |
| Violation | Line |
|---|---|
| A method/constructor shouldnt explicitly throw java.lang.Exception | 70 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 70 |
| Consider simply returning the value vs storing it in local variable 'udrArray' | 80 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 95 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 95 |
| Avoid variables with short names like as | 97 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 110 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 110 |
| Avoid variables with short names like as | 112 |
| Avoid variables with short names like ap | 116 |
| Consider simply returning the value vs storing it in local variable 'ap' | 117 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'uniqueCookie1' | 45 |
| Avoid using redundant field initializer for 'uniqueCookie2' | 46 |
| Avoid variables with short names like mc | 49 |
| Avoid using if statements without curly braces | 52–53 |
| Avoid using if statements without curly braces | 54–55 |
| Violation | Line |
|---|---|
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 87 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 101 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'TEMPLATE_AUT_1'. | 86 |
| Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 94 |
| Avoid using redundant field initializer for '_plugin' | 100 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 117 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 124 |
| Avoid empty catch blocks | 143–145 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 143 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 158 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 158 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 160 |
| Avoid using if statements without curly braces | 179–180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Do not add empty strings | 191 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 227 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 227 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 229 |
| Avoid using if statements without curly braces | 231–232 |
| Avoid variables with short names like ap | 241 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 251 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 251 |
| Avoid variables with short names like ap | 257 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 259 |
