Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/phraseanet/business/account/AccountDAO.java

Violation Line
Avoid unused private fields such as 'SQL_QUERY_SELECT_TOKEN'. 51

fr/paris/lutece/plugins/phraseanet/business/embed/Embed.java

Violation Line
Private field '_mapEmbedItems' could be made final; it is only initialized in the declaration or constructor. 46
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 46

fr/paris/lutece/plugins/phraseanet/business/record/MetadataValue.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 46
Private field '_mapMetadatas' could be made final; it is only initialized in the declaration or constructor. 46

fr/paris/lutece/plugins/phraseanet/business/response/Meta.java

Violation Line
Avoid short class names like Meta 40176

fr/paris/lutece/plugins/phraseanet/service/PhraseanetService.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 90
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 131
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 133
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 170
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 171
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 175
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 229
Use block level rather than method level synchronization 258275
Avoid variables with short names like st 265
Use block level rather than method level synchronization 281298
Avoid variables with short names like st 288

fr/paris/lutece/plugins/phraseanet/service/SearchCriterias.java

Violation Line
Private field '_listBases' could be made final; it is only initialized in the declaration or constructor. 54
Avoid variables with short names like st 138

fr/paris/lutece/plugins/phraseanet/service/api/PhraseanetApiAuthentication.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccess' 38
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccess' 38
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccessException' 39
Avoid unused imports such as 'fr.paris.lutece.util.httpaccess.HttpAccessException' 39
Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' 40
Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' 40
Avoid unused imports such as 'org.apache.commons.lang.StringUtils' 41
Avoid unused imports such as 'org.apache.commons.lang.StringUtils' 41
Avoid unused private fields such as 'PARAMETER_CLIENT_ID'. 51
Avoid unused private fields such as 'PARAMETER_REDIRECT_URI'. 52
Avoid unused private fields such as 'PARAMETER_REDIRECT_URI_VALUE'. 53
Avoid unused private fields such as 'PARAMETER_RESPONSE_TYPE'. 54
Avoid unused private fields such as 'PARAMETER_RESPONSE_TYPE_VALUE'. 55
Avoid unused private fields such as 'PARAMETER_LOGIN'. 56
Avoid unused private fields such as 'PARAMETER_PASSWORD'. 57
Avoid unused private fields such as 'PARAMETER_ACTION_LOGIN'. 58
Avoid unused private fields such as 'PARAMETER_ACTION_LOGIN_VALUE'. 59
Avoid unused private fields such as 'PARAMETER_ACCESS_TOKEN'. 60
Avoid unused private fields such as '_logger'. 62
The Logger variable declaration does not contain the static and final modifiers 62

fr/paris/lutece/plugins/phraseanet/service/api/PhraseanetApiCallService.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 60
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 86
New exception is thrown in catch block, original stack trace may be lost 92
Use explicit scoping instead of the default package private level 102117
New exception is thrown in catch block, original stack trace may be lost 145

fr/paris/lutece/plugins/phraseanet/service/parsers/CollectionsJsonParser.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.plugins.phraseanet.service.api.PhraseanetApiCallService' 38
Avoid unused imports such as 'fr.paris.lutece.plugins.phraseanet.service.api.PhraseanetApiCallService' 38
Avoid variables with short names like i 74
New exception is thrown in catch block, original stack trace may be lost 9293

fr/paris/lutece/plugins/phraseanet/service/parsers/DataboxesJsonParser.java

Violation Line
Avoid unused imports such as 'net.sf.json.JSONArray' 41
Avoid unused imports such as 'net.sf.json.JSONArray' 41
Avoid variables with short names like i 73
New exception is thrown in catch block, original stack trace may be lost 9091

fr/paris/lutece/plugins/phraseanet/service/parsers/EmbedJsonParser.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 53
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 71
Avoid variables with short names like i 72
Avoid variables with short names like ei 82
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 84
New exception is thrown in catch block, original stack trace may be lost 9394
Avoid variables with short names like ei 106
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 130
Avoid variables with short names like p 131
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 141
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 144

fr/paris/lutece/plugins/phraseanet/service/parsers/MetaJsonParser.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 50
New exception is thrown in catch block, original stack trace may be lost 8081

fr/paris/lutece/plugins/phraseanet/service/parsers/MetadatasJsonParser.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.plugins.phraseanet.business.record.MetadataValue' 37
Avoid unused imports such as 'fr.paris.lutece.plugins.phraseanet.business.record.MetadataValue' 37
The Logger variable declaration does not contain the static and final modifiers 58
Avoid variables with short names like i 82
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 117
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 119
Avoid variables with short names like i 120
New exception is thrown in catch block, original stack trace may be lost 136137

fr/paris/lutece/plugins/phraseanet/service/parsers/RecordJsonParser.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 66
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 102
New exception is thrown in catch block, original stack trace may be lost 133134

fr/paris/lutece/plugins/phraseanet/service/parsers/SearchResultsJsonParser.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 57
Avoid variables with short names like i 94
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 101
New exception is thrown in catch block, original stack trace may be lost 118119

fr/paris/lutece/plugins/phraseanet/web/PhraseanetJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 341220
Avoid really long classes. 761219
The class 'PhraseanetJspBean' has a Cyclomatic Complexity of 5 (Highest = 12). 761219
Avoid unused private fields such as 'JSP_URL_CREATE_ACCOUNT'. 170
The Logger variable declaration does not contain the static and final modifiers 192
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 221
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 240
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 293
Avoid variables with short names like mh 357
Avoid variables with short names like mh 445
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 449
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 514
Avoid variables with short names like mh 550
Avoid variables with short names like mh 586
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 621
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 626
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 634
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 642
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 664
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 680
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 717
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 738
The method 'doCreateAccount' has a Cyclomatic Complexity of 10. 790844
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 912
The method 'doModifyAccount' has a Cyclomatic Complexity of 12. 9951079
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1091
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1106

fr/paris/lutece/plugins/phraseanet/web/PhraseanetLinkService.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.plugins.phraseanet.business.record.MetadataValue' 42
Avoid unused imports such as 'fr.paris.lutece.plugins.phraseanet.business.record.MetadataValue' 42
The Logger variable declaration does not contain the static and final modifiers 95
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 119
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 144
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 172
Avoid variables with short names like mh 176
Avoid variables with short names like mh 232
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 242
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 244
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 247
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 250
Avoid variables with short names like t 256
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 258
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 262
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 284
Avoid variables with short names like t 287