Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/publicdashboard/business/IPublicDashboardDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 127
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 136
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 143

fr/paris/lutece/plugins/publicdashboard/web/PublicDashboardJspBean.java

Rule Violation Line
LocalVariableNamingConventions The local variable name 'opt_public_dashboard' doesn't match '[a-z][a-zA-Z0-9]*' 225

Priority 3

fr/paris/lutece/plugins/publicdashboard/business/IPublicDashboardDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 46152

fr/paris/lutece/plugins/publicdashboard/business/PublicDashboard.java

Rule Violation Line
ShortVariable Avoid variables with short names like o 146
ConfusingTernary Avoid if (x != y) ..; else ..; 148155

fr/paris/lutece/plugins/publicdashboard/business/PublicDashboardDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50338
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 225228

fr/paris/lutece/plugins/publicdashboard/business/PublicDashboardHome.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 196

fr/paris/lutece/plugins/publicdashboard/service/PublicDashboardCacheService.java

Rule Violation Line
CommentRequired Header comments are required 885
CallSuperInConstructor It is a good practice to call super() in a constructor 1720
MissingOverride The method 'getName()' is missing an @Override annotation. 3841
ShortVariable Avoid variables with short names like r 55
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'r' 57
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. 69
ConfusingTernary Avoid if (x != y) ..; else ..; 7279
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 80

fr/paris/lutece/plugins/publicdashboard/service/PublicDashboardService.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 59159
ShortVariable Avoid variables with short names like id 75
ShortVariable Avoid variables with short names like id 101

fr/paris/lutece/plugins/publicdashboard/web/AbstractManagePublicDashboardJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 50102

fr/paris/lutece/plugins/publicdashboard/web/PublicDashboardJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 68398
UnusedPrivateField Avoid unused private fields such as 'JSP_MANAGE_DASHBOARDS'. 88
UnusedPrivateField Avoid unused private fields such as '_listIdDashboards'. 125
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 137
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 142
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 142
ConfusingTernary Avoid if (x != y) ..; else ..; 170
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 251259
CollapsibleIfStatements These nested if statements could be combined 251259

fr/paris/lutece/plugins/publicdashboard/web/PublicDashboardXPage.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 58108
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 86

Priority 4

fr/paris/lutece/plugins/publicdashboard/web/PublicDashboardJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.html.AbstractPaginator' 52
UnusedImports Avoid unused imports such as 'java.util.Comparator' 54
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 56
UnusedImports Avoid unused imports such as 'java.util.stream.Collectors' 61

Files

fr/paris/lutece/plugins/publicdashboard/business/IPublicDashboardDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 46152
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 127
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 136
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 143

fr/paris/lutece/plugins/publicdashboard/business/PublicDashboard.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like o 3 146
ConfusingTernary Avoid if (x != y) ..; else ..; 3 148155

fr/paris/lutece/plugins/publicdashboard/business/PublicDashboardDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 50338
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 225228

fr/paris/lutece/plugins/publicdashboard/business/PublicDashboardHome.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 196

fr/paris/lutece/plugins/publicdashboard/service/PublicDashboardCacheService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 885
CallSuperInConstructor It is a good practice to call super() in a constructor 3 1720
MissingOverride The method 'getName()' is missing an @Override annotation. 3 3841
ShortVariable Avoid variables with short names like r 3 55
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'r' 3 57
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. 3 69
ConfusingTernary Avoid if (x != y) ..; else ..; 3 7279
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 80

fr/paris/lutece/plugins/publicdashboard/service/PublicDashboardService.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 59159
ShortVariable Avoid variables with short names like id 3 75
ShortVariable Avoid variables with short names like id 3 101

fr/paris/lutece/plugins/publicdashboard/web/AbstractManagePublicDashboardJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 50102

fr/paris/lutece/plugins/publicdashboard/web/PublicDashboardJspBean.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.html.AbstractPaginator' 4 52
UnusedImports Avoid unused imports such as 'java.util.Comparator' 4 54
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 4 56
UnusedImports Avoid unused imports such as 'java.util.stream.Collectors' 4 61
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 68398
UnusedPrivateField Avoid unused private fields such as 'JSP_MANAGE_DASHBOARDS'. 3 88
UnusedPrivateField Avoid unused private fields such as '_listIdDashboards'. 3 125
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 137
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 142
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 142
ConfusingTernary Avoid if (x != y) ..; else ..; 3 170
LocalVariableNamingConventions The local variable name 'opt_public_dashboard' doesn't match '[a-z][a-zA-Z0-9]*' 1 225
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 251259
CollapsibleIfStatements These nested if statements could be combined 3 251259

fr/paris/lutece/plugins/publicdashboard/web/PublicDashboardXPage.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 58108
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 86