PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/quotientfamille/business/QuotientFamilial.java
| Violation |
Line |
| Avoid unused imports such as 'fr.paris.lutece.plugins.quotientfamille.service.TranchesService' |
37 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.quotientfamille.service.TranchesService' |
37 |
fr/paris/lutece/plugins/quotientfamille/dataclient/RevenuDataClient.java
| Violation |
Line |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. |
81 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. |
82 |
| Use block level rather than method level synchronization |
86–110 |
fr/paris/lutece/plugins/quotientfamille/dataclient/UserRevenu.java
| Violation |
Line |
| Avoid unused imports such as 'java.util.Map' |
43 |
| Avoid unused imports such as 'java.util.Map' |
43 |
| Private field '_qf' could be made final; it is only initialized in the declaration or constructor. |
56 |
fr/paris/lutece/plugins/quotientfamille/service/DirectoryDataService.java
| Violation |
Line |
| Avoid unused imports such as 'org.springframework.http.HttpRequest' |
8 |
| Avoid unused imports such as 'org.springframework.http.HttpRequest' |
8 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' |
23 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' |
23 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
29–182 |
| Avoid really long methods. |
32–180 |
| The method pushInDirectory() has an NCSS line count of 106 |
32–180 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
37 |
| Avoid printStackTrace(); use a logger call instead. |
40 |
| Avoid printStackTrace(); use a logger call instead. |
155 |
fr/paris/lutece/plugins/quotientfamille/service/TranchesService.java
| Violation |
Line |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
45–86 |
| Singleton is not thread safe |
52–56 |
| This usage of the Collection.toArray() method will throw a ClassCastException. |
83 |
fr/paris/lutece/plugins/quotientfamille/web/FranceConnectSampleApp.java
| Violation |
Line |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' |
47 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' |
47 |
| Perhaps '_quotientFamilial' could be replaced by a local variable. |
90 |
| Private field '_directoryData' could be made final; it is only initialized in the declaration or constructor. |
92 |
| Avoid empty if statements |
161–163 |
| System.out.println is used |
165 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
200 |
| Avoid printStackTrace(); use a logger call instead. |
201 |
