PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/rating/service/RatingService.java
| Violation |
Line |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
46–135 |
| Singleton is not thread safe |
128–131 |
fr/paris/lutece/plugins/rating/service/ResourceDisplayManager.java
| Violation |
Line |
| Avoid using Literals in Conditional Statements |
121 |
| Avoid using Literals in Conditional Statements |
183 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
195 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
246 |
| Prefer StringBuffer over += for concatenating strings |
251 |
fr/paris/lutece/plugins/rating/web/DownloadCountFilter.java
| Violation |
Line |
| The Logger variable declaration does not contain the static and final modifiers |
67 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
79 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
80 |
| Document empty method |
104–105 |
fr/paris/lutece/plugins/rating/web/ResourceManager.java
| Violation |
Line |
| Avoid using Literals in Conditional Statements |
305 |
