PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/recastbots/business/RecastBot.java
| Violation |
Line |
| Avoid unused imports such as 'javax.validation.constraints' |
36 |
| Avoid unused imports such as 'org.hibernate.validator.constraints' |
37 |
fr/paris/lutece/plugins/recastbots/service/BotInstance.java
| Violation |
Line |
| Private field '_strKey' could be made final; it is only initialized in the declaration or constructor. |
62 |
| Private field '_strName' could be made final; it is only initialized in the declaration or constructor. |
63 |
| Private field '_strDescription' could be made final; it is only initialized in the declaration or constructor. |
64 |
| Private field '_strAvatarUrl' could be made final; it is only initialized in the declaration or constructor. |
65 |
| Private field '_strToken' could be made final; it is only initialized in the declaration or constructor. |
66 |
| Private field '_strLanguage' could be made final; it is only initialized in the declaration or constructor. |
67 |
| Private field '_mapRenderers' could be made final; it is only initialized in the declaration or constructor. |
70 |
| Document empty method |
243–245 |
fr/paris/lutece/plugins/recastbots/service/BotRegistrationService.java
| Violation |
Line |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
48–128 |
| Singleton is not thread safe |
83–88 |
fr/paris/lutece/plugins/recastbots/service/LanguageService.java
| Violation |
Line |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
47–82 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
50 |
fr/paris/lutece/plugins/recastbots/web/AbstractManageBotsJspBean.java
| Violation |
Line |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. |
66 |
fr/paris/lutece/plugins/recastbots/web/RecastBotJspBean.java
| Violation |
Line |
| Assigning an Object to null is a code smell. Consider refactoring. |
115 |
